aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Refactor ProgressRecorder for non-optional Celery usage and add doc strings #2139

Merged
hansegucker merged 8 commits from fix/progress into 359-make-celery-non-optional 2021-02-16 19:33:19 +01:00
Conversation 15 Commits 8 Files changed 2 +139 -18
hansegucker commented 2021-02-16 10:35:44 +01:00
Owner
Copy link

Close #377

Close #377
hansegucker commented 2021-02-16 10:37:00 +01:00
Author
Owner
Copy link

@debdolph I added your branch for !2136 as target, so you can merge this into yours after @nik did a review.

@debdolph I added your branch for !2136 as target, so you can merge this into yours after @nik did a review.
nik commented 2021-02-16 10:38:56 +01:00
Owner
Copy link

Is this an API from the base progress recorder, or a new method invented by you?

Is this an API from the base progress recorder, or a new method invented by you?
hansegucker commented 2021-02-16 10:39:57 +01:00
Author
Owner
Copy link

If I remember correctly, this is a new method.

If I remember correctly, this is a new method.
nik commented 2021-02-16 10:40:52 +01:00
Owner
Copy link

Hiding this decorator in the recorder class is a bit inobvious. The method should not do two things, decorating a function to be automatically delayd on call and tracking its progress should be separated.

Hiding this decorator in the recorder class is a bit inobvious. The method should not do two things, decorating a function to be automatically `delay`d on call and tracking its progress should be separated.
nik commented 2021-02-16 10:41:50 +01:00
Owner
Copy link

Please find out. If it overrides an existing method, you should take care not to shadow its docstring.

Please find out. If it overrides an existing method, you should take care not to shadow its docstring.
hansegucker commented 2021-02-16 10:43:08 +01:00
Author
Owner
Copy link

It's definitely new.

It's definitely new.
nik commented 2021-02-16 11:03:22 +01:00
Owner
Copy link

k

k
nik commented 2021-02-16 11:05:36 +01:00
Owner
Copy link

Please use functools.wraps.

https://docs.python.org/3/library/functools.html#functools.wraps

Please use `functools.wraps`. https://docs.python.org/3/library/functools.html#functools.wraps
nik commented 2021-02-16 17:27:54 +01:00
Owner
Copy link

I figure you have a dice with a float on each side?

I figure you have a dice with a float on each side?
nik commented 2021-02-16 18:41:25 +01:00
Owner
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/494/diffs?diff_id=4834&start_sha=c9345e83b2aa546b1541a8ce2bd5898a79971219#62ff94f713598e770fb7bc6f7ab3cbacbbc4a643_110_146)
nik commented 2021-02-16 18:41:25 +01:00
Owner
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/494/diffs?diff_id=4834&start_sha=c9345e83b2aa546b1541a8ce2bd5898a79971219#62ff94f713598e770fb7bc6f7ab3cbacbbc4a643_125_150)
nik commented 2021-02-16 18:41:25 +01:00
Owner
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/494/diffs?diff_id=4834&start_sha=c9345e83b2aa546b1541a8ce2bd5898a79971219#62ff94f713598e770fb7bc6f7ab3cbacbbc4a643_118_146)
nik commented 2021-02-16 18:41:26 +01:00
Owner
Copy link

added 7 commits

  • 0bdf5664 - Remove questionnable workaround for timing issue
  • c81581cc - Simplify and rename task recording decorator
  • a8400ce4 - Update documenttion on ProgressRecorder
  • 0d35f974 - Factor recorded_task out of class for brevity
  • f2e29d79 - Rework progress API to be more coherent with upstream and DRY
  • aa176305 - Add iterator interface to record progress from an iterable
  • 924b33a7 - Remove unused import

Compare with previous version

added 7 commits <ul><li>0bdf5664 - Remove questionnable workaround for timing issue</li><li>c81581cc - Simplify and rename task recording decorator</li><li>a8400ce4 - Update documenttion on ProgressRecorder</li><li>0d35f974 - Factor recorded_task out of class for brevity</li><li>f2e29d79 - Rework progress API to be more coherent with upstream and DRY</li><li>aa176305 - Add iterator interface to record progress from an iterable</li><li>924b33a7 - Remove unused import</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/494/diffs?diff_id=4834&start_sha=c9345e83b2aa546b1541a8ce2bd5898a79971219)
nik commented 2021-02-16 19:12:40 +01:00
Owner
Copy link

resolved all threads

resolved all threads
nik commented 2021-02-16 19:33:15 +01:00
Owner
Copy link

mentioned in commit d7b52b1bc8

mentioned in commit d7b52b1bc84843c0090a43196be76507ad79c4ba
nik merged commit d7b52b1bc8 into 359-make-celery-non-optional 2021-02-16 19:33:19 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2139
No description provided.