aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Make Celery non-optional" #2136

Merged
hansegucker merged 26 commits from 359-make-celery-non-optional into master 2021-02-17 11:25:00 +01:00
Conversation 42 Commits 26 Files changed 10 +210 -255
tteichler commented 2021-02-14 21:07:08 +01:00
Owner
Copy link

Closes #359

Closes #359
tteichler commented 2021-02-14 21:35:57 +01:00
Author
Owner
Copy link

added 2 commits

  • 572e67a2 - Make celery dependencies non-optional.
  • 07899126 - Make celery non-optional

Compare with previous version

added 2 commits <ul><li>572e67a2 - Make celery dependencies non-optional.</li><li>07899126 - Make celery non-optional</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4794&start_sha=6e3ba7058860acdb89beaba90f286d245f1dab24)
tteichler commented 2021-02-14 21:42:58 +01:00
Author
Owner
Copy link

added 1 commit

  • 28973ef6 - Make celery non-optional

Compare with previous version

added 1 commit <ul><li>28973ef6 - Make celery non-optional</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4795&start_sha=07899126fa278dd6f2953ebbb5866ec3cc4ff627)
hansegucker commented 2021-02-14 21:46:42 +01:00
Owner
Copy link

requested review from @hansegucker

requested review from @hansegucker
hansegucker commented 2021-02-14 21:46:44 +01:00
Owner
Copy link

assigned to @nik and unassigned @debdolph

assigned to @nik and unassigned @debdolph
tteichler commented 2021-02-14 21:47:14 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>41cd2ecc - Make celery non-optional</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4796&start_sha=28973ef65276e29d8e9064e6ee031a5afbc1ad99)
nik commented 2021-02-14 22:28:38 +01:00
Owner
Copy link

mentioned in issue #375

mentioned in issue #375
tteichler commented 2021-02-14 22:31:42 +01:00
Author
Owner
Copy link

added 1 commit

  • 851ed826 - Drop DummyRecorder

Compare with previous version

added 1 commit <ul><li>851ed826 - Drop DummyRecorder</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4797&start_sha=41cd2ecc013e2b9242256faf0fafa4de251b7a4b)
tteichler commented 2021-02-14 22:39:07 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>1e2d2d31 - Drop DummyRecorder</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4798&start_sha=851ed826655db398ecae21de49dbaea8f26ceb3b)
tteichler commented 2021-02-14 22:52:44 +01:00
Author
Owner
Copy link

added 1 commit

  • 2fcace0e - Use default ProgressRecorder

Compare with previous version

added 1 commit <ul><li>2fcace0e - Use default ProgressRecorder</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4800&start_sha=1e2d2d313662605729d612c1ad03c1354b71d2d4)
tteichler commented 2021-02-14 22:56:08 +01:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
tteichler commented 2021-02-14 22:56:47 +01:00
Author
Owner
Copy link

@hansegucker: Please review and approve.

@hansegucker: Please review and approve.
tteichler commented 2021-02-14 23:16:27 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>36e6c33f - Use default ProgressRecorder</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4803&start_sha=2fcace0e8b18deca267b911c1efc9b102002c497)
nik commented 2021-02-14 23:16:29 +01:00
Owner
Copy link

Please keep this diff smaller by not re-arranging the order of dependencies.

Please keep this diff smaller by not re-arranging the order of dependencies.
nik commented 2021-02-14 23:16:30 +01:00
Owner
Copy link

Please keep this optional (you can still have the app in INSTALLED_APPS all the time, but not set the backend unconditionally).

Please keep this optional (you can still have the app in INSTALLED_APPS all the time, but not set the backend unconditionally).
nik commented 2021-02-14 23:16:31 +01:00
Owner
Copy link

This can be moved to the top of the file now, can't it?

This can be moved to the top of the file now, can't it?
nik commented 2021-02-14 23:16:31 +01:00
Owner
Copy link

Now, we of course need to ensure that all code locations that call a function that previously was an optional celery task call it with transaction.on_commit and .delay().

Maybe we should keep a wrapper that does this…

Now, we of course need to ensure that all code locations that call a function that previously was an optional celery task call it with `transaction.on_commit` and `.delay()`. Maybe we should keep a wrapper that does this…
hansegucker commented 2021-02-15 08:35:36 +01:00
Owner
Copy link

Adding the recorder to a task which should run in the background is superfluous and won't work here.

Adding the recorder to a task which should run in the background is superfluous and won't work here.
hansegucker commented 2021-02-15 08:35:37 +01:00
Owner
Copy link

Adding the recorder to a task which should run in the background is superfluous and won't work here.

Adding the recorder to a task which should run in the background is superfluous and won't work here.
hansegucker commented 2021-02-15 08:35:37 +01:00
Owner
Copy link

Adding the recorder to a task which should run in the background is superfluous and won't work here.

Adding the recorder to a task which should run in the background is superfluous and won't work here.
hansegucker commented 2021-02-15 08:35:37 +01:00
Owner
Copy link

We should keep at least a wrapper for this little bit of magic.

We should keep at least a wrapper for this little bit of magic.
hansegucker commented 2021-02-16 10:37:00 +01:00
Owner
Copy link

mentioned in merge request !2139

mentioned in merge request !2139
nik commented 2021-02-16 19:33:23 +01:00
Owner
Copy link

added 9 commits

  • c9345e83 - Refactor ProgressRecorder for non-optional Celery usage and add doc strings
  • 0bdf5664 - Remove questionnable workaround for timing issue
  • c81581cc - Simplify and rename task recording decorator
  • a8400ce4 - Update documenttion on ProgressRecorder
  • 0d35f974 - Factor recorded_task out of class for brevity
  • f2e29d79 - Rework progress API to be more coherent with upstream and DRY
  • aa176305 - Add iterator interface to record progress from an iterable
  • 924b33a7 - Remove unused import
  • d7b52b1b - Merge branch 'fix/progress' into '359-make-celery-non-optional'

Compare with previous version

added 9 commits <ul><li>c9345e83 - Refactor ProgressRecorder for non-optional Celery usage and add doc strings</li><li>0bdf5664 - Remove questionnable workaround for timing issue</li><li>c81581cc - Simplify and rename task recording decorator</li><li>a8400ce4 - Update documenttion on ProgressRecorder</li><li>0d35f974 - Factor recorded_task out of class for brevity</li><li>f2e29d79 - Rework progress API to be more coherent with upstream and DRY</li><li>aa176305 - Add iterator interface to record progress from an iterable</li><li>924b33a7 - Remove unused import</li><li>d7b52b1b - Merge branch &#39;fix/progress&#39; into &#39;359-make-celery-non-optional&#39;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4840&start_sha=36e6c33fb6dedcc8e9bdc98c2073eb889c16879d)
tteichler commented 2021-02-16 19:41:33 +01:00
Author
Owner
Copy link

added 3 commits

  • d7b52b1b...26fabd33 - 2 commits from branch master
  • e2848cb8 - Merge branch 'master' into 359-make-celery-non-optional

Compare with previous version

added 3 commits <ul><li>d7b52b1b...26fabd33 - 2 commits from branch <code>master</code></li><li>e2848cb8 - Merge branch &#39;master&#39; into 359-make-celery-non-optional</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4842&start_sha=d7b52b1bc84843c0090a43196be76507ad79c4ba)
tteichler commented 2021-02-16 19:47:46 +01:00
Author
Owner
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4843&start_sha=e2848cb8f7673f1969b25959c2bc55091d85f3a2#ca5e4a886c594c4b59402dbdbd16348bdbcddf3a_415_415)
tteichler commented 2021-02-16 19:47:47 +01:00
Author
Owner
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4843&start_sha=e2848cb8f7673f1969b25959c2bc55091d85f3a2#6267c6562bd3f9ae2961917beb12e8107bbf034b_10_8)
tteichler commented 2021-02-16 19:47:47 +01:00
Author
Owner
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4843&start_sha=e2848cb8f7673f1969b25959c2bc55091d85f3a2#6267c6562bd3f9ae2961917beb12e8107bbf034b_20_18)
tteichler commented 2021-02-16 19:47:47 +01:00
Author
Owner
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4843&start_sha=e2848cb8f7673f1969b25959c2bc55091d85f3a2#6267c6562bd3f9ae2961917beb12e8107bbf034b_20_18)
tteichler commented 2021-02-16 19:47:49 +01:00
Author
Owner
Copy link

added 1 commit

  • 98678f60 - Reduce size of diff

Compare with previous version

added 1 commit <ul><li>98678f60 - Reduce size of diff</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4843&start_sha=e2848cb8f7673f1969b25959c2bc55091d85f3a2)
tteichler commented 2021-02-16 19:49:10 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>54df673c - Reduce size of diff</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4844&start_sha=98678f6033a8596ce631476fa367ccb667de4d78)
nik commented 2021-02-16 20:16:40 +01:00
Owner
Copy link

added 1 commit

  • 9e8b9077 - Fix generation of record_task decorator with arguments

Compare with previous version

added 1 commit <ul><li>9e8b9077 - Fix generation of record_task decorator with arguments</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4845&start_sha=54df673c11ed88feb2ef5b2b81b95dc6c3d29f26)
hansegucker commented 2021-02-16 20:19:45 +01:00
Owner
Copy link

added 1 commit

  • 1a208a92 - Multiply calculated progress with 100 to get a percentage

Compare with previous version

added 1 commit <ul><li>1a208a92 - Multiply calculated progress with 100 to get a percentage</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4846&start_sha=9e8b90777a828895e4e36d62f44927b42f45acf8)
nik commented 2021-02-16 20:33:37 +01:00
Owner
Copy link

added 2 commits

  • c82be665 - Replace default app Task with a task that runs on_commit
  • 5d34782c - Merge branch '359-make-celery-non-optional' of...

Compare with previous version

added 2 commits <ul><li>c82be665 - Replace default app Task with a task that runs on_commit</li><li>5d34782c - Merge branch &#39;359-make-celery-non-optional&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4847&start_sha=1a208a92bf2e9bd994415746ccede9119205cd3c)
nik commented 2021-02-16 20:40:48 +01:00
Owner
Copy link

added 1 commit

  • df5cc954 - Fix task calling in decorator to not transport *args

Compare with previous version

added 1 commit <ul><li>df5cc954 - Fix task calling in decorator to not transport *args</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4848&start_sha=5d34782cb59ce904080fbe5cceedec774a6e951a)
nik commented 2021-02-16 21:04:46 +01:00
Owner
Copy link

added 1 commit

  • 3bae1a9a - Make only message sending run on_commit

Compare with previous version

added 1 commit <ul><li>3bae1a9a - Make only message sending run on_commit</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4849&start_sha=df5cc954e5a6348fbb95c2c955763d12493e7793)
nik commented 2021-02-16 21:07:07 +01:00
Owner
Copy link

We now delay the final AMQP message sending until commit.

We now delay the final AMQP message sending until commit.
nik commented 2021-02-16 21:07:08 +01:00
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-02-16 21:09:50 +01:00
Author
Owner
Copy link

added 2 commits

  • 4d65440b - Fix call of data checks
  • 7551d8e0 - Merge branch '359-make-celery-non-optional' of...

Compare with previous version

added 2 commits <ul><li>4d65440b - Fix call of data checks</li><li>7551d8e0 - Merge branch &#39;359-make-celery-non-optional&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4850&start_sha=3bae1a9a5592171cbb7bdedb86894ca5e8612175)
nik commented 2021-02-17 11:18:37 +01:00
Owner
Copy link

added 3 commits

  • 57c1300b - Disable atomic requests
  • 4e53ed3c - Revert "Make only message sending run on_commit"
  • d69e7ac6 - Revert "Replace default app Task with a task that runs on_commit"

Compare with previous version

added 3 commits <ul><li>57c1300b - Disable atomic requests</li><li>4e53ed3c - Revert &quot;Make only message sending run on_commit&quot;</li><li>d69e7ac6 - Revert &quot;Replace default app Task with a task that runs on_commit&quot;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/491/diffs?diff_id=4856&start_sha=7551d8e0467d22a16746921e3c48b8b436d8c3c3)
hansegucker commented 2021-02-17 11:23:20 +01:00
Owner
Copy link

approved this merge request

approved this merge request
hansegucker commented 2021-02-17 11:23:21 +01:00
Owner
Copy link

Now successful tested.

Now successful tested.
nik merged commit bbdb845474 into master 2021-02-17 11:25:01 +01:00
nik commented 2021-02-17 11:25:04 +01:00
Owner
Copy link

mentioned in commit bbdb845474

mentioned in commit bbdb845474259ad6572edc5d7adce793021e6fa4
Sign in to join this conversation.
Reviewers
No reviewers
hansegucker
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2136
No description provided.