Revert "Support custom authentication backends" #2104

Merged

hansegucker merged 1 commit from bugfix/remove-custom-auth-backends into master

2021-01-23 19:25:07 +01:00

nik commented

2021-01-23 18:30:54 +01:00

Owner

This reverts merge request !1979.

The way custom authentication backends were implemented break too much stuff, or requires workarounds that hide other mistakes. As nothing in AlekSIS uses custom auth backends, and we are currently integratin django-allauth in !2058, I request the feature to be removed.

If someone wants to add a custom authentication backend, they should hook into allauth instead.

@hansegucker Please merge after taking note if you do not have any objective arguments to keep this custom implementation.

Closes #313

This reverts merge request !1979. The way custom authentication backends were implemented break too much stuff, or requires workarounds that hide other mistakes. As nothing in AlekSIS uses custom auth backends, and we are currently integratin django-allauth in !2058, I request the feature to be removed. If someone wants to add a custom authentication backend, they should hook into allauth instead. @hansegucker Please merge after taking note if you do not have any objective arguments to keep this custom implementation. Closes #313

nik commented

2021-01-23 18:32:47 +01:00

Author

Owner

added 1 commit

10762433 - Revert "Support custom authentication backends"

Compare with previous version

added 1 commit <ul><li>10762433 - Revert "Support custom authentication backends"</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/459/diffs?diff_id=4481&start_sha=37345c4a06601a7e975fdd7b615dd4d8dfc9e33f)

nik commented

2021-01-23 18:33:04 +01:00

Author

Owner

changed title from Revert "{-Add test for custom authentication backends and fix a little bit-}" to Revert "{+Support custom authentication backends+}"

changed title from **Revert "{-Add test for custom authentication backends and fix a little bit-}"** to **Revert "{+Support custom authentication backends+}"**

nik commented

2021-01-23 18:34:20 +01:00

Author

Owner

changed the description

nik commented

2021-01-23 19:09:03 +01:00

Author

Owner

added 1 commit

6be1929f - Revert "Support custom authentication backends"

Compare with previous version

added 1 commit <ul><li>6be1929f - Revert "Support custom authentication backends"</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/459/diffs?diff_id=4483&start_sha=107624335583f584bb43738f1ec159fe0cbad896)