aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "User registration" #2058

Merged
hansegucker merged 63 commits from 331-user-registration into master 2021-05-21 16:38:47 +02:00
Conversation 207 Commits 63 Files changed 31 +1046 -114
tteichler commented 2020-12-26 14:13:39 +01:00
Owner
Copy link

Closes #331

Closes #236

Closes #354

Closes #353

Tests

  • Signup
  • Close signup
  • Change password
  • Disable changing of passwords
  • Reset password
  • Email confirmation
  • Verify templates
  • Social accounts
Closes #331 Closes #236 Closes #354 Closes #353 ## Tests - [X] Signup - [X] Close signup - [X] Change password - [x] Disable changing of passwords - [X] Reset password - [X] Email confirmation - [X] Verify templates - [x] Social accounts
nik commented 2020-12-26 14:13:57 +01:00
Owner
Copy link

assigned to @nik

assigned to @nik
nik commented 2020-12-26 14:14:02 +01:00
Owner
Copy link

requested review from @hansegucker

requested review from @hansegucker
tteichler commented 2020-12-26 15:09:00 +01:00
Author
Owner
Copy link

added 1 commit

  • 50101dff - Install django-allauth and add backends.

Compare with previous version

added 1 commit <ul><li>50101dff - Install django-allauth and add backends.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4066&start_sha=6563144f6a64e4ad80682c57713ee3d7ae682845)
tteichler commented 2020-12-26 15:16:19 +01:00
Author
Owner
Copy link

added 1 commit

  • befb4ac0 - Install django-allauth and add backends.

Compare with previous version

added 1 commit <ul><li>befb4ac0 - Install django-allauth and add backends.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4067&start_sha=50101dff3505a676b7c41e9f47d9567fcefe2ecc)
tteichler commented 2020-12-26 15:17:31 +01:00
Author
Owner
Copy link

added 1 commit

  • 73ad01cf - Install django-allauth and add backends.

Compare with previous version

added 1 commit <ul><li>73ad01cf - Install django-allauth and add backends.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4068&start_sha=befb4ac098004ec24e59641854efc43412ea4e65)
tteichler commented 2020-12-26 15:26:46 +01:00
Author
Owner
Copy link

added 1 commit

  • 7e78f191 - Install django-allauth and add backends.

Compare with previous version

added 1 commit <ul><li>7e78f191 - Install django-allauth and add backends.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4069&start_sha=73ad01cf53434b5d618f002f8142fc54f282b8ef)
tteichler commented 2020-12-26 15:33:41 +01:00
Author
Owner
Copy link

added 1 commit

  • d1fd2417 - Install django-allauth and add backends.

Compare with previous version

added 1 commit <ul><li>d1fd2417 - Install django-allauth and add backends.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4070&start_sha=7e78f191c9d172aafedf1744498656689b6ca535)
tteichler commented 2020-12-26 15:47:36 +01:00
Author
Owner
Copy link

added 1 commit

  • a2ff5c9e - Install django-allauth and add backends.

Compare with previous version

added 1 commit <ul><li>a2ff5c9e - Install django-allauth and add backends.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4071&start_sha=d1fd24171ae86f99e45c8ad78566ffa7d761bdd6)
tteichler commented 2020-12-26 16:21:29 +01:00
Author
Owner
Copy link

added 1 commit

  • c050e0f0 - Install django-allauth and add backends.

Compare with previous version

added 1 commit <ul><li>c050e0f0 - Install django-allauth and add backends.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4072&start_sha=a2ff5c9e87397d83dc1acc430b955cce2fae5b94)
tteichler commented 2020-12-26 16:24:56 +01:00
Author
Owner
Copy link

added 1 commit

  • 10e64bb7 - Install django-allauth and add backends.

Compare with previous version

added 1 commit <ul><li>10e64bb7 - Install django-allauth and add backends.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4073&start_sha=c050e0f04c6f3a78ac31051717aeccab36e736dc)
tteichler commented 2020-12-26 18:43:53 +01:00
Author
Owner
Copy link

added 1 commit

  • 7f29c3a1 - Add templates

Compare with previous version

added 1 commit <ul><li>7f29c3a1 - Add templates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4077&start_sha=10e64bb7301b2138451f525c547829f35cf2cf8a)
hansegucker commented 2020-12-26 19:19:00 +01:00
Owner
Copy link

A short notice: Please remember that you will have to take screenshots from all newly added views/templates ;-)

A short notice: Please remember that you will have to take screenshots from all newly added views/templates ;-)
tteichler commented 2020-12-26 19:28:59 +01:00
Author
Owner
Copy link

added 2 commits

  • 6c46db71 - Fix template syntax
  • 204d672c - Add menu entry, fix settings.

Compare with previous version

added 2 commits <ul><li>6c46db71 - Fix template syntax</li><li>204d672c - Add menu entry, fix settings.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4078&start_sha=7f29c3a15ab1f2ae2c0d1d6c5bcc3d34741a9976)
tteichler commented 2020-12-26 19:41:37 +01:00
Author
Owner
Copy link

added 1 commit

  • 4ede0e63 - Fix lint issues

Compare with previous version

added 1 commit <ul><li>4ede0e63 - Fix lint issues</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4081&start_sha=204d672ca6515c99cb47aaf2a46fc030e7b246b8)
nik commented 2020-12-26 22:16:37 +01:00
Owner
Copy link

added 1 commit

  • 6460f2a1 - Use custom socialaccount adapter to accommodate LDAP backend

Compare with previous version

added 1 commit <ul><li>6460f2a1 - Use custom socialaccount adapter to accommodate LDAP backend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4086&start_sha=4ede0e6312d928b0deff7a8491b083d93bae8b52)
nik commented 2020-12-26 22:18:05 +01:00
Owner
Copy link

added 1 commit

  • 664acacf - Deduplicate setting retrieval

Compare with previous version

added 1 commit <ul><li>664acacf - Deduplicate setting retrieval</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4087&start_sha=6460f2a1bd5d082d7719c1af8f1bdd8d6b8dfca4)
tteichler commented 2020-12-26 22:48:35 +01:00
Author
Owner
Copy link

changed the description

changed the description
tteichler commented 2020-12-26 23:09:00 +01:00
Author
Owner
Copy link

added 3 commits

  • 7abfd286 - Rewrite templates
  • fe78852e - Merge branch '331-user-registration' of...
  • f4b20d09 - Rewrite default values of settings

Compare with previous version

added 3 commits <ul><li>7abfd286 - Rewrite templates</li><li>fe78852e - Merge branch &#39;331-user-registration&#39; of...</li><li>f4b20d09 - Rewrite default values of settings</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4090&start_sha=664acacf4416d4b773b97816e9624b4d743bf516)
tteichler commented 2020-12-27 00:11:52 +01:00
Author
Owner
Copy link

added 1 commit

  • 28b75d1d - Add SignUpForm, rewrite templates

Compare with previous version

added 1 commit <ul><li>28b75d1d - Add SignUpForm, rewrite templates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4096&start_sha=f4b20d09013eced086029fa840bad9a352e43a96)
tteichler commented 2020-12-27 12:08:07 +01:00
Author
Owner
Copy link

added 1 commit

  • ad2ea2f2 - Update registration form

Compare with previous version

added 1 commit <ul><li>ad2ea2f2 - Update registration form</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4097&start_sha=28b75d1d13a04411110b2e33b96ea1c4b3fcfb4f)
tteichler commented 2020-12-27 14:11:48 +01:00
Author
Owner
Copy link

added 1 commit

  • b87e9efd - Update registration form

Compare with previous version

added 1 commit <ul><li>b87e9efd - Update registration form</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4098&start_sha=ad2ea2f2c4090f7022cb9637883ff60dc77321e3)
tteichler commented 2020-12-27 15:08:58 +01:00
Author
Owner
Copy link

added 1 commit

  • ed75adff - Reformat

Compare with previous version

added 1 commit <ul><li>ed75adff - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4099&start_sha=b87e9efd16ca0f535166f77a927fa370499b1b90)
tteichler commented 2020-12-27 15:52:28 +01:00
Author
Owner
Copy link

Confirm email

Screenshot_20201227_155007

Signup

Screenshot_20201227_151311

Social connections

Screenshot_20201227_154818

# Confirm email ![Screenshot_20201227_155007](/uploads/ea34b2e9b6c902ba4cafc6cecd7df180/Screenshot_20201227_155007.png) # Signup ![Screenshot_20201227_151311](/uploads/7fe034767c197c7ec655cd9eac2009bb/Screenshot_20201227_151311.png) # Social connections ![Screenshot_20201227_154818](/uploads/aaf11600fade5964d9dd406b709b409a/Screenshot_20201227_154818.png)
tteichler commented 2020-12-27 16:05:18 +01:00
Author
Owner
Copy link

Account inactive

Screenshot_20201227_155957

Change password

Screenshot_20201227_160325

# Account inactive ![Screenshot_20201227_155957](/uploads/2e58173c63f4a8fb7bd0ace3560dc250/Screenshot_20201227_155957.png) # Change password ![Screenshot_20201227_160325](/uploads/9d858f633ba006b158bb72a688e6379a/Screenshot_20201227_160325.png)
tteichler commented 2020-12-27 17:42:37 +01:00
Author
Owner
Copy link

requested review from @ZugBahnHof and removed review request for @hansegucker

requested review from @ZugBahnHof and removed review request for @hansegucker
leuckeju commented 2020-12-28 14:16:04 +01:00
Member
Copy link

Please use a Materialize collection with a line for each account

Please use a Materialize collection with a line for each account
leuckeju commented 2020-12-28 14:16:04 +01:00
Member
Copy link

Please move this button to the right side (https://materializecss.com/collections.html#secondary)

Please move this button to the right side (https://materializecss.com/collections.html#secondary)
leuckeju commented 2020-12-28 14:16:04 +01:00
Member
Copy link

Why is this a warning? You might want to let users know that this is an important action, but the text "Please confirm..." is not a warning.

Why is this a warning? You might want to let users know that this is an important action, but the text "Please confirm..." is not a warning.
leuckeju commented 2020-12-28 14:16:05 +01:00
Member
Copy link

Please use the msgbox Snippet (https://edugit.org/AlekSIS/official/AlekSIS-Core/-/blob/master/aleksis/core/templates/components/msgbox.html)

Please use the msgbox Snippet (https://edugit.org/AlekSIS/official/AlekSIS-Core/-/blob/master/aleksis/core/templates/components/msgbox.html)
leuckeju commented 2020-12-28 14:16:05 +01:00
Member
Copy link

Is this the right text?

Is this the right text?
leuckeju commented 2020-12-28 14:16:05 +01:00
Member
Copy link

What is the purpose of this page?

What is the purpose of this page?
leuckeju commented 2020-12-28 14:25:23 +01:00
Member
Copy link

Good icon choice

Good icon choice
leuckeju commented 2020-12-28 14:36:11 +01:00
Member
Copy link

Why do you use this icon? It doesn't seem like anything related to submitting

Why do you use this icon? It doesn't seem like anything related to submitting
leuckeju commented 2020-12-28 14:36:11 +01:00
Member
Copy link

I don't think this should be a warning

I don't think this should be a warning
leuckeju commented 2020-12-28 14:36:11 +01:00
Member
Copy link

I don't think this is a warning

I don't think this is a warning
leuckeju commented 2020-12-28 14:36:11 +01:00
Member
Copy link

Why do you use this icon? It doesn't seem like anything related to submitting

Why do you use this icon? It doesn't seem like anything related to submitting
leuckeju commented 2020-12-28 14:36:12 +01:00
Member
Copy link

Please use a consistent spelling of email/e-mail/mail

Please use a consistent spelling of email/e-mail/mail
leuckeju commented 2020-12-28 14:36:12 +01:00
Member
Copy link

Isn't there a form missing here?

Isn't there a form missing here?
leuckeju commented 2020-12-28 14:36:12 +01:00
Member
Copy link

Why do you use this icon? It doesn't seem like anything related to submitting

Why do you use this icon? It doesn't seem like anything related to submitting
leuckeju commented 2020-12-28 14:36:12 +01:00
Member
Copy link

I don't think a red card is suited for this. Together with the error icon, the user may think there is a problem

I don't think a red card is suited for this. Together with the error icon, the user may think there is a problem
leuckeju commented 2020-12-28 14:36:13 +01:00
Member
Copy link

Will this button delete all accounts? Because if not, then it should be in the loop and if it is, then that's bad UX.

Will this button delete all accounts? Because if not, then it should be in the loop and if it is, then that's bad UX.
leuckeju commented 2020-12-28 14:36:13 +01:00
Member
Copy link

Why is this ul not inside the file?

Why is this ul not inside the file?
leuckeju commented 2020-12-28 14:36:13 +01:00
Member
Copy link

Did you try a materialize collection? I believe it may be better, but maybe it's too heavy for this page

Did you try a materialize collection? I believe it may be better, but maybe it's too heavy for this page
leuckeju commented 2020-12-28 14:36:13 +01:00
Member
Copy link

Are these classes necessary?

Are these classes necessary?
leuckeju commented 2020-12-28 14:36:14 +01:00
Member
Copy link

Typo

Typo
magicfelix commented 2021-01-08 18:32:18 +01:00
Member
Copy link

Fixed, see !2075

Fixed, see !2075
tteichler commented 2021-01-11 20:04:22 +01:00
Author
Owner
Copy link

added 72 commits

  • ed75adff...4f1416d6 - 71 commits from branch master
  • 247adf8f - Merge branch 'master' into 331-user-registration

Compare with previous version

added 72 commits <ul><li>ed75adff...4f1416d6 - 71 commits from branch <code>master</code></li><li>247adf8f - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4281&start_sha=ed75adff6e1df76d53aa3892d83d96ebc4390533)
tteichler commented 2021-01-11 21:13:27 +01:00
Author
Owner
Copy link

added 1 commit

  • 63d3cb17 - Rewrite registration form

Compare with previous version

added 1 commit <ul><li>63d3cb17 - Rewrite registration form</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4283&start_sha=247adf8f1e646d3f2e98e883ca2fd13d1f039a11)
tteichler commented 2021-01-11 21:52:33 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-01-11 21:53:06 +01:00
Author
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4287&start_sha=63d3cb17f85bb2dc514acc07d2c002d9b738473b#8e0729c7956073f3cda9f9a8b90fca666d7fb3a8_14_13)
tteichler commented 2021-01-11 21:53:07 +01:00
Author
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4287&start_sha=63d3cb17f85bb2dc514acc07d2c002d9b738473b#ce9ef9a6e62968f34b099ba716466e98fb1998fc_10_10)
tteichler commented 2021-01-11 21:53:07 +01:00
Author
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4287&start_sha=63d3cb17f85bb2dc514acc07d2c002d9b738473b#55b1418b68f96d44de30d50aba58a638c8caf5d3_12_0)
tteichler commented 2021-01-11 21:53:08 +01:00
Author
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4287&start_sha=63d3cb17f85bb2dc514acc07d2c002d9b738473b#55b1418b68f96d44de30d50aba58a638c8caf5d3_1_0)
tteichler commented 2021-01-11 21:53:08 +01:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
tteichler commented 2021-01-11 21:53:09 +01:00
Author
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4287&start_sha=63d3cb17f85bb2dc514acc07d2c002d9b738473b#4b49dfded3e25e8e8c8ab3518fc89d3aea48975f_20_20)
tteichler commented 2021-01-11 21:53:10 +01:00
Author
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4287&start_sha=63d3cb17f85bb2dc514acc07d2c002d9b738473b#c0c0ec6f3da74f79d6910519ef1c23d677157d30_29_29)
tteichler commented 2021-01-11 21:53:10 +01:00
Author
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4287&start_sha=63d3cb17f85bb2dc514acc07d2c002d9b738473b#df1982474817612841cd595a980bab6be153cb81_13_13)
tteichler commented 2021-01-11 21:53:10 +01:00
Author
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4287&start_sha=63d3cb17f85bb2dc514acc07d2c002d9b738473b#03aecca200f730367a7e5995ab5fd857efede2ef_11_11)
tteichler commented 2021-01-11 21:53:11 +01:00
Author
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4287&start_sha=63d3cb17f85bb2dc514acc07d2c002d9b738473b#8e0729c7956073f3cda9f9a8b90fca666d7fb3a8_47_47)
tteichler commented 2021-01-11 21:53:11 +01:00
Author
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4287&start_sha=63d3cb17f85bb2dc514acc07d2c002d9b738473b#8e0729c7956073f3cda9f9a8b90fca666d7fb3a8_48_47)
tteichler commented 2021-01-11 21:53:11 +01:00
Author
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4287&start_sha=63d3cb17f85bb2dc514acc07d2c002d9b738473b#c5eaacf8dd3a3db9e82da3aba63d3eeca221b0ff_18_22)
tteichler commented 2021-01-11 21:53:12 +01:00
Author
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4287&start_sha=63d3cb17f85bb2dc514acc07d2c002d9b738473b#02bae0c02e44947674e21057814a24167932cb23_17_17)
tteichler commented 2021-01-11 21:53:13 +01:00
Author
Owner
Copy link

added 1 commit

  • d3237c2e - Rewrite tempaltes

Compare with previous version

added 1 commit <ul><li>d3237c2e - Rewrite tempaltes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4287&start_sha=63d3cb17f85bb2dc514acc07d2c002d9b738473b)
tteichler commented 2021-01-11 21:56:07 +01:00
Author
Owner
Copy link

added 1 commit

  • 60a507b2 - Rewrite tempaltes

Compare with previous version

added 1 commit <ul><li>60a507b2 - Rewrite tempaltes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4288&start_sha=d3237c2ee4de583e98dbb0c7205d16a6921832d6)
tteichler commented 2021-01-11 21:59:20 +01:00
Author
Owner
Copy link

added 9 commits

  • 60a507b2...52a9a9e6 - 7 commits from branch master
  • 96b8c452 - Install and configure django-allauth.
  • 56e11556 - Rewrite templates and forms.

Compare with previous version

added 9 commits <ul><li>60a507b2...52a9a9e6 - 7 commits from branch <code>master</code></li><li>96b8c452 - Install and configure django-allauth.</li><li>56e11556 - Rewrite templates and forms.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4290&start_sha=60a507b2f576bf162c5825a9f45b0c082ffc67c4)
tteichler commented 2021-01-11 22:08:11 +01:00
Author
Owner
Copy link

changed the description

changed the description
tteichler commented 2021-01-11 22:08:34 +01:00
Author
Owner
Copy link

changed the description

changed the description
tteichler commented 2021-01-11 22:10:03 +01:00
Author
Owner
Copy link

mentioned in issue #331

mentioned in issue #331
nik commented 2021-01-11 22:20:55 +01:00
Owner
Copy link

requested review from @hansegucker and removed review request for @ZugBahnHof

requested review from @hansegucker and removed review request for @ZugBahnHof
nik commented 2021-01-11 22:21:17 +01:00
Owner
Copy link

assigned to @hansegucker and unassigned @nik

assigned to @hansegucker and unassigned @nik
nik commented 2021-01-11 22:21:25 +01:00
Owner
Copy link

requested review from @ZugBahnHof and removed review request for @hansegucker

requested review from @ZugBahnHof and removed review request for @hansegucker
tteichler commented 2021-01-11 22:21:26 +01:00
Author
Owner
Copy link

requested review from @hansegucker and removed review request for @ZugBahnHof

requested review from @hansegucker and removed review request for @ZugBahnHof
nik commented 2021-01-11 22:37:12 +01:00
Owner
Copy link

There must be a setting to enable/disable each features (in addition to social accoutns and registration, which are already configurable, changing passwords and getting reset links must also be configurable.

Also, most, if not all, of that, should be site preferences rather than settings (if needed by allauth itself, watch out for the lazy_preference stuff used elsewhere to pull preferences into settings).

There must be a setting to enable/disable each features (in addition to social accoutns and registration, which are already configurable, changing passwords and getting reset links must also be configurable. Also, most, if not all, of that, should be site preferences rather than settings (if needed by allauth itself, watch out for the lazy_preference stuff used elsewhere to pull preferences into settings).
nik commented 2021-01-11 22:37:14 +01:00
Owner
Copy link

We do not have consents yet.

We do not have consents yet.
nik commented 2021-01-11 22:37:14 +01:00
Owner
Copy link
        super().__init__(*args, **kwargs)

We have Python 3! Happy 2021 ❤️!

```suggestion:-0+0 super().__init__(*args, **kwargs) ``` We have Python 3! Happy 2021 :heart:!
nik commented 2021-01-11 22:37:15 +01:00
Owner
Copy link

Why do you create the fields in __init__ instead of just defining them as slots o nthe class?

Why do you create the fields in `__init__` instead of just defining them as slots o nthe class?
nik commented 2021-01-11 22:37:15 +01:00
Owner
Copy link
        super().clean()
```suggestion:-0+0 super().clean() ```
nik commented 2021-01-11 22:37:16 +01:00
Owner
Copy link

What is this supposed to do? Looking further down, it is used wrongly (get_user_model returns the model class, not a User instance)

What is this supposed to do? Looking further down, it is used wrongly (`get_user_model` returns the model class, not a User instance)
nik commented 2021-01-11 22:37:16 +01:00
Owner
Copy link

This should also be configurable. A system that does not allow using social accounts hsould not expose this menu to users.

This should also be configurable. A system that does not allow using social accounts hsould not expose this menu to users.
nik commented 2021-01-11 22:37:16 +01:00
Owner
Copy link

This should only be loaded if social accoutns are enabled.

This should only be loaded if social accoutns are enabled.
nik commented 2021-01-11 22:37:17 +01:00
Owner
Copy link

Move inside the if block below to only set it if social accounts are enabled.

Move inside the `if` block below to only set it if social accounts are enabled.
nik commented 2021-01-11 22:37:17 +01:00
Owner
Copy link

The setting name might get ambibious. As I understand it, this only supports social accounts supported by allauth. Does that include, like, general things like LDAP, etc.?

The setting name might get ambibious. As I understand it, this only supports social accounts supported by allauth. Does that include, like, general things like LDAP, etc.?
nik commented 2021-01-11 22:37:17 +01:00
Owner
Copy link

Should default to the app title as configured in preferences.

Should default to the app title as configured in preferences.
nik commented 2021-01-11 22:37:18 +01:00
Owner
Copy link

Should default to False.

Should default to False.
nik commented 2021-01-11 22:37:18 +01:00
Owner
Copy link

Should contain the configured app name.

Should contain the configured app name.
nik commented 2021-01-11 22:37:18 +01:00
Owner
Copy link

Should this be prepended with a text of some sort? Like, what is this listed for?

Should this be prepended with a text of some sort? Like, what is this listed for?
nik commented 2021-01-11 22:37:19 +01:00
Owner
Copy link

Should contain the same wording as in the change password template (for example "forgot" vs. "forgotten")

Should contain the same wording as in the change password template (for example "forgot" vs. "forgotten")
nik commented 2021-01-11 22:37:19 +01:00
Owner
Copy link

troblue?

Also, remove the comma before the if.

troblue? Also, remove the comma before the if.
nik commented 2021-01-11 22:37:20 +01:00
Owner
Copy link

"No newline at end of file"

"No newline at end of file"
nik commented 2021-01-11 22:37:20 +01:00
Owner
Copy link

I somehow remember writing this. Seems to have been lost in a squash or something? Please restore.

I somehow remember writing this. Seems to have been lost in a squash or something? Please restore.
nik commented 2021-01-11 22:37:21 +01:00
Owner
Copy link

Why don't we use a generic validator that can validate any given setting? Seems unlikely that we want to add one funtion for each and every setting.

Why don't we use a generic validator that can validate any given setting? Seems unlikely that we want to add one funtion for each and every setting.
hansegucker commented 2021-01-12 10:34:22 +01:00
Owner
Copy link

Can you also please provide a new screenshot for the current "Social accounts" page?,

Can you also please provide a new screenshot for the current "Social accounts" page?,
tteichler commented 2021-01-17 13:40:27 +01:00
Author
Owner
Copy link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4372&start_sha=56e11556b8ab321418d4bbb1092e3d5850f3dcdf#c0c0ec6f3da74f79d6910519ef1c23d677157d30_12_12)
tteichler commented 2021-01-17 13:40:28 +01:00
Author
Owner
Copy link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4372&start_sha=56e11556b8ab321418d4bbb1092e3d5850f3dcdf#622da2712f4801473aba0b611c3232f8148ef126_387_387)
tteichler commented 2021-01-17 13:40:28 +01:00
Author
Owner
Copy link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4372&start_sha=56e11556b8ab321418d4bbb1092e3d5850f3dcdf#622da2712f4801473aba0b611c3232f8148ef126_391_389)
tteichler commented 2021-01-17 13:40:29 +01:00
Author
Owner
Copy link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4372&start_sha=56e11556b8ab321418d4bbb1092e3d5850f3dcdf#622da2712f4801473aba0b611c3232f8148ef126_410_399)
tteichler commented 2021-01-17 13:40:29 +01:00
Author
Owner
Copy link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4372&start_sha=56e11556b8ab321418d4bbb1092e3d5850f3dcdf#622da2712f4801473aba0b611c3232f8148ef126_414_402)
tteichler commented 2021-01-17 13:40:30 +01:00
Author
Owner
Copy link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4372&start_sha=56e11556b8ab321418d4bbb1092e3d5850f3dcdf#abc9d828b78bd9d36e05475d0bc91119bc5bc6b0_104_104)
tteichler commented 2021-01-17 13:40:30 +01:00
Author
Owner
Copy link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4372&start_sha=56e11556b8ab321418d4bbb1092e3d5850f3dcdf#abc9d828b78bd9d36e05475d0bc91119bc5bc6b0_229_227)
tteichler commented 2021-01-17 13:40:31 +01:00
Author
Owner
Copy link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4372&start_sha=56e11556b8ab321418d4bbb1092e3d5850f3dcdf#abc9d828b78bd9d36e05475d0bc91119bc5bc6b0_232_228)
tteichler commented 2021-01-17 13:40:31 +01:00
Author
Owner
Copy link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4372&start_sha=56e11556b8ab321418d4bbb1092e3d5850f3dcdf#abc9d828b78bd9d36e05475d0bc91119bc5bc6b0_281_282)
tteichler commented 2021-01-17 13:40:32 +01:00
Author
Owner
Copy link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4372&start_sha=56e11556b8ab321418d4bbb1092e3d5850f3dcdf#ce9ef9a6e62968f34b099ba716466e98fb1998fc_34_34)
tteichler commented 2021-01-17 13:40:32 +01:00
Author
Owner
Copy link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4372&start_sha=56e11556b8ab321418d4bbb1092e3d5850f3dcdf#c0c0ec6f3da74f79d6910519ef1c23d677157d30_20_19)
tteichler commented 2021-01-17 13:40:32 +01:00
Author
Owner
Copy link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4372&start_sha=56e11556b8ab321418d4bbb1092e3d5850f3dcdf#c5eaacf8dd3a3db9e82da3aba63d3eeca221b0ff_42_42)
tteichler commented 2021-01-17 13:40:34 +01:00
Author
Owner
Copy link

added 1 commit

  • 8bd163ad - Rewrite registration

Compare with previous version

added 1 commit <ul><li>8bd163ad - Rewrite registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4372&start_sha=56e11556b8ab321418d4bbb1092e3d5850f3dcdf)
tteichler commented 2021-01-17 16:37:10 +01:00
Author
Owner
Copy link

added 11 commits

  • 8bd163ad...f7485aa0 - 10 commits from branch master
  • 01a7c631 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 11 commits <ul><li>8bd163ad...f7485aa0 - 10 commits from branch <code>master</code></li><li>01a7c631 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4377&start_sha=8bd163adbd0741002e33979df50e865134975e8f)
hansegucker commented 2021-01-17 16:47:30 +01:00
Owner
Copy link

I think there must be one somewhere.

I think there must be one somewhere.
tteichler commented 2021-01-17 19:08:12 +01:00
Author
Owner
Copy link

Please take a look at the SignupForm from django-allauth

https://github.com/pennersr/django-allauth/blob/master/allauth/account/forms.py#L394

Please take a look at the SignupForm from django-allauth https://github.com/pennersr/django-allauth/blob/master/allauth/account/forms.py#L394
tteichler commented 2021-01-17 19:49:00 +01:00
Author
Owner
Copy link

changed this line in version 27 of the diff

changed this line in [version 27 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4381&start_sha=01a7c63179178871d13d01c379817e3f0c70cad4#3652bc6732067a8fc205c90ccf0761599aaffa0e_9_9)
tteichler commented 2021-01-17 19:49:02 +01:00
Author
Owner
Copy link

added 1 commit

  • c3012276 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 1 commit <ul><li>c3012276 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4381&start_sha=01a7c63179178871d13d01c379817e3f0c70cad4)
tteichler commented 2021-01-17 21:30:20 +01:00
Author
Owner
Copy link

changed this line in version 28 of the diff

changed this line in [version 28 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4081&start_sha=c3012276b7319aff42b97b499a7fefe75bba6629#8e0729c7956073f3cda9f9a8b90fca666d7fb3a8_32_0)
tteichler commented 2021-01-17 21:30:20 +01:00
Author
Owner
Copy link

changed this line in version 28 of the diff

changed this line in [version 28 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4081&start_sha=c3012276b7319aff42b97b499a7fefe75bba6629#ce9ef9a6e62968f34b099ba716466e98fb1998fc_26_0)
tteichler commented 2021-01-17 21:30:22 +01:00
Author
Owner
Copy link

changed this line in version 28 of the diff

changed this line in [version 28 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4081&start_sha=c3012276b7319aff42b97b499a7fefe75bba6629#622da2712f4801473aba0b611c3232f8148ef126_404_373)
tteichler commented 2021-01-17 21:30:22 +01:00
Author
Owner
Copy link

changed this line in version 28 of the diff

changed this line in [version 28 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4081&start_sha=c3012276b7319aff42b97b499a7fefe75bba6629#e25342bba815fa538d53a3e922ea2f6e55b6a2b3_81_70)
tteichler commented 2021-01-17 21:30:24 +01:00
Author
Owner
Copy link

changed this line in version 28 of the diff

changed this line in [version 28 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4081&start_sha=c3012276b7319aff42b97b499a7fefe75bba6629#abc9d828b78bd9d36e05475d0bc91119bc5bc6b0_267_251)
tteichler commented 2021-01-17 21:30:24 +01:00
Author
Owner
Copy link

changed this line in version 28 of the diff

changed this line in [version 28 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4081&start_sha=c3012276b7319aff42b97b499a7fefe75bba6629#02bae0c02e44947674e21057814a24167932cb23_21_0)
tteichler commented 2021-01-17 21:30:25 +01:00
Author
Owner
Copy link

changed this line in version 28 of the diff

changed this line in [version 28 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4081&start_sha=c3012276b7319aff42b97b499a7fefe75bba6629#8c15ef90a05145592bdded0de1ca9faad06ca049_169_166)
tteichler commented 2021-01-17 21:30:29 +01:00
Author
Owner
Copy link

added 5 commits

  • 10e64bb7 - Install django-allauth and add backends.
  • 7f29c3a1 - Add templates
  • 6c46db71 - Fix template syntax
  • 204d672c - Add menu entry, fix settings.
  • 4ede0e63 - Fix lint issues

Compare with previous version

added 5 commits <ul><li>10e64bb7 - Install django-allauth and add backends.</li><li>7f29c3a1 - Add templates</li><li>6c46db71 - Fix template syntax</li><li>204d672c - Add menu entry, fix settings.</li><li>4ede0e63 - Fix lint issues</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4384&start_sha=c3012276b7319aff42b97b499a7fefe75bba6629)
tteichler commented 2021-01-17 21:32:56 +01:00
Author
Owner
Copy link

added 89 commits

  • 4ede0e63...f7485aa0 - 88 commits from branch master
  • b9592a1e - Merge branch 'master' into 331-user-registration

Compare with previous version

added 89 commits <ul><li>4ede0e63...f7485aa0 - 88 commits from branch <code>master</code></li><li>b9592a1e - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4385&start_sha=4ede0e6312d928b0deff7a8491b083d93bae8b52)
tteichler commented 2021-01-17 22:02:21 +01:00
Author
Owner
Copy link

added 1 commit

  • be0ac67c - Add rule for signup

Compare with previous version

added 1 commit <ul><li>be0ac67c - Add rule for signup</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4386&start_sha=b9592a1eb7f68ad5e4becefec67566a36c88af30)
tteichler commented 2021-01-17 22:10:43 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-01-17 22:10:50 +01:00
Author
Owner
Copy link

added 2 commits

  • 96edb165 - Install and configure django-allauth.
  • d0a52502 - Use custom socialaccount adapter to accommodate LDAP backend

Compare with previous version

added 2 commits <ul><li>96edb165 - Install and configure django-allauth.</li><li>d0a52502 - Use custom socialaccount adapter to accommodate LDAP backend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4388&start_sha=be0ac67c92518aeb0edf1044f8d0098c3fe55315)
tteichler scheduled this pull request to auto merge when all checks succeed 2021-01-17 22:11:54 +01:00
tteichler commented 2021-01-17 22:19:53 +01:00
Author
Owner
Copy link

aborted the automatic merge because source branch was updated

aborted the automatic merge because source branch was updated
tteichler commented 2021-01-17 22:19:54 +01:00
Author
Owner
Copy link

added 1 commit

  • bf23e289 - Add missing preference

Compare with previous version

added 1 commit <ul><li>bf23e289 - Add missing preference</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4390&start_sha=d0a525023cf2790a92f4484226b8b0f24eae2b79)
tteichler commented 2021-01-17 22:28:41 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>b069f624 - Add missing preference</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4392&start_sha=bf23e289ee279b344a448c57712e401d603a7432)
tteichler commented 2021-01-17 22:54:01 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>eb4cf5e1 - Add missing settings</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4393&start_sha=b069f6249b9ab6c0587ed99bccf35d750be720d6)
tteichler commented 2021-01-17 22:57:36 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>6e2a7e33 - Remove logout confirmation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4394&start_sha=eb4cf5e1f4848e1399987784ded8e45c38703bb7)
leuckeju commented 2021-01-18 19:15:13 +01:00
Member
Copy link

This would be nice

This would be nice
tteichler commented 2021-01-18 21:47:23 +01:00
Author
Owner
Copy link

Screenshot_20210118_214540

![Screenshot_20210118_214540](/uploads/5ccd809e66144657b90e9a6e463e612e/Screenshot_20210118_214540.png)
tteichler commented 2021-01-18 21:47:24 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-01-18 22:05:13 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>929c0d71 - Add missing templates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4396&start_sha=6e2a7e33a4c8d70eda9bee1d9224dc1cba207818)
nik commented 2021-01-18 22:58:51 +01:00
Owner
Copy link

changed the description

changed the description
nik commented 2021-01-18 22:58:51 +01:00
Owner
Copy link

requested review from @nik and removed review request for @hansegucker

requested review from @nik and removed review request for @hansegucker
tteichler commented 2021-01-19 21:10:48 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>ed2721e3 - Add missing templates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4406&start_sha=929c0d714dd8a2afc13e3f708f2ec5aa0fd08dc8)
tteichler commented 2021-01-23 16:14:58 +01:00
Author
Owner
Copy link

added 18 commits

  • ed2721e3...d39a3291 - 17 commits from branch master
  • 02c821f5 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 18 commits <ul><li>ed2721e3...d39a3291 - 17 commits from branch <code>master</code></li><li>02c821f5 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4460&start_sha=ed2721e3971c81ce6fd1b34d90f8b68823908751)
tteichler commented 2021-01-23 16:42:11 +01:00
Author
Owner
Copy link

marked the checklist item LDAP account, person linked as completed

marked the checklist item **LDAP account, person linked** as completed
tteichler commented 2021-01-23 16:42:15 +01:00
Author
Owner
Copy link

marked the checklist item Add social account from one of enabled providers as completed

marked the checklist item **Add social account from one of enabled providers** as completed
tteichler commented 2021-01-23 16:45:06 +01:00
Author
Owner
Copy link

marked the checklist item Register django-local account if preference enabled as completed

marked the checklist item **Register django-local account if preference enabled** as completed
tteichler commented 2021-01-23 16:45:08 +01:00
Author
Owner
Copy link

marked the checklist item Enable registration as completed

marked the checklist item **Enable registration** as completed
nik commented 2021-01-23 18:30:59 +01:00
Owner
Copy link

mentioned in merge request !2104

mentioned in merge request !2104
tteichler commented 2021-01-26 21:38:44 +01:00
Author
Owner
Copy link

added 34 commits

  • 02c821f5...dc647698 - 33 commits from branch master
  • 4c640a6c - Merge branch 'master' into 331-user-registration

Compare with previous version

added 34 commits <ul><li>02c821f5...dc647698 - 33 commits from branch <code>master</code></li><li>4c640a6c - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4530&start_sha=02c821f5f7b473c72188cea60e1b084758bc7a7b)
tteichler commented 2021-01-26 22:13:48 +01:00
Author
Owner
Copy link

added 1 commit

  • f05fdeb8 - Clean up code

Compare with previous version

added 1 commit <ul><li>f05fdeb8 - Clean up code</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4535&start_sha=8b8cd0eb70cc80533daa5e5772041a3bf5970f1f)
tteichler commented 2021-01-26 22:17:59 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>28b14412 - Clean up code</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4538&start_sha=f05fdeb81469329ee438372c6fde49056d7dcc37)
tteichler commented 2021-01-26 22:18:12 +01:00
Author
Owner
Copy link

marked the checklist item Enable registration as incomplete

marked the checklist item **Enable registration** as incomplete
tteichler commented 2021-01-26 22:18:14 +01:00
Author
Owner
Copy link

marked the checklist item LDAP account, person linked as incomplete

marked the checklist item **LDAP account, person linked** as incomplete
tteichler commented 2021-01-26 22:18:15 +01:00
Author
Owner
Copy link

marked the checklist item Add social account from one of enabled providers as incomplete

marked the checklist item **Add social account from one of enabled providers** as incomplete
tteichler commented 2021-01-26 22:18:16 +01:00
Author
Owner
Copy link

marked the checklist item Register django-local account if preference enabled as incomplete

marked the checklist item **Register django-local account if preference enabled** as incomplete
tteichler commented 2021-01-27 19:22:09 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f6c9da9d - Clean up code</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4547&start_sha=28b1441250525bb23683ce6e92ea1a698c913de5)
tteichler commented 2021-02-07 18:11:29 +01:00
Author
Owner
Copy link

added 7 commits

  • f6c9da9d...c216a427 - 6 commits from branch master
  • dd3aa077 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 7 commits <ul><li>f6c9da9d...c216a427 - 6 commits from branch <code>master</code></li><li>dd3aa077 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4654&start_sha=f6c9da9d7f2b3840b80e21849e39c0202a843347)
tteichler commented 2021-02-07 21:24:49 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a50309a4 - Fix templates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4672&start_sha=dd3aa0779a105c5960d2c6f9dba1ca59c4635239)
tteichler commented 2021-02-08 17:48:52 +01:00
Author
Owner
Copy link

added 15 commits

  • a50309a4...b528d806 - 14 commits from branch master
  • 1af84364 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 15 commits <ul><li>a50309a4...b528d806 - 14 commits from branch <code>master</code></li><li>1af84364 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4704&start_sha=a50309a4edc4ab788e87e848b68192eb5bc26e79)
nik commented 2021-02-09 23:44:55 +01:00
Owner
Copy link

changed this line in version 46 of the diff

changed this line in [version 46 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4723&start_sha=1af8436483a98a5f32049326584139f2407bfdad#4b49dfded3e25e8e8c8ab3518fc89d3aea48975f_12_12)
nik commented 2021-02-09 23:44:56 +01:00
Owner
Copy link

added 5 commits

  • f49b0514 - Allow users to change their password. Closes #354
  • c2fbe569 - Allow users to change their password. Closes #354
  • 84956b00 - Merge branch '354-change-password' of edugit.org:AlekSIS/Official/AlekSIS-Core...
  • 38ec95c3 - Merge branch '331-user-registration' into 354-change-password
  • 62a075ea - Merge branch '354-change-password' into '331-user-registration'

Compare with previous version

added 5 commits <ul><li>f49b0514 - Allow users to change their password. Closes #354</li><li>c2fbe569 - Allow users to change their password. Closes #354</li><li>84956b00 - Merge branch &#39;354-change-password&#39; of edugit.org:AlekSIS/Official/AlekSIS-Core...</li><li>38ec95c3 - Merge branch &#39;331-user-registration&#39; into 354-change-password</li><li>62a075ea - Merge branch &#39;354-change-password&#39; into &#39;331-user-registration&#39;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4723&start_sha=1af8436483a98a5f32049326584139f2407bfdad)
nik commented 2021-02-09 23:54:22 +01:00
Owner
Copy link

added 3 commits

  • 41c6e768 - Fix templates
  • 2d841027 - Merge branch '331-user-registration' into 353-password-reset
  • c15e244b - Merge branch '353-password-reset' into '331-user-registration'

Compare with previous version

added 3 commits <ul><li>41c6e768 - Fix templates</li><li>2d841027 - Merge branch &#39;331-user-registration&#39; into 353-password-reset</li><li>c15e244b - Merge branch &#39;353-password-reset&#39; into &#39;331-user-registration&#39;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4727&start_sha=62a075ea5b379eadab58979ffb1ccc384e1fc0d8)
nik commented 2021-02-09 23:55:11 +01:00
Owner
Copy link

mentioned in merge request AlekSIS-App-LDAP!1693

mentioned in merge request AlekSIS-App-LDAP!1693
tteichler commented 2021-02-10 15:02:50 +01:00
Author
Owner
Copy link

mentioned in issue #353

mentioned in issue #353
tteichler commented 2021-02-10 15:03:25 +01:00
Author
Owner
Copy link

changed the description

changed the description
tteichler commented 2021-02-10 15:03:35 +01:00
Author
Owner
Copy link

changed the description

changed the description
tteichler commented 2021-02-14 00:07:22 +01:00
Author
Owner
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>28b14412 - Clean up code</li><li>1209a1df - Merge branch &#39;331-user-registration&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4774&start_sha=c15e244b30e7412ab00f0ecc049bad1cbb2e60f5)
hansegucker commented 2021-02-14 17:52:49 +01:00
Owner
Copy link

Is it possible to use the help text as label here? The extra label looks ugly in the frontend.

Is it possible to use the help text as label here? The extra label looks ugly in the frontend.
tteichler commented 2021-02-17 15:38:02 +01:00
Author
Owner
Copy link

added 66 commits

  • 1209a1df...d23be3b6 - 65 commits from branch master
  • 77b61fc9 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 66 commits <ul><li>1209a1df...d23be3b6 - 65 commits from branch <code>master</code></li><li>77b61fc9 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4862&start_sha=1209a1df9de9da771dfb83da9f8f9520a34b9979)
tteichler commented 2021-02-17 20:23:51 +01:00
Author
Owner
Copy link

changed this line in version 50 of the diff

changed this line in [version 50 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4865&start_sha=77b61fc95db57bd931bd392d26274f42369fd102#0c49214c95cc78b406f5e65b2c23b7b58b9dce19_34_35)
tteichler commented 2021-02-17 20:23:51 +01:00
Author
Owner
Copy link

changed this line in version 50 of the diff

changed this line in [version 50 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4865&start_sha=77b61fc95db57bd931bd392d26274f42369fd102#c0c0ec6f3da74f79d6910519ef1c23d677157d30_13_9)
tteichler commented 2021-02-17 20:23:53 +01:00
Author
Owner
Copy link

added 3 commits

Compare with previous version

added 3 commits <ul><li>d0b8a870 - Add password reset link</li><li>dd62ddec - Merge branch &#39;331-user-registration&#39; of...</li><li>60a2b3d7 - REwrite templates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4865&start_sha=77b61fc95db57bd931bd392d26274f42369fd102)
tteichler commented 2021-02-21 19:37:30 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-02-21 19:37:44 +01:00
Author
Owner
Copy link

added 1 commit

  • 91a78776 - Use label instead of help_text

Compare with previous version

added 1 commit <ul><li>91a78776 - Use label instead of help_text</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4925&start_sha=60a2b3d740998241ef49dd50427eb15caeec0b51)
tteichler commented 2021-02-21 21:31:32 +01:00
Author
Owner
Copy link

added 5 commits

  • 91a78776...d50b445b - 4 commits from branch master
  • c33217b2 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 5 commits <ul><li>91a78776...d50b445b - 4 commits from branch <code>master</code></li><li>c33217b2 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=4935&start_sha=91a78776b25a378dfb34dc0ef327846c45b64136)
tteichler commented 2021-02-28 17:02:37 +01:00
Author
Owner
Copy link

added 5 commits

  • c33217b2...77df2d66 - 4 commits from branch master
  • 1de961c1 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 5 commits <ul><li>c33217b2...77df2d66 - 4 commits from branch <code>master</code></li><li>1de961c1 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=5022&start_sha=c33217b2631a6ba66babb107dcee8794de98a4c3)
tteichler commented 2021-03-24 16:36:50 +01:00
Author
Owner
Copy link

added 158 commits

  • 1de961c1...c6f14fe1 - 157 commits from branch master
  • 7882bb4c - Merge branch 'master' into 331-user-registration

Compare with previous version

added 158 commits <ul><li>1de961c1...c6f14fe1 - 157 commits from branch <code>master</code></li><li>7882bb4c - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=6289&start_sha=1de961c13eeedf347494243eee615a26f7017eb1)
tteichler commented 2021-03-31 16:26:13 +02:00
Author
Owner
Copy link

added 24 commits

  • 7882bb4c...262b664b - 23 commits from branch master
  • 6d5e9dac - Merge branch 'master' into 331-user-registration

Compare with previous version

added 24 commits <ul><li>7882bb4c...262b664b - 23 commits from branch <code>master</code></li><li>6d5e9dac - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=6577&start_sha=7882bb4c9e14903e9da820fa19847e110e89728e)
tteichler commented 2021-04-15 21:32:38 +02:00
Author
Owner
Copy link

added 25 commits

  • 6d5e9dac...ab7953bf - 24 commits from branch master
  • 2a851f31 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 25 commits <ul><li>6d5e9dac...ab7953bf - 24 commits from branch <code>master</code></li><li>2a851f31 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=7257&start_sha=6d5e9dac064516e3128f4afa297e301cd5f6bf9c)
hansegucker commented 2021-04-16 09:57:43 +02:00
Owner
Copy link

It is possible to get some updated screenshots to document the final state of this MR?

It is possible to get some updated screenshots to document the final state of this MR?
tteichler commented 2021-04-16 21:07:35 +02:00
Author
Owner
Copy link

added 10 commits

  • 2a851f31...29e673dd - 9 commits from branch master
  • 2dba6aa3 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 10 commits <ul><li>2a851f31...29e673dd - 9 commits from branch <code>master</code></li><li>2dba6aa3 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=7353&start_sha=2a851f31d92662a325c6eedab8323115b62003e1)
tteichler commented 2021-04-17 19:39:18 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>13b12eae - Fix help text in form</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=7440&start_sha=2dba6aa3883a5f38a5d8b8fee6fea875db125f56)
tteichler commented 2021-04-17 19:45:31 +02:00
Author
Owner
Copy link

added 43 commits

  • 13b12eae...1fd6195e - 41 commits from branch master
  • 35de37dc - Merge branch 'master' into 331-user-registration
  • dc5a9e65 - Merge branch '331-user-registration' of...

Compare with previous version

added 43 commits <ul><li>13b12eae...1fd6195e - 41 commits from branch <code>master</code></li><li>35de37dc - Merge branch &#39;master&#39; into 331-user-registration</li><li>dc5a9e65 - Merge branch &#39;331-user-registration&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=7441&start_sha=13b12eae3a274178fcdf09383a5acd0d53e18739)
tteichler commented 2021-04-25 15:02:21 +02:00
Author
Owner
Copy link

added 9 commits

  • dc5a9e65...c7fae2a0 - 8 commits from branch master
  • 0c3778c8 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 9 commits <ul><li>dc5a9e65...c7fae2a0 - 8 commits from branch <code>master</code></li><li>0c3778c8 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=7665&start_sha=dc5a9e65621c0ade7988dd6c91d4a769813c0f25)
tteichler commented 2021-05-04 15:56:03 +02:00
Author
Owner
Copy link

added 15 commits

  • 0c3778c8...db66c5d5 - 14 commits from branch master
  • f8be13d3 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 15 commits <ul><li>0c3778c8...db66c5d5 - 14 commits from branch <code>master</code></li><li>f8be13d3 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=7916&start_sha=0c3778c8172fc2139c6e44c64e2030b8ba61aa6f)
tteichler commented 2021-05-15 12:37:18 +02:00
Author
Owner
Copy link

added 43 commits

  • f8be13d3...bf7dffbe - 40 commits from branch master
  • 9b00a0a1 - Add tests
  • 8b810a8c - Merge branch 'master' into 331-user-registration
  • 0b3069be - Fix url

Compare with previous version

added 43 commits <ul><li>f8be13d3...bf7dffbe - 40 commits from branch <code>master</code></li><li>9b00a0a1 - Add tests</li><li>8b810a8c - Merge branch &#39;master&#39; into 331-user-registration</li><li>0b3069be - Fix url</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8178&start_sha=f8be13d319588b9168a91ea77db568351d7c9b39)
tteichler commented 2021-05-15 14:41:34 +02:00
Author
Owner
Copy link

added 1 commit

  • 4f0087a3 - Add tests

Compare with previous version

added 1 commit <ul><li>4f0087a3 - Add tests</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8220&start_sha=0b3069be2b02e1b8cd39f594121b2edffadf5d97)
tteichler commented 2021-05-15 15:11:13 +02:00
Author
Owner
Copy link

added 1 commit

  • a06863d7 - Add tests

Compare with previous version

added 1 commit <ul><li>a06863d7 - Add tests</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8224&start_sha=4f0087a3e35d8df60a74f0963ef90570f19cf7d4)
tteichler commented 2021-05-15 16:33:00 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>08660b95 - Add tests</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8275&start_sha=a06863d7d661d31f59938ea13e787322aa32da74)
tteichler commented 2021-05-15 22:21:33 +02:00
Author
Owner
Copy link

added 3 commits

  • 7a4ffce2 - Add custom account adapter
  • 8e9e3b90 - Create person on signup
  • 87916c80 - Verify templates

Compare with previous version

added 3 commits <ul><li>7a4ffce2 - Add custom account adapter</li><li>8e9e3b90 - Create person on signup</li><li>87916c80 - Verify templates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8344&start_sha=08660b951a30a0ec8a29ff9bbd53a4368c1fd8c6)
tteichler commented 2021-05-15 22:25:22 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c7bac65e - Verify templates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8346&start_sha=87916c80848f0a688b82801d6284f965b8498583)
tteichler commented 2021-05-15 22:28:03 +02:00
Author
Owner
Copy link

added 45 commits

  • c7bac65e...e546f60c - 44 commits from branch master
  • 794d6707 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 45 commits <ul><li>c7bac65e...e546f60c - 44 commits from branch <code>master</code></li><li>794d6707 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8347&start_sha=c7bac65e15d25113b59e93f1abafcc9c1bd66f41)
tteichler commented 2021-05-15 22:59:23 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>8a1325fa - Fix menu icon</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8349&start_sha=794d6707bdc6fedb21eeae0cd89504baaf1e8370)
tteichler commented 2021-05-15 23:01:18 +02:00
Author
Owner
Copy link

changed the description

changed the description
tteichler commented 2021-05-15 23:01:43 +02:00
Author
Owner
Copy link

changed the description

changed the description
tteichler commented 2021-05-16 13:57:49 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>4743b747 - Fix socialaccount settings</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8426&start_sha=8a1325facb55f7fe7ae3ad7ea597d2a69ae5afca)
tteichler commented 2021-05-16 14:02:01 +02:00
Author
Owner
Copy link

marked the checklist item Social accounts as incomplete

marked the checklist item **Social accounts** as incomplete
tteichler commented 2021-05-16 15:33:06 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c30a7996 - Reformat templates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8462&start_sha=4743b747cd5ca498d74580b7a80cccbcb7e4b046)
tteichler commented 2021-05-16 15:48:01 +02:00
Author
Owner
Copy link

added 10 commits

  • c30a7996...0051b0bd - 9 commits from branch master
  • b9ed1cb5 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 10 commits <ul><li>c30a7996...0051b0bd - 9 commits from branch <code>master</code></li><li>b9ed1cb5 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8464&start_sha=c30a79965aadc318cbcb1867c0bc1b1da0f430a3)
tteichler commented 2021-05-16 17:24:20 +02:00
Author
Owner
Copy link

added 21 commits

  • 23e61718...ed9626d3 - 20 commits from branch master
  • 3f27351b - Merge branch 'master' into 331-user-registration

Compare with previous version

added 21 commits <ul><li>23e61718...ed9626d3 - 20 commits from branch <code>master</code></li><li>3f27351b - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8518&start_sha=23e617187d614a53320c601b73e897f53b3c25bc)
tteichler commented 2021-05-16 19:06:45 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>8e21e8fe - Use custom change view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8544&start_sha=3f27351b4a3b5bdc059bb023ff7e379308ec1951)
tteichler commented 2021-05-18 20:53:42 +02:00
Author
Owner
Copy link

added 11 commits

  • 8e21e8fe...d4bf41b7 - 10 commits from branch master
  • 73247866 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 11 commits <ul><li>8e21e8fe...d4bf41b7 - 10 commits from branch <code>master</code></li><li>73247866 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8650&start_sha=8e21e8fe20c19f318ad94199f8c660c05a182ef1)
tteichler commented 2021-05-18 21:42:14 +02:00
Author
Owner
Copy link

added 1 commit

  • 01799e68 - Fix disabling of password change

Compare with previous version

added 1 commit <ul><li>01799e68 - Fix disabling of password change</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8651&start_sha=732478668e04758fb80277c5e125e713ed236032)
tteichler commented 2021-05-18 21:42:31 +02:00
Author
Owner
Copy link

changed the description

changed the description
tteichler commented 2021-05-18 21:44:45 +02:00
Author
Owner
Copy link

marked the checklist item Disable changing of passwords as completed

marked the checklist item **Disable changing of passwords** as completed
nik commented 2021-05-20 12:24:42 +02:00
Owner
Copy link

Are social accounts still broken here? If so, we need it to be fixed quite immediately, @debdolph @hansegucker

Are social accounts still broken here? If so, we need it to be fixed quite immediately, @debdolph @hansegucker
hansegucker commented 2021-05-20 20:07:20 +02:00
Owner
Copy link

added 34 commits

  • 01799e68...fb172b9f - 33 commits from branch master
  • 9d068430 - Merge branch 'master' into 331-user-registration

Compare with previous version

added 34 commits <ul><li>01799e68...fb172b9f - 33 commits from branch <code>master</code></li><li>9d068430 - Merge branch &#39;master&#39; into 331-user-registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8837&start_sha=01799e6870dab17ff516729d1f0307258f13178f)
tteichler commented 2021-05-20 21:11:35 +02:00
Author
Owner
Copy link

added 5 commits

  • 9d068430...52cde73c - 3 commits from branch master
  • fa4ec33f - Merge branch 'master' into 331-user-registration
  • f1ca5218 - Update lockfile

Compare with previous version

added 5 commits <ul><li>9d068430...52cde73c - 3 commits from branch <code>master</code></li><li>fa4ec33f - Merge branch &#39;master&#39; into 331-user-registration</li><li>f1ca5218 - Update lockfile</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8845&start_sha=9d06843005f1cd88c49b5974598f2e9d21409ee0)
yuha commented 2021-05-20 22:41:30 +02:00
Member
Copy link

added 1 commit

  • f7753869 - Fix automated adding of social auth providers to INSTALLED_APPS

Compare with previous version

added 1 commit <ul><li>f7753869 - Fix automated adding of social auth providers to INSTALLED_APPS</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8873&start_sha=f1ca521814727cd4c011baf2e6bf9352da9ff292)
yuha commented 2021-05-20 22:57:42 +02:00
Member
Copy link

added 1 commit

  • 4122c5f8 - Fix automated adding of social auth providers to INSTALLED_APPS

Compare with previous version

added 1 commit <ul><li>4122c5f8 - Fix automated adding of social auth providers to INSTALLED_APPS</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8878&start_sha=f775386944e32c64e8bfd8778dc9eefc52fa4cff)
yuha commented 2021-05-21 01:07:50 +02:00
Member
Copy link

added 1 commit

  • 3e626237 - Fix deletion of social accounts

Compare with previous version

added 1 commit <ul><li>3e626237 - Fix deletion of social accounts</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8885&start_sha=4122c5f8187f30ff9e2a3d9c782ec657d4cbbc61)
nik commented 2021-05-21 01:08:58 +02:00
Owner
Copy link

marked the checklist item Social accounts as completed

marked the checklist item **Social accounts** as completed
hansegucker commented 2021-05-21 16:11:53 +02:00
Owner
Copy link

changed the description

changed the description
tteichler commented 2021-05-21 16:19:51 +02:00
Author
Owner
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>8ad6ab81 - Update lockfile</li><li>56073272 - Fix code style</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/413/diffs?diff_id=8897&start_sha=3e626237d409daf791884d0aa9f32872a8253496)
hansegucker commented 2021-05-21 16:38:52 +02:00
Owner
Copy link

mentioned in commit 6ca32fa347

mentioned in commit 6ca32fa3478a9f5a9060f9b528bc134ec28a73f6
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2058
No description provided.