Resolve "Improve newly added filters" #1972

Merged

hansegucker merged 6 commits from 294-improve-newly-added-filters into master 2020-07-10 15:52:18 +02:00

Conversation 22 Commits 6 Files changed 8 +83 -45

hansegucker commented 2020-07-06 17:35:49 +02:00

Owner

Copy link

Closes #294

Closes #294

hansegucker commented 2020-07-06 17:36:19 +02:00

Author

Owner

Copy link

added 2 commits

• 7fe69580 - Fix clean method of SchoolTerm (exclude wasn't done correctly)
• c4d8bf59 - Fix typo

Compare with previous version

added 2 commits <ul><li>7fe69580 - Fix clean method of SchoolTerm (exclude wasn&#39;t done correctly)</li><li>c4d8bf59 - Fix typo</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/327/diffs?diff_id=2774&start_sha=68c58c7226e365efad52b63d359329798cdaeea0)

hansegucker commented 2020-07-10 11:22:13 +02:00

Author

Owner

Copy link

added 3 commits

• 79ad5b4b - Add more fields to person and group filters and merge some filter fields
• f86fd9f6 - Remove filters from person and group full views
• 72bd8ed4 - Divide filters by headings and add clear button

Compare with previous version

added 3 commits <ul><li>79ad5b4b - Add more fields to person and group filters and merge some filter fields</li><li>f86fd9f6 - Remove filters from person and group full views</li><li>72bd8ed4 - Divide filters by headings and add clear button</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/327/diffs?diff_id=2781&start_sha=c4d8bf592f1cd29095f30cb09610aa4008010eea)

hansegucker commented 2020-07-10 11:22:43 +02:00

Author

Owner

Copy link

Please review, @nik @debdolph

Please review, @nik @debdolph

hansegucker commented 2020-07-10 11:22:43 +02:00

Author

Owner

Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**

hansegucker commented 2020-07-10 11:22:44 +02:00

Author

Owner

Copy link

assigned to @nik

assigned to @nik

hansegucker commented 2020-07-10 11:25:13 +02:00

Author

Owner

Copy link

added 3 commits

• 72bd8ed4...8612b134 - 2 commits from branch master
• 09bfc385 - Merge branch 'master' into 294-improve-newly-added-filters

Compare with previous version

added 3 commits <ul><li>72bd8ed4...8612b134 - 2 commits from branch <code>master</code></li><li>09bfc385 - Merge branch &#39;master&#39; into 294-improve-newly-added-filters</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/327/diffs?diff_id=2782&start_sha=72bd8ed4845fb0a1d7a94b229daea5640b6bd398)

nik commented 2020-07-10 12:51:21 +02:00

Owner

Copy link

Pipeline failed. Plese check (you can see this yourself IIRC)

Pipeline failed. Plese check (you can see this yourself IIRC)

hansegucker commented 2020-07-10 12:52:48 +02:00

Author

Owner

Copy link

I think it's not my fault that the pipeline failed.

I think it's not my fault that the pipeline failed.

nik commented 2020-07-10 12:52:55 +02:00

Owner

Copy link

Please remove submodule changes from commit history.

Please remove submodule changes from commit history.

hansegucker commented 2020-07-10 12:55:09 +02:00

Author

Owner

Copy link

Ups

Ups

nik commented 2020-07-10 13:00:00 +02:00

Owner

Copy link

Please check rather than think :).

Please check rather than think :).

nik commented 2020-07-10 13:01:01 +02:00

Owner

Copy link

If the failure is unrelated to this change, open an issue to get it fixed. Neither fixing the build nor reporting an out-of-scope failure tells you didn't care.

If the failure is unrelated to this change, open an issue to get it fixed. Neither fixing the build nor reporting an out-of-scope failure tells you didn't care.

tteichler commented 2020-07-10 14:11:03 +02:00

Owner

Copy link

Why did you drop filters from person and group view?

Why did you drop filters from `person` and `group` view?

hansegucker commented 2020-07-10 14:24:34 +02:00

Author

Owner

Copy link

They made this views very confusing and broke the layout.

They made this views very confusing and broke the layout.

hansegucker commented 2020-07-10 14:52:24 +02:00

Author

Owner

Copy link

added 4 commits

• 3f415724 - Fix clean method of SchoolTerm (exclude wasn't done correctly)
• 18caee07 - Fix typo
• c633ffd1 - Add more fields to person and group filters and merge some filter fields
• 1bf5ee80 - Divide filters by headings and add clear button

Compare with previous version

added 4 commits <ul><li>3f415724 - Fix clean method of SchoolTerm (exclude wasn&#39;t done correctly)</li><li>18caee07 - Fix typo</li><li>c633ffd1 - Add more fields to person and group filters and merge some filter fields</li><li>1bf5ee80 - Divide filters by headings and add clear button</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/327/diffs?diff_id=2791&start_sha=09bfc3850c740251a19e980cca331fccd0ab63eb)

hansegucker commented 2020-07-10 15:01:09 +02:00

Author

Owner

Copy link

added 2 commits

• 640ba672 - Add more fields to person and group filters and merge some filter fields
• ecfc61b3 - Divide filters by headings and add clear button

Compare with previous version

added 2 commits <ul><li>640ba672 - Add more fields to person and group filters and merge some filter fields</li><li>ecfc61b3 - Divide filters by headings and add clear button</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/327/diffs?diff_id=2793&start_sha=1bf5ee80bcc564724b9f329a4d132551219ac908)

hansegucker commented 2020-07-10 15:02:56 +02:00

Author

Owner

Copy link

added 4 commits

• 7fe69580 - Fix clean method of SchoolTerm (exclude wasn't done correctly)
• c4d8bf59 - Fix typo
• cbbcf144 - Reformat
• 4df38182 - Merge branch 'fix/views-models' into 294-improve-newly-added-filters

Compare with previous version

added 4 commits <ul><li>7fe69580 - Fix clean method of SchoolTerm (exclude wasn&#39;t done correctly)</li><li>c4d8bf59 - Fix typo</li><li>cbbcf144 - Reformat</li><li>4df38182 - Merge branch &#39;fix/views-models&#39; into 294-improve-newly-added-filters</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/327/diffs?diff_id=2794&start_sha=ecfc61b31871331c1c1053319131a5ee1a483af4)

hansegucker commented 2020-07-10 15:14:03 +02:00

Author

Owner

Copy link

added 4 commits

• c51734a5 - Add more fields to person and group filters and merge some filter fields
• 042c945b - Divide filters by headings and add clear button
• 98d5e9c0 - Fix clean method of SchoolTerm (exclude wasn't done correctly)
• 129f4906 - Reformat

Compare with previous version

added 4 commits <ul><li>c51734a5 - Add more fields to person and group filters and merge some filter fields</li><li>042c945b - Divide filters by headings and add clear button</li><li>98d5e9c0 - Fix clean method of SchoolTerm (exclude wasn&#39;t done correctly)</li><li>129f4906 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/327/diffs?diff_id=2795&start_sha=4df38182d6ea029a7a3b30a2333fbd51bc04fc06)

hansegucker commented 2020-07-10 15:45:58 +02:00

Author

Owner

Copy link

Now it succeeds.

Now it succeeds.

hansegucker commented 2020-07-10 15:46:00 +02:00

Author

Owner

Copy link

resolved all threads

resolved all threads

nik commented 2020-07-10 15:52:17 +02:00

Owner

Copy link

mentioned in commit a7107d14f7

mentioned in commit a7107d14f7045e34f8ce9ad9f8bdab8dc629c830

nik commented 2020-07-10 15:52:18 +02:00

Owner

Copy link

merged

merged

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Security

  

TeX

Needs LaTeX template

  

auto-update

  

board

done

  

board

ready

  

board

todo

  

check

delete-eslint-rc-js

  

check

update-builddeps-package-json

  

check

update-eslint-rc-js

  

check

update-gitignore

  

check

update-merge-request-template

  

check

update-prettier-ignore

  

check

update-pyproject-toml

  

check

update-renovate-json

  

check

update-tox-ini

  

part

backend

Backend (view code, models, logic, etc.)

  

part

ci

  

part

docs

Issue or addition to the documentation

  

part

frontend

Frontend (templates, etc.)

  

part

i18n

Translation or internationalisation issue

  

part

non-technical

Non-technical (policy, maintenance, etc.) issue or discussion

  

part

packaging

Issue concerning the packaging of AlekSIS and components

  

prio

1

Priority High

  

prio

2

Priority Medium

  

prio

3

Priority Low

  

release-mr-5.x

  

size

large

  

size

medium

  

size

small

  

source

customer

Requested by a customer or affiliated user

  

source

customer::fsmw

  

source

customer::fss

  

source

customer::teckids

  

source

downstream

Issue or merge request from other projects using AlekSIS or parts of it

  

type

breaking

  

type

bug

Bug

  

type

feature

New feature

  

type

refactoring

  

workflow

blocked

Issue is blocked by another issue

  

workflow

confirmed

The bug is reproducible and will be fixed

  

workflow

current-todo

  

workflow

discussing

Needs to be discussed before implementation

  

workflow

new-app

Requires new AlekSIS app, which has to be created

  

workflow

wontfix

The bug is not reproducible or the feature was decided against

No labels

Security

TeX

auto-update

board

done

board

ready

board

todo

check

delete-eslint-rc-js

check

update-builddeps-package-json

check

update-eslint-rc-js

check

update-gitignore

check

update-merge-request-template

check

update-prettier-ignore

check

update-pyproject-toml

check

update-renovate-json

check

update-tox-ini

part

backend

part

ci

part

docs

part

frontend

part

i18n

part

non-technical

part

packaging

prio

1

prio

2

prio

3

release-mr-5.x

size

large

size

medium

size

small

source

customer

source

customer::fsmw

source

customer::fss

source

customer::teckids

source

downstream

type

breaking

type

bug

type

feature

type

refactoring

workflow

blocked

workflow

confirmed

workflow

current-todo

workflow

discussing

workflow

new-app

workflow

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

nik

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

aleksis/AlekSIS-Core!1972

No description provided.