Improve newly added filters #294

New issue

Closed

opened 2020-07-02 12:30:46 +02:00 by hansegucker · 6 comments

hansegucker commented

2020-07-02 12:30:46 +02:00

Owner

The following discussion from !1966 should be addressed:

@hansegucker started a discussion: (+1 comment)

Again: I think it was too early to merge this MR. It needs some extra work on frontend issues, also the filters that are used can be improved. Please give your opinions, @debdolph @nik.

As it was a frontend issue, I think, I actually should had done a review on this before merging it.

The following discussion from !1966 should be addressed: - [ ] @hansegucker started a [discussion](https://edugit.org/AlekSIS/official/AlekSIS/-/merge_requests/321#note_13725): (+1 comment) > Again: I think it was too early to merge this MR. It needs some extra work on frontend issues, also the filters that are used can be improved. Please give your opinions, @debdolph @nik. > > As it was a frontend issue, I think, I actually should had done a review on this before merging it.

tteichler commented

2020-07-02 15:27:40 +02:00

Owner

What would you exactly improve?

hansegucker commented

2020-07-02 17:26:06 +02:00

Author

Owner

Options for filtering (maybe someone wants to get all active users, for example)
Labels of fields (I don't like the label "First name contains", maybe "First name" is enough)
The form should be wrapped with a row and a s12-col at least.
I would prefer a less primary look for the "Search" ("Filter") button.

- Options for filtering (maybe someone wants to get all active users, for example) - Labels of fields (I don't like the label "First name contains", maybe "First name" is enough) - The form should be wrapped with a row and a s12-col at least. - I would prefer a less primary look for the "Search" ("Filter") button.

hansegucker commented

2020-07-06 17:35:57 +02:00

Author

Owner

created merge request !1972 to address this issue