aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Add statistics about group to group view #1874

Merged
hansegucker merged 7 commits from group-stats into master 2020-11-08 15:16:37 +01:00
Conversation 32 Commits 7 Files changed 5 +78 -8
tteichler commented 2020-04-22 13:44:36 +02:00
Owner
Copy link

This MR also includes a small fix to avoid calculating age_at for persons where date_of_birth is None.

This MR also includes a small fix to avoid calculating `age_at` for persons where `date_of_birth` is `None`.
nik commented 2020-04-22 15:02:31 +02:00
Owner
Copy link

Please commit this fix separately.

Please commit this fix separately.
nik commented 2020-04-22 15:02:56 +02:00
Owner
Copy link

I am not sure this should go directly in this template.

I am not sure this should go directly in this template.
nik commented 2020-04-22 15:03:25 +02:00
Owner
Copy link

This should be a method on the Group model.

This should be a method on the `Group` model.
nik commented 2020-04-22 15:05:27 +02:00
Owner
Copy link

I am not sure we should enable this by default and in the standard group view, as aggregating data is a separate use case in terms of privacy regulations. At the very least, there must be a separate permission (so I propose doing this after the permissions got merged).

I am not sure we should enable this by default and in the standard group view, as aggregating data is a separate use case in terms of privacy regulations. At the very least, there must be a separate permission (so I propose doing this after the permissions got merged).
tteichler commented 2020-04-22 15:15:45 +02:00
Author
Owner
Copy link

What do you mean, @hansegucker

What do you mean, @hansegucker
tteichler commented 2020-04-22 15:17:24 +02:00
Author
Owner
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/official/AlekSIS/-/merge_requests/229/diffs?diff_id=1837&start_sha=f44fc23c5384bc8893b435f614331a308e9bc7bf#da19f63ebfaac02d499250824afd90af20b474a2_19_19)
tteichler commented 2020-04-22 15:17:41 +02:00
Author
Owner
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/official/AlekSIS/-/merge_requests/229/diffs?diff_id=1837&start_sha=f44fc23c5384bc8893b435f614331a308e9bc7bf#8c15ef90a05145592bdded0de1ca9faad06ca049_176_174)
tteichler commented 2020-04-22 15:17:43 +02:00
Author
Owner
Copy link

added 3 commits

Compare with previous version

added 3 commits <ul><li>42999209 - Add get_group_stats method to Group model</li><li>3a2f141f - Add stats to template</li><li>b501b333 - Fix age_at method</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/229/diffs?diff_id=1837&start_sha=f44fc23c5384bc8893b435f614331a308e9bc7bf)
tteichler commented 2020-04-22 15:26:49 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>0896cccf - Use isnull instead Q</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/229/diffs?diff_id=1838&start_sha=b501b33347409a91c1a765809af0f10413075135)
hansegucker commented 2020-04-22 17:50:43 +02:00
Owner
Copy link

I think there is no problem doing that. Maybe we can make it optional (by settings), but I see no reason why not.

I think there is no problem doing that. Maybe we can make it optional (by settings), but I see no reason why not.
tteichler commented 2020-04-22 18:24:48 +02:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2020-04-22 19:56:25 +02:00
Author
Owner
Copy link

So this is waiting for !1852

~"workflow::blocked"

So this is waiting for !1852 ~"workflow::blocked"
tteichler commented 2020-04-22 19:56:31 +02:00
Author
Owner
Copy link

marked as a Work In Progress

marked as a **Work In Progress**
hansegucker commented 2020-05-16 17:11:23 +02:00
Owner
Copy link

No longer blocked by AlekSIS!1852

No longer blocked by AlekSIS!1852
hansegucker commented 2020-05-16 17:11:32 +02:00
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2020-06-28 16:03:17 +02:00
Author
Owner
Copy link

added 538 commits

  • 0896cccf...d6a0b2bd - 537 commits from branch master
  • 929d12b6 - Merge branch 'master' into group-stats

Compare with previous version

added 538 commits <ul><li>0896cccf...d6a0b2bd - 537 commits from branch <code>master</code></li><li>929d12b6 - Merge branch &#39;master&#39; into group-stats</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/229/diffs?diff_id=2718&start_sha=0896cccf6847f7b4f7e035b972be720530bb067a)
tteichler commented 2020-06-29 09:47:30 +02:00
Author
Owner
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
hansegucker commented 2020-07-12 11:58:17 +02:00
Owner
Copy link

Seems to be fine. Any comments left on this, @nik?

Seems to be fine. Any comments left on this, @nik?
tteichler commented 2020-11-01 13:54:08 +01:00
Author
Owner
Copy link

Anything wrong with this?

Anything wrong with this?
tteichler commented 2020-11-01 13:54:13 +01:00
Author
Owner
Copy link

added 154 commits

  • 929d12b6...b0ffe11b - 153 commits from branch master
  • 9d5bc0a1 - Merge branch 'master' into group-stats

Compare with previous version

added 154 commits <ul><li>929d12b6...b0ffe11b - 153 commits from branch <code>master</code></li><li>9d5bc0a1 - Merge branch &#39;master&#39; into group-stats</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/229/diffs?diff_id=3579&start_sha=929d12b69b088d37396b99f2cd742802ede7bb25)
hansegucker commented 2020-11-01 14:03:45 +01:00
Owner
Copy link

assigned to @nik and unassigned @hansegucker

assigned to @nik and unassigned @hansegucker
hansegucker commented 2020-11-01 14:03:53 +01:00
Owner
Copy link

approved this merge request

approved this merge request
tteichler commented 2020-11-01 14:20:40 +01:00
Author
Owner
Copy link

approved this merge request

approved this merge request
nik commented 2020-11-01 21:37:49 +01:00
Owner
Copy link

I don;t know if it's just me but for instane there seems to be a strikingly obvious absence of screenshots :)!

I don;t know if it's just me but for instane there seems to be a strikingly obvious absence of screenshots :)!
tteichler commented 2020-11-08 14:33:20 +01:00
Author
Owner
Copy link

added 10 commits

  • 9d5bc0a1...f90161bc - 9 commits from branch master
  • 35de8737 - Merge branch 'master' into group-stats

Compare with previous version

added 10 commits <ul><li>9d5bc0a1...f90161bc - 9 commits from branch <code>master</code></li><li>35de8737 - Merge branch &#39;master&#39; into group-stats</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/229/diffs?diff_id=3621&start_sha=9d5bc0a1aef5640881d9ef3f9e63c4340fa13558)
tteichler commented 2020-11-08 15:06:21 +01:00
Author
Owner
Copy link

Screenshot_20201108_150550

![Screenshot_20201108_150550](/uploads/e9a6fc10cad4571a84bfb70ef0c1f109/Screenshot_20201108_150550.png)
tteichler commented 2020-11-08 15:06:22 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2020-11-08 15:16:16 +01:00
Owner
Copy link

assigned to @hansegucker and unassigned @nik

assigned to @hansegucker and unassigned @nik
hansegucker commented 2020-11-08 15:16:38 +01:00
Owner
Copy link

mentioned in commit efe7b67d45

mentioned in commit efe7b67d4595a92a2829197db2b03fd51d256a2b
tteichler commented 2020-11-08 15:20:33 +01:00
Author
Owner
Copy link

mentioned in merge request Teckids/ticdesk!1700

mentioned in merge request Teckids/ticdesk!1700
tteichler approved these changes 2026-07-30 18:40:32 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
hansegucker
debdolph
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!1874
No description provided.