Resolve "Roles and permissions" #1852

Merged
hansegucker merged 47 commits from 25-roles-and-permissions into master 2020-04-22 23:23:00 +02:00
Owner

Closes #25

Closes #25
Author
Owner

changed milestone to %"2.0a2"

changed milestone to %"2.0a2"
Author
Owner

assigned to @nik

assigned to @nik
Author
Owner

added 2 commits

  • 36751aa8 - Add django-rules and django-guardian to pyproject.toml
  • 46e06f98 - Add django-rules and django-guardian settings

Compare with previous version

added 2 commits <ul><li>36751aa8 - Add django-rules and django-guardian to pyproject.toml</li><li>46e06f98 - Add django-rules and django-guardian settings</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1632&start_sha=6185ada4e7f2531baf47f676b4edb9d11e1b43bf)
Author
Owner

added 1 commit

  • 1713b1ad - Add django-rules and django-guardian settings

Compare with previous version

added 1 commit <ul><li>1713b1ad - Add django-rules and django-guardian settings</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1633&start_sha=46e06f984377134d19fd28c599ea0d003962da42)
fph commented 2020-04-05 15:47:56 +02:00 (Migrated from edugit.org)

added 1 commit

  • d48506e6 - First try to implement rules

Compare with previous version

added 1 commit <ul><li>d48506e6 - First try to implement rules</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1636&start_sha=1713b1ad88209a5d5fa088ba5b34c3552c25cb36)
Owner

added 2 commits

  • 5d1a9bd8 - Provide util code for permissions and predicates
  • 06f4d276 - Add permission rules for Person model

Compare with previous version

added 2 commits <ul><li>5d1a9bd8 - Provide util code for permissions and predicates</li><li>06f4d276 - Add permission rules for Person model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1637&start_sha=d48506e6a162d4df839bba8e76c99efef9b95b95)
Owner

added 2 commits

  • 5d1a9bd8 - Provide util code for permissions and predicates
  • 06f4d276 - Add permission rules for Person model

Compare with previous version

added 2 commits <ul><li>5d1a9bd8 - Provide util code for permissions and predicates</li><li>06f4d276 - Add permission rules for Person model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1638&start_sha=d48506e6a162d4df839bba8e76c99efef9b95b95)
Owner

added 1 commit

  • 2ceef829 - Use new BaseModelAdmin

Compare with previous version

added 1 commit <ul><li>2ceef829 - Use new BaseModelAdmin</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1640&start_sha=06f4d27662adcc3d6f46496eb3ffe8b9a39606d9)
Owner

added 9 commits

  • 2ceef829...573f3d12 - 2 commits from branch master
  • 5412ef70 - Add django-rules and django-guardian to pyproject.toml
  • 38dae130 - Add django-rules and django-guardian settings
  • 581d8bb8 - First try to implement rules
  • 6d5d236f - Provide util code for permissions and predicates
  • af785889 - Add permission rules for Person model
  • a74aeeeb - Use new BaseModelAdmin
  • 8fb38b7a - Add permissions for groups view

Compare with previous version

added 9 commits <ul><li>2ceef829...573f3d12 - 2 commits from branch <code>master</code></li><li>5412ef70 - Add django-rules and django-guardian to pyproject.toml</li><li>38dae130 - Add django-rules and django-guardian settings</li><li>581d8bb8 - First try to implement rules</li><li>6d5d236f - Provide util code for permissions and predicates</li><li>af785889 - Add permission rules for Person model</li><li>a74aeeeb - Use new BaseModelAdmin</li><li>8fb38b7a - Add permissions for groups view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1649&start_sha=2ceef829c446d9fcd6c1a343f452dc199d0552ed)
Owner

Please remove this change from commit history.

Please remove this change from commit history.
Author
Owner

added 73 commits

  • 8fb38b7a...a7665dd6 - 72 commits from branch master
  • b7d54702 - Merge branch 'master' into 25-roles-and-permissions

Compare with previous version

added 73 commits <ul><li>8fb38b7a...a7665dd6 - 72 commits from branch <code>master</code></li><li>b7d54702 - Merge branch &#39;master&#39; into 25-roles-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1771&start_sha=8fb38b7a644969db094e96db4ccba90052fd799b)
Author
Owner

added 1 commit

  • 93a8abca - Add first permissions for person object

Compare with previous version

added 1 commit <ul><li>93a8abca - Add first permissions for person object</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1774&start_sha=b7d54702188e5f42f93cbb88462ce3496029a25b)
Author
Owner

added 1 commit

  • ab6116aa - Add first permissions for person object

Compare with previous version

added 1 commit <ul><li>ab6116aa - Add first permissions for person object</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1775&start_sha=93a8abca908d86779658d5fc6e566dab0deca0c0)
Author
Owner

added 1 commit

Compare with previous version

added 1 commit <ul><li>afbab6f5 - Add permission for photo</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1779&start_sha=ab6116aab1f3e0f9f1507cff75c77eccd3d57784)
Author
Owner

added 1 commit

  • 1a6070f8 - Use django-rules instead of django-guardian in template

Compare with previous version

added 1 commit <ul><li>1a6070f8 - Use django-rules instead of django-guardian in template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1780&start_sha=afbab6f5941265be885d3823c7141e0936839eae)
Member

added 1 commit

  • 47ee8d6f - Adhere to other rules, therefore replace "see" with "view"

Compare with previous version

added 1 commit <ul><li>47ee8d6f - Adhere to other rules, therefore replace &quot;see&quot; with &quot;view&quot;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1781&start_sha=1a6070f838155ee065abccda23a391fa08360081)
Member

added 1 commit

  • accb7f3a - Add rules that were already mentioned in template

Compare with previous version

added 1 commit <ul><li>accb7f3a - Add rules that were already mentioned in template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1783&start_sha=47ee8d6f4ecd201c7c60c5a9c19d360c70230441)
Member

added 1 commit

  • e6961eea - Add rules that were already mentioned in template

Compare with previous version

added 1 commit <ul><li>e6961eea - Add rules that were already mentioned in template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1784&start_sha=accb7f3a5a011e8e5c2827d7203deade0f69cf14)
Member

added 1 commit

  • cd94541a - Add rules that were already mentioned in template

Compare with previous version

added 1 commit <ul><li>cd94541a - Add rules that were already mentioned in template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1785&start_sha=e6961eeac78f14f6116442b4f77bc529f132733b)
Author
Owner

added 1 commit

Compare with previous version

added 1 commit <ul><li>87bb772c - Add migration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1786&start_sha=cd94541ae5dbf08a5f267154a131fd9a16648a3c)
Author
Owner

added 1 commit

  • 8eef83d5 - Add permissions for view persons groups

Compare with previous version

added 1 commit <ul><li>8eef83d5 - Add permissions for view persons groups</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1787&start_sha=87bb772c9a4769403696a4365250108d461c2939)
Author
Owner

added 1 commit

  • 75f59c4c - Add permissions for view persons groups

Compare with previous version

added 1 commit <ul><li>75f59c4c - Add permissions for view persons groups</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1788&start_sha=8eef83d5207847affb4bc5ac13a851190d48c9e6)
Author
Owner

added 1 commit

  • e2b812f9 - Add permissions to views

Compare with previous version

added 1 commit <ul><li>e2b812f9 - Add permissions to views</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1789&start_sha=75f59c4c39cb288bd3a5a8db2cdcabe88a51053c)
Member

added 1 commit

Compare with previous version

added 1 commit <ul><li>80d113cd - Add rules for all views</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1805&start_sha=e2b812f9bbecabac2ad3883601b03cbfdf8246b9)
Member

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1814&start_sha=80d113cd1d7d6b3976b885dcfed8084aebf07638#2e44ad1f61249cf0440bea20d23bd07cc7f3a61a_535_545)
Member

added 15 commits

  • 135ed457 - Add migration for global permission model
  • a4192086 - Remove unnecessary django-rules objectgetter import in models
  • caa7923b - Change edit_schoolterm permission name to fit right name
  • 6a8bdd32 - Fix formatting
  • a9155ed3 - Fix get_announcement_by_pk argument issue
  • b62fb670 - Fixed typo
  • 46a2e04d - Change "edit" to "change" to fit django standard permissions
  • aca54110 - Fixed schoolterm spelling
  • c6bbfb87 - Fixed announcement permissions typos
  • 9d0129ce - Rearrange and add view admin menu permission
  • c63e223d - Reformat
  • dfe6836d - Reformat
  • 201ee5a1 - Add non-managed model for non-model-related global permissions
  • a4d0ad13 - Remove unnecessary validator
  • a59a1063 - Replace admin section validators with django-rules-based custom validators

Compare with previous version

added 15 commits <ul><li>135ed457 - Add migration for global permission model</li><li>a4192086 - Remove unnecessary django-rules objectgetter import in models</li><li>caa7923b - Change edit_schoolterm permission name to fit right name</li><li>6a8bdd32 - Fix formatting</li><li>a9155ed3 - Fix get_announcement_by_pk argument issue</li><li>b62fb670 - Fixed typo</li><li>46a2e04d - Change &quot;edit&quot; to &quot;change&quot; to fit django standard permissions</li><li>aca54110 - Fixed schoolterm spelling</li><li>c6bbfb87 - Fixed announcement permissions typos</li><li>9d0129ce - Rearrange and add view admin menu permission</li><li>c63e223d - Reformat</li><li>dfe6836d - Reformat</li><li>201ee5a1 - Add non-managed model for non-model-related global permissions</li><li>a4d0ad13 - Remove unnecessary validator</li><li>a59a1063 - Replace admin section validators with django-rules-based custom validators</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1814&start_sha=80d113cd1d7d6b3976b885dcfed8084aebf07638)
Member

added 2 commits

  • 38dcd2c6 - Replace decorators for dashboard and search with django-rules decorators,...
  • ef5d6135 - Drop decorators.py since it is not needed anymore

Compare with previous version

added 2 commits <ul><li>38dcd2c6 - Replace decorators for dashboard and search with django-rules decorators,...</li><li>ef5d6135 - Drop decorators.py since it is not needed anymore</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1815&start_sha=a59a10638f57434f5c56aa6eb5cef8386be24a8f)
Member

added 10 commits

  • 81e75233 - Fix get_announcement_by_pk argument issue
  • f8b3ba9e - Change "edit" to "change" to fit django standard permissions
  • 25cf992e - Changed schoolterm spelling to fit model
  • 59fbe282 - Fixed announcement permissions typos
  • 2b483b36 - Rearrange and add "view admin menu" permission
  • fb95d9d6 - Add non-managed model for non-model-related global permissions
  • 0bcd3001 - Remove unnecessary validator
  • 79912be6 - Replace admin section validators with django-rules-based custom validators in menu
  • c48d8134 - Replace decorators for dashboard and search with django-rules decorators,...
  • 7f3a445d - Drop decorators.py since it is not needed anymore

Compare with previous version

added 10 commits <ul><li>81e75233 - Fix get_announcement_by_pk argument issue</li><li>f8b3ba9e - Change &quot;edit&quot; to &quot;change&quot; to fit django standard permissions</li><li>25cf992e - Changed schoolterm spelling to fit model</li><li>59fbe282 - Fixed announcement permissions typos</li><li>2b483b36 - Rearrange and add &quot;view admin menu&quot; permission</li><li>fb95d9d6 - Add non-managed model for non-model-related global permissions</li><li>0bcd3001 - Remove unnecessary validator</li><li>79912be6 - Replace admin section validators with django-rules-based custom validators in menu</li><li>c48d8134 - Replace decorators for dashboard and search with django-rules decorators,...</li><li>7f3a445d - Drop decorators.py since it is not needed anymore</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1816&start_sha=ef5d6135fd8b8c11b2ab6755e02e66170e16a011)
Owner

Please rename to is_current_person.

Please rename to `is_current_person`.
Owner

Please rename to has_person.

Please rename to `has_person`.
Owner

Please use relative imports.

Please use relative imports.
Owner

Please use relative imports.

Please use relative imports.
Member

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1817&start_sha=7f3a445d898b600326a1d5c5a572fac9640d9bf0#f18032ae09f8cc14c59919f1376970c13eb57713_83_83)
Member

added 1 commit

  • e6206af4 - Rename is_person predicate to is_current_person

Compare with previous version

added 1 commit <ul><li>e6206af4 - Rename is_person predicate to is_current_person</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1817&start_sha=7f3a445d898b600326a1d5c5a572fac9640d9bf0)
Member

added 1 commit

  • 240f4f6f - Rename has_person_predicate predicate to has_predicate

Compare with previous version

added 1 commit <ul><li>240f4f6f - Rename has_person_predicate predicate to has_predicate</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1818&start_sha=e6206af4011ddf45960bd97f116123d157a3a150)
Member

changed this line in version 27 of the diff

changed this line in [version 27 of the diff](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1819&start_sha=240f4f6f940165b883e353bf7ee374c5a7c46623#f18032ae09f8cc14c59919f1376970c13eb57713_9_9)
Member

added 1 commit

  • 041f65d2 - Rename has_person_predicate predicate to has_predicate

Compare with previous version

added 1 commit <ul><li>041f65d2 - Rename has_person_predicate predicate to has_predicate</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1819&start_sha=240f4f6f940165b883e353bf7ee374c5a7c46623)
Member

added 1 commit

  • 412e0798 - Uncomment maintain_default_data classmethod

Compare with previous version

added 1 commit <ul><li>412e0798 - Uncomment maintain_default_data classmethod</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1820&start_sha=041f65d2f109bacc4b57e9b89c3ecd4441f344c7)
Member

changed this line in version 29 of the diff

changed this line in [version 29 of the diff](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1821&start_sha=412e079831255c58821454ac1837ed9ca5a7b472#216f48f50c6758eba4a72b334fd1ea4e6af4b3c0_3_3)
Member

added 2 commits

  • 60eac122 - Change absolute imports to relative imports
  • 1373ba04 - Change absolute imports to relative imports

Compare with previous version

added 2 commits <ul><li>60eac122 - Change absolute imports to relative imports</li><li>1373ba04 - Change absolute imports to relative imports</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1821&start_sha=412e079831255c58821454ac1837ed9ca5a7b472)
Member

added 1 commit

  • 75769933 - Change absolute imports to relative imports

Compare with previous version

added 1 commit <ul><li>75769933 - Change absolute imports to relative imports</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1822&start_sha=1373ba0467ef22b9a7361201c83162669e0a450d)
Member

resolved all threads

resolved all threads
Member

unmarked as a Work In Progress

unmarked as a **Work In Progress**
Author
Owner

added 33 commits

  • 75769933...8e52fe4f - 32 commits from branch master
  • 8ff41a99 - Merge branch 'master' into 25-roles-and-permissions

Compare with previous version

added 33 commits <ul><li>75769933...8e52fe4f - 32 commits from branch <code>master</code></li><li>8ff41a99 - Merge branch &#39;master&#39; into 25-roles-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1823&start_sha=757699335898080434f2bc183b7940145893a9ba)
Author
Owner

added 1 commit

  • e1ae2101 - Remove duplicated app from pyproject

Compare with previous version

added 1 commit <ul><li>e1ae2101 - Remove duplicated app from pyproject</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1824&start_sha=8ff41a997ed4a1bb87551a77eef831ca87c5ff5e)
Author
Owner

added 2 commits

Compare with previous version

added 2 commits <ul><li>5706d3bd - UPdate poetry.lock</li><li>8e597c57 - UPdate Dashboardfeeds</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1827&start_sha=e1ae210125b98e76b85d86bd131d4ebe3dcf850a)
Author
Owner

added 3 commits

  • 8e597c57...11f240c9 - 2 commits from branch master
  • 2e5ee8de - Merge branch 'master' into 25-roles-and-permissions

Compare with previous version

added 3 commits <ul><li>8e597c57...11f240c9 - 2 commits from branch <code>master</code></li><li>2e5ee8de - Merge branch &#39;master&#39; into 25-roles-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1828&start_sha=8e597c577d91047fe6771f011e94334830a9295c)
Author
Owner

added 1 commit

Compare with previous version

added 1 commit <ul><li>b9330396 - Remove old import</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1829&start_sha=2e5ee8dec5faabd8e12b839b1ef89dc0a8f339e3)
Owner

added 1 commit

  • 8bc8142c - Silence system check about guardian not being hooked

Compare with previous version

added 1 commit <ul><li>8bc8142c - Silence system check about guardian not being hooked</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1830&start_sha=b9330396bc9811853099b02b2aaf542a66c70066)
Author
Owner

added 2 commits

  • c7770ece - Fix name of rule
  • 28fa2009 - Merge branch '25-roles-and-permissions' of edugit.org:AlekSIS/official/AlekSIS...

Compare with previous version

added 2 commits <ul><li>c7770ece - Fix name of rule</li><li>28fa2009 - Merge branch &#39;25-roles-and-permissions&#39; of edugit.org:AlekSIS/official/AlekSIS...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1831&start_sha=8bc8142c44f3219f3231260f23e64a026c98e072)
Author
Owner

added 1 commit

  • 419d3ae5 - Add permission for personal details

Compare with previous version

added 1 commit <ul><li>419d3ae5 - Add permission for personal details</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1832&start_sha=28fa20095d10da9ee9682bc0c1fa2b2143edea22)
Author
Owner

added 1 commit

  • f4cb5f1d - Add permission for personal details

Compare with previous version

added 1 commit <ul><li>f4cb5f1d - Add permission for personal details</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1833&start_sha=419d3ae588759988e69223976b0b97c937d52617)
Author
Owner

The search feature does not respect permissions yet.

Also the sidenav does strange things while searching (a scrollbar appears,…)

The search feature does not respect permissions yet. Also the sidenav does strange things while searching (a scrollbar appears,…)
Member

added 1 commit

  • 90dee43a - Fix search field flickering bug and hide it if user has no search permission

Compare with previous version

added 1 commit <ul><li>90dee43a - Fix search field flickering bug and hide it if user has no search permission</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1839&start_sha=f4cb5f1d370d5b3469cbee3227d617d45ad3d93e)
Author
Owner

mentioned in merge request !1874

mentioned in merge request !1874
Member

marked as a Work In Progress

marked as a **Work In Progress**
Member

added 2 commits

  • eefc706a - Remove login_required import since it is not required anymore
  • 73bbe508 - Add permission check for search

Compare with previous version

added 2 commits <ul><li>eefc706a - Remove login_required import since it is not required anymore</li><li>73bbe508 - Add permission check for search</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1840&start_sha=90dee43a322b1d8c62a14913ac26018f42e3f92e)
Owner

added 1 commit

  • 526e2874 - Reintroduce permission check on searchbar snippets

Compare with previous version

added 1 commit <ul><li>526e2874 - Reintroduce permission check on searchbar snippets</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/207/diffs?diff_id=1841&start_sha=73bbe508074dd4bef04bbf9604957795b1088ba1)
Owner

unmarked as a Work In Progress

unmarked as a **Work In Progress**
Owner

mentioned in commit c2439d0279

mentioned in commit c2439d02799e04d9808a212a3b5ca9df5c318771
Owner

merged

merged
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!1852
No description provided.