aleksis/AlekSIS-App-Chronos
8
0
Fork 0
Code Issues 51 Pull requests 5 Projects Releases 4 Packages Activity Actions

Introduce substitution to do list #633

Merged
yuha merged 127 commits from 225-introduce-substitution-to-do-list-generated-from-teachers-absences into master 2024-12-08 13:20:50 +01:00
Conversation 246 Commits 127 Files changed 19 +1583 -32
yuha commented 2024-01-02 16:07:01 +01:00 (Migrated from edugit.org)
Copy link

Closes #225

grafik

Closes #225 ![grafik](/uploads/3bfe50b519c2b10b23807d67b4d6b2cc/grafik.png)
yuha commented 2024-01-02 16:07:01 +01:00 (Migrated from edugit.org)
Copy link

assigned to @yuha

assigned to @yuha
yuha commented 2024-01-02 16:07:50 +01:00 (Migrated from edugit.org)
Copy link

added 12 commits

  • 315680b9...b530b4ee - 12 commits from branch master

Compare with previous version

added 12 commits <ul><li>315680b9...b530b4ee - 12 commits from branch <code>master</code></li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=37473&start_sha=315680b9978f503ef87ca92982b268374211f40d)
yuha commented 2024-01-02 17:12:39 +01:00 (Migrated from edugit.org)
Copy link

added 86 commits

  • b530b4ee...87873a96 - 76 earlier commits
  • ef150b95 - Merge branch 'master' into new-model-based-on-calendar
  • 1d3d4ead - Merge branch 'new-model-based-on-calendar' of...
  • 0947c567 - Update pyproject.toml
  • 25585b51 - Fix lint
  • fa1706c9 - Drop outdated regression test
  • c2a4ccb8 - Bump version
  • 3e10726d - Correctly show supervisions in the calendar
  • 315680b9 - Add supervisions to timetable
  • c6af6bed - Merge branch 'new-model-based-on-calendar' into 211-implement-vue-substitution-frontend
  • ceb66e6b - Merge branch '211-implement-vue-substitution-frontend' into...

Compare with previous version

added 86 commits <ul><li>b530b4ee...87873a96 - 76 earlier commits</li><li>ef150b95 - Merge branch &#39;master&#39; into new-model-based-on-calendar</li><li>1d3d4ead - Merge branch &#39;new-model-based-on-calendar&#39; of...</li><li>0947c567 - Update pyproject.toml</li><li>25585b51 - Fix lint</li><li>fa1706c9 - Drop outdated regression test</li><li>c2a4ccb8 - Bump version</li><li>3e10726d - Correctly show supervisions in the calendar</li><li>315680b9 - Add supervisions to timetable</li><li>c6af6bed - Merge branch &#39;new-model-based-on-calendar&#39; into 211-implement-vue-substitution-frontend</li><li>ceb66e6b - Merge branch &#39;211-implement-vue-substitution-frontend&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=37474&start_sha=b530b4eed4e07f5804df7c1ece4d2ec8aaad6970)
yuha commented 2024-01-02 17:28:45 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • e0043603 - Merge branch '211-implement-vue-substitution-frontend' into...

Compare with previous version

added 1 commit <ul><li>e0043603 - Merge branch &#39;211-implement-vue-substitution-frontend&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=37479&start_sha=ceb66e6b0c19b7dbc6cee6672e8e8e75e0710209)
yuha commented 2024-01-02 17:29:16 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 7286c731 - Merge branch '211-implement-vue-substitution-frontend' into...

Compare with previous version

added 1 commit <ul><li>7286c731 - Merge branch &#39;211-implement-vue-substitution-frontend&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=37480&start_sha=e0043603ea42403330de63aa092e0bf2393a302a)
hansegucker commented 2024-01-03 14:37:03 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as draft

marked this merge request as **draft**
yuha commented 2024-01-15 17:23:08 +01:00 (Migrated from edugit.org)
Copy link

added 24 commits

  • 7286c731...bdd25787 - 20 commits from branch master
  • efeed7b3 - Merge branch 'master' into new-model-based-on-calendar
  • e105841a - Fix migrations
  • 197cc817 - Remove (unused) model and form extensions
  • 56621109 - Merge branch 'new-model-based-on-calendar' into...

Compare with previous version

added 24 commits <ul><li>7286c731...bdd25787 - 20 commits from branch <code>master</code></li><li>efeed7b3 - Merge branch &#39;master&#39; into new-model-based-on-calendar</li><li>e105841a - Fix migrations</li><li>197cc817 - Remove (unused) model and form extensions</li><li>56621109 - Merge branch &#39;new-model-based-on-calendar&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=38066&start_sha=7286c731d7a3f3a08c035b58d850dbd85a574be3)
yuha commented 2024-01-21 23:13:53 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 409c1b68 - WIP: Add very basic substitution to-do-list

Compare with previous version

added 1 commit <ul><li>409c1b68 - WIP: Add very basic substitution to-do-list</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=38262&start_sha=566211098eba8ff6bed8b9f8335e9c3eb5d01353)
yuha commented 2024-01-22 12:02:28 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • ae28f3df - WIP: Add very basic substitution to-do-list

Compare with previous version

added 1 commit <ul><li>ae28f3df - WIP: Add very basic substitution to-do-list</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=38264&start_sha=409c1b68230da2c36db7c48542d5a6efa4e48604)
yuha commented 2024-01-24 20:40:02 +01:00 (Migrated from edugit.org)
Copy link

changed title from Draft: {-Add view for all timetables with lesson events-} to Draft: {+Introduce substitution to do list+}

changed title from **Draft: {-Add view for all timetables with lesson events-}** to **Draft: {+Introduce substitution to do list+}**
yuha commented 2024-02-10 23:18:09 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • d367711f - WIP: Add very basic substitution to-do-list

Compare with previous version

added 1 commit <ul><li>d367711f - WIP: Add very basic substitution to-do-list</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=38999&start_sha=ae28f3df0035e1de9ccf20020cc675cfacd3a30b)
yuha commented 2024-02-13 18:46:49 +01:00 (Migrated from edugit.org)
Copy link

added 6 commits

  • 89e7d348 - Allow filtering LessonEvents by course
  • 6552e7fc - Add graphene type for LessonEvent
  • 4a7d8da4 - Fix "No newline at end of file"
  • 750ff75a - Allow filtering for amended and amending LessonEvents in get_objects
  • fa84c9d8 - WIP: Add very basic substitution to-do-list
  • 8c8cb592 - Merge branch 'new-model-based-on-calendar' into...

Compare with previous version

added 6 commits <ul><li>89e7d348 - Allow filtering LessonEvents by course</li><li>6552e7fc - Add graphene type for LessonEvent</li><li>4a7d8da4 - Fix &quot;No newline at end of file&quot;</li><li>750ff75a - Allow filtering for amended and amending LessonEvents in get_objects</li><li>fa84c9d8 - WIP: Add very basic substitution to-do-list</li><li>8c8cb592 - Merge branch &#39;new-model-based-on-calendar&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=39104&start_sha=d367711f0cce3a96a12d644e6a7e2a3f51fe01fa)
yuha commented 2024-02-22 14:25:12 +01:00 (Migrated from edugit.org)
Copy link

added 7 commits

  • d1af59cf - Allow filtering for own lessons as teacher
  • fdd0d935 - Bump dev version
  • ae6f14ac - Fix get_objects filtering for all/own lessons
  • e1695a38 - Translate timetable types in frontend
  • e028f57d - Reformat
  • 63826a5d - Show all groups in timetable view
  • 089667c1 - Merge branch 'new-model-based-on-calendar' into...

Compare with previous version

added 7 commits <ul><li>d1af59cf - Allow filtering for own lessons as teacher</li><li>fdd0d935 - Bump dev version</li><li>ae6f14ac - Fix get_objects filtering for all/own lessons</li><li>e1695a38 - Translate timetable types in frontend</li><li>e028f57d - Reformat</li><li>63826a5d - Show all groups in timetable view</li><li>089667c1 - Merge branch &#39;new-model-based-on-calendar&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=39525&start_sha=8c8cb592e7cb680bdde564381be2c2a9444d1d02)
yuha commented 2024-02-24 02:16:41 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 49d9e866 - Reformat, add translations and fix gql queries

Compare with previous version

added 1 commit <ul><li>49d9e866 - Reformat, add translations and fix gql queries</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=39571&start_sha=089667c1dfca5ea0ab9f0e4fa944d2bf05c3dda3)
yuha commented 2024-02-24 18:02:49 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 610499a7 - Reformat, add translations and fix gql queries

Compare with previous version

added 1 commit <ul><li>610499a7 - Reformat, add translations and fix gql queries</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=39630&start_sha=49d9e86622d7aa3559f05e44a435c897bb7ac5cc)
yuha commented 2024-02-24 18:09:24 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • d118ed16 - Reformat, add translations and fix gql queries

Compare with previous version

added 1 commit <ul><li>d118ed16 - Reformat, add translations and fix gql queries</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=39631&start_sha=610499a7cbecda2860a1db2acdbc91a82060a19d)
yuha commented 2024-02-25 17:51:31 +01:00 (Migrated from edugit.org)
Copy link

added 8 commits

  • 955800d1 - Specify active icon for chronos
  • f0a822c1 - Merge branch 'new-model-based-on-calendar' into 211-implement-vue-substitution-frontend
  • b022bdba - Merge branch '211-implement-vue-substitution-frontend' into...
  • 19e2816e - Adapt to CRUD refactoring
  • cf092d08 - Properly handle LessonEvents without subject
  • 3aae76cc - Merge branch '211-implement-vue-substitution-frontend' into...
  • 40edcdd0 - Adapt deletion of substitutions to CRUD refactoring
  • a96875bc - Merge branch '211-implement-vue-substitution-frontend' into...

Compare with previous version

added 8 commits <ul><li>955800d1 - Specify active icon for chronos</li><li>f0a822c1 - Merge branch &#39;new-model-based-on-calendar&#39; into 211-implement-vue-substitution-frontend</li><li>b022bdba - Merge branch &#39;211-implement-vue-substitution-frontend&#39; into...</li><li>19e2816e - Adapt to CRUD refactoring</li><li>cf092d08 - Properly handle LessonEvents without subject</li><li>3aae76cc - Merge branch &#39;211-implement-vue-substitution-frontend&#39; into...</li><li>40edcdd0 - Adapt deletion of substitutions to CRUD refactoring</li><li>a96875bc - Merge branch &#39;211-implement-vue-substitution-frontend&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=39687&start_sha=d118ed16df060f65c4857e1e9347164975ddc083)
yuha commented 2024-02-25 21:22:38 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 262dc6fc - Merge branch '211-implement-vue-substitution-frontend' into...

Compare with previous version

added 1 commit <ul><li>262dc6fc - Merge branch &#39;211-implement-vue-substitution-frontend&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=39710&start_sha=a96875bcd9cdbfe637a10dbe5266d348ab5e8147)
yuha commented 2024-03-06 20:06:58 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>37f416ea - Fix predicate</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=40360&start_sha=262dc6fc1ed459d884b24027503e9b3eb1efa0e7)
yuha commented 2024-03-07 16:47:39 +01:00 (Migrated from edugit.org)
Copy link

TODO: Some substitutions are not displayed correctly in timetables

TODO: Some substitutions are not displayed correctly in timetables
yuha commented 2024-03-07 16:47:50 +01:00 (Migrated from edugit.org)
Copy link

TODO: Menu point naming is confusing

TODO: Menu point naming is confusing
yuha commented 2024-03-07 17:33:21 +01:00 (Migrated from edugit.org)
Copy link

TODO: Time range selection fields

TODO: Time range selection fields
yuha commented 2024-03-07 17:33:26 +01:00 (Migrated from edugit.org)
Copy link

.

.
yuha commented 2024-03-07 17:35:03 +01:00 (Migrated from edugit.org)
Copy link

(similar to coursebook)

(similar to coursebook)
hansegucker commented 2024-03-07 21:49:59 +01:00 (Migrated from edugit.org)
Copy link

There are some fixes related to this in !614. I am not sure whether they are already adapted here.

There are some fixes related to this in !614. I am not sure whether they are already adapted here.
yuha commented 2024-03-11 11:48:20 +01:00 (Migrated from edugit.org)
Copy link

I'll have a look, thanks for the hint

I'll have a look, thanks for the hint
yuha commented 2024-03-11 12:11:42 +01:00 (Migrated from edugit.org)
Copy link

added 7 commits

  • 37f416ea...00ac1913 - 5 commits from branch master
  • 1a573779 - Merge branch 'new-model-based-on-calendar' into...
  • f94b824e - Adapt to dropping of real_amends

Compare with previous version

added 7 commits <ul><li>37f416ea...00ac1913 - 5 commits from branch <code>master</code></li><li>1a573779 - Merge branch &#39;new-model-based-on-calendar&#39; into...</li><li>f94b824e - Adapt to dropping of real_amends</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=40459&start_sha=37f416ea56a1f28e29e8417ad5bb422c12e986eb)
yuha commented 2024-03-11 12:16:02 +01:00 (Migrated from edugit.org)
Copy link

added 6 commits

  • f94b824e...ccbc6ee0 - 3 commits from branch master
  • 0e1ffed5 - Merge branch 'master' into 211-implement-vue-substitution-frontend
  • bb438cc7 - Reformat and fix lint
  • 3bec1bec - Merge branch '211-implement-vue-substitution-frontend' into...

Compare with previous version

added 6 commits <ul><li>f94b824e...ccbc6ee0 - 3 commits from branch <code>master</code></li><li>0e1ffed5 - Merge branch &#39;master&#39; into 211-implement-vue-substitution-frontend</li><li>bb438cc7 - Reformat and fix lint</li><li>3bec1bec - Merge branch &#39;211-implement-vue-substitution-frontend&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=40461&start_sha=f94b824eefb146ed50c48b4968e31c4af817ddc6)
yuha commented 2024-04-04 21:34:51 +02:00 (Migrated from edugit.org)
Copy link

FIXME: the amendment related managers are broken – all LessonEvents with one ore more LEs they amend/that amends them are filtered out (which is not we want in this situation since we're dealing with individual lessons) – maybe the mechanism of get_single_events does this already in the correct way (by evaluating ical, cf alsijil)?

FIXME: the amendment related managers are broken – all LessonEvents with one ore more LEs they amend/that amends them are filtered out (which is not we want in this situation since we're dealing with individual lessons) – maybe the mechanism of get_single_events does this already in the correct way (by evaluating ical, cf alsijil)?
yuha commented 2024-04-17 11:33:49 +02:00 (Migrated from edugit.org)
Copy link

added 38 commits

  • 3bec1bec...7274012b - 37 commits from branch master
  • 400c5787 - Merge branch '216-add-preference-for-group-type-to-show-in-timetable-view' into 'master'

Compare with previous version

added 38 commits <ul><li>3bec1bec...7274012b - 37 commits from branch <code>master</code></li><li>400c5787 - Merge branch &#39;216-add-preference-for-group-type-to-show-in-timetable-view&#39; into &#39;master&#39;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=41904&start_sha=3bec1bec63efd8cbc0a68cb066d2583484665637)
yuha commented 2024-04-17 12:13:41 +02:00 (Migrated from edugit.org)
Copy link

not_amending does work correctly after all, since it filters for LessonEvents that have amended set, which are usually single lesson events amending a repetitive lesson event

`not_amending` does work correctly after all, since it filters for `LessonEvents` that have `amended` set, which are usually single lesson events amending a repetitive lesson event
yuha commented 2024-04-17 12:27:07 +02:00 (Migrated from edugit.org)
Copy link

see https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1448

must wait for @permcu 's changes regarding the dynamic loading mechanism in coursebook

see https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1448 must wait for @permcu 's changes regarding the dynamic loading mechanism in coursebook
yuha commented 2024-04-17 17:50:36 +02:00 (Migrated from edugit.org)
Copy link

seems to be fine now

seems to be fine now
yuha commented 2024-04-17 18:08:41 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>cbdf65c2 - Remove uneeded comment</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=41918&start_sha=400c57873b82578cb8d0c0380ac143a4ffb17e47)
yuha commented 2024-04-17 18:16:54 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 4d0ef3de - Change wording to "substitution (lesson)" in some cases

Compare with previous version

added 1 commit <ul><li>4d0ef3de - Change wording to &quot;substitution (lesson)&quot; in some cases</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=41920&start_sha=cbdf65c22225d6955160ad3afe16979e42dd2b58)
yuha commented 2024-04-17 18:33:05 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 42022c38 - Change wording to "substitution (lesson)" in some cases

Compare with previous version

added 1 commit <ul><li>42022c38 - Change wording to &quot;substitution (lesson)&quot; in some cases</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=41922&start_sha=4d0ef3de68cf9c8aba7817b927e1d4d58c120748)
yuha commented 2024-04-17 18:36:28 +02:00 (Migrated from edugit.org)
Copy link

This would, in general, massively benefit from some components built for the new coursebook being generalised (e.g. LessonInformation)

This would, in general, massively benefit from some components built for the new coursebook being generalised (e.g. `LessonInformation`)
yuha commented 2024-04-18 15:45:04 +02:00 (Migrated from edugit.org)
Copy link

Filter by teachers

Filter by teachers
yuha commented 2024-04-18 15:51:44 +02:00 (Migrated from edugit.org)
Copy link

TODO: Add information box (including note that absences can be added in kolego) & possible allow adding absences on same page?

TODO: Add information box (including note that absences can be added in kolego) & possible allow adding absences on same page?
yuha commented 2024-04-18 23:31:46 +02:00 (Migrated from edugit.org)
Copy link

added 5 commits

  • 5601afca - Change date design
  • d80db3a0 - Remove CRUDIterator elevation
  • 698cbffd - Remove some margin
  • 19b7b681 - Move component related to substitution overview to seperate folder
  • cce0c911 - Layout improvements

Compare with previous version

added 5 commits <ul><li>5601afca - Change date design</li><li>d80db3a0 - Remove CRUDIterator elevation</li><li>698cbffd - Remove some margin</li><li>19b7b681 - Move component related to substitution overview to seperate folder</li><li>cce0c911 - Layout improvements</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42059&start_sha=42022c380882c0450a39b1992ea969ceea900ea8)
yuha commented 2024-04-21 16:32:19 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 23280f8c - Reorganise grouping of substitution lessons (taken from coursebook)

Compare with previous version

added 1 commit <ul><li>23280f8c - Reorganise grouping of substitution lessons (taken from coursebook)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42128&start_sha=cce0c9112a4c17cfd6b9d87084f3d07827f627f6)
yuha commented 2024-04-21 16:33:37 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 24eb6ee1 - Some visual improvements to CRUD iterator

Compare with previous version

added 1 commit <ul><li>24eb6ee1 - Some visual improvements to CRUD iterator</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42129&start_sha=23280f8c10c9b9a3c7853702d7d2a33bfe65349a)
yuha commented 2024-04-21 20:14:21 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 6469ef1a - Generalise date select/dynamic loading mechanism from coursebook & use for substitution page

Compare with previous version

added 1 commit <ul><li>6469ef1a - Generalise date select/dynamic loading mechanism from coursebook &amp; use for substitution page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42133&start_sha=24eb6ee1f82eae99c0efd147b2e166aada8fc5e6)
yuha commented 2024-04-21 20:15:07 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>784b6359 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42134&start_sha=6469ef1a02c8ca09ebad1f4f363437a3fa6289a6)
yuha commented 2024-04-21 21:00:17 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 74a82a79 - Add info alert with link to absences page of AlekSIS-App-Kolego
  • 57d0a08a - Add icon for cancelled lessons

Compare with previous version

added 2 commits <ul><li>74a82a79 - Add info alert with link to absences page of AlekSIS-App-Kolego</li><li>57d0a08a - Add icon for cancelled lessons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42150&start_sha=784b6359da5db5992b74d7edb75762cbfd17072b)
yuha commented 2024-04-23 12:25:25 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>00de6b60 - Change texts in info alert</li><li>c59306db - Use small button</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42228&start_sha=57d0a08a36888538e6513b9dad298445d2dde794)
yuha commented 2024-04-24 17:38:30 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • fed795b0 - Adapt to generic infinite scrolling CRUD iterator

Compare with previous version

added 1 commit <ul><li>fed795b0 - Adapt to generic infinite scrolling CRUD iterator</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42345&start_sha=c59306db17fdbb3280f51a079f32e863ba04965b)
yuha commented 2024-04-24 17:38:51 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 237b781e - Adapt to generic infinite scrolling CRUD iterator

Compare with previous version

added 1 commit <ul><li>237b781e - Adapt to generic infinite scrolling CRUD iterator</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42346&start_sha=fed795b040b86360a4acd2028d34e5f25f1ffeaf)
yuha commented 2024-04-24 17:39:29 +02:00 (Migrated from edugit.org)
Copy link

done, requires generic component from https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1455

done, requires generic component from https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1455
yuha commented 2024-04-24 17:39:39 +02:00 (Migrated from edugit.org)
Copy link

done, requires https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1455

done, requires https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1455
yuha commented 2024-04-24 20:30:46 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 8366f02d - Adapt to generic infinite scrolling CRUD iterator

Compare with previous version

added 1 commit <ul><li>8366f02d - Adapt to generic infinite scrolling CRUD iterator</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42356&start_sha=237b781e4bf3b58ff086e3f23915ffc9c69a5330)
yuha commented 2024-04-24 20:40:04 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 9a9df667 - Change cancel lesson button text
  • 4090f58d - Change layout of substitution page
  • d949531d - Add loading status indicator in cancel button

Compare with previous version

added 3 commits <ul><li>9a9df667 - Change cancel lesson button text</li><li>4090f58d - Change layout of substitution page</li><li>d949531d - Add loading status indicator in cancel button</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42358&start_sha=8366f02df60a2230ee470770adf51db9536b827e)
yuha commented 2024-04-24 20:48:52 +02:00 (Migrated from edugit.org)
Copy link

TODO: make cards less high

TODO: make cards less high
yuha commented 2024-04-24 20:50:15 +02:00 (Migrated from edugit.org)
Copy link

TODO: edit subject & room

TODO: edit subject & room
ZugBahnHof commented 2024-04-24 20:50:27 +02:00 (Migrated from edugit.org)
Copy link

i believe the word you are looking for is tall

i believe the word you are looking for is `tall`
yuha commented 2024-04-24 20:50:53 +02:00 (Migrated from edugit.org)
Copy link

TODO: add status icon (already edited or not?)

TODO: add status icon (already edited or not?)
yuha commented 2024-04-24 20:51:28 +02:00 (Migrated from edugit.org)
Copy link

TODO: add filter for switching between all affected lessons & all those that still "need work"

TODO: add filter for switching between all affected lessons & all those that still "need work"
ZugBahnHof commented 2024-04-24 20:51:30 +02:00 (Migrated from edugit.org)
Copy link

maybe combine with the icon for cancelled lessons?

maybe combine with the icon for cancelled lessons?
ZugBahnHof commented 2024-04-24 20:52:09 +02:00 (Migrated from edugit.org)
Copy link

e.g. stati are:

  • unedited
  • substitution/changes
  • cancellation
  • ...
e.g. stati are: - unedited - substitution/changes - cancellation - ...
yuha commented 2024-04-24 20:52:10 +02:00 (Migrated from edugit.org)
Copy link

TODO: (probably needs another issue) add options for teachers to indicate preferences (free/busy etc)

TODO: (probably needs another issue) add options for teachers to indicate preferences (free/busy etc)
yuha commented 2024-04-24 20:52:18 +02:00 (Migrated from edugit.org)
Copy link

TODO: free/busy also for rooms??

TODO: free/busy also for rooms??
yuha commented 2024-04-24 20:52:33 +02:00 (Migrated from edugit.org)
Copy link

t a l l

`t a l l`
yuha commented 2024-04-24 20:54:49 +02:00 (Migrated from edugit.org)
Copy link

TODO: short names for teachers??

TODO: short names for teachers??
yuha commented 2024-04-24 20:56:15 +02:00 (Migrated from edugit.org)
Copy link

TODO: cancelled button -> chip group select?

TODO: cancelled button -> chip group select?
yuha commented 2024-04-24 20:56:31 +02:00 (Migrated from edugit.org)
Copy link

because that button is too prominent rn

because that button is too prominent rn
yuha commented 2024-04-24 20:56:32 +02:00 (Migrated from edugit.org)
Copy link

approved this merge request

approved this merge request
yuha commented 2024-04-24 20:56:38 +02:00 (Migrated from edugit.org)
Copy link

unapproved this merge request

unapproved this merge request
yuha commented 2024-04-24 20:58:41 +02:00 (Migrated from edugit.org)
Copy link

TODO: show non-available teachers separately (outside of the teacher select field)?

TODO: show non-available teachers separately (outside of the teacher select field)?
yuha commented 2024-04-24 21:00:20 +02:00 (Migrated from edugit.org)
Copy link

TODO: add comment field

TODO: add comment field
yuha commented 2024-04-24 21:04:29 +02:00 (Migrated from edugit.org)
Copy link

for now:

  • chips of non-available teachers outlined in red with cancelled icon
  • chips of "new" teachers outlined in green with plus icon
  • chips of "old", but still remaining teachers in standard chip design
for now: - chips of non-available teachers outlined in red with cancelled icon - chips of "new" teachers outlined in green with plus icon - chips of "old", but still remaining teachers in standard chip design
yuha commented 2024-04-24 21:06:05 +02:00 (Migrated from edugit.org)
Copy link

TODO: use status icon or card as loading indicator

TODO: use status icon or card as loading indicator
yuha commented 2024-04-24 21:06:50 +02:00 (Migrated from edugit.org)
Copy link

and disable all fields during loading

and disable _all_ fields during loading
yuha commented 2024-04-24 21:06:50 +02:00 (Migrated from edugit.org)
Copy link

approved this merge request

approved this merge request
yuha commented 2024-04-24 21:06:54 +02:00 (Migrated from edugit.org)
Copy link

unapproved this merge request

unapproved this merge request
yuha commented 2024-04-24 21:10:49 +02:00 (Migrated from edugit.org)
Copy link

FIXME: for some reason, prepended teacher chips disappear when loading sometimes?

FIXME: for some reason, prepended teacher chips disappear when loading sometimes?
yuha commented 2024-04-27 19:10:14 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 7bc11a67 - Use item card to indicate loading status & disable fields when loading
  • 494d3424 - Add skeleton loaders

Compare with previous version

added 2 commits <ul><li>7bc11a67 - Use item card to indicate loading status &amp; disable fields when loading</li><li>494d3424 - Add skeleton loaders</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42402&start_sha=d949531d0b58095ec4565d40ff745d7f8db2a7cc)
yuha commented 2024-04-27 19:21:03 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>7e3b5d0a - Add skeleton loaders</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42404&start_sha=494d342451e2690b60eb4cd8680b24cb97158428)
yuha commented 2024-04-27 19:57:28 +02:00 (Migrated from edugit.org)
Copy link

fields are disabled now

fields are disabled now
yuha commented 2024-04-27 19:57:29 +02:00 (Migrated from edugit.org)
Copy link

approved this merge request

approved this merge request
yuha commented 2024-04-27 19:57:34 +02:00 (Migrated from edugit.org)
Copy link

unapproved this merge request

unapproved this merge request
yuha commented 2024-04-27 19:57:54 +02:00 (Migrated from edugit.org)
Copy link

also needs another issue

also needs another issue
yuha commented 2024-04-27 19:58:51 +02:00 (Migrated from edugit.org)
Copy link

this apparently does not happen anymore

this apparently does not happen anymore
yuha commented 2024-04-27 20:20:22 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • c7f41389 - Remove unused code sections that were commented out
  • 21af0cbf - Use chip group for selecting cancellation status

Compare with previous version

added 2 commits <ul><li>c7f41389 - Remove unused code sections that were commented out</li><li>21af0cbf - Use chip group for selecting cancellation status</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42412&start_sha=7e3b5d0a904237887149ce90efb5e8d1380fbf7f)
yuha commented 2024-04-29 00:18:56 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>64b2f8bc - Add fields to query</li><li>6f92da60 - Use status-based chips for teachers</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42426&start_sha=21af0cbf3bf89426e3c624c17b3eb0f3491c1ac9)
yuha commented 2024-04-29 00:19:35 +02:00 (Migrated from edugit.org)
Copy link

card is used now

card is used now
yuha commented 2024-04-29 00:33:56 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 7ca215a3 - Make substitution card less tall

Compare with previous version

added 1 commit <ul><li>7ca215a3 - Make substitution card less tall</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42428&start_sha=6f92da60a10709e2347814749e46323b73ca15ab)
yuha commented 2024-04-30 13:38:37 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 0e28260e - Use dummy objects instead of always creating substitutions

Compare with previous version

added 1 commit <ul><li>0e28260e - Use dummy objects instead of always creating substitutions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42470&start_sha=7ca215a36ff19d0602dffb68d5ad6dfa3d43481a)
yuha commented 2024-04-30 13:40:50 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • cb9b41bb - Prevent triggering mutation on substitution card creation

Compare with previous version

added 1 commit <ul><li>cb9b41bb - Prevent triggering mutation on substitution card creation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42474&start_sha=0e28260e5b44495f1ea01701af06e84d271fc785)
yuha commented 2024-04-30 13:43:31 +02:00 (Migrated from edugit.org)
Copy link

it's way faster now :))

it's way faster now :))
yuha commented 2024-04-30 13:44:34 +02:00 (Migrated from edugit.org)
Copy link

looks like this now, btw:

image.png

looks like this now, btw: ![image.png](/uploads/b981a9f4f1de235ab0d5eeaac9ee3b65/image.png)
yuha commented 2024-04-30 13:46:08 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>36f74cc3 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42476&start_sha=cb9b41bbb53da0b2700a6b4ba30e5c7e2e9f40e8)
yuha commented 2024-05-01 20:33:05 +02:00 (Migrated from edugit.org)
Copy link

add tooltips

add tooltips
yuha commented 2024-05-01 20:33:56 +02:00 (Migrated from edugit.org)
Copy link

TODO: add way to ignore absent teachers

TODO: add way to ignore absent teachers
yuha commented 2024-05-01 20:34:59 +02:00 (Migrated from edugit.org)
Copy link

think of way to actually persist that

think of way to actually persist that
yuha commented 2024-05-01 20:38:43 +02:00 (Migrated from edugit.org)
Copy link

TODO: button group for cancellation status?

TODO: button group for cancellation status?
yuha commented 2024-05-01 21:12:50 +02:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • e6e1934f - Change cancellation wording
  • 8ed36ae5 - Use default value for cancelled value
  • fd610836 - Remove revert button for absent teachers
  • a5c1bcb7 - Use different icons

Compare with previous version

added 4 commits <ul><li>e6e1934f - Change cancellation wording</li><li>8ed36ae5 - Use default value for cancelled value</li><li>fd610836 - Remove revert button for absent teachers</li><li>a5c1bcb7 - Use different icons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42521&start_sha=36f74cc38e624c6296cc217f4e8025fb7a4cdbdc)
yuha commented 2024-05-15 01:53:12 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f52c5551 - Remove unused fixture</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42959&start_sha=a5c1bcb71386399c601b0c76758cd42da8f78fe1)
yuha commented 2024-05-15 02:35:58 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

Compare with previous version

added 3 commits <ul><li>51c80584 - Tidy up information component</li><li>1b8463ac - Drop iterator mixin</li><li>d930c675 - Add status icon</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=42965&start_sha=f52c555113401211f291cbc6067394daaa07b459)
yuha commented 2024-05-16 15:00:01 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c21bb4cd - Fix setting of cancellation status

Compare with previous version

added 1 commit <ul><li>c21bb4cd - Fix setting of cancellation status</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43068&start_sha=d930c67544c51fe779f69ea5ca087742ac26e518)
yuha commented 2024-05-16 15:11:33 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 79e3e3d4 - Patch substitutions directly after change

Compare with previous version

added 1 commit <ul><li>79e3e3d4 - Patch substitutions directly after change</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43070&start_sha=c21bb4cd83f0030803e8cf61278eb977910062d2)
yuha commented 2024-05-17 01:08:58 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 51dee3d7 - Use different initial value for cancelled

Compare with previous version

added 1 commit <ul><li>51dee3d7 - Use different initial value for cancelled</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43104&start_sha=79e3e3d4342604ab96435131c2f7548aa75377d6)
yuha commented 2024-05-20 12:55:44 +02:00 (Migrated from edugit.org)
Copy link

added 10 commits

  • 51dee3d7...647ff918 - 9 commits from branch master
  • b23d8b5f - Merge branch 'master' into 225-introduce-substitution-to-do-list-generated-from-teachers-absences

Compare with previous version

added 10 commits <ul><li>51dee3d7...647ff918 - 9 commits from branch <code>master</code></li><li>b23d8b5f - Merge branch &#39;master&#39; into 225-introduce-substitution-to-do-list-generated-from-teachers-absences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43174&start_sha=51dee3d742f92ee602334a46d649a1572c3e3238)
ZugBahnHof commented 2024-05-20 15:45:28 +02:00 (Migrated from edugit.org)
Copy link
      redirect: () => {
```suggestion:-0+0 redirect: () => { ```
ZugBahnHof commented 2024-05-20 16:03:22 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 7fbc04f1 - Fix import of timetable component in chronos menu

Compare with previous version

added 1 commit <ul><li>7fbc04f1 - Fix import of timetable component in chronos menu</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43177&start_sha=b23d8b5fc1e07dedd3ef4382a4674e6bc1eff88b)
yuha commented 2024-05-21 11:18:33 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>b4a356b9 - Use correct query for group select</li><li>f2045a9b - Fix permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43182&start_sha=7fbc04f1f70b61162a64fd38ee2fa99ba044724d)
yuha commented 2024-05-21 14:13:18 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>b5b4d2a0 - Remove commented out lines</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43210&start_sha=f2045a9be35ccad4e08037c92482d00ac654a120)
yuha commented 2024-05-21 14:32:24 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>7cdcf31e - Add comment field</li><li>42e0af0b - Adapt style of teacher select</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43211&start_sha=b5b4d2a0ba15da95b0a9a90722b7b7e48f48fa23)
yuha commented 2024-05-21 14:33:24 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 55 of the diff

changed this line in [version 55 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43213&start_sha=42e0af0b2001f57ce339a88fcc662b9ba1b5c25d#33d8047ff6cbfa526deb44b6e61dc2102566b5b9_39_39)
yuha commented 2024-05-21 14:33:26 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • aed4f3bf - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>aed4f3bf - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43213&start_sha=42e0af0b2001f57ce339a88fcc662b9ba1b5c25d)
yuha commented 2024-05-21 14:37:11 +02:00 (Migrated from edugit.org)
Copy link

it does happen still; seemingly sometimes when more are fetched?

it does happen still; seemingly _sometimes_ when more are fetched?
yuha commented 2024-05-22 09:51:33 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 57ad72fc - Add room field & rewrite save logic

Compare with previous version

added 1 commit <ul><li>57ad72fc - Add room field &amp; rewrite save logic</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43222&start_sha=aed4f3bf6c5a04d15ec13263ceaea7d1e44f7b66)
yuha commented 2024-05-22 09:54:48 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 761b6ea6 - WIP: temporarily comment out room select slot content

Compare with previous version

added 1 commit <ul><li>761b6ea6 - WIP: temporarily comment out room select slot content</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43224&start_sha=57ad72fcc661b26f621fee78f4684838339b129c)
yuha commented 2024-05-22 13:07:20 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>659a8dbb - Fix room select</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43248&start_sha=761b6ea6e11a279c45c3ef96bbe7aefce6f943ff)
yuha commented 2024-05-22 13:08:02 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>621b9b31 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43250&start_sha=659a8dbbf4ae0778e944bdff9fc484476afa3158)
yuha commented 2024-05-22 21:02:22 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c7179a14 - Adapt to teacher field</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43296&start_sha=621b9b318410f09d972fe042ba96f822f78bf2ce)
yuha commented 2024-05-22 21:13:35 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e62d741a - Improve layout</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43302&start_sha=c7179a14e6ad4c1a3eab344865c2648683dea78a)
yuha commented 2024-05-22 21:15:53 +02:00 (Migrated from edugit.org)
Copy link

room possible now

room possible now
yuha commented 2024-05-22 21:22:21 +02:00 (Migrated from edugit.org)
Copy link

kind of resolved: TeacherField is now used which also displays short names

kind of resolved: `TeacherField` is now used which also displays short names
yuha commented 2024-05-22 21:29:36 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 032150b3 - Add tooltips to teacher select

Compare with previous version

added 1 commit <ul><li>032150b3 - Add tooltips to teacher select</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43306&start_sha=e62d741a346ff1c4816b3ecdfa4c7805afb7cccd)
yuha commented 2024-05-31 16:44:21 +02:00 (Migrated from edugit.org)
Copy link

added 4 commits

Compare with previous version

added 4 commits <ul><li>070697e3 - Adapt to changes in teacherField</li><li>27cec7b9 - Rename computed property</li><li>5214a215 - Add filter for incomplete substitutions</li><li>4d032d66 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43451&start_sha=032150b3c8a7aa64f61a92ce145bda36838b62d0)
yuha commented 2024-05-31 17:02:03 +02:00 (Migrated from edugit.org)
Copy link

Additionally, take other events of teacher into consideration

Additionally, take other events of teacher into consideration
yuha commented 2024-05-31 17:02:28 +02:00 (Migrated from edugit.org)
Copy link

& indicate availability of teachers based on these factors in teacher select

& indicate availability of teachers based on these factors in teacher select
yuha commented 2024-05-31 17:02:52 +02:00 (Migrated from edugit.org)
Copy link

this should probably be done using the aggregated free/busy mechanism from https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1330#2e44ad1f61249cf0440bea20d23bd07cc7f3a61a

this should probably be done using the aggregated free/busy mechanism from https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1330#2e44ad1f61249cf0440bea20d23bd07cc7f3a61a
yuha commented 2024-05-31 17:03:05 +02:00 (Migrated from edugit.org)
Copy link

new issue for that?

new issue for that?
yuha commented 2024-05-31 17:03:17 +02:00 (Migrated from edugit.org)
Copy link

@hansegucker what do you think?

@hansegucker what do you think?
yuha commented 2024-05-31 17:53:31 +02:00 (Migrated from edugit.org)
Copy link

TODO: add nicer templates for the no-data and loading slots

TODO: add nicer templates for the `no-data` and `loading` slots
yuha commented 2024-05-31 18:06:37 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 06429f5a - Move substitution overview component
  • de84d864 - Fix room/teacher removing mechanism

Compare with previous version

added 2 commits <ul><li>06429f5a - Move substitution overview component</li><li>de84d864 - Fix room/teacher removing mechanism</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43457&start_sha=4d032d667665bec6f39e28a7fe04452acf31c617)
yuha commented 2024-05-31 18:08:09 +02:00 (Migrated from edugit.org)
Copy link

I have no idea how this can be done – editing the absence itself doesn't make sense; and creating a substitution with the teacher that is supposed to be absent feels weird too. Any ideas?

I have no idea how this can be done – editing the absence itself doesn't make sense; and creating a substitution with the teacher that is supposed to be absent feels weird too. Any ideas?
yuha commented 2024-05-31 18:23:15 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>1bf05bfe - Allow editing subject</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43458&start_sha=de84d8640c4882e9a8082071b19ed3bbe166ef2b)
hansegucker commented 2024-06-02 20:27:32 +02:00 (Migrated from edugit.org)
Copy link

Yes

Yes
yuha commented 2024-06-07 03:11:41 +02:00 (Migrated from edugit.org)
Copy link

TODO: check permissions (it probably does not make sense to only allow for showing & editing substitutions when user is owner of the respective group)

TODO: check permissions (it probably does not make sense to only allow for showing & editing substitutions when user is owner of the respective group)
yuha commented 2024-06-07 03:11:49 +02:00 (Migrated from edugit.org)
Copy link

see coursebook?

see coursebook?
yuha commented 2024-06-07 15:41:51 +02:00 (Migrated from edugit.org)
Copy link

added 6 commits

Compare with previous version

added 6 commits <ul><li>6e000055 - Move comment field to end</li><li>4b33626d - Change to grid layout</li><li>aadf0b7c - Change wording in i18n texts</li><li>3e1f445e - Make icons smaller &amp; change plus icon</li><li>dbe9c4c0 - Add labels</li><li>18a52a25 - Make absence entering alert more responsive</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43758&start_sha=1bf05bfe853b8ab8bfe6a643db92c2ff1e0ae44e)
yuha commented 2024-06-07 16:30:50 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c8821028 - Add global permission to manage substitutions

Compare with previous version

added 1 commit <ul><li>c8821028 - Add global permission to manage substitutions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43759&start_sha=18a52a2580c186e5cf368c868edd0ceabef18789)
yuha commented 2024-06-07 16:32:59 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 9a542b4e - Add global permission to manage substitutions

Compare with previous version

added 1 commit <ul><li>9a542b4e - Add global permission to manage substitutions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43760&start_sha=c88210282a0795bbe4d8ba35ef3d6e2beb4c56d8)
yuha commented 2024-06-07 16:33:55 +02:00 (Migrated from edugit.org)
Copy link

now there is a global permission that bypasses this filtering and allows for managing substitutions for every group

now there is a global permission that bypasses this filtering and allows for managing substitutions for every group
yuha commented 2024-06-07 18:28:42 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 4d99f213 - Delete substitutions when all fields are emptied

Compare with previous version

added 1 commit <ul><li>4d99f213 - Delete substitutions when all fields are emptied</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43763&start_sha=9a542b4ef77774df7a3b3d8f75031b61837c918c)
yuha commented 2024-06-07 19:39:27 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • dd7a13be - Reset ID to oldId if present on delete instead of removing substitution

Compare with previous version

added 1 commit <ul><li>dd7a13be - Reset ID to oldId if present on delete instead of removing substitution</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43764&start_sha=4d99f213e6fd897f98f1468ff1c681c13a893777)
yuha commented 2024-06-11 16:19:05 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 19b97d27 - Emit event when substitution is emtied & does not contain oldId

Compare with previous version

added 1 commit <ul><li>19b97d27 - Emit event when substitution is emtied &amp; does not contain oldId</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=43916&start_sha=dd7a13beb085c77068d61a415fa342b870ba1d8c)
yuha commented 2024-06-20 22:50:39 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 2d93f185 - Only consider LessonEvent objects when searching for existing substitutions
  • 7ed8a4e1 - Use empty content page from core

Compare with previous version

added 2 commits <ul><li>2d93f185 - Only consider LessonEvent objects when searching for existing substitutions</li><li>7ed8a4e1 - Use empty content page from core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=44236&start_sha=19b97d270049a97b864fc057010db45a87c5da82)
yuha commented 2024-06-27 22:24:49 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 9ae3d71c - Use empty content page from core

Compare with previous version

added 1 commit <ul><li>9ae3d71c - Use empty content page from core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=44534&start_sha=7ed8a4e1872f32be3ecc7da905538bda1cb7002e)
yuha commented 2024-06-27 22:46:58 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 9d702308 - Pass substitution start/end date to teacher field

Compare with previous version

added 1 commit <ul><li>9d702308 - Pass substitution start/end date to teacher field</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=44541&start_sha=9ae3d71c40e0e8145a86e5d3e270c19cd8482a79)
yuha commented 2024-07-09 10:42:53 +02:00 (Migrated from edugit.org)
Copy link

both possible now

both possible now
yuha commented 2024-07-09 10:43:50 +02:00 (Migrated from edugit.org)
Copy link

This works now with https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/51

This works now with https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/51
yuha commented 2024-07-10 12:08:55 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 2357fb10 - Use button group for cancellation status

Compare with previous version

added 1 commit <ul><li>2357fb10 - Use button group for cancellation status</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=44912&start_sha=9d7023085813fb508575a1222c9055f49624047a)
yuha commented 2024-09-17 08:39:44 +02:00 (Migrated from edugit.org)
Copy link

added 50 commits

  • 2357fb10...50ba0341 - 49 commits from branch master
  • e1a9571c - Merge branch 'master' into 225-introduce-substitution-to-do-list-generated-from-teachers-absences

Compare with previous version

added 50 commits <ul><li>2357fb10...50ba0341 - 49 commits from branch <code>master</code></li><li>e1a9571c - Merge branch &#39;master&#39; into 225-introduce-substitution-to-do-list-generated-from-teachers-absences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=47760&start_sha=2357fb10316289ff58c824dcc47fa2e5f8a0873b)
yuha commented 2024-09-17 08:42:46 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 9417ee0b - Merge branch 'master' into 225-introduce-substitution-to-do-list-generated-from-teachers-absences

Compare with previous version

added 1 commit <ul><li>9417ee0b - Merge branch &#39;master&#39; into 225-introduce-substitution-to-do-list-generated-from-teachers-absences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=47761&start_sha=e1a9571cd549392a3a0725e007f87640ef208531)
yuha commented 2024-09-17 08:46:27 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f23575ad - Merge branch 'master' into 225-introduce-substitution-to-do-list-generated-from-teachers-absences

Compare with previous version

added 1 commit <ul><li>f23575ad - Merge branch &#39;master&#39; into 225-introduce-substitution-to-do-list-generated-from-teachers-absences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=47762&start_sha=9417ee0b8c0e6422fb17c285ce5c5fb1c67336dc)
yuha commented 2024-10-06 23:27:58 +02:00 (Migrated from edugit.org)
Copy link

requested review from @hansegucker

requested review from @hansegucker
yuha commented 2024-10-06 23:28:41 +02:00 (Migrated from edugit.org)
Copy link

anyways, I'll put that in a follow-up issue

anyways, I'll put that in a follow-up issue
yuha commented 2024-10-06 23:31:57 +02:00 (Migrated from edugit.org)
Copy link

added 7 commits

  • f23575ad...cfcfa211 - 6 commits from branch master
  • 74bbc020 - Merge branch 'master' into 225-introduce-substitution-to-do-list-generated-from-teachers-absences

Compare with previous version

added 7 commits <ul><li>f23575ad...cfcfa211 - 6 commits from branch <code>master</code></li><li>74bbc020 - Merge branch &#39;master&#39; into 225-introduce-substitution-to-do-list-generated-from-teachers-absences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48432&start_sha=f23575ad7515a9c81b904b29691bc3cce216c1f2)
yuha commented 2024-10-06 23:42:16 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 3054c85c - Merge branch 'master' into 225-introduce-substitution-to-do-list-generated-from-teachers-absences

Compare with previous version

added 1 commit <ul><li>3054c85c - Merge branch &#39;master&#39; into 225-introduce-substitution-to-do-list-generated-from-teachers-absences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48434&start_sha=74bbc020fcff7996f67741345aa40fe16a9c1c85)
yuha commented 2024-10-06 23:45:50 +02:00 (Migrated from edugit.org)
Copy link

looks nicer now:

image.png

looks nicer now: ![image.png](/uploads/c9202182ef8f2c3ee1fac9ba871bfa98/image.png)
yuha commented 2024-10-11 18:26:01 +02:00 (Migrated from edugit.org)
Copy link

created #254 to continue this discussion

created #254 to continue this discussion
yuha commented 2024-10-11 18:26:01 +02:00 (Migrated from edugit.org)
Copy link

mentioned in issue #254

mentioned in issue #254
hansegucker commented 2024-10-13 16:39:00 +02:00 (Migrated from edugit.org)
Copy link

Please delete file.

Please delete file.
hansegucker commented 2024-10-13 16:39:01 +02:00 (Migrated from edugit.org)
Copy link

I don't think that this line will have an effect as the related model seems to be a group and not a substitution.

I don't think that this line will have an effect as the related model seems to be a group and not a substitution.
hansegucker commented 2024-10-13 16:39:01 +02:00 (Migrated from edugit.org)
Copy link
add_perm("chronos.create_substitution_rule", add_substitution_predicate)
```suggestion:-0+0 add_perm("chronos.create_substitution_rule", add_substitution_predicate) ```
hansegucker commented 2024-10-13 16:39:01 +02:00 (Migrated from edugit.org)
Copy link

all is not a good name (reserved).

`all` is not a good name (reserved).
hansegucker commented 2024-10-13 16:39:01 +02:00 (Migrated from edugit.org)
Copy link

Valid change?

Valid change?
hansegucker commented 2024-10-13 16:39:01 +02:00 (Migrated from edugit.org)
Copy link

We have Django 5 ;-)

We have Django 5 ;-)
hansegucker commented 2024-10-13 16:39:01 +02:00 (Migrated from edugit.org)
Copy link
            if info.context.user.has_perm("chronos.create_substitution_rule", amended_lesson_event):
```suggestion:-0+0 if info.context.user.has_perm("chronos.create_substitution_rule", amended_lesson_event): ```
hansegucker commented 2024-10-13 16:39:01 +02:00 (Migrated from edugit.org)
Copy link

Please make more readable.

Please make more readable.
hansegucker commented 2024-10-13 16:39:02 +02:00 (Migrated from edugit.org)
Copy link

Please make more readable.

Please make more readable.
hansegucker commented 2024-10-13 16:39:02 +02:00 (Migrated from edugit.org)
Copy link

Please make more readable.

Please make more readable.
hansegucker commented 2024-10-13 16:39:02 +02:00 (Migrated from edugit.org)
Copy link

Please add some comments explaining what is happening here.

Please add some comments explaining what is happening here.
hansegucker commented 2024-10-13 16:39:02 +02:00 (Migrated from edugit.org)
Copy link

FIXME

FIXME
yuha commented 2024-10-14 01:22:29 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>15ed1bb4 - Allow filtering by teacher</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48703&start_sha=3054c85cefdd4b52e160666448ae92676175928d)
yuha commented 2024-10-14 01:41:36 +02:00 (Migrated from edugit.org)
Copy link

this works now – but the page got painfully slow somewhere in the process.

this works now – but the page got painfully slow somewhere in the process.
yuha commented 2024-10-14 21:27:24 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • cb846ef4 - Improve teacher filtering mechanism when generating substitutions from absences

Compare with previous version

added 1 commit <ul><li>cb846ef4 - Improve teacher filtering mechanism when generating substitutions from absences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48723&start_sha=15ed1bb48cc3a6596635ee1fac5c3b168f859ec9)
yuha commented 2024-10-16 00:44:33 +02:00 (Migrated from edugit.org)
Copy link

changed this file in version 83 of the diff

changed this file in [version 83 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48763&start_sha=cb846ef41ad8ce15e60c9fafc33a259d69dd92a5#245d8ec80d138d8104c8f8338a3e2066fd7680d1)
yuha commented 2024-10-16 00:44:35 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>dcde9e47 - Remove coverage file</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48763&start_sha=cb846ef41ad8ce15e60c9fafc33a259d69dd92a5)
yuha commented 2024-10-16 00:46:11 +02:00 (Migrated from edugit.org)
Copy link

I don't think so. Why do you think the related model is a group?

I don't think so. Why do you think the related model is a group?
yuha commented 2024-10-16 00:47:11 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48765&start_sha=dcde9e472f40e573166b31f3600d10bc81b943b4#925b3235efacb793fcbdcf6ac1b6e50f2a6a317b_58_58)
yuha commented 2024-10-16 00:47:12 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48765&start_sha=dcde9e472f40e573166b31f3600d10bc81b943b4#9fe1b4f3ed029a98c121073d5adc35d4c9a9de59_179_179)
yuha commented 2024-10-16 00:47:13 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>6531ffcc - Rename permission</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48765&start_sha=dcde9e472f40e573166b31f3600d10bc81b943b4)
yuha commented 2024-10-16 00:48:11 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 85 of the diff

changed this line in [version 85 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48767&start_sha=6531ffcc79d3253529d0b213f3346923bd641a9e#aff889560e418df674a6887a541974fc95f8cd36_1615_1615)
yuha commented 2024-10-16 00:48:13 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 0717fd02 - Avoid collision with reserved name

Compare with previous version

added 1 commit <ul><li>0717fd02 - Avoid collision with reserved name</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48767&start_sha=6531ffcc79d3253529d0b213f3346923bd641a9e)
yuha commented 2024-10-16 00:49:39 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 86 of the diff

changed this line in [version 86 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48769&start_sha=0717fd0205f6efa4bce98bbbe467a55fe2c4beb4#601948d5f8dd219a0874cb98a4b16b80f18d0628_888_888)
yuha commented 2024-10-16 00:49:41 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c55288a2 - Fix manager filters</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48769&start_sha=0717fd0205f6efa4bce98bbbe467a55fe2c4beb4)
yuha commented 2024-10-16 00:49:59 +02:00 (Migrated from edugit.org)
Copy link

oh

oh
yuha commented 2024-10-16 00:56:11 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 87 of the diff

changed this line in [version 87 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48771&start_sha=c55288a25d2140f7ab60c980894658feb3dafd59#9fe1b4f3ed029a98c121073d5adc35d4c9a9de59_167_166)
yuha commented 2024-10-16 00:56:12 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>72af4d7f - Revise comment</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48771&start_sha=c55288a25d2140f7ab60c980894658feb3dafd59)
yuha commented 2024-10-16 00:56:51 +02:00 (Migrated from edugit.org)
Copy link

but still, we can't properly use it due to its inability to differentiate between different permissions that are to be checked depending on the operation

but still, we can't properly use it due to its inability to differentiate between different permissions that are to be checked depending on the operation
yuha commented 2024-10-16 00:58:53 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 88 of the diff

changed this line in [version 88 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48773&start_sha=72af4d7fa29d059ae785a8e3dd90481e887d2e2b#7131711ee0579c16a3cc167d950b6a3778ce0107_57_57)
yuha commented 2024-10-16 00:58:54 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 3667d5fc - Improve readability

Compare with previous version

added 1 commit <ul><li>3667d5fc - Improve readability</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48773&start_sha=72af4d7fa29d059ae785a8e3dd90481e887d2e2b)
yuha commented 2024-10-16 00:59:43 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 89 of the diff

changed this line in [version 89 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48775&start_sha=3667d5fc9f78d329a4164008d574aa93ed55996f#36b1df04c37c5be98bd77c6eed2058496193d056_47_43)
yuha commented 2024-10-16 00:59:45 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 01aace28 - Improve readability

Compare with previous version

added 1 commit <ul><li>01aace28 - Improve readability</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48775&start_sha=3667d5fc9f78d329a4164008d574aa93ed55996f)
yuha commented 2024-10-16 01:00:29 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 90 of the diff

changed this line in [version 90 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48777&start_sha=01aace288ae678c0696a4f2775716b45b5518c0f#f31d5eabee7aee70295c234fed859d5dd338abba_384_378)
yuha commented 2024-10-16 01:00:30 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>046f9821 - Improve readability</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48777&start_sha=01aace288ae678c0696a4f2775716b45b5518c0f)
yuha commented 2024-10-16 01:14:32 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>83832f8b - Add some explaining comments</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48780&start_sha=046f9821d40f4c75430c8856cee7b8ca90f4459b)
yuha commented 2024-10-16 01:17:17 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e4d70539 - Remove unneeded imports</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48782&start_sha=83832f8b42e3cd6dc9af0bbabad578ed8fff174e)
yuha commented 2024-10-16 02:28:29 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 93 of the diff

changed this line in [version 93 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48789&start_sha=e4d7053943346e7a83b257cf3b57396a34222b74#f31d5eabee7aee70295c234fed859d5dd338abba_320_320)
yuha commented 2024-10-16 02:28:30 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • a1ce195f - Include teacher id in route
  • 2bfbeb67 - Refetch day on delete of item without oldId

Compare with previous version

added 2 commits <ul><li>a1ce195f - Include teacher id in route</li><li>2bfbeb67 - Refetch day on delete of item without oldId</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48789&start_sha=e4d7053943346e7a83b257cf3b57396a34222b74)
yuha commented 2024-10-16 02:28:39 +02:00 (Migrated from edugit.org)
Copy link

done, needs https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1598

done, needs https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1598
yuha commented 2024-10-16 02:32:39 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>6f974c30 - Reformat</li><li>7bfa14f0 - Fix lesson event graphene type</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48791&start_sha=2bfbeb6761bc5d8cef614de453f74671513d33ae)
yuha commented 2024-10-16 20:24:18 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3cd2e0fa - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=48807&start_sha=7bfa14f0875e1013c7bac21b67b60a270ed5299e)
yuha commented 2024-10-17 09:19:38 +02:00 (Migrated from edugit.org)
Copy link

@hansegucker ?

@hansegucker ?
yuha commented 2024-10-17 09:19:54 +02:00 (Migrated from edugit.org)
Copy link

image.png

![image.png](/uploads/8cdc7d3d446bdb9a1c6e76f599e0a99c/image.png)
ZugBahnHof commented 2024-10-17 15:21:56 +02:00 (Migrated from edugit.org)
Copy link

What about using the subject chip select field?

What about using the subject chip select field?
yuha commented 2024-10-19 22:07:04 +02:00 (Migrated from edugit.org)
Copy link

good idea

good idea
yuha commented 2024-10-19 22:23:47 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • ce422359 - Use subject chip select field

Compare with previous version

added 1 commit <ul><li>ce422359 - Use subject chip select field</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=49041&start_sha=3cd2e0fa9a8a54b5b46736217c176bb62f74a0cd)
yuha commented 2024-10-19 22:24:05 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2024-10-21 20:04:37 +02:00 (Migrated from edugit.org)
Copy link

How could it be a substitution? This is a permission for creating – there is no substitution yet.

How could it be a substitution? This is a permission for **creating** – there is no substitution yet.
yuha commented 2024-10-30 11:52:47 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 97 of the diff

changed this line in [version 97 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=49335&start_sha=ce42235972d401c4d9e890a7668a31d702c51d2b#925b3235efacb793fcbdcf6ac1b6e50f2a6a317b_54_54)
yuha commented 2024-10-30 11:52:48 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 28ed5668 - Remove superfluous object perm check

Compare with previous version

added 1 commit <ul><li>28ed5668 - Remove superfluous object perm check</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=49335&start_sha=ce42235972d401c4d9e890a7668a31d702c51d2b)
yuha commented 2024-10-30 11:52:51 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
yuha commented 2024-10-30 11:52:55 +01:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker and unassigned @yuha

assigned to @hansegucker and unassigned @yuha
yuha commented 2024-10-30 11:53:05 +01:00 (Migrated from edugit.org)
Copy link

@hansegucker please have a look again

@hansegucker please have a look again
hansegucker commented 2024-10-30 17:18:57 +01:00 (Migrated from edugit.org)
Copy link

German comment

German comment
yuha commented 2024-11-05 16:42:58 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 98 of the diff

changed this line in [version 98 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=49908&start_sha=28ed5668191e2d57ae23a01a9bf6cb6aa0bac32a#f31d5eabee7aee70295c234fed859d5dd338abba_14_14)
yuha commented 2024-11-05 16:42:58 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>5f2101c1 - Remove unused comment</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=49908&start_sha=28ed5668191e2d57ae23a01a9bf6cb6aa0bac32a)
yuha commented 2024-11-05 16:43:02 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
ZugBahnHof commented 2024-11-27 11:15:23 +01:00 (Migrated from edugit.org)
Copy link

What's the status on this? @yuha @hansegucker

What's the status on this? @yuha @hansegucker
yuha commented 2024-12-04 19:27:14 +01:00 (Migrated from edugit.org)
Copy link

added 125 commits

  • 5f2101c1...d4064ae1 - 124 commits from branch master
  • b6a49a58 - Merge branch 'master' into 225-introduce-substitution-to-do-list-generated-from-teachers-absences

Compare with previous version

added 125 commits <ul><li>5f2101c1...d4064ae1 - 124 commits from branch <code>master</code></li><li>b6a49a58 - Merge branch &#39;master&#39; into 225-introduce-substitution-to-do-list-generated-from-teachers-absences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51490&start_sha=5f2101c119f55eb4bb06f478430aa143a232ace1)
yuha commented 2024-12-04 19:47:04 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as draft

marked this merge request as **draft**
yuha commented 2024-12-04 19:50:33 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 6d5f772f - Add permission check for owner timetables
  • c29d4f17 - Fix prefetch absence logic

Compare with previous version

added 2 commits <ul><li>6d5f772f - Add permission check for owner timetables</li><li>c29d4f17 - Fix prefetch absence logic</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51492&start_sha=b6a49a58af532c162ab590f0a396d7c12293861e)
yuha commented 2024-12-04 19:55:58 +01:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • c3cc1065 - Merge branch 'master' into 225-introduce-substitution-to-do-list-generated-from-teachers-absences
  • d1238637 - Add permission check for owner timetables
  • 05dd6d08 - Fix prefetch absence logic

Compare with previous version

added 3 commits <ul><li>c3cc1065 - Merge branch &#39;master&#39; into 225-introduce-substitution-to-do-list-generated-from-teachers-absences</li><li>d1238637 - Add permission check for owner timetables</li><li>05dd6d08 - Fix prefetch absence logic</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51494&start_sha=c29d4f17abb96b5842878b0bc80e335bb504a7c5)
yuha commented 2024-12-04 19:57:59 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3df5f151 - Add missing imports</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51496&start_sha=05dd6d083383e8cb9a98de6f31617a1dac25484a)
yuha commented 2024-12-04 19:58:01 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2024-12-05 15:52:21 +01:00 (Migrated from edugit.org)
Copy link
aleksis-app-kolego = "^0.1.0.dev0"
```suggestion:-0+0 aleksis-app-kolego = "^0.1.0.dev0" ```
hansegucker commented 2024-12-05 15:52:27 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2024-12-05 15:52:30 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 103 of the diff

changed this line in [version 103 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51534&start_sha=3df5f151f0140aee3812afd9df4f0e04a6ea3ff4#5d07e7d72637aa0d59c89d381fe6dc4cf46e2491_57_57)
hansegucker commented 2024-12-05 15:52:31 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 9036631a - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>9036631a - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51534&start_sha=3df5f151f0140aee3812afd9df4f0e04a6ea3ff4)
hansegucker commented 2024-12-05 16:12:27 +01:00 (Migrated from edugit.org)
Copy link

That doesn't work:

  • Changing the comment clears the teachers
  • Changing the rooms clears the teachers
  • Deleting last new room using x in chip doesn't work (same for teachers)
  • Setting a teacher or room doesn't change status to cancelled=False
  • Person filter doesn't seem to work at all
That doesn't work: - [x] Changing the comment clears the teachers - [x] Changing the rooms clears the teachers - [ ] Deleting last new room using x in chip doesn't work (same for teachers) - [x] Setting a teacher or room doesn't change status to cancelled=False - [x] Person filter doesn't seem to work at all
hansegucker commented 2024-12-05 16:12:36 +01:00 (Migrated from edugit.org)
Copy link
2024-12-05 16:12:07,562 ERROR django.request[2427228]: Internal Server Error: /graphql/
Traceback (most recent call last):
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/views/decorators/csrf.py", line 65, in _view_wrapper
    return view_func(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/utils/decorators.py", line 48, in _wrapper
    return bound_method(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/utils/decorators.py", line 188, in _view_wrapper
    result = _process_exception(request, e)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/utils/decorators.py", line 186, in _view_wrapper
    response = view_func(request, *args, **kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/graphene_django/views.py", line 201, in dispatch
    result, status_code = self.get_response(request, data, show_graphiql)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/graphene_django/views.py", line 218, in get_response
    execution_result = self.execute_graphql_request(
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/aleksis/core/views.py", line 1278, in execute_graphql_request
    raise error
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/graphql/execution/execute.py", line 542, in execute_field
    completed = self.complete_value(
                ^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/graphql/execution/execute.py", line 609, in complete_value
    raise result
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/graphene_django/debug/middleware.py", line 65, in resolve
    result = next(root, info, **args)
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/aleksis/apps/chronos/schema/__init__.py", line 234, in mutate
    objs = [cls.create_or_update(info, substitution) for substitution in input]
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/aleksis/apps/chronos/schema/__init__.py", line 193, in create_or_update
    obj = LessonEvent.objects.create(
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/db/models/manager.py", line 87, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/db/models/query.py", line 677, in create
    obj = self.model(**kwargs)
          ^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/polymorphic/models.py", line 194, in __init__
    super().__init__(*args, **kwargs)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/db/models/base.py", line 543, in __init__
    _setattr(self, field.name, rel_obj)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/db/models/fields/related_descriptors.py", line 287, in __set__
    raise ValueError(
graphql.error.graphql_error.GraphQLError: Cannot assign "'2006'": "LessonEvent.subject" must be a "Subject" instance.

GraphQL request:2:3
1 | mutation createOrUpdateSubstitutions($input: [SubstitutionInputType]!) {
2 |   createOrUpdateSubstitutions(input: $input) {
  |   ^
3 |     items: substitutions {
``` 2024-12-05 16:12:07,562 ERROR django.request[2427228]: Internal Server Error: /graphql/ Traceback (most recent call last): File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/core/handlers/exception.py", line 55, in inner response = get_response(request) ^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/core/handlers/base.py", line 197, in _get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/views/decorators/csrf.py", line 65, in _view_wrapper return view_func(request, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/views/generic/base.py", line 104, in view return self.dispatch(request, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/utils/decorators.py", line 48, in _wrapper return bound_method(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/utils/decorators.py", line 188, in _view_wrapper result = _process_exception(request, e) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/utils/decorators.py", line 186, in _view_wrapper response = view_func(request, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/graphene_django/views.py", line 201, in dispatch result, status_code = self.get_response(request, data, show_graphiql) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/graphene_django/views.py", line 218, in get_response execution_result = self.execute_graphql_request( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/aleksis/core/views.py", line 1278, in execute_graphql_request raise error File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/graphql/execution/execute.py", line 542, in execute_field completed = self.complete_value( ^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/graphql/execution/execute.py", line 609, in complete_value raise result File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/graphene_django/debug/middleware.py", line 65, in resolve result = next(root, info, **args) ^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/aleksis/apps/chronos/schema/__init__.py", line 234, in mutate objs = [cls.create_or_update(info, substitution) for substitution in input] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/aleksis/apps/chronos/schema/__init__.py", line 193, in create_or_update obj = LessonEvent.objects.create( ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/db/models/manager.py", line 87, in manager_method return getattr(self.get_queryset(), name)(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/db/models/query.py", line 677, in create obj = self.model(**kwargs) ^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/polymorphic/models.py", line 194, in __init__ super().__init__(*args, **kwargs) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/db/models/base.py", line 543, in __init__ _setattr(self, field.name, rel_obj) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Chronos/.venv/lib/python3.12/site-packages/django/db/models/fields/related_descriptors.py", line 287, in __set__ raise ValueError( graphql.error.graphql_error.GraphQLError: Cannot assign "'2006'": "LessonEvent.subject" must be a "Subject" instance. GraphQL request:2:3 1 | mutation createOrUpdateSubstitutions($input: [SubstitutionInputType]!) { 2 | createOrUpdateSubstitutions(input: $input) { | ^ 3 | items: substitutions { ```
hansegucker commented 2024-12-05 16:12:46 +01:00 (Migrated from edugit.org)
Copy link

BROKEN!

BROKEN!
yuha commented 2024-12-06 18:24:34 +01:00 (Migrated from edugit.org)
Copy link

TODO: do some optimizations – the page gets fairly slow with a high amount of lessons

TODO: do some optimizations – the page gets fairly slow with a high amount of lessons
yuha commented 2024-12-06 18:51:14 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 8158904e - Fix duplicated rooms
  • f9d0bce2 - Fix faulty clearing of teachers on comment save

Compare with previous version

added 2 commits <ul><li>8158904e - Fix duplicated rooms</li><li>f9d0bce2 - Fix faulty clearing of teachers on comment save</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51554&start_sha=9036631aca0834daea8baad588638e69861f10d4)
yuha commented 2024-12-06 18:54:39 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 9ce289d4 - Set cancelled to false when entering teacher/room

Compare with previous version

added 1 commit <ul><li>9ce289d4 - Set cancelled to false when entering teacher/room</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51556&start_sha=f9d0bce2ec812ea6430641f528825fc152f9a5d2)
yuha commented 2024-12-06 18:57:45 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>6f0c5145 - Fix filtering by teachers</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51558&start_sha=9ce289d4b745f6cc7be6dfa88e30bcdf0bf40c6e)
yuha commented 2024-12-06 18:57:49 +01:00 (Migrated from edugit.org)
Copy link

1, 2, 4, 5 fixed

1, 2, 4, 5 fixed
hansegucker commented 2024-12-07 16:49:09 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c30cfe63 - Update changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51868&start_sha=6f0c514558f363c2ea2b09129db89bdfc2b42382)
hansegucker commented 2024-12-07 17:02:28 +01:00 (Migrated from edugit.org)
Copy link

.

.
yuha commented 2024-12-07 21:14:31 +01:00 (Migrated from edugit.org)
Copy link

3 fixed

3 fixed
yuha commented 2024-12-07 21:17:21 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 188b6b64 - Clear dummy substitution after deleting substitution with oldId

Compare with previous version

added 1 commit <ul><li>188b6b64 - Clear dummy substitution after deleting substitution with oldId</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51889&start_sha=c30cfe631a2ca4f0f8be8b1a780f903827529a2f)
yuha commented 2024-12-07 22:07:43 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 6c5481d0 - Fix setting of subject of substitutions

Compare with previous version

added 1 commit <ul><li>6c5481d0 - Fix setting of subject of substitutions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51892&start_sha=188b6b6426038199204a960cb7c037358f9b2c6e)
yuha commented 2024-12-07 22:10:07 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 356bd117 - Fix setting of subject of substitutions

Compare with previous version

added 1 commit <ul><li>356bd117 - Fix setting of subject of substitutions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51894&start_sha=6c5481d025cd044d56c39d9c8b157b8e07501a67)
yuha commented 2024-12-07 23:45:57 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 7eb1105f - Use shorter dayIncrement
  • 0f093525 - Don't pass start/end date to teacher field

Compare with previous version

added 2 commits <ul><li>7eb1105f - Use shorter dayIncrement</li><li>0f093525 - Don&#39;t pass start/end date to teacher field</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51917&start_sha=356bd1174f98a1a031427dc7687f1bfff60aaf88)
yuha commented 2024-12-07 23:53:57 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 681754c4 - Make layout slightly more compact

Compare with previous version

added 1 commit <ul><li>681754c4 - Make layout slightly more compact</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51919&start_sha=0f0935255d90d8b653baf8b6afc9383d82c4e8fa)
yuha commented 2024-12-08 00:15:38 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c58464f9 - Fetch subjects, teachers and rooms once and pass them down

Compare with previous version

added 1 commit <ul><li>c58464f9 - Fetch subjects, teachers and rooms once and pass them down</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51922&start_sha=681754c437e07f0be71afb7fda494cd8275e5e04)
yuha commented 2024-12-08 00:17:52 +01:00 (Migrated from edugit.org)
Copy link

I've reduced the increment now and teachers, rooms and subjects are now fetched once and passed down (needs https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/68)– but I can't think of anything else right now

I've reduced the increment now and teachers, rooms and subjects are now fetched once and passed down (needs https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/68)– but I can't think of anything else right now
yuha commented 2024-12-08 00:17:52 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2024-12-08 12:10:58 +01:00 (Migrated from edugit.org)
Copy link

changed the description

changed the description
hansegucker commented 2024-12-08 12:32:43 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3e4cdf88 - Reformat and fix lint</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/329/diffs?diff_id=51955&start_sha=c58464f9676c84eaad213671a8508d032c1f1b02)
hansegucker commented 2024-12-08 13:20:50 +01:00 (Migrated from edugit.org)
Copy link

mentioned in commit 263e68fe45

mentioned in commit 263e68fe451a2dd745bff825e75d349e34e5bee2
hansegucker (Migrated from edugit.org) merged commit 263e68fe45 into master 2024-12-08 13:20:50 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Chronos!633
No description provided.