aleksis/AlekSIS-App-Chronos
8
0
Fork 0
Code Issues 51 Pull requests 5 Projects Releases 4 Packages Activity Actions

Resolve "Implement Vue substitution frontend" #614

Merged
permcu merged 52 commits from 211-implement-vue-substitution-frontend into master 2024-03-28 17:47:37 +01:00
Conversation 63 Commits 52 Files changed 7 +409 -14
permcu commented 2023-08-23 17:57:57 +02:00 (Migrated from edugit.org)
Copy link

Closes #211

Closes #211
permcu commented 2023-08-23 17:57:58 +02:00 (Migrated from edugit.org)
Copy link

requested review from @hansegucker

requested review from @hansegucker
permcu commented 2023-08-23 17:57:58 +02:00 (Migrated from edugit.org)
Copy link

assigned to @permcu

assigned to @permcu
permcu (Migrated from edugit.org) changed target branch from master to new-model-based-on-calendar 2023-08-23 18:25:58 +02:00
permcu commented 2023-08-24 23:21:04 +02:00 (Migrated from edugit.org)
Copy link

added 7 commits

  • dd4a6246 - Add edit button to lesson details
  • bca7820f - Add dialog-object-form to lesson details
  • b226e583 - Name text fields in amend form of lesson details
  • 81ec8fde - Standartize on cancelled spelling with two l
  • e986e133 - Update text field names in amend form of lesson details
  • f05225d5 - Add default amend object to lesson details
  • daeafeb0 - Implement graphql amend lesson mutation

Compare with previous version

added 7 commits <ul><li>dd4a6246 - Add edit button to lesson details</li><li>bca7820f - Add dialog-object-form to lesson details</li><li>b226e583 - Name text fields in amend form of lesson details</li><li>81ec8fde - Standartize on cancelled spelling with two l</li><li>e986e133 - Update text field names in amend form of lesson details</li><li>f05225d5 - Add default amend object to lesson details</li><li>daeafeb0 - Implement graphql amend lesson mutation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=33958&start_sha=9e492da7d8bfb41f22203b3db6887be83ac2b6a0)
permcu commented 2023-08-28 19:19:44 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 5e302e09 - Handle amend lesson mutation like other use sites & add it to props

Compare with previous version

added 1 commit <ul><li>5e302e09 - Handle amend lesson mutation like other use sites &amp; add it to props</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=33995&start_sha=daeafeb02aa7e6e48ff1a3ddb51e6630412edd8e)
permcu commented 2023-08-28 19:22:47 +02:00 (Migrated from edugit.org)
Copy link

added 6 commits

  • 5e302e09...c07bd892 - 5 commits from branch new-model-based-on-calendar
  • 52967280 - Merge branch 'new-model-based-on-calendar' into 211-implement-vue-substitution-frontend

Compare with previous version

added 6 commits <ul><li>5e302e09...c07bd892 - 5 commits from branch <code>new-model-based-on-calendar</code></li><li>52967280 - Merge branch &#39;new-model-based-on-calendar&#39; into 211-implement-vue-substitution-frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=33996&start_sha=5e302e09a19b10ea10527be18accbfd0048f7d21)
permcu commented 2023-08-30 18:20:51 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 1be0db49 - Fix graphql amend lesson mutation

Compare with previous version

added 1 commit <ul><li>1be0db49 - Fix graphql amend lesson mutation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34012&start_sha=5296728094d8d8033c69a11e813e50c129db6bcf)
permcu commented 2023-08-30 20:17:44 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • b44c2074 - Remove timezone handling code since LessonEvent uses UTC

Compare with previous version

added 1 commit <ul><li>b44c2074 - Remove timezone handling code since LessonEvent uses UTC</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34017&start_sha=1be0db4983f169574a18799123a9781202f81f74)
permcu commented 2023-08-31 17:52:33 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • becd63ff - WIP: patch mutation

Compare with previous version

added 1 commit <ul><li>becd63ff - WIP: patch mutation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34025&start_sha=b44c207411821935d1bde02536618b2379ad174f)
permcu commented 2023-09-01 19:14:56 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • a41cbf1e - Add id to LessonEvent meta field (= x-meta ical field)
  • 9eb5c966 - Enable editing of amended lesson with a amend lesson mutation

Compare with previous version

added 2 commits <ul><li>a41cbf1e - Add id to LessonEvent meta field (= x-meta ical field)</li><li>9eb5c966 - Enable editing of amended lesson with a amend lesson mutation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34047&start_sha=becd63ff7280cc1e725ab4a781c8b1ca9dc0fbcf)
permcu commented 2023-09-02 12:45:29 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 0c8e3f07 - Remove debug prints
  • 5161437c - Enable autocomplete for subject, teachers & rooms

Compare with previous version

added 2 commits <ul><li>0c8e3f07 - Remove debug prints</li><li>5161437c - Enable autocomplete for subject, teachers &amp; rooms</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34053&start_sha=9eb5c9664ff73d97a1d909c4533c4d0f3d8470d2)
yuha commented 2023-09-02 13:19:15 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>ae723f2d - Fix typo</li><li>57b32c3b - Refresh calendar after lesson is amended</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34056&start_sha=5161437cf9f84255eb87dd749f68b17066a13b28)
yuha commented 2023-09-02 13:23:50 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 04a916ce - Use (bigger) v-textarea for imputting comments when amending lessons

Compare with previous version

added 1 commit <ul><li>04a916ce - Use (bigger) v-textarea for imputting comments when amending lessons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34058&start_sha=57b32c3bf296707272948890167ac2562f369b0e)
hansegucker commented 2023-09-02 17:21:32 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • ba21458f - Fix displaying of subjects in lesson feed

Compare with previous version

added 1 commit <ul><li>ba21458f - Fix displaying of subjects in lesson feed</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34070&start_sha=04a916cefeed137d19d7c40911a6123a9b84bfb8)
hansegucker commented 2023-09-02 19:19:51 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 39a85c05 - Correctly set timezones with amended lesson events

Compare with previous version

added 1 commit <ul><li>39a85c05 - Correctly set timezones with amended lesson events</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34072&start_sha=ba21458f135193504816e1cdc39556e8f3742d34)
hansegucker commented 2023-09-03 12:57:32 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 6586e6cc - Make labels for amend dialog better understandable

Compare with previous version

added 1 commit <ul><li>6586e6cc - Make labels for amend dialog better understandable</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34073&start_sha=39a85c05591a91fe095674cddf9695e32c2e3e73)
permcu commented 2023-09-04 18:38:28 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 156c5c3b - Check permission before showing substitution frontend

Compare with previous version

added 1 commit <ul><li>156c5c3b - Check permission before showing substitution frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34107&start_sha=6586e6cc777f073f41c3f90ae7acb7a7288bee1c)
permcu commented 2023-09-04 19:22:55 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 1391b48c - Check permission before showing substitution frontend

Compare with previous version

added 1 commit <ul><li>1391b48c - Check permission before showing substitution frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34110&start_sha=156c5c3bd419abc6b312a1641c0a64b057379702)
permcu commented 2023-09-05 12:52:43 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 2d8945d5 - Use id in edit-item of substitution frontend
  • 98a44758 - Disable subject, teachers & rooms selection if lesson cancelled

Compare with previous version

added 2 commits <ul><li>2d8945d5 - Use id in edit-item of substitution frontend</li><li>98a44758 - Disable subject, teachers &amp; rooms selection if lesson cancelled</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34112&start_sha=1391b48cc283c3c1d7e3cf644ef0038233a8e115)
yuha commented 2023-09-11 19:17:00 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 2acec8b2 - Close lesson detail view after amending
  • 20e00758 - Fix values of amended lessons not being shown in form

Compare with previous version

added 2 commits <ul><li>2acec8b2 - Close lesson detail view after amending</li><li>20e00758 - Fix values of amended lessons not being shown in form</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34242&start_sha=98a44758b5978a622ecdff5a44daa30546f895dc)
hansegucker commented 2023-09-13 12:01:56 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • bce6b8f6 - Fix datetime handling
  • 582b606a - Merge branch '211-implement-vue-substitution-frontend' of...

Compare with previous version

added 2 commits <ul><li>bce6b8f6 - Fix datetime handling</li><li>582b606a - Merge branch &#39;211-implement-vue-substitution-frontend&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34262&start_sha=20e0075823d041bb92a9644898b92542a07a5457)
hansegucker commented 2023-09-13 21:06:17 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • fd036dc1 - Convert datetimes on substitution creation to UTC to transfer data correctly

Compare with previous version

added 1 commit <ul><li>fd036dc1 - Convert datetimes on substitution creation to UTC to transfer data correctly</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34274&start_sha=582b606a8af0ed488cc0d4c95851919ac0bfacf5)
permcu commented 2023-09-17 11:40:17 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 31c88e61 - Fix DatetimeTimezoneMixin to work with create and patch mutations

Compare with previous version

added 1 commit <ul><li>31c88e61 - Fix DatetimeTimezoneMixin to work with create and patch mutations</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34328&start_sha=fd036dc11d8e66a0aa7215c818e537045c01a3ae)
permcu commented 2023-09-17 12:04:20 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 3ca1e9d3 - Enable deletion of substitution in substitution frontend

Compare with previous version

added 1 commit <ul><li>3ca1e9d3 - Enable deletion of substitution in substitution frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34329&start_sha=31c88e61293e6aae01485d5601e9b23571517339)
yuha commented 2023-09-20 01:17:57 +02:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • 3ca1e9d3...c8e10b49 - 3 commits from branch new-model-based-on-calendar
  • 03c9b5f0 - Merge branch 'new-model-based-on-calendar' into 211-implement-vue-substitution-frontend

Compare with previous version

added 4 commits <ul><li>3ca1e9d3...c8e10b49 - 3 commits from branch <code>new-model-based-on-calendar</code></li><li>03c9b5f0 - Merge branch &#39;new-model-based-on-calendar&#39; into 211-implement-vue-substitution-frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34443&start_sha=3ca1e9d307456ec8b23c89425c06e8c3f0897583)
permcu commented 2023-09-22 21:58:30 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 8be93719 - Set cancel substitution confirm dialog title
  • a36cfade - Move amend lesson (substitution ui) to own component
  • c40d3243 - Remove amendEvent namespace in now standalone AmendEvent component

Compare with previous version

added 3 commits <ul><li>8be93719 - Set cancel substitution confirm dialog title</li><li>a36cfade - Move amend lesson (substitution ui) to own component</li><li>c40d3243 - Remove amendEvent namespace in now standalone AmendEvent component</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34558&start_sha=03c9b5f04ab75cad14a96d0d3abcb25fb2729afd)
yuha commented 2023-09-25 14:43:33 +02:00 (Migrated from edugit.org)
Copy link

FIXME: Check permissions (and rename the edit_lessonsubstitution permission/use another, global one since this one is based on a legacy model)

FIXME: Check permissions (and rename the `edit_lessonsubstitution` permission/use another, global one since this one is based on a legacy model)
magicfelix commented 2023-09-28 21:31:00 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 10b5781b - Use existing permissions
  • 48d59b6a - Merge branch 'new-model-based-on-calendar' into 211-implement-vue-substitution-frontend

Compare with previous version

added 2 commits <ul><li>10b5781b - Use existing permissions</li><li>48d59b6a - Merge branch &#39;new-model-based-on-calendar&#39; into 211-implement-vue-substitution-frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34629&start_sha=c40d32433bd3ecd0ef7f599572fbd3220b1c203f)
magicfelix commented 2023-09-28 21:53:12 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>907762cb - Avoid using reserved names</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34633&start_sha=48d59b6aae0e35c6de4ac51af5bc5d73a219d629)
magicfelix commented 2023-09-29 20:00:48 +02:00 (Migrated from edugit.org)
Copy link

@permcu this is currently not working. Clicking on a lesson event in the timetable opens the detailed card(?), but without an edit button and the console contains a few error messages like this one Error in render: "TypeError: _vm.selectedEvent is undefined".

@permcu this is currently not working. Clicking on a lesson event in the timetable opens the detailed card(?), but without an edit button and the console contains a few error messages like this one `Error in render: "TypeError: _vm.selectedEvent is undefined"`.
yuha commented 2023-10-11 20:39:56 +02:00 (Migrated from edugit.org)
Copy link

@yuha

@yuha
yuha commented 2023-10-12 16:24:55 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 97da5398 - Fix issues caused by separating AmendLesson component

Compare with previous version

added 1 commit <ul><li>97da5398 - Fix issues caused by separating AmendLesson component</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=34880&start_sha=907762cb98002b746ded6494062fab2a8f5c6376)
yuha commented 2023-10-12 16:26:17 +02:00 (Migrated from edugit.org)
Copy link

fixed

fixed
yuha commented 2023-10-12 16:26:18 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
yuha commented 2023-10-12 16:26:36 +02:00 (Migrated from edugit.org)
Copy link

.

.
yuha commented 2023-10-12 16:26:38 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2023-10-26 17:00:46 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>87873a96 - Bump dev version</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=35312&start_sha=97da53983655d75eff300e48bac09b83089e28f6)
magicfelix commented 2023-11-04 21:59:07 +01:00 (Migrated from edugit.org)
Copy link

added 15 commits

  • 87873a96...315680b9 - 14 commits from branch new-model-based-on-calendar
  • c6af6bed - Merge branch 'new-model-based-on-calendar' into 211-implement-vue-substitution-frontend

Compare with previous version

added 15 commits <ul><li>87873a96...315680b9 - 14 commits from branch <code>new-model-based-on-calendar</code></li><li>c6af6bed - Merge branch &#39;new-model-based-on-calendar&#39; into 211-implement-vue-substitution-frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=35378&start_sha=87873a967e05e66c6b640acbee3e36294a9366aa)
yuha commented 2024-02-25 16:35:31 +01:00 (Migrated from edugit.org)
Copy link

added 46 commits

  • c6af6bed...955800d1 - 45 commits from branch new-model-based-on-calendar
  • f0a822c1 - Merge branch 'new-model-based-on-calendar' into 211-implement-vue-substitution-frontend

Compare with previous version

added 46 commits <ul><li>c6af6bed...955800d1 - 45 commits from branch <code>new-model-based-on-calendar</code></li><li>f0a822c1 - Merge branch &#39;new-model-based-on-calendar&#39; into 211-implement-vue-substitution-frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=39680&start_sha=c6af6bed3410468b44ad43e12a1546d909024582)
yuha commented 2024-02-25 17:21:16 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 19e2816e - Adapt to CRUD refactoring
  • cf092d08 - Properly handle LessonEvents without subject

Compare with previous version

added 2 commits <ul><li>19e2816e - Adapt to CRUD refactoring</li><li>cf092d08 - Properly handle LessonEvents without subject</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=39682&start_sha=f0a822c157dc04237548bbb614d44079797370b2)
yuha commented 2024-02-25 17:47:47 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 40edcdd0 - Adapt deletion of substitutions to CRUD refactoring

Compare with previous version

added 1 commit <ul><li>40edcdd0 - Adapt deletion of substitutions to CRUD refactoring</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=39684&start_sha=cf092d08eee635dd56c4eabb7c9744b7ceb907c4)
yuha commented 2024-02-25 17:50:41 +01:00 (Migrated from edugit.org)
Copy link

TODO: Add meaningful message to delete dialog of substitutions (may require changes in DeleteDialog since the text displayed for individual objects to be deleted there can only be the content of one property of the said objects)

TODO: Add meaningful message to delete dialog of substitutions (may require changes in DeleteDialog since the text displayed for individual objects to be deleted there can only be the content of one property of the said objects)
yuha commented 2024-02-25 17:50:47 +01:00 (Migrated from edugit.org)
Copy link

.

.
hansegucker commented 2024-03-07 11:28:13 +01:00 (Migrated from edugit.org)
Copy link

deleted the new-model-based-on-calendar branch. This merge request now targets the master branch

deleted the `new-model-based-on-calendar` branch. This merge request now targets the `master` branch
hansegucker commented 2024-03-07 12:35:53 +01:00 (Migrated from edugit.org)
Copy link

added 10 commits

  • 40edcdd0...ccbc6ee0 - 8 commits from branch master
  • 0e1ffed5 - Merge branch 'master' into 211-implement-vue-substitution-frontend
  • bb438cc7 - Reformat and fix lint

Compare with previous version

added 10 commits <ul><li>40edcdd0...ccbc6ee0 - 8 commits from branch <code>master</code></li><li>0e1ffed5 - Merge branch &#39;master&#39; into 211-implement-vue-substitution-frontend</li><li>bb438cc7 - Reformat and fix lint</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=40385&start_sha=40edcdd0409e27731216bd3220619f6ebace348d)
hansegucker commented 2024-03-07 21:49:59 +01:00 (Migrated from edugit.org)
Copy link

mentioned in merge request !633

mentioned in merge request !633
yuha commented 2024-03-11 12:32:08 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 71aed507 - Strike through teachers absent in substitutions even though there is no substitution teacher yet

Compare with previous version

added 1 commit <ul><li>71aed507 - Strike through teachers absent in substitutions even though there is no substitution teacher yet</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=40463&start_sha=bb438cc77d76c3e1d1b991eb8a2312bdc317b677)
yuha commented 2024-03-11 12:51:51 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • ce526f4f - Strike through teachers absent in substitutions even though there is no substitution teacher yet

Compare with previous version

added 1 commit <ul><li>ce526f4f - Strike through teachers absent in substitutions even though there is no substitution teacher yet</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=40465&start_sha=71aed507b8d19133a5cc33f55baa3167cb9a702c)
yuha commented 2024-03-11 13:40:48 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • bffc96e5 - Add proper delete text

Compare with previous version

added 1 commit <ul><li>bffc96e5 - Add proper delete text</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=40468&start_sha=ce526f4f5db0f229a9fdb361a654c226a6541865)
yuha commented 2024-03-11 13:41:27 +01:00 (Migrated from edugit.org)
Copy link

solved now, but requires https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1428

solved now, but requires https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1428
yuha commented 2024-03-13 01:04:58 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>cfc417f1 - Add proper delete text</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=40491&start_sha=bffc96e5eb36e78f6c2f5067b0a402bbf4f1176f)
hansegucker commented 2024-03-15 10:06:46 +01:00 (Migrated from edugit.org)
Copy link

removed review request for @hansegucker

removed review request for @hansegucker
hansegucker commented 2024-03-15 10:06:49 +01:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker and unassigned @permcu

assigned to @hansegucker and unassigned @permcu
yuha commented 2024-03-15 17:57:46 +01:00 (Migrated from edugit.org)
Copy link

added 6 commits

  • cfc417f1...c1ec3a81 - 5 commits from branch master
  • a9cdcdd5 - Merge branch 'master' into 211-implement-vue-substitution-frontend

Compare with previous version

added 6 commits <ul><li>cfc417f1...c1ec3a81 - 5 commits from branch <code>master</code></li><li>a9cdcdd5 - Merge branch &#39;master&#39; into 211-implement-vue-substitution-frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=40641&start_sha=cfc417f1eec4906dab0a519198ea4644c43ae138)
yuha commented 2024-03-15 18:06:35 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 11fd7e05 - Fix amends field of LessonEvent in gql schema

Compare with previous version

added 1 commit <ul><li>11fd7e05 - Fix amends field of LessonEvent in gql schema</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=40643&start_sha=a9cdcdd5fe774d12479db9fdd8b301b0c3258afe)
hansegucker commented 2024-03-24 10:55:50 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2024-03-24 11:13:22 +01:00 (Migrated from edugit.org)
Copy link
        "delete_dialog": "Are you sure you want to delete this substitution?",
```suggestion:-0+0 "delete_dialog": "Are you sure you want to delete this substitution?", ```
hansegucker commented 2024-03-24 15:52:28 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2024-03-24 15:52:38 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 48 of the diff

changed this line in [version 48 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=41001&start_sha=11fd7e05065c9bf8e4b04fd366a9ce00c0b704ed#fdc1da301d9b98558910face9edfb653d25eed15_38_38)
hansegucker commented 2024-03-24 15:52:39 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>0cc4d77a - Fix messages</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=41001&start_sha=11fd7e05065c9bf8e4b04fd366a9ce00c0b704ed)
hansegucker commented 2024-03-24 16:02:46 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>7d753474 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=41004&start_sha=0cc4d77a2cc04a68cca7814a38fd7996d3fdbaa0)
hansegucker commented 2024-03-28 17:46:28 +01:00 (Migrated from edugit.org)
Copy link

added 11 commits

  • 7d753474...2743bd0f - 10 commits from branch master
  • b8cfaaac - Merge branch 'master' into 211-implement-vue-substitution-frontend

Compare with previous version

added 11 commits <ul><li>7d753474...2743bd0f - 10 commits from branch <code>master</code></li><li>b8cfaaac - Merge branch &#39;master&#39; into 211-implement-vue-substitution-frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/310/diffs?diff_id=41253&start_sha=7d75347482b17b90b2b8aeebde876751fde83c5e)
hansegucker commented 2024-03-28 17:47:10 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2024-03-28 17:47:38 +01:00 (Migrated from edugit.org)
Copy link

mentioned in commit 210217945f

mentioned in commit 210217945f7de01db3fd54e1b57b04ac59b0b806
hansegucker (Migrated from edugit.org) merged commit 210217945f into master 2024-03-28 17:47:38 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Chronos!614
No description provided.