aleksis/AlekSIS-App-CSVImport
8
0
Fork 0
Code Issues 16 Pull requests 5 Projects Releases 2 Packages Activity Actions

Resolve "Move phone number country code preference to core" #141

Merged
hansegucker merged 3 commits from 36-move-phone-number-country-code-preference-to-core into master 2022-01-11 11:01:48 +01:00
Conversation 11 Commits 3 Files changed 5 +5 -13
hansegucker commented 2022-01-07 14:40:28 +01:00 (Migrated from edugit.org)
Copy link

Closes #36

Waiting for !139 and AlekSIS/official/AlekSIS-Core!947

Closes #36 Waiting for !139 and AlekSIS/official/AlekSIS-Core!947
hansegucker commented 2022-01-07 14:40:29 +01:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker

assigned to @hansegucker
hansegucker commented 2022-01-07 14:53:57 +01:00 (Migrated from edugit.org)
Copy link

added 23 commits

  • 594656d6 - Catch not-configured database to make it possible to run some management commands without database
  • 8e66320d - Provide default templates as YAML and support args for field types
  • 948bb5a1 - Fix phone number parsing
  • d12743d9 - Don't limit import to specific models
  • 88d64767 - Use args for field types and fix match type handling
  • 9f17633a - Add regex and street/housenumber field types
  • 22d73a9a - Support suffixing email address local parts with domains
  • c3a1cd39 - Fix/add primary group field types
  • 84862b93 - Update template for Schild-NRW students
  • 0ed3fb04 - Update changelog
  • c5a60ca5 - Fix typo in changelog
  • 17310884 - Fix check for `email_domain` argument
  • fa4df581 - Update copyright
  • cfb15ad9 - Fixed argument parsing for management command
  • 6a2ab856 - Allow import of first column (configurable)
  • 9e83b617 - Update copyright
  • 2ddd99e7 - Allow duplicate spaces in between street and house numbers
  • 09dd1a67 - Align capitalisation of Schild-NRW with upstream
  • 6f3bc883 - Allow fully-qualified mail addresses even if email_domain is set
  • 967f70bd - Add template for Schild-NRW teachers
  • b4b8cb55 - Use newer version of ALekSIS-Core
  • 3dfd25f1 - Use ruamel.yaml as YAML library
  • 9cfd7ffc - Use phone number country preference from Core

Compare with previous version

added 23 commits <ul><li>594656d6 - Catch not-configured database to make it possible to run some management commands without database</li><li>8e66320d - Provide default templates as YAML and support args for field types</li><li>948bb5a1 - Fix phone number parsing</li><li>d12743d9 - Don&#39;t limit import to specific models</li><li>88d64767 - Use args for field types and fix match type handling</li><li>9f17633a - Add regex and street/housenumber field types</li><li>22d73a9a - Support suffixing email address local parts with domains</li><li>c3a1cd39 - Fix/add primary group field types</li><li>84862b93 - Update template for Schild-NRW students</li><li>0ed3fb04 - Update changelog</li><li>c5a60ca5 - Fix typo in changelog</li><li>17310884 - Fix check for `email_domain` argument</li><li>fa4df581 - Update copyright</li><li>cfb15ad9 - Fixed argument parsing for management command</li><li>6a2ab856 - Allow import of first column (configurable)</li><li>9e83b617 - Update copyright</li><li>2ddd99e7 - Allow duplicate spaces in between street and house numbers</li><li>09dd1a67 - Align capitalisation of Schild-NRW with upstream</li><li>6f3bc883 - Allow fully-qualified mail addresses even if email_domain is set</li><li>967f70bd - Add template for Schild-NRW teachers</li><li>b4b8cb55 - Use newer version of ALekSIS-Core</li><li>3dfd25f1 - Use ruamel.yaml as YAML library</li><li>9cfd7ffc - Use phone number country preference from Core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/66/diffs?diff_id=15710&start_sha=54d9b3935c84ac7be9b4cdb30824e8df81ff7383)
hansegucker commented 2022-01-07 14:54:19 +01:00 (Migrated from edugit.org)
Copy link

changed the description

changed the description
hansegucker commented 2022-01-10 18:51:19 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2022-01-10 18:51:19 +01:00 (Migrated from edugit.org)
Copy link

added 34 commits

  • 9cfd7ffc...8068b492 - 32 commits from branch master
  • 94bd9421 - Merge branch 'master' into 36-move-phone-number-country-code-preference-to-core
  • a53d58dd - Depend on Core version 2.6

Compare with previous version

added 34 commits <ul><li>9cfd7ffc...8068b492 - 32 commits from branch <code>master</code></li><li>94bd9421 - Merge branch &#39;master&#39; into 36-move-phone-number-country-code-preference-to-core</li><li>a53d58dd - Depend on Core version 2.6</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/66/diffs?diff_id=16302&start_sha=9cfd7ffc493ea235b529cccdebfbc27a3de6913d)
hansegucker commented 2022-01-10 18:51:23 +01:00 (Migrated from edugit.org)
Copy link

assigned to @benni and unassigned @hansegucker

assigned to @benni and unassigned @hansegucker
hansegucker commented 2022-01-10 18:51:25 +01:00 (Migrated from edugit.org)
Copy link

assigned to @nik and unassigned @benni

assigned to @nik and unassigned @benni
nik commented 2022-01-11 11:00:13 +01:00 (Migrated from edugit.org)
Copy link

I think this needs a migration.

I think this needs a migration.
nik commented 2022-01-11 11:01:27 +01:00 (Migrated from edugit.org)
Copy link

Naah, maybe not.

Naah, maybe not.
nik commented 2022-01-11 11:01:29 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
nik (Migrated from edugit.org) merged commit 17a624f88a into master 2022-01-11 11:01:48 +01:00
nik commented 2022-01-11 11:01:49 +01:00 (Migrated from edugit.org)
Copy link

mentioned in commit 17a624f88a

mentioned in commit 17a624f88adc80a1f04b59e734b5fee2cb71a085
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-CSVImport!141
No description provided.