aleksis/AlekSIS-App-CSVImport

Watch

Fork 0

Reintroduce Schild-NRW import with generic importer #139

Merged

hansegucker merged 24 commits from 28-allow-providing-args-for-field-types into master

2022-01-07 19:04:42 +01:00

hansegucker commented

2021-12-30 12:11:55 +01:00

Owner

Closes: #15, #28, #29, #30

Still to do:

Allow using field type twice (#34)
Allow using strings from preferences (e.g. mail domain) (#35)

Closes: #15, #28, #29, #30 Still to do: * [ ] Allow using field type twice (#34) * [ ] Allow using strings from preferences (e.g. mail domain) (#35)

hansegucker commented

2021-12-30 12:11:55 +01:00

Author

Owner

assigned to @hansegucker

hansegucker commented

2021-12-30 12:17:26 +01:00

Author

Owner

added 2 commits

594656d6 - Catch not-configured database to make it possible to run some management commands without database
66bc9aa0 - Provide default templates as YAML and support args for field types

Compare with previous version

added 2 commits <ul><li>594656d6 - Catch not-configured database to make it possible to run some management commands without database</li><li>66bc9aa0 - Provide default templates as YAML and support args for field types</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15424&start_sha=54d9b3935c84ac7be9b4cdb30824e8df81ff7383)

hansegucker commented

2021-12-30 12:18:07 +01:00

Author

Owner

added 1 commit

8e66320d - Provide default templates as YAML and support args for field types

Compare with previous version

added 1 commit <ul><li>8e66320d - Provide default templates as YAML and support args for field types</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15426&start_sha=66bc9aa0641b58767faccdb17f5e7f54d0dd9bd7)

hansegucker commented

2021-12-30 12:18:12 +01:00

Author

Owner

assigned to @nik and unassigned @hansegucker

nik commented

2021-12-30 15:07:44 +01:00

Owner

This becomes a constant 0 in line 37.

This becomes a constant `0` in line 37.

hansegucker commented

2021-12-31 12:42:31 +01:00

Author

Owner

added 8 commits

948bb5a1 - Fix phone number parsing
d12743d9 - Don't limit import to specific models
88d64767 - Use args for field types and fix match type handling
9f17633a - Add regex and street/housenumber field types
22d73a9a - Support suffixing email address local parts with domains
c3a1cd39 - Fix/add primary group field types
84862b93 - Update template for Schild-NRW students
0ed3fb04 - Update changelog

Compare with previous version

added 8 commits <ul><li>948bb5a1 - Fix phone number parsing</li><li>d12743d9 - Don't limit import to specific models</li><li>88d64767 - Use args for field types and fix match type handling</li><li>9f17633a - Add regex and street/housenumber field types</li><li>22d73a9a - Support suffixing email address local parts with domains</li><li>c3a1cd39 - Fix/add primary group field types</li><li>84862b93 - Update template for Schild-NRW students</li><li>0ed3fb04 - Update changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15458&start_sha=8e66320dbd01f0b0c42fe24dd7d0fc17e857419b)

nik commented

2021-12-31 17:40:40 +01:00

Owner

marked this merge request as ready

marked this merge request as **ready**

nik commented

2021-12-31 17:53:40 +01:00

Owner

        if "email_domain" in cls.get_args():

```suggestion:-0+0 if "email_domain" in cls.get_args(): ```

nik commented

2021-12-31 17:53:40 +01:00

Owner

* Add field type to set an owner of a person's primary group by its short name.

```suggestion:-0+0 * Add field type to set an owner of a person's primary group by its short name. ```

nik commented

2021-12-31 17:59:01 +01:00

Owner

It actually doesn't. Still learning Python ;)!

nik commented

2021-12-31 17:59:45 +01:00

Owner

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15461&start_sha=0ed3fb04f7bd4151166bf64cfba8a84cc5c43b5f#45267e3a9556cafa9cb7b61dab7a3b6659e73aad_17_17)

nik commented

2021-12-31 17:59:46 +01:00

Owner

added 1 commit

c5a60ca5 - Fix typo in changelog

Compare with previous version

added 1 commit <ul><li>c5a60ca5 - Fix typo in changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15461&start_sha=0ed3fb04f7bd4151166bf64cfba8a84cc5c43b5f)

nik commented

2021-12-31 18:00:05 +01:00

Owner

resolved all threads

nik commented

2021-12-31 18:00:07 +01:00

Owner

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15462&start_sha=c5a60ca5d498f429b2a794a03f6b8ce2b745ebad#109f1a1af772b7d4ac38456a0cd912e2eb4a2e76_251_251)

nik commented

2021-12-31 18:00:08 +01:00

Owner

added 1 commit

17310884 - Fix check for `email_domain` argument

Compare with previous version

added 1 commit <ul><li>17310884 - Fix check for `email_domain` argument</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15462&start_sha=c5a60ca5d498f429b2a794a03f6b8ce2b745ebad)

hansegucker commented

2022-01-01 15:07:42 +01:00

Author

Owner

added 1 commit

fa4df581 - Update copyright

Compare with previous version

added 1 commit <ul><li>fa4df581 - Update copyright</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15475&start_sha=1731088421c49ff8fe54e3ba152e7888c6f13bbc)

nik commented

2022-01-01 22:49:41 +01:00

Owner

changed the description

nik commented

2022-01-01 22:56:10 +01:00

Owner

added 1 commit

cfb15ad9 - Fixed argument parsing for management command

Compare with previous version

added 1 commit <ul><li>cfb15ad9 - Fixed argument parsing for management command</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15481&start_sha=fa4df5813cd1b569e11feab68e1374264cd2c850)

nik commented

2022-01-01 23:21:37 +01:00

Owner

changed title from Re{-solve "Allow providing args for field types"-} to Re{+introduce SchILD import with generic importer+}

changed title from **Re{-solve "Allow providing args for field types"-}** to **Re{+introduce SchILD import with generic importer+}**

nik commented

2022-01-01 23:21:37 +01:00

Owner

changed the description

nik commented

2022-01-01 23:38:55 +01:00

Owner

changed the description

nik commented

2022-01-01 23:44:13 +01:00

Owner

added 1 commit

6a2ab856 - Allow import of first column (configurable)

Compare with previous version

added 1 commit <ul><li>6a2ab856 - Allow import of first column (configurable)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15484&start_sha=cfb15ad9ba10388699fae0774684e184a205ab8b)

nik commented

2022-01-01 23:49:04 +01:00

Owner

added 2 commits

9e83b617 - Update copyright
2ddd99e7 - Allow duplicate spaces in between street and house numbers

Compare with previous version

added 2 commits <ul><li>9e83b617 - Update copyright</li><li>2ddd99e7 - Allow duplicate spaces in between street and house numbers</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15485&start_sha=6a2ab856d062f52f0668ed392d8029c6280ec4a8)

nik commented

2022-01-01 23:50:53 +01:00

Owner

added 1 commit

09dd1a67 - Align capitalisation of Schild-NRW with upstream

Compare with previous version

added 1 commit <ul><li>09dd1a67 - Align capitalisation of Schild-NRW with upstream</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15486&start_sha=2ddd99e7ae1d579e3b16cb6d3bb08d890e89e35e)

nik commented

2022-01-02 00:13:49 +01:00

Owner

added 2 commits

6f3bc883 - Allow fully-qualified mail addresses even if email_domain is set
967f70bd - Add template for Schild-NRW teachers

Compare with previous version

added 2 commits <ul><li>6f3bc883 - Allow fully-qualified mail addresses even if email_domain is set</li><li>967f70bd - Add template for Schild-NRW teachers</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15488&start_sha=09dd1a67a5cc9b1c7b9cc129e233ed479649e204)

nik commented

2022-01-02 00:13:49 +01:00

Owner

marked this merge request as draft

marked this merge request as **draft**

nik commented

2022-01-02 00:17:22 +01:00

Owner

changed the description

nik commented

2022-01-02 18:22:44 +01:00

Owner

changed title from Draft: Reintroduce Sch{-ILD-} import with generic importer to Draft: Reintroduce Sch{+ild-NRW+} import with generic importer

changed title from **Draft: Reintroduce Sch{-ILD-} import with generic importer** to **Draft: Reintroduce Sch{+ild-NRW+} import with generic importer**

tteichler commented

2022-01-02 23:38:50 +01:00

Owner

added 1 commit

b4b8cb55 - Use newer version of ALekSIS-Core

Compare with previous version

added 1 commit <ul><li>b4b8cb55 - Use newer version of ALekSIS-Core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15516&start_sha=967f70bd60a1ac9db2017bcfdc96857301c0e34e)

nik commented

2022-01-03 00:09:30 +01:00

Owner

added 1 commit

2c6a4dd3 - Use ruamel.yaml as YAML library

Compare with previous version

added 1 commit <ul><li>2c6a4dd3 - Use ruamel.yaml as YAML library</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15518&start_sha=b4b8cb55402c1592fe7386da419f2f4444ecf7ec)

nik commented

2022-01-03 13:53:21 +01:00

Owner

added 1 commit

3dfd25f1 - Use ruamel.yaml as YAML library

Compare with previous version

added 1 commit <ul><li>3dfd25f1 - Use ruamel.yaml as YAML library</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15532&start_sha=2c6a4dd382bd81e12473e25e86a33538d01c1d09)

nik commented

2022-01-06 16:17:00 +01:00

Owner

On the last import at HHG, the addresses were missing. My commit 2ddd99e7ae might be the culprit.

On the last import at HHG, the addresses were missing. My commit 2ddd99e7ae1d579e3b16cb6d3bb08d890e89e35e might be the culprit.

hansegucker commented

2022-01-07 14:54:20 +01:00

Author

Owner

mentioned in merge request !141

hansegucker commented

2022-01-07 14:54:45 +01:00

Author

Owner

mentioned in merge request !140

hansegucker commented

2022-01-07 17:56:12 +01:00

Author

Owner

mentioned in merge request !142

hansegucker commented

2022-01-07 18:00:48 +01:00

Author

Owner

added 2 commits

05bd8f74 - Add poetry.lock to .gitignore
d943d78e - Drop custom import templates

Compare with previous version

added 2 commits <ul><li>05bd8f74 - Add poetry.lock to .gitignore</li><li>d943d78e - Drop custom import templates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/64/diffs?diff_id=15761&start_sha=3dfd25f1eb9ff521a25b47342257ac4bdc51d1c9)

hansegucker commented

2022-01-07 18:01:25 +01:00

Author

Owner

marked this merge request as ready

marked this merge request as **ready**

hansegucker scheduled this pull request to auto merge when all checks succeed

2022-01-07 18:02:06 +01:00

hansegucker merged commit 5c849141af into master

2022-01-07 19:04:42 +01:00

hansegucker commented

2022-01-07 19:04:43 +01:00