Resolve "Add simple course book list" #740
No reviewers
Labels
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
No milestone
No project
No assignees
5 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
aleksis/AlekSIS-App-Alsijil!740
Loading…
Reference in a new issue
No description provided.
Delete branch "256-add-simple-course-book-list"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #256
Closes #63
Screenshots
Frontend todos
assigned to @yuha
added 11 commits
79517819- 1 earlier commit52a9cd14- Add GraphQL schema for Documentation97e41acf- WIP: Add permissions for Documentation26b4e2b2- Correct verbose namesdd092e32- Remove obsolete codeb6701825- Return only documentations a user is allowed to view428c5a8c- Add some verbose names for new class register modelsfc19c951- Update models467aada0- Set mutation fields explicitly3fca9a1f- Fix lint9ea0ed66- Update models and fix migrationsCompare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
21863194- Create endpoint for real and dummy documentations in a timeframeCompare with previous version
added 1 commit
eaf6e8d3- Add frontend qgl query for coursebook documentationsCompare with previous version
added 2 commits
9d4dcad9- Only include existing documentations in coursebook when dates match9618c373- Use unique dummy ids in coursebook documentations queryCompare with previous version
added 1 commit
2d58b4c4- Rename variable use to access reference objectCompare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
37317563- Add update/create mutation for documentationsCompare with previous version
added 1 commit
75514e71- Fix update/create documentation mutationCompare with previous version
added 4 commits
6513a320- Initialize coursebook frontend7baed8d8- Name coursebook query result itemsCompare with previous version
added 2 commits
4023ab7d- Group documentations by day and show in coursebook frontend6a0b8f50- Do not show a create (or edit) button in coursebookCompare with previous version
added 2 commits
8e1fbb11- Make groupDocsByDay keep date time of day7beae884- Show localized daily dateCompare with previous version
added 1 commit
8515fa1b- Allow accessing coursebook for different object types (courses, groups, ...)Compare with previous version
added 3 commits
f74d5ec4- Do proper date localizationafd51c38- Add coursebook sub componentsf784b204- Remove outer cardCompare with previous version
added 2 commits
84f98c7e- Add permission checks for coursebook356c223f- ReformatCompare with previous version
added 1 commit
2e66e26a- Fix importsCompare with previous version
added 1 commit
a0764e91- Fix coursebook child routeCompare with previous version
added 4 commits
6440fe13- Correct styling in documentation containerdc4cbd31- Start work on LessonInformation.vuef05ed666- Display topic, homework and groupnote370687af- Make documentation card full widthCompare with previous version
added 1 commit
b14c8dd1- Fix date calculationCompare with previous version
added 1 commit
0d4b2741- Fix typosCompare with previous version
added 7 commits
0ea4656a- Add course to LessonInformation00b1c0e5- Make subject chip work with missing subjectCompare with previous version
added 5 commits
c731ed02- Change documentation mutation to batch90e3b820- Add graphql documentation mutation1b19258a- Implement lesson summary (topic, homework, note) interface0a83654f- Implement saveTopic and wire documentation mutation up15926c5b- Remove too eager commentCompare with previous version
added 4 commits
fbf25845- Fix batch documentation mutation0d825eb7- Fix graphql naming - mutation was incompatible with mutationMixine2814e04- Add missing data definitionsd8f59025- Do not mutate topic if unchangedCompare with previous version
added 5 commits
5a725948- Inline v-card into documentation component11fa1b88- Fill the lesson summary text fieldsCompare with previous version
added 3 commits
9e566fe4- Implement modal lesson summary componentc492cab2- Implement cache updated9b61a53- Fix backend documentation updateCompare with previous version
added 1 commit
45d8d9d6- Fix timezone handling when creating documentationsCompare with previous version
added 1 commit
bf526ea2- Fix documentations not being displayed due to timezone mismatchCompare with previous version
added 1 commit
1ed0e73e- Exclude substituted lessons from coursebookCompare with previous version
added 1 commit
f9f6132f- Query for groupsByOwner & coursesOfTeacherCompare with previous version
added 1 commit
6b6cb08b- Add class & course navigation by selectionCompare with previous version
added 4 commits
895e12df- Translate coursebook540d1cfc- Show loading animation for topic autosave45dc727c- Hide soon-to-be-removed views in alsijil sidenava4f8bf26- Use correct title and icons in coursebook menu entryCompare with previous version
added 6 commits
0b8eb2f6- Fix "this.groups is undefined" error when loading coursebooka22de842- Set max-width of Documentation listd1a40932- Set coursebook to full width713bab14- Reformatf157ecc6- Improve look of coursebook on desktop7fea2376- Make lesson info center alignedCompare with previous version
added 3 commits
3bd8a7e6- Make group selector same style as search input27dfe0e3- Limit chips vertical space8d0ec93b- Create dummy chips in lesson notes componentCompare with previous version
added 1 commit
afa83852- Show laoding animation in main coursebook viewCompare with previous version
Accessing the coursebook shows results in an error and, after a few failed GraphQL requests, „No data available“. When I select a group, it works fine.
added 1 commit
Compare with previous version
fixed
added 1 commit
9ff315e4- Introduce new URL scheme with my/all filteringCompare with previous version
resolved all threads
added 1 commit
ccca2693- Bump version of KolegoCompare with previous version
FIXME: Clearing Documentation-related fields is not possible
added 1 commit
1032b51c- Add translations to group/course selectCompare with previous version
added 1 commit
24a7b80a- Add placeholder text for group/course filterCompare with previous version
added 1 commit
48e0db78- Fix permission checkingCompare with previous version
added 1 commit
46efd6aa- Display loader and messages for empty coursebook correctly using slots of crud-iteratorCompare with previous version
added 2 commits
Compare with previous version
added 1 commit
c9048240- Add missing translationCompare with previous version
added 1 commit
d0cf2cd1- Specify icons to show when menu items are activeCompare with previous version
added 1 commit
f47212f8- Use canEdit in coursebook frontendCompare with previous version
@ZugBahnHof fixes URL scheme (only one date instead of start/end)
@yuha fixes mismatch between displayed groups/courses appliable as filter & actually displayed documentations (due to courses/groups the user is only member but not owner of not being available as filter options)
@yuha makes documentations where user is assigned as teacher available in coursebook frontend
@ZugBahnHof @yuha will check if canEdit logic also works backend-wise (probably not) and, if necessary, fix that
added 7 commits
54708b5d- Replace $attrs with a prop13c28933- Extract coursebook skeleton loader into separate component1c632786- Reformat06ad4e15- Extract coursebook errors into different component6b078b3c- Move coursebook to different directory87ab3b70- Fix oversights6bc7feaf- Create date select for coursebookCompare with previous version
that works, indeed
now: need to check whether permissions are matched with other occurences (as described above) @yuha
added 2 commits
e25acd73- Fix permissionsc605d3ab- ReformatCompare with previous version
TODO: When the user is not allowed to edit a documentation, there should a. probably be no text edit fields at all (and the contents of the documentation should simply be displayed as text) and b. the DialogObjectForm should at least not have the save/cancel buttons.
Yes, definitely.
done; requires these MRs to be merged @hansegucker
https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/30
https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1427
https://edugit.org/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/335
added 2 commits
c9892b7a- Change queries for group/course selection in coursebook184dedb9- Fix predicateCompare with previous version
added 5 commits
1af2a4c7- Replace datestart and dateEnd url params from coursebook with singular date paramda1e774f- Emit events in CoursebookDateSelect.vueba41a790- Load new documentations and scroll to selected date80358342- Merge remote-tracking branch 'origin/256-add-simple-course-book-list' into...11892d1f- ReformatCompare with previous version
added 1 commit
1637ed66- Allow focusing inputs outside the bottomsheetCompare with previous version
this, obviously, requires
teachersto be added as a field in the data modelchanged the description
changed the description
changed the description
changed the description
@permcu fixes this
@hansegucker i was told you still have something to say about this...?
TODO: Make sure substitution lessons appear in coursebook (following the permission structure outline further down this MR) and mark them in some special way
Yeah, I wonder whether you have fixed the usage of courses (as groups and teachers are synced to the lesson event).
added 3 commits
ccd576da- Move `compact` and `documentation` props into separate mixinf4017258- Use activator for dialog at the correct placea421e416- Stack lesson times in compact mode like in the mockupCompare with previous version
marked the checklist item Uhrzeit so wie im Mockup as completed
marked the checklist item datum braucht Wochentag as completed
marked the checklist item datum gleiche einrückung wie das datum as completed
marked the checklist item datum sollte überschrift sein und prominenter gestaltet as completed
marked the checklist item Remove outer card as completed
marked the checklist item fach und subject strukturierter nebeneinander as completed
marked the checklist item mittlere spalte linksaligned as completed
added 9 commits
650d6baa- Disable elevation of curditerator in the coursebook07350bcf- Display weekday of days in coursebookae58a4e2- Increase fontsize of datesfc60b22f- Decrease Homework and Groupnote Chip size5eae0311- Use card-title for dialog title1d712d4b- Fix positioning of lesson-* elements in documentationbd1bc345- Set minWidth of topic dynamically69146424- Fix mobile design of coursebook5a7206de- Decrease spacing on coursebook pageCompare with previous version
added 1 commit
b4c3648d- Change evaluation order in coursebook predicatesCompare with previous version
PERMISSION/RULES LOGIC OVERVIEW:
Persons can edit documentations if:
LessonEventlinked to theDocumentationCourselinked to the aforementionedLessonEventCourselinked to theDocumentationDocumentationitselfGroupslinked to the respectiveLessonEventGroupslinked to thoseGroupsAdditionally, they can view (but not edit) documentations if:
Groupslinked to the respectiveLessonEventOwnership of
GroupsofCourseslinked theDocumentation'sLessonEventis checked since theseGroupsare synced with those of theLessonEventand this can't be changed anywhere (afaik).Following that logic, only
GroupsandCourseswill be displayed in the filter select that fit any of the mentioned conditions.please comment down here if any of you think that something in there doesn't make sense
MY/ALL DOCUMENTATIONS LOGIC OVERVIEW:
It is possible to switch, regardless of the group/course filter currently applied, between two filter settings: "Only show own lessons" and "All lessons" (which is set when the "Only show own lessons" switch is off).
"Only show own lessons" only shows the documentations of a subset of all lessons the user is allowed to view or edit: Only lessons where the user's
Personis assigned as a teacher or those where it is a member of any of the lesson'sGroupsare shown. In a standard school setting, this would mean that only lessons that are actually teached by oneself or that one participates in are displayed. This also includes all lessons that act as substitution lessons to lessons matching the criteria set out above (that is, that are amending those lessons), even though the substitutions lessons are teached by someone else, for example."All lessons" shows the documentations of all lessons the user is allowed to view or edit. This extends the aforementioned subset to include lessons where the user's
Personis amongst any of the linkedGroup's (or their respective parent groups') owners.…which was done now
i see – at least the MRs mentioned above have nothing to do with this anymore. As you can see in the permission overview comment further down this MR, permissions are indeed checked based on both Courses and LessonEvents – which (when checking whether a person is assigned as a teacher to a documentation) gets relevant in substitution lesson cases. Furthermore, it is at least possible to change the teachers of individual LessonEvents in Lesrooster (for some reason I don't know)... What does make sense though is to remove the checks for group ownership on course groups since those are indeed synced and can't be changed anywhere afaik
added 3 commits
1792cf1f- Add teachers field to documentationeced46b8- Add color and show in coursebook fields to ExtraMarkb0c3eda1- Merge branch '246-roadmap-migrate-to-new-data-model' into 256-add-simple-course-book-listCompare with previous version
added 1 commit
b0a2e9b9- Drop checks for course group owner-/membership in predicatesCompare with previous version
see: https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/350/diffs?commit_id=b0a2e9b9d02c155f5b22f966a62d94ac4d4aa99b
changed in https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/350/diffs?commit_id=b0a2e9b9d02c155f5b22f966a62d94ac4d4aa99b
This is probably needed when the substitution-related MRs in Chronos are merged – as of now, substitution lessons don't break the coursebook, at least.
added 1 commit
7b227d8d- Fix add documentation ruleCompare with previous version
FIXME: In some cases, the
LessonEventreference object of documentations don't contain a subjectadded 1 commit
3456254a- Use correct graphene types for subject and course of documentationCompare with previous version
added 3 commits
b86959aa- Set coursebook text fields to readonly instead of disabled78e9fbea- Reflect canEdit in documentation modal's buttons9d566f5f- Finish lesson summary truncate via cssCompare with previous version
added 2 commits
00b2ced4- Remove loading state handing2e589ca5- Enable emptying of documentation fieldsCompare with previous version
Done
Some thoughts:
The access rights for substitutions therefore shouldn't depend on courses, but on the amended lesson event.
I am not sure whether those queries belong into Cursus and Core, as they seem to include very specific logic. Wouldn't this be a case for Alsijil-specific queries?
probably yes
that does make sense, thanks for the comment
added 1 commit
b125af74- Unify spacing of LessonInformationCompare with previous version
changed the description
@ZugBahnHof does this in frontend
changed the description
changed the description
added 1 commit
adf8d2f2- Add filtered queries for groups & coursesCompare with previous version
did that & closed the MRs in cursus & core
problem: m2m relation to teachers cannot be added to dummy models without saving them – any ideas?
TODO: Test view with a substitution, a cancelled event, and a longer event (like 5 hours) with lessons inbetween.
TODO: Show teachers in class register
FIX: Drop pagination at bottom
FIXME: No input fields when read-only, just show the information
TO DISCUSS: Two buttons (homework and group note) opening the same dialog is confusing. Idea from @fph: Box with edit button like in the absences mockup
TODO: Prevent entering content for events in the future (at least configurable) Maybe also a mode where entering is allowed for today
See https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/issues/268 for this
we'll have a look how that looks
add preference & add check for that in canEdit & when dummy documentations are generated
what do you mean with a "longer event"? something like flexibel events (like a wandertag) that should be documented?
related to substitutions/cancelled events (i guess you mean cancelled lessons with that since these are afaik the only events that can be cancelled?) see https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/350#note_88497
FIXME: Make time period aligned to the right
FIXME: Make time period break in a nicer way here:
@ZugBahnHof thinks (very hard) about possible solutions (probably also outside the box)
changed the description
we already discussed how this could look like – but requires https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/350#note_87839 to be finished in order to deliver related teachers to frontend
@ZugBahnHof ?
Yes
We are always talking about LessonEvents (they can be longer than one hour).
changed the description
added 1 commit
77b5d4c6- Make times right alignedCompare with previous version
marked the checklist item Rechtsbuendig @ZugBahnHof as completed
added 3 commits
98647a7f- Add teachers to DocumentationType17e8450c- Make subject and teachers editable in backend8404be14- Include teachers in coursebookCompare with previous version
yes, fixed it
added 1 commit
f2f9d3f8- Use teachers from lesson events instead of from coursesCompare with previous version
@yuha and I are hardly thinking
added 2 commits
b8c9cce2- Add dummy edit button chip to LessonNotes2a97ee0b- Remove edit icon from subject chipCompare with previous version
added 1 commit
1fcc0d63- Open documentation dialog when clicking on teachers or subjectsCompare with previous version
added 2 commits
98edc9da- Make text fields for homework & group note more compact & clearablecaf7962b- Merge branch '256-add-simple-course-book-list' of...Compare with previous version
added 2 commits
ad5ce20d- Hide footer of cruditerator in coursebookb5f937b8- Merge remote-tracking branch 'origin/256-add-simple-course-book-list' into...Compare with previous version
added 1 commit
284b0d76- Load avatarContentUrl for teachersCompare with previous version
added 1 commit
666cc8e2- Use footer instead of bottom sheet for date selectCompare with previous version
marked the checklist item Bottom sheet for date select should not be full width of screen (@yuha ) as completed
changed the description
changed the description
FIXME: Search should also respect subjects, teachers, course names etc.
~"source::customer::kath"
FIXME: Add filter for missing data (empty topic)
Attention: Cancelled lessons with empty topics are no missing data.
~"source::customer::kath"
TODO: Check that lessons without a course and without any groups are shown in the respective teacher class registers.
~"source::customer::kath"
FIXME: Rename occurrences of "Class" to "Group"
added 1 commit
2c860ab0- Use correct z-index on coursebook date select footerCompare with previous version
added 7 commits
d0df6b63- Use teachers correctly4d284cd7- Use css grid for main documentation layout40e2c278- Remove superfluous padding in LessonInformationa8b76416- Combine homework and groupnote chips to singular cardbd9c2996- Refine LessonSummary layout using css gridc87b4855- Use outlined field for topica9b38674- Merge remote-tracking branch 'origin/256-add-simple-course-book-list' into...Compare with previous version
added 2 commits
377293fe- Fix documentation style in dialogfb044393- Change width of topic fieldCompare with previous version
changed the description
we thought hard and we have a result. closing now
added 2 commits
cb2fae58- Add status icon for documentations9f345140- Merge branch '256-add-simple-course-book-list' of...Compare with previous version
added 1 commit
150f199c- Move documentation-status from documentation to LessonInformationCompare with previous version
added 1 commit
f1a89360- Add success/error indicator for topic fieldCompare with previous version
added 1 commit
23123c71- Change documentation status icon available conditionCompare with previous version
FIXME: Status icon does not update properly when creating new doc from dummy (only after first save of "real" doc)
marked the checklist item Indikator ob Stundenthema richtig gespeichert wurde (@yuha ) as completed
marked the checklist item when hovering over icon & success: show some fancy success message as completed
marked the checklist item when hovering over icon & error: show error message as completed
marked the checklist item Statusicon am Anfang der Zeile fehlt (#63 explains the different stati) as completed
marked the checklist item when hovering over icon & success: show some fancy success message as incomplete
marked the checklist item when hovering over icon & error: show error message as incomplete
FIXME: Doc status icon does not update automatically when page is open & lesson is over
FIXME: Sometimes, the topic indicator icon does not show (first save after creation of "real" doc from dummy doc)
marked the checklist item Kasten nicht höher als input-feld as completed
will be resolved in separate issue: https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/issues/63
will be resolved in separate issue: https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/issues/63
added 2 commits
46baa955- Make allowing future coursebook entries configurablef6ff4bfd- ReformatCompare with previous version
TODO: When disabled & empty, the documentation topic field is still confusing:
.
@ZugBahnHof any ideas? should we just do https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/350#note_88723
@ZugBahnHof could you please have a look at this? I have no clue how the search works.
added 1 commit
3726d8a6- Replace "(school) class" with "group"Compare with previous version
changed the description
since that is merged now, handling of substitutions will be solved with regard to the other threads containing relevant stuff
strike through lesson-related data (teachers, subject etc) when substitutions replace that data
weird stuff is happening when changing lessonevents (?)
TODO: timezones are weird
second toggle beneath "own lesson" one
added 1 commit
0034ff71- Replace "(school) class" with "group"Compare with previous version
added 1 commit
461c8375- Fix oldId handlingCompare with previous version
marked the checklist item Kursnamen irgendwie hervorheben as completed
added 1 commit
00038961- Add watcher for documentation in status iconCompare with previous version
added 1 commit
623bca5e- Also set status timeout when lesson has already started but is not yet finishedCompare with previous version
added 1 commit
546bcab7- Fix timezone handlingCompare with previous version
added 4 commits
3726d8a6- Replace "(school) class" with "group"fa4f0cc9- Merge branch '256-add-simple-course-book-list' of...32467ea7- Show readonly information with own components, add matching notices for future/empty documentations18ec1a4f- Merge branch '256-add-simple-course-book-list' of...Compare with previous version
@hansegucker did some work
added 2 commits
72480a2e- Add check for allowed time range preference when creating docs from dummyb07a4284- ReformatCompare with previous version
may be fixed now; will be checked
added 7 commits
6ed3df3b- Disable pagination for coursebook892174ab- Remove filter to include only not amended lessonsa25ea04a- Fix logic in status iconec50cb19- Reformat and lint27d9b58d- Add filter for incomplete documentations6bdc3f34- Fix query for documentations to include information about cancelled lessonsb4f47ecf- Merge branch '256-add-simple-course-book-list' of...Compare with previous version
that is indeed fixed
added 2 commits
c035f05e- Drop unused mutations due to security reasonsac8b93d7- Use reversion for coursebook entriesCompare with previous version
marked the checklist item verify that changes are being tracked using revisions (using a mixin in core creating revisions when mutating) (blocked by https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1433) as completed
added 2 commits
5202a41f- Move subject chip5bf85bf3- Merge remote-tracking branch 'origin/256-add-simple-course-book-list' into...Compare with previous version
With all permissions, you should respect the teachers attribute of the lesson documentation.
Shouldn't this be checked by the rule?
I think this would deserve a separate component.
This shouldn't depend on the course.
This shouldn't depend on the course.
What type is doc.teachers? Probably it needs to be done like below (with Person query).
Wrong permission
Wrong permission
Nice
It's probably a bad ID to use such a generic name for an ID, please use classes instead (also for date-select-footer).
Is there are more beautiful way to do this?
This probably should move to a separate component
TODO
TODO
TODO
Also, someone please write a nice piece of changelog.
assigned to @hansegucker and unassigned @yuha
added 1 commit
a5dd17ea- Use deep search in coursebookCompare with previous version
added 1 commit
60a6fe08- Fix lint in coursebookCompare with previous version
added 2 commits
b2f54874- Add proper handling of documentations of substitution lessons1f635175- Merge branch '256-add-simple-course-book-list' of...Compare with previous version
Handling of documentations of substitution lessons fixed now too
@ZugBahnHof fixed that; needs https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1445/diffs
should this become a generic component for displaying time values (resulting in this generic component being used twice here) or in a component including both the start and end times? We don't consider this particularly useful or urgent.
m2mfield.add does not take a queryset but only an arbitrary amount of arguments (objects) so that using a queryset isn't an option (see https://docs.djangoproject.com/en/5.0/topics/db/examples/many_to_many/)
makes sense, also change
date-select-footerto something slightly less generic@permcu will have a look bus isn't sure whether there is a more beautiful way
ok
@permcu does that
changed this line in version 95 of the diff
added 1 commit
9ac059b9- Remove deprecated todoCompare with previous version
will be solved with new loading mechanism
will be solved with new loading mechanism
@yuha
@yuha
@yuha
@yuha
@yuha
@yuha
"but on the amended lesson event." do you mean the lesson event the documentation is referring to (the one amending another lesson event) or the one amended by this lesson event (the original lesson event)? Only the first option makes sense to me. Apart from that, in case the substitution lesson event lacks teachers (e.g. when only the room is changed), permission checks should still be done on the original lesson event amended, of course.
added 1 commit
d9b6daad- Add check if person is documentation teacher in relevant predicatesCompare with previous version
That would be really nice, but unfortunately what we've got at the point the code runs is a. the LessonEvent the Documentation will refer to + the concrete start & end DateTimes parsed from the dummy id. Since that's all in the creation part of the mutation, no check of documentation-related rules (which contain a check for that preference, see edit part of mutation) is possible.
changed this line in version 97 of the diff
changed this line in version 97 of the diff
added 1 commit
286e031c- Remove some unneccesary checks for teacher status in coursesCompare with previous version
Yeah, well, I can live with this.
@permcu could you have a look? if not, i'll do that on wednesday
@hansegucker
Both the original teachers and the substitution teachers should have access, so
documentation.teachersshould be filled with the substitution teachers, sodocumentation.lesson_event.amends.teachershas to used for the original teachers, I think.changed this line in version 98 of the diff
changed this line in version 98 of the diff
added 3 commits
ce49fbab- Fix predicate5675ce4f- Add coursebook menu rulee37d01ac- ReformatCompare with previous version
@yuha checks again if that is the case
this is already the case due to
all_teachersbeing usedchanged this line in version 99 of the diff
added 1 commit
d4e65e0d- Use css classes for date select footerCompare with previous version
added 1 commit
Compare with previous version
added 1 commit
12696dc9- Fix coursebook layoutCompare with previous version
added 1 commit
e5a19a94- Add tooltip for topic status iconCompare with previous version
added 1 commit
Compare with previous version
added 1 commit
03696fee- ReformatCompare with previous version
marked the checklist item when hovering over icon & success: show some fancy success message as completed
marked the checklist item when hovering over icon & error: show error message as completed
added 1 commit
e7db0ebb- Remove unused legacy routesCompare with previous version
@yuha
@permcu could you please add some screenshots (since how the coursebook looks with your adjustments to the dynamic fetching system is probably how it will look like when finalised)?
added 1 commit
361bf85e- Add changelogCompare with previous version
the date select footer should probably be moved to AlekSIS-Core since it is useful as a generic component (e.g. for the substitution to do list feature)
added 1 commit
4eefca14- Adapt to moved date select footerCompare with previous version
requires https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1448
@permcu reminder
@permcu reminder
i'll do that
i'll do that
changed this line in version 108 of the diff
added 1 commit
97a01f46- Fix clearing of groupNote and homework fieldsCompare with previous version
changed this line in version 109 of the diff
added 1 commit
023dff50- Move coursebook filters in separate componentCompare with previous version
added 1 commit
0afb039c- ReformatCompare with previous version
added 1 commit
fdd16ddf- Fix lintCompare with previous version
make gap between days smaller
.
added 1 commit
2013968a- Make ParticipationStatus a CalendarEvent and clean up migrationsCompare with previous version
added 1 commit
ca799cae- Rename references on lesson_event to amendsCompare with previous version
added 2 commits
Compare with previous version
added 2 commits
27d8f0dd- Remove not working constraint43774a59- ReformatCompare with previous version
added 1 commit
5bc38ebe- Fix migration referencesCompare with previous version
added 1 commit
2d153af2- Fix field referencesCompare with previous version
mentioned in merge request !745
marked the checklist item Move search, group select, ... into an app bar (see also this) as completed
changed this line in version 118 of the diff
changed this line in version 118 of the diff
added 44 commits
706ea391- Move to internal currentDate state and update hash fragment on idle412e8e63- Move key for day into it's topmost elementb91f0c14- Do not trigger currentDate if last day is visible6ea5c885- Improve navigation logic3a28bb26- Introduce top-margin prop - document the magic number97a58a34- Introduce day-increment prop & increase days loaded at onceaf5d4954- Reduce debug printscc238ebf- Merge felix's changes from '256-add-simple-course-book-list'189bc40f- Reformatc03aa1f5- Merge branch 'rebased2-michael-scrollt' into '256-add-simple-course-book-list'Compare with previous version
added 3 commits
5a004719- Update changelog867c43dd- Update dependencies to include all required changesef02e0dc- Update translation filesCompare with previous version
marked this merge request as ready
resolved all threads
added 1 commit
bce32819- Remove access to old class registerCompare with previous version
mentioned in commit
0e5225db25changed the description