aleksis/AlekSIS-App-Alsijil
8
0
Fork 0
Code Issues 51 Pull requests 10 Projects Releases 3 Packages Activity Actions

Implement infinite scrolling and by date navigation for coursebook #745

Merged
permcu merged 43 commits from rebased2-michael-scrollt into 256-add-simple-course-book-list 2024-04-23 16:29:11 +02:00
Conversation 32 Commits 43 Files changed 4 +306 -117
permcu commented 2024-04-18 21:05:32 +02:00 (Migrated from edugit.org)
Copy link

This builds on top of https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/350

It is put in a separate merge request to hopefully allow for easier review.

Resolves: https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/issues/270

This builds on top of https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/350 It is put in a separate merge request to hopefully allow for easier review. Resolves: https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/issues/270
permcu commented 2024-04-18 21:07:04 +02:00 (Migrated from edugit.org)
Copy link

changed the description

changed the description
permcu commented 2024-04-18 21:07:04 +02:00 (Migrated from edugit.org)
Copy link

requested review from @hansegucker

requested review from @hansegucker
permcu commented 2024-04-18 21:07:04 +02:00 (Migrated from edugit.org)
Copy link

assigned to @permcu

assigned to @permcu
permcu commented 2024-04-18 21:07:20 +02:00 (Migrated from edugit.org)
Copy link

changed the description

changed the description
hansegucker (Migrated from edugit.org) changed target branch from master to 256-add-simple-course-book-list 2024-04-18 21:15:14 +02:00
permcu commented 2024-04-18 21:15:18 +02:00 (Migrated from edugit.org)
Copy link

mentioned in merge request AlekSIS-Core!1840

mentioned in merge request AlekSIS-Core!1840
hansegucker commented 2024-04-18 21:21:46 +02:00 (Migrated from edugit.org)
Copy link

Debug print

Debug print
hansegucker commented 2024-04-18 21:21:46 +02:00 (Migrated from edugit.org)
Copy link

Eh, yeah, no magic constants

Eh, yeah, no magic constants
hansegucker commented 2024-04-18 21:21:47 +02:00 (Migrated from edugit.org)
Copy link

No magic constants

No magic constants
hansegucker commented 2024-04-18 21:21:47 +02:00 (Migrated from edugit.org)
Copy link

TODO

TODO
hansegucker commented 2024-04-18 21:21:47 +02:00 (Migrated from edugit.org)
Copy link

TODO

TODO
hansegucker commented 2024-04-18 21:21:47 +02:00 (Migrated from edugit.org)
Copy link

Please clean up all those console prints and fix/remove todos.

Please clean up all those console prints and fix/remove todos.
permcu commented 2024-04-19 16:44:32 +02:00 (Migrated from edugit.org)
Copy link

We already had some lengthy discussion on how to get the values otherwise; but that lead nowhere. How would you suggest defining it? Its the height of the app-bar & the crud-bar & some xtra.

We already had some lengthy discussion on how to get the values otherwise; but that lead nowhere. How would you suggest defining it? Its the height of the app-bar & the crud-bar & some xtra.
permcu commented 2024-04-19 16:45:08 +02:00 (Migrated from edugit.org)
Copy link

Where else should they be defined? Prop maybe?

Where else should they be defined? Prop maybe?
permcu commented 2024-04-19 16:46:02 +02:00 (Migrated from edugit.org)
Copy link

I will. Right after I remove the remaining & rather pesky bugs ;)

I will. Right after I remove the remaining & rather pesky bugs ;)
permcu commented 2024-04-19 17:16:45 +02:00 (Migrated from edugit.org)
Copy link

changed title from Draft: Implemen infinite scrolling and by date navigation for coursebook to Draft: Implemen{+t+} infinite scrolling and by date navigation for coursebook

changed title from **Draft: Implemen infinite scrolling and by date navigation for coursebook** to **Draft: Implemen{+t+} infinite scrolling and by date navigation for coursebook**
hansegucker commented 2024-04-19 17:52:37 +02:00 (Migrated from edugit.org)
Copy link

I just would write a constant somewhere in the source code of this component.

I just would write a constant somewhere in the source code of this component.
permcu commented 2024-04-19 19:50:13 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/355/diffs?diff_id=42093&start_sha=706ea391f4b87251f74166e9fe779fafe0002c68#234f7a73ce2e850b15dc2bc3ac791fcfe8682f3b_125_144)
permcu commented 2024-04-19 19:50:13 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/355/diffs?diff_id=42093&start_sha=706ea391f4b87251f74166e9fe779fafe0002c68#234f7a73ce2e850b15dc2bc3ac791fcfe8682f3b_261_274)
permcu commented 2024-04-19 19:50:14 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/355/diffs?diff_id=42093&start_sha=706ea391f4b87251f74166e9fe779fafe0002c68#234f7a73ce2e850b15dc2bc3ac791fcfe8682f3b_289_300)
permcu commented 2024-04-19 19:50:14 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/355/diffs?diff_id=42093&start_sha=706ea391f4b87251f74166e9fe779fafe0002c68#234f7a73ce2e850b15dc2bc3ac791fcfe8682f3b_304_334)
permcu commented 2024-04-19 19:50:14 +02:00 (Migrated from edugit.org)
Copy link

added 6 commits

  • 412e8e63 - Move key for day into it's topmost element
  • b91f0c14 - Do not trigger currentDate if last day is visible
  • 6ea5c885 - Improve navigation logic
  • 3a28bb26 - Introduce top-margin prop - document the magic number
  • 1b5b27ed - Introduce day-increment prop & increase days loaded at once
  • a4865846 - Reduce debug prints

Compare with previous version

added 6 commits <ul><li>412e8e63 - Move key for day into it&#39;s topmost element</li><li>b91f0c14 - Do not trigger currentDate if last day is visible</li><li>6ea5c885 - Improve navigation logic</li><li>3a28bb26 - Introduce top-margin prop - document the magic number</li><li>1b5b27ed - Introduce day-increment prop &amp; increase days loaded at once</li><li>a4865846 - Reduce debug prints</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/355/diffs?diff_id=42093&start_sha=706ea391f4b87251f74166e9fe779fafe0002c68)
permcu commented 2024-04-19 19:53:39 +02:00 (Migrated from edugit.org)
Copy link

I removed some of them. But I want to keep some until we are certain this works properly.

I removed some of them. But I want to keep some until we are certain this works properly.
permcu commented 2024-04-19 19:56:30 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 174f7463 - Introduce day-increment prop & increase days loaded at once
  • 01a019b5 - Reduce debug prints

Compare with previous version

added 2 commits <ul><li>174f7463 - Introduce day-increment prop &amp; increase days loaded at once</li><li>01a019b5 - Reduce debug prints</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/355/diffs?diff_id=42095&start_sha=a48658465b747b309d6ccf0cfd0c02fac56b5f56)
permcu commented 2024-04-19 20:11:28 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 97a58a34 - Introduce day-increment prop & increase days loaded at once
  • af5d4954 - Reduce debug prints

Compare with previous version

added 2 commits <ul><li>97a58a34 - Introduce day-increment prop &amp; increase days loaded at once</li><li>af5d4954 - Reduce debug prints</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/355/diffs?diff_id=42097&start_sha=01a019b5283b40a039bcddae18b47e7772ded481)
permcu commented 2024-04-22 17:44:55 +02:00 (Migrated from edugit.org)
Copy link

added 7 commits

  • af5d4954...2d153af2 - 6 commits from branch 256-add-simple-course-book-list
  • cc238ebf - Merge felix's changes from '256-add-simple-course-book-list'

Compare with previous version

added 7 commits <ul><li>af5d4954...2d153af2 - 6 commits from branch <code>256-add-simple-course-book-list</code></li><li>cc238ebf - Merge felix&#39;s changes from &#39;256-add-simple-course-book-list&#39;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/355/diffs?diff_id=42165&start_sha=af5d4954088b17186792d2cb713441249c4f4c4b)
permcu commented 2024-04-22 18:12:19 +02:00 (Migrated from edugit.org)
Copy link

changed the description

changed the description
hansegucker commented 2024-04-23 16:17:52 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2024-04-23 16:17:55 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2024-04-23 16:27:16 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/355/diffs?diff_id=42241&start_sha=cc238ebfa11eeaa9aed9fceb8e65773311c7f737#234f7a73ce2e850b15dc2bc3ac791fcfe8682f3b_284_279)
hansegucker commented 2024-04-23 16:27:17 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>189bc40f - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/355/diffs?diff_id=42241&start_sha=cc238ebfa11eeaa9aed9fceb8e65773311c7f737)
hansegucker commented 2024-04-23 16:29:10 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit c03aa1f54d

mentioned in commit c03aa1f54dc6e9b021193fc16075f8185300b1b7
hansegucker (Migrated from edugit.org) merged commit c03aa1f54d into 256-add-simple-course-book-list 2024-04-23 16:29:11 +02:00
nik commented 2026-02-18 12:50:01 +01:00 (Migrated from edugit.org)
Copy link

unassigned @permcu

unassigned @permcu
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Alsijil!745
No description provided.