Resolve "Check permission rules if they handle lessons with substitutions correctly" #548

Merged

hansegucker merged 3 commits from 147-check-permission-rules-if-they-handle-lessons-with-substitutions-correctly into master

2021-03-11 12:01:21 +01:00

hansegucker commented

2021-03-10 19:39:58 +01:00

(Migrated from edugit.org)

Closes #147

get_teachers will return the following:

simply the teachers for events and extra lessons
the original teachers for lesson periods without substitution, otherwise the new teacher

So, we have to check the teachers of lesson periods additionally to keep the access for the original teacher.

Closes #147 `get_teachers` will return the following: - simply the teachers for events and extra lessons - the original teachers for lesson periods without substitution, otherwise the new teacher So, we have to check the teachers of lesson periods additionally to keep the access for the original teacher.

hansegucker commented

2021-03-10 19:42:35 +01:00

(Migrated from edugit.org)

added 1 commit

c2e98047 - Fix predicates for lesson teachers to check both original teachers and substitution teachers

Compare with previous version

added 1 commit <ul><li>c2e98047 - Fix predicates for lesson teachers to check both original teachers and substitution teachers</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/158/diffs?diff_id=5419&start_sha=d142255ae19fcd6db80d5d657964bc9d707c98de)

hansegucker commented

2021-03-10 19:42:39 +01:00

(Migrated from edugit.org)

assigned to @nik and unassigned @hansegucker

hansegucker commented

2021-03-10 19:44:25 +01:00

(Migrated from edugit.org)

changed the description

hansegucker commented

2021-03-10 19:44:32 +01:00

(Migrated from edugit.org)

marked this merge request as ready

marked this merge request as **ready**

nik commented

2021-03-11 00:20:28 +01:00

(Migrated from edugit.org)

marked this merge request as draft

marked this merge request as **draft**

nik commented

2021-03-11 00:25:21 +01:00

(Migrated from edugit.org)

marked this merge request as ready

marked this merge request as **ready**

hansegucker commented

2021-03-11 10:35:05 +01:00

(Migrated from edugit.org)

added 1 commit

7c0a44c8 - Ensure that original teachers only can view substituted lessons

Compare with previous version

added 1 commit <ul><li>7c0a44c8 - Ensure that original teachers only can view substituted lessons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/158/diffs?diff_id=5466&start_sha=c2e98047ca006d30bf1111dba215651a4763f186)

hansegucker commented

2021-03-11 10:35:40 +01:00

(Migrated from edugit.org)

@nik Please check again.

hansegucker commented

2021-03-11 11:57:30 +01:00

(Migrated from edugit.org)

added 1 commit

8f133168 - Add preference for allowing original teachers to edit their substituted lessons

Compare with previous version

added 1 commit <ul><li>8f133168 - Add preference for allowing original teachers to edit their substituted lessons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/158/diffs?diff_id=5474&start_sha=7c0a44c836aaa57f00d5d9934f50a07b41a1e64e)