Check permission rules if they handle lessons with substitutions correctly

hansegucker commented

2021-03-10 17:16:06 +01:00

(Migrated from edugit.org)

Currently, original teachers don't get access to their lessons if there are substitutions assigned to this lesson. This has to be fixed and we should check if there any similar issues.

hansegucker commented

2021-03-10 19:40:04 +01:00

(Migrated from edugit.org)

created merge request !548 to address this issue

hansegucker commented

2021-03-10 19:40:04 +01:00

(Migrated from edugit.org)

mentioned in merge request !548

nik commented

2021-03-11 00:20:12 +01:00

(Migrated from edugit.org)

When drafting the access model in Alsijil, compeltely transferring the complete teacher role to a substitution teacher was intentional because only one teacher should be able to author notes for a lesson at any given time.

If this is to be changed, it needs to be discussed.

When drafting the access model in Alsijil, compeltely transferring the complete teacher role to a substitution teacher was intentional because only one teacher should be able to author notes for a lesson at any given time. If this is to be changed, it needs to be discussed.

hansegucker commented

2021-03-11 10:09:46 +01:00

(Migrated from edugit.org)

Yes, you're right. But the original teacher should be able to view the notes for the lesson at least. I will check that again.

Yes, you're right. But the original teacher should be able to **view** the notes for the lesson at least. I will check that again.

nik commented

2021-03-11 10:35:52 +01:00

(Migrated from edugit.org)

Then again, we already depart from that, because nowadays lessons can have more than one teacher. Thus, we should probably treat substitutions the same as co-teaching…

hansegucker commented

2021-03-11 10:36:56 +01:00

(Migrated from edugit.org)

Then I can remove the last commit?

nik commented

2021-03-11 10:38:57 +01:00

(Migrated from edugit.org)

First, you should provide argumentation. If you support my first position, or maybe the option to make the lesson read-only for the regular teacher, please document why. (Same for all other options; we should not make changes because someone says it might be a good idea without reasoning).

hansegucker commented

2021-03-11 10:42:29 +01:00

(Migrated from edugit.org)

I think we should make the lesson writable for the original and the substitution teacher because of the following points:

We already have to deal with the option that there can be more than one teacher which is able to edit a lesson documentation.
The risk that the original teacher manipulates the data inserted by the substitution teacher is minimal.
The original teacher should be able to edit personal notes afterwards to correct them if necessary (i. e. through student input).

I think we should make the lesson writable for the original and the substitution teacher because of the following points: - We already have to deal with the option that there can be more than one teacher which is able to edit a lesson documentation. - The risk that the original teacher manipulates the data inserted by the substitution teacher is minimal. - The original teacher should be able to edit personal notes afterwards to correct them if necessary (i. e. through student input).

nik commented

2021-03-11 10:46:39 +01:00

(Migrated from edugit.org)

Do we have a mechanism to notify the original author of a lesson documentation if it is changed by someone else afterwards?

hansegucker commented

2021-03-11 10:53:25 +01:00

(Migrated from edugit.org)

In addition to the change history, nothing.

nik commented

2021-03-11 10:59:57 +01:00

(Migrated from edugit.org)

Please open an issue to implement that, then, and link it as follow-up issue in your MR.