aleksis/AlekSIS-Core
Watch
8
0
Fork
You've already forked AlekSIS-Core
 0
Code Issues 206 Pull requests 61 Projects Releases 14 Packages 1 Wiki Activity Actions

Ask whether to remember session #4041

Merged
nik merged 2 commits from 4040-session-not-remembered into master 2026-10-26 21:19:28 +01:00
Conversation 2 Commits 2 Files changed 2 +2 -1
magicfelix commented 2026-10-25 13:23:56 +01:00
Member
Copy link

Closes #4040

Information and screenshots

Not really tested, I didn't wait for the session to be forgotten. But login worked – with and without the checkbox ticked.

Screenshot_20261025_132149

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

Closes #4040 ## Information and screenshots Not really tested, I didn't wait for the session to be forgotten. But login worked – with and without the checkbox ticked. ![Screenshot_20261025_132149](/attachments/fc53277f-4255-4cbe-a284-6b260130ae1c) ## Checklist - [ ] `tox -e reformat,lint` used - [x] Changelog updated/No update necessary - [ ] Documentation (incl. Screenshots) up-to-date - [ ] Copyright in `apps.py` and `README.rst` up-to-date - [ ] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [ ] Adhere to [URL scheme](https://code.teckids.org/aleksis/aleksis/issues/86) - [ ] Tested with admin account - [ ] Tested with normal account (based on permissions) ## Backend checklist - [ ] Use permissions for all GraphQL mutations - [ ] Use query optimizer for all GraphQL queries - [ ] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [ ] Screenshots are attached (mobile and desktop) - [ ] Tested on mobile, tablet, and desktop sizes - [ ] Adhered to [frontend guidelines](hhttps://code.teckids.org/aleksis/AlekSIS/src/branch/master/project/frontend_guidelines.rst) - [ ] Checked with [Firefox Accessibility Checker](https://firefox-source-docs.mozilla.org/devtools-user/accessibility_inspector/)
Screenshot_20261025_132149.png
29 KiB
Ask whether to remember session
All checks were successful
CI / lock (push) Successful in 31s
Details
CI / lint (push) Successful in 1m16s
Details
CI / build (push) Successful in 1m18s
Details
CI / test (push) Successful in 3m40s
Details
CI / tests-done (push) Successful in 2s
Details
CI / publish (push) Successful in 11s
Details
6109540af1 
Closes #4040
nik commented 2026-10-25 13:34:06 +01:00
Owner
Copy link

How is this asked? Is it a separate step, or a checkbox on the regular login form?

How is this asked? Is it a separate step, or a checkbox on the regular login form?
hansegucker commented 2026-10-25 18:03:08 +01:00
Owner
Copy link

@nik wrote in #4041 (comment):

How is this asked? Is it a separate step, or a checkbox on the regular login form?

A checkbox in the regular login form

@nik wrote in https://code.teckids.org/aleksis/AlekSIS-Core/pulls/4041#issuecomment-120444: > How is this asked? Is it a separate step, or a checkbox on the regular login form? A checkbox in the regular login form
Make "remember me" configurable
Some checks failed
CI / lock (push) Successful in 44s
Details
CI / test (push) Failing after 1m10s
Details
CI / lint (push) Successful in 1m32s
Details
CI / build (push) Successful in 1m36s
Details
CI / tests-done (push) Failing after 2s
Details
CI / publish (push) Has been skipped
Details
a2457ad577
nik merged commit ccd4146c68 into master 2026-10-26 21:19:28 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-Core!4041
No description provided.