Resolve "No current school term notification always present if not logged in" #3930

Merged
Member

Information and screenshots

No further information have been provided.

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

Closes #1626

## Information and screenshots No further information have been provided. ## Checklist - [x] `tox -e reformat,lint` used - [x] Changelog updated/No update necessary - [ ] Documentation (incl. Screenshots) up-to-date - [ ] Copyright in `apps.py` and `README.rst` up-to-date - [ ] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [ ] Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86) - [ ] Tested with admin account - [ ] Tested with normal account (based on permissions) ## Backend checklist - [ ] Use permissions for all GraphQL mutations - [ ] Use query optimizer for all GraphQL queries - [ ] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [ ] Screenshots are attached (mobile and desktop) - [ ] Tested on mobile, tablet, and desktop sizes - [ ] Adhered to [frontend guidelines](https://edugit.org/AlekSIS/official/AlekSIS/-/blob/master/project/frontend_guidelines.rst?ref_type=heads) - [ ] Checked with [Firefox Accessibility Checker](https://firefox-source-docs.mozilla.org/devtools-user/accessibility_inspector/) Closes #1626
Author
Member

added 2 commits

  • a61ed965 - Move active schoolterm to the appstore
  • 21c02083 - Fix loading handling for active school term

Compare with previous version

added 2 commits <ul><li>a61ed965 - Move active schoolterm to the appstore</li><li>21c02083 - Fix loading handling for active school term</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2285/diffs?diff_id=144876&start_sha=4281f6fb02472f3bdc1153468b77849d107719c7)
Author
Member

added 1 commit

  • 02ea7c10 - Write changelog for schoolterm banner fix

Compare with previous version

added 1 commit <ul><li>02ea7c10 - Write changelog for schoolterm banner fix</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2285/diffs?diff_id=144879&start_sha=21c0208396a7b30f11fdae72d13e28e94b7fe608)
Author
Member

marked the checklist item tox -e reformat,lint used as completed

marked the checklist item **tox \-e reformat,lint used** as completed
Author
Member

marked the checklist item Changelog updated/No update necessary as completed

marked the checklist item **Changelog updated/No update necessary** as completed
Author
Member

marked this merge request as ready

marked this merge request as **ready**
Author
Member

assigned to @hansegucker

assigned to @hansegucker
Owner

mentioned in commit e324d51d5b

mentioned in commit e324d51d5ba426e880ae30ea3c496adb3c297550
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-Core!3930
No description provided.