aleksis/AlekSIS-Core

Watch

Fork 0

Resolve "Adding persons to groups should allow multiple persons" #3899

Merged

hansegucker merged 10 commits from 1557-adding-persons-to-groups-should-allow-multiple-persons into master

2026-06-08 21:15:45 +02:00

leuckeju commented

2026-05-07 19:26:19 +02:00

Member

Information and screenshots

No further information have been provided.

Checklist

tox -e reformat,lint used
Changelog updated/No update necessary
Documentation (incl. Screenshots) up-to-date
Copyright in apps.py and README.rst up-to-date
(Unit) tests for new feature/regression tests for bug fixes (only if useful)
Adhere to URL scheme
Tested with admin account
Tested with normal account (based on permissions)

Backend checklist

Use permissions for all GraphQL mutations
Use query optimizer for all GraphQL queries
Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

Screenshots are attached (mobile and desktop)
Tested on mobile, tablet, and desktop sizes
Adhered to frontend guidelines
Checked with Firefox Accessibility Checker

Closes #1557

## Information and screenshots No further information have been provided. ## Checklist - [x] `tox -e reformat,lint` used - [x] Changelog updated/No update necessary - [ ] Documentation (incl. Screenshots) up-to-date - [ ] Copyright in `apps.py` and `README.rst` up-to-date - [ ] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [ ] Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86) - [ ] Tested with admin account - [ ] Tested with normal account (based on permissions) ## Backend checklist - [ ] Use permissions for all GraphQL mutations - [ ] Use query optimizer for all GraphQL queries - [ ] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [x] Screenshots are attached (mobile and desktop) - [x] Tested on mobile, tablet, and desktop sizes - [x] Adhered to [frontend guidelines](https://edugit.org/AlekSIS/official/AlekSIS/-/blob/master/project/frontend_guidelines.rst?ref_type=heads) - [ ] Checked with [Firefox Accessibility Checker](https://firefox-source-docs.mozilla.org/devtools-user/accessibility_inspector/) Closes #1557

leuckeju commented

2026-05-10 14:10:34 +02:00

Author

Member

added 1 commit

d62cbd64 - Allow creating memberships for multiple persons at once

Compare with previous version

added 1 commit <ul><li>d62cbd64 - Allow creating memberships for multiple persons at once</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2254/diffs?diff_id=112717&start_sha=8e20c872ba2ca6ada32a73152403416d91cea4b0)

leuckeju commented

2026-05-13 11:49:23 +02:00

Author

Member

added 3 commits

a71043c0 - Disable editing person inside membership
645f0481 - Only show respective multi-fields on create
20b595b3 - Fix cache updating by forcing uniform structure

Compare with previous version

added 3 commits <ul><li>a71043c0 - Disable editing person inside membership</li><li>645f0481 - Only show respective multi-fields on create</li><li>20b595b3 - Fix cache updating by forcing uniform structure</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2254/diffs?diff_id=117388&start_sha=d62cbd6415e2a203e82cd22dbd203b38b5d9366e)

leuckeju commented

2026-05-13 11:54:09 +02:00

Author

Member

marked this merge request as ready

marked this merge request as **ready**

leuckeju commented

2026-05-13 11:54:13 +02:00

Author

Member

marked the checklist item tox -e reformat,lint used as completed

marked the checklist item **tox \-e reformat,lint used** as completed

leuckeju commented

2026-05-13 11:54:15 +02:00

Author

Member

marked the checklist item Changelog updated/No update necessary as completed

marked the checklist item **Changelog updated/No update necessary** as completed

leuckeju commented

2026-05-13 12:01:21 +02:00

Author

Member

added 9 commits

20b595b3...12570820 - 4 commits from branch master
b054873a - Allow creating memberships for multiple persons at once
967ae53d - Disable editing person inside membership
e413c19a - Only show respective multi-fields on create
65457103 - Fix cache updating by forcing uniform structure
85e77989 - Write changelog for batch creation of group memberships

Compare with previous version

added 9 commits <ul><li>20b595b3...12570820 - 4 commits from branch <code>master</code></li><li>b054873a - Allow creating memberships for multiple persons at once</li><li>967ae53d - Disable editing person inside membership</li><li>e413c19a - Only show respective multi-fields on create</li><li>65457103 - Fix cache updating by forcing uniform structure</li><li>85e77989 - Write changelog for batch creation of group memberships</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2254/diffs?diff_id=117419&start_sha=20b595b358eb8ff365a77bc339706dff84bca440)

hansegucker commented

2026-05-21 19:36:42 +02:00

Owner

* When adding persons to a group, multiple persons can now be selected at once.
* When adding a person to groups, multiple groups can now be selected at once.

```suggestion:-1+0 * When adding persons to a group, multiple persons can now be selected at once. * When adding a person to groups, multiple groups can now be selected at once. ```

hansegucker commented

2026-05-21 19:36:42 +02:00

Owner

The label "of group" should be probably "of group(s)".

hansegucker commented

2026-05-21 19:36:42 +02:00

Owner

Same with "Person" when adding members to a group.

hansegucker commented

2026-05-21 19:36:42 +02:00

Owner

left review comments

hansegucker commented

2026-05-21 19:36:44 +02:00

Owner

assigned to @hansegucker

hansegucker commented

2026-05-21 19:37:34 +02:00

Owner

Now that multiple entries can be selected, I think the input fields should have the full width.

leuckeju commented

2026-06-01 17:14:16 +02:00

Author

Member

added 1 commit

2e4eac9c - Change labels for plural fields

Compare with previous version

added 1 commit <ul><li>2e4eac9c - Change labels for plural fields</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2254/diffs?diff_id=141139&start_sha=85e779894c6df1ebdd470ddba1f57282a6fdb4e2)

leuckeju commented

2026-06-01 17:14:42 +02:00

Author

Member

resolved all threads

leuckeju commented

2026-06-01 17:14:45 +02:00

Author

Member

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2254/diffs?diff_id=141140&start_sha=2e4eac9ca42b35f80f8fc59464c37490a929df67#45267e3a9556cafa9cb7b61dab7a3b6659e73aad_16_15)

leuckeju commented

2026-06-01 17:14:47 +02:00

Author

Member

added 1 commit

bd75fd8c - Rephrase Changelog

Compare with previous version

added 1 commit <ul><li>bd75fd8c - Rephrase Changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2254/diffs?diff_id=141140&start_sha=2e4eac9ca42b35f80f8fc59464c37490a929df67)

leuckeju commented

2026-06-01 17:15:45 +02:00

Author

Member

{width=900 height=490}

{width=900 height=403}

![grafik](/uploads/05667e50b7ed0f6e27482dbd04be6b65/grafik.png){width=900 height=490} ![grafik](/uploads/63be61748ceeca9cc863181a73f410c2/grafik.png){width=900 height=403}

leuckeju commented

2026-06-01 17:16:12 +02:00

Author

Member

requested review from @hansegucker

leuckeju commented

2026-06-01 17:16:17 +02:00

Author

Member

marked the checklist item Tested on mobile, tablet, and desktop sizes as completed

marked the checklist item **Tested on mobile, tablet, and desktop sizes** as completed

leuckeju commented

2026-06-01 17:16:18 +02:00

Author

Member

marked the checklist item Screenshots are attached (mobile and desktop) as completed

marked the checklist item **Screenshots are attached \(mobile and desktop\)** as completed

leuckeju commented

2026-06-01 17:16:19 +02:00

Author

Member

marked the checklist item Adhered to frontend guidelines as completed

marked the checklist item **Adhered to frontend guidelines** as completed

leuckeju commented

2026-06-01 17:24:06 +02:00

Author

Member

added 73 commits

bd75fd8c...6228f5eb - 72 commits from branch master
a872e29d - Merge branch 'master' into 1557-adding-persons-to-groups-should-allow-multiple-persons

Compare with previous version

added 73 commits <ul><li>bd75fd8c...6228f5eb - 72 commits from branch <code>master</code></li><li>a872e29d - Merge branch 'master' into 1557-adding-persons-to-groups-should-allow-multiple-persons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2254/diffs?diff_id=141144&start_sha=bd75fd8cfc75d625edb83cad43df6a0e1ab78e6c)

hansegucker commented

2026-06-04 21:44:34 +02:00

Owner

Please fix unrelated changes (plural) in this file.

leuckeju commented

2026-06-08 17:19:22 +02:00

Author

Member

added 1 commit

82309fb1 - Remove unnecessary changes

Compare with previous version

added 1 commit <ul><li>82309fb1 - Remove unnecessary changes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2254/diffs?diff_id=144658&start_sha=a872e29df78519ffc1efa6183c0c660d80925bce)

leuckeju commented

2026-06-08 17:19:26 +02:00

Author

Member

resolved all threads

hansegucker commented

2026-06-08 20:50:12 +02:00

Owner

added 9 commits

82309fb1...fb28bada - 8 commits from branch master
f430a108 - Merge branch 'master' into '1557-adding-persons-to-groups-should-allow-multiple-persons'

Compare with previous version

added 9 commits <ul><li>82309fb1...fb28bada - 8 commits from branch <code>master</code></li><li>f430a108 - Merge branch 'master' into '1557-adding-persons-to-groups-should-allow-multiple-persons'</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2254/diffs?diff_id=144666&start_sha=82309fb1a436c2f6e9b71e12d672cbf204f07592)

hansegucker merged commit 0720666254 into master

2026-06-08 21:15:45 +02:00

hansegucker commented

2026-06-08 21:15:47 +02:00

Owner

mentioned in commit 0720666254

mentioned in commit 0720666254d668eb34ed022b42c801679d4f713b