aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

OIDC core claim improvements #3790

Merged
hansegucker merged 5 commits from oidc-improvements into master 2026-02-05 14:47:25 +01:00
Conversation 18 Commits 5 Files changed 3 +113 -22
nik commented 2026-02-05 11:56:42 +01:00
Owner
Copy link

Information and screenshots

Closes #1542.

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

## Information and screenshots Closes #1542. ## Checklist - [x] `tox -e reformat,lint` used - [x] Changelog updated/No update necessary - [ ] Documentation (incl. Screenshots) up-to-date - [x] Copyright in `apps.py` and `README.rst` up-to-date - [ ] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [ ] Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86) - [ ] Tested with admin account - [ ] Tested with normal account (based on permissions) ## Backend checklist - [ ] Use permissions for all GraphQL mutations - [ ] Use query optimizer for all GraphQL queries - [ ] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [ ] Screenshots are attached (mobile and desktop) - [ ] Tested on mobile, tablet, and desktop sizes - [ ] Adhered to [frontend guidelines](https://edugit.org/AlekSIS/official/AlekSIS/-/blob/master/project/frontend_guidelines.rst?ref_type=heads) - [ ] Checked with [Firefox Accessibility Checker](https://firefox-source-docs.mozilla.org/devtools-user/accessibility_inspector/)
nik commented 2026-02-05 11:56:43 +01:00
Author
Owner
Copy link

assigned to @hansegucker

assigned to @hansegucker
nik commented 2026-02-05 11:56:49 +01:00
Author
Owner
Copy link

marked this merge request as draft

marked this merge request as **draft**
nik commented 2026-02-05 12:02:37 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>dc5681f1 - Update changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2145/diffs?diff_id=82971&start_sha=d76f993608b017ea9b2af9de51c96fedf69b93c1)
nik commented 2026-02-05 12:09:19 +01:00
Author
Owner
Copy link

changed title from Draft: Oidc improvements to Draft: OIDC core claim improvements

<p>changed title from <code class="idiff">Draft: O<span class="idiff left right deletion">idc</span> improvements</code> to <code class="idiff">Draft: O<span class="idiff left right addition">IDC core claim</span> improvements</code></p>
nik commented 2026-02-05 12:12:24 +01:00
Author
Owner
Copy link

marked the checklist item tox -e reformat,lint used as completed

marked the checklist item **`tox -e reformat,lint` used** as completed
nik commented 2026-02-05 12:12:25 +01:00
Author
Owner
Copy link

marked the checklist item Changelog updated/No update necessary as completed

marked the checklist item **Changelog updated/No update necessary** as completed
nik commented 2026-02-05 12:12:29 +01:00
Author
Owner
Copy link

marked the checklist item Copyright in apps.py and README.rst up-to-date as completed

marked the checklist item **Copyright in `apps.py` and `README.rst` up-to-date** as completed
nik commented 2026-02-05 12:18:42 +01:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
nik commented 2026-02-05 12:38:23 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3805a90f - Add dev docs for OIDC</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2145/diffs?diff_id=82977&start_sha=dc5681f1de9af4586744524a4d3d87083c405c93)
hansegucker commented 2026-02-05 14:11:20 +01:00
Owner
Copy link

Shouldn't we use a dictionary for this?

Shouldn't we use a dictionary for this?
hansegucker commented 2026-02-05 14:11:20 +01:00
Owner
Copy link

Maybe this should be a property on the Address model and make use of a f-string?

Maybe this should be a property on the `Address` model and make use of a f-string?
hansegucker commented 2026-02-05 14:11:20 +01:00
Owner
Copy link

left review comments

left review comments
nik commented 2026-02-05 14:28:11 +01:00
Author
Owner
Copy link

No.

No.
nik commented 2026-02-05 14:28:55 +01:00
Author
Owner
Copy link

No. At least not "and".

No. At least not "and".
nik commented 2026-02-05 14:28:56 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
nik commented 2026-02-05 14:30:20 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2145/diffs?diff_id=82987&start_sha=3805a90fdbaebad3e2dcf7b5e92b5c753684b30c#c5bff67ef2f26802f3c80e9bf77dc3105d8fc8ec_249_249)
nik commented 2026-02-05 14:30:21 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>cda5d196 - Use f-string for address</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2145/diffs?diff_id=82987&start_sha=3805a90fdbaebad3e2dcf7b5e92b5c753684b30c)
nik merged commit fe892df302 into master 2026-02-05 14:47:25 +01:00
nik commented 2026-02-05 14:47:31 +01:00
Author
Owner
Copy link

mentioned in commit fe892df302

mentioned in commit fe892df302543ef46c67334e9c0eb5ea1cef8039
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!3790
No description provided.