aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Add geolocation of persons" #3755

Merged
hansegucker merged 37 commits from 215-add-geolocation-of-persons-2 into master 2026-01-24 22:47:34 +01:00
Conversation 49 Commits 37 Files changed 28 +997 -119
nik commented 2026-01-19 13:39:52 +01:00
Owner
Copy link

Information and screenshots

No further information have been provided.

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

Closes #215

## Information and screenshots No further information have been provided. ## Checklist - [x] `tox -e reformat,lint` used - [x] Changelog updated/No update necessary - [ ] Documentation (incl. Screenshots) up-to-date - [x] Copyright in `apps.py` and `README.rst` up-to-date - [x] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [x] Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86) - [x] Tested with admin account - [x] Tested with normal account (based on permissions) ## Backend checklist - [x] Use permissions for all GraphQL mutations - [ ] Use query optimizer for all GraphQL queries - [x] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [x] Screenshots are attached (mobile and desktop) - [x] Tested on mobile, tablet, and desktop sizes - [ ] Adhered to [frontend guidelines](https://edugit.org/AlekSIS/official/AlekSIS/-/blob/master/project/frontend_guidelines.rst?ref_type=heads) - [ ] Checked with [Firefox Accessibility Checker](https://firefox-source-docs.mozilla.org/devtools-user/accessibility_inspector/) Closes #215
nik commented 2026-01-20 13:11:20 +01:00
Author
Owner
Copy link

added 10 commits

  • b0ae07c7 - Add lat/lon to Address
  • f540c19b - Add mapbox geocoding backend
  • b2418e96 - Add doc strings
  • 0f053cf8 - Introduce geocoding backend preference and parametrize test
  • c5be2ede - Add missing doc string
  • d228f2c1 - Add copyright
  • f61f523e - Add background task for missing address geocodes
  • 85f7f909 - Add geojson for person to GraphQL
  • 91eefa98 - Revert "Add geojson for person to GraphQL"
  • ab93f1bd - Add map to person detail page

Compare with previous version

added 10 commits <ul><li>b0ae07c7 - Add lat/lon to Address</li><li>f540c19b - Add mapbox geocoding backend</li><li>b2418e96 - Add doc strings</li><li>0f053cf8 - Introduce geocoding backend preference and parametrize test</li><li>c5be2ede - Add missing doc string</li><li>d228f2c1 - Add copyright</li><li>f61f523e - Add background task for missing address geocodes</li><li>85f7f909 - Add geojson for person to GraphQL</li><li>91eefa98 - Revert &quot;Add geojson for person to GraphQL&quot;</li><li>ab93f1bd - Add map to person detail page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=81999&start_sha=906d232d2c0312811270b4ae8c32e56756fc451d)
nik commented 2026-01-20 15:04:08 +01:00
Author
Owner
Copy link

added 1 commit

  • 91f3add2 - Add map to person detail page

Compare with previous version

added 1 commit <ul><li>91f3add2 - Add map to person detail page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82043&start_sha=ab93f1bd3c77fbcd93bc5e1719b4201e4164ab68)
nik commented 2026-01-20 16:17:46 +01:00
Author
Owner
Copy link

added 1 commit

  • 55f5927d - Add navigation button to addresses in person view

Compare with previous version

added 1 commit <ul><li>55f5927d - Add navigation button to addresses in person view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82050&start_sha=91f3add2af0424b0015899f455f18fbfb06fbe60)
nik commented 2026-01-20 17:05:15 +01:00
Author
Owner
Copy link

added 1 commit

  • 67318a8c - Proxy map tile requests behind AlekSIS

Compare with previous version

added 1 commit <ul><li>67318a8c - Proxy map tile requests behind AlekSIS</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82053&start_sha=55f5927daef2d0b906161ecb502c59ba473836e7)
nik commented 2026-01-20 17:17:10 +01:00
Author
Owner
Copy link

added 3 commits

Compare with previous version

added 3 commits <ul><li>1cde4b5e - Fix lint</li><li>3b902247 - Move map preferences to own section</li><li>328be110 - Fix frontend lints</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82054&start_sha=67318a8c407f5b9f15266de8bf7a843b0c0738f4)
nik commented 2026-01-20 17:18:48 +01:00
Author
Owner
Copy link

image{width=624 height=652}

![image](/uploads/ab26ff8897ef3c9fcdd0150f3f63dcbb/image.png){width=624 height=652}
nik commented 2026-01-20 17:19:42 +01:00
Author
Owner
Copy link

assigned to @hansegucker

assigned to @hansegucker
nik commented 2026-01-20 17:19:46 +01:00
Author
Owner
Copy link

marked the checklist item tox -e reformat,lint used as completed

marked the checklist item **`tox -e reformat,lint` used** as completed
nik commented 2026-01-20 17:19:47 +01:00
Author
Owner
Copy link

marked the checklist item Changelog updated/No update necessary as completed

marked the checklist item **Changelog updated/No update necessary** as completed
nik commented 2026-01-20 17:19:49 +01:00
Author
Owner
Copy link

marked the checklist item Copyright in apps.py and README.rst up-to-date as completed

marked the checklist item **Copyright in `apps.py` and `README.rst` up-to-date** as completed
nik commented 2026-01-20 17:19:50 +01:00
Author
Owner
Copy link

marked the checklist item (Unit) tests for new feature/regression tests for bug fixes (only if useful) as completed

marked the checklist item **(Unit) tests for new feature/regression tests for bug fixes (only if useful)** as completed
nik commented 2026-01-20 17:20:04 +01:00
Author
Owner
Copy link

marked the checklist item Screenshots are attached (mobile and desktop) as completed

marked the checklist item **Screenshots are attached (mobile and desktop)** as completed
nik commented 2026-01-20 17:50:23 +01:00
Author
Owner
Copy link

added 1 commit

  • 87af2eda - Add caching logic to tiles proxy view

Compare with previous version

added 1 commit <ul><li>87af2eda - Add caching logic to tiles proxy view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82056&start_sha=328be110e08181b4e16a4c12d72598313bac6377)
nik commented 2026-01-20 17:52:50 +01:00
Author
Owner
Copy link

added 1 commit

  • fd22dddc - Add caching logic to tiles proxy view

Compare with previous version

added 1 commit <ul><li>fd22dddc - Add caching logic to tiles proxy view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82057&start_sha=87af2edae6bf6300ac1fc2749a3b6c7497dc72df)
nik commented 2026-01-20 17:56:08 +01:00
Author
Owner
Copy link

added 1 commit

  • 9ce894bb - Add caching logic to tiles proxy view

Compare with previous version

added 1 commit <ul><li>9ce894bb - Add caching logic to tiles proxy view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82058&start_sha=fd22dddc334d41c95aa5e645443e85a0881e3d1b)
nik commented 2026-01-20 18:59:18 +01:00
Author
Owner
Copy link

added 1 commit

  • 7229ad35 - Add initial members map to group overview

Compare with previous version

added 1 commit <ul><li>7229ad35 - Add initial members map to group overview</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82059&start_sha=9ce894bb5c0503f0f808c6d392b670ee0e84bf85)
hansegucker commented 2026-01-21 13:57:33 +01:00
Owner
Copy link

added 2 commits

  • 750422db - Migrate address to many-to-one
  • 3663120e - Include first version of avatar

Compare with previous version

added 2 commits <ul><li>750422db - Migrate address to many-to-one</li><li>3663120e - Include first version of avatar</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82078&start_sha=7229ad3599ff193d2949de67408c3ce1cbd3c582)
nik commented 2026-01-21 21:24:01 +01:00
Author
Owner
Copy link

added 2 commits

  • 6ae01a87 - Add padding to map zoom
  • 7ebff90a - Merge branch '215-add-geolocation-of-persons-2' of...

Compare with previous version

added 2 commits <ul><li>6ae01a87 - Add padding to map zoom</li><li>7ebff90a - Merge branch &#39;215-add-geolocation-of-persons-2&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82124&start_sha=46651b0311aa7efdb3ff9c848eb74732a20e989d)
nik commented 2026-01-21 21:31:50 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>46b71b50 - Make map height relative</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82147&start_sha=7ebff90a74ccdddf75e923bba2f7209a9b9e23a6)
nik commented 2026-01-21 21:56:48 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>1f8cf27f - Allow all BSD licenses</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82148&start_sha=46b71b50e88323b44f1daca5af7715960fb5f4a8)
hansegucker commented 2026-01-22 14:01:05 +01:00
Owner
Copy link

added 35 commits

  • 1f8cf27f...13a2aaa4 - 33 commits from branch master
  • 8570a703 - Merge branch 'master' into 215-add-geolocation-of-persons-2
  • 1845df9e - Fix migration history after merging

Compare with previous version

added 35 commits <ul><li>1f8cf27f...13a2aaa4 - 33 commits from branch <code>master</code></li><li>8570a703 - Merge branch &#39;master&#39; into 215-add-geolocation-of-persons-2</li><li>1845df9e - Fix migration history after merging</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82256&start_sha=1f8cf27f3e8297e8697a74ccd08f7c25270cf279)
hansegucker commented 2026-01-22 14:36:00 +01:00
Owner
Copy link

added 1 commit

  • f04be70e - Use correct avatar URL for map

Compare with previous version

added 1 commit <ul><li>f04be70e - Use correct avatar URL for map</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82263&start_sha=1845df9e782e1c6ca9b613368713b15dbef34aad)
hansegucker commented 2026-01-22 14:44:20 +01:00
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
nik commented 2026-01-22 15:50:17 +01:00
Author
Owner
Copy link

marked the checklist item Adhere to URL scheme as completed

marked the checklist item **Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86)** as completed
nik commented 2026-01-22 15:50:20 +01:00
Author
Owner
Copy link

marked the checklist item Tested with admin account as completed

marked the checklist item **Tested with admin account** as completed
nik commented 2026-01-22 16:04:19 +01:00
Author
Owner
Copy link

marked the checklist item Tested with normal account (based on permissions) as completed

marked the checklist item **Tested with normal account (based on permissions)** as completed
nik commented 2026-01-22 16:04:28 +01:00
Author
Owner
Copy link

marked the checklist item Don't use inefficient DB queries as completed

marked the checklist item **Don't use inefficient DB queries** as completed
nik commented 2026-01-22 16:04:34 +01:00
Author
Owner
Copy link

marked the checklist item Use permissions for all GraphQL mutations as completed

marked the checklist item **Use permissions for all GraphQL mutations** as completed
nik commented 2026-01-22 16:04:40 +01:00
Author
Owner
Copy link

marked the checklist item Tested on mobile, tablet, and desktop sizes as completed

marked the checklist item **Tested on mobile, tablet, and desktop sizes** as completed
yuha commented 2026-01-22 16:38:04 +01:00
Member
Copy link

Why are the tests failing?

Why are the tests failing?
hansegucker commented 2026-01-22 16:46:38 +01:00
Owner
Copy link

Because of the changed model. I will fix this.

Because of the changed model. I will fix this.
hansegucker commented 2026-01-22 16:54:13 +01:00
Owner
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>0ae607f2 - Fix CSS for map marker icons</li><li>d5a89ffa - Fix tests</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82282&start_sha=f04be70ed5d1ff339151fafb773df698027d3d05)
hansegucker commented 2026-01-22 16:57:47 +01:00
Owner
Copy link

resolved all threads

resolved all threads
yuha commented 2026-01-22 17:00:05 +01:00
Member
Copy link

otherwise this looks good. congrats!

otherwise this looks good. congrats!
nik commented 2026-01-22 17:15:12 +01:00
Author
Owner
Copy link

added 3 commits

  • 3901f333 - Fix map with only non-geocoded addresses
  • 54099001 - Update changelog
  • c816a6d7 - Merge branch '215-add-geolocation-of-persons-2' of...

Compare with previous version

added 3 commits <ul><li>3901f333 - Fix map with only non-geocoded addresses</li><li>54099001 - Update changelog</li><li>c816a6d7 - Merge branch &#39;215-add-geolocation-of-persons-2&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82288&start_sha=d5a89ffaecfcee59af0a201878d2bfa41ed0e6f9)
nik commented 2026-01-22 17:15:57 +01:00
Author
Owner
Copy link

Needs a better height

Needs a better height
nik commented 2026-01-22 17:15:57 +01:00
Author
Owner
Copy link

Needs a better height

Needs a better height
nik commented 2026-01-22 17:15:58 +01:00
Author
Owner
Copy link

There is a white square behind each marker @hansegucker

There is a white square behind each marker @hansegucker
nik commented 2026-01-22 17:15:58 +01:00
Author
Owner
Copy link

left review comments

left review comments
nik commented 2026-01-22 17:18:25 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>52d58511 - Remove map watcher</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82289&start_sha=c816a6d775f5d98cde3110dcadcb6c2638e70275)
nik commented 2026-01-22 18:59:53 +01:00
Author
Owner
Copy link

I thought !important were evil?

I thought `!important` were evil?
hansegucker commented 2026-01-22 19:22:21 +01:00
Owner
Copy link

Normally it is, but in this case it's necessary to override leaftlet's CSS.

Normally it is, but in this case it's necessary to override leaftlet's CSS.
nik commented 2026-01-22 23:24:19 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
nik commented 2026-01-22 23:32:19 +01:00
Author
Owner
Copy link

changed this line in version 19 of the diff

changed this line in [version 19 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82298&start_sha=52d585117094eefbc6942628c3d12dce10a67200#56dff5380ccfc540cea5d4a326de65fc186951ab_15_15)
nik commented 2026-01-22 23:32:21 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>27d5655b - Fit map height on viewport</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82298&start_sha=52d585117094eefbc6942628c3d12dce10a67200)
nik commented 2026-01-24 22:42:49 +01:00
Author
Owner
Copy link

added 1 commit

  • 4f4d85b8 - Add MapTiler geocoding backend

Compare with previous version

added 1 commit <ul><li>4f4d85b8 - Add MapTiler geocoding backend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82348&start_sha=27d5655b0fb3133734f413ddc885fa8113b3f2e0)
nik commented 2026-01-24 22:45:20 +01:00
Author
Owner
Copy link

added 1 commit

  • 576ad5a0 - Fix MapTiler with single address in query

Compare with previous version

added 1 commit <ul><li>576ad5a0 - Fix MapTiler with single address in query</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82400&start_sha=4f4d85b89b96dd549ddf5e4a4aa3485fe3d41df5)
nik commented 2026-01-24 22:47:08 +01:00
Author
Owner
Copy link

added 10 commits

  • 576ad5a0...d03b157a - 9 commits from branch master
  • 85dacbaa - Merge remote-tracking branch 'origin/master' into 215-add-geolocation-of-persons-2

Compare with previous version

added 10 commits <ul><li>576ad5a0...d03b157a - 9 commits from branch <code>master</code></li><li>85dacbaa - Merge remote-tracking branch &#39;origin/master&#39; into 215-add-geolocation-of-persons-2</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/2110/diffs?diff_id=82411&start_sha=576ad5a0968ce698f37e4e6c28d3beca3f946d23)
nik merged commit d529637002 into master 2026-01-24 22:47:34 +01:00
nik commented 2026-01-24 22:47:41 +01:00
Author
Owner
Copy link

mentioned in commit d529637002

mentioned in commit d5296370029aafb196b56d541bf867c4e74a84de
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!3755
No description provided.