Person and group details/form in Vue 3 #3603
No reviewers
Labels
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
aleksis/AlekSIS-Core!3603
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/person-vue3"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Close #1373
Close #1343
Close #1379
Close #1363
Close #1380
Information and screenshots
No further information have been provided.
Checklist
tox -e reformat,lintusedapps.pyandREADME.rstup-to-dateBackend checklist
Frontend checklist (mandatory with ~"part::frontend")
marked the checklist item
tox -e reformat,lintused as completedmarked the checklist item
tox -e reformat,lintused as incompletemarked the checklist item
tox -e reformat,lintused as completedadded 26 commits
masterdf70d53d- Merge branch 'master' into fix/person-vue3Compare with previous version
added 2 commits
5eec8a70- Fix handling of addresses in frontend788e0a3d- Fix tox.iniCompare with previous version
added 4 commits
9ebd5167- Switch from userid/username to user typebbb35f01- Fix smaller bugs with person formbe7201a3- Fix rules/perms for addresses0c7e56bb- Fix tox.iniCompare with previous version
added 3 commits
56954166- Migrate itemsPerPage to composableaac71687- Introduce number formatting45bd9598- Migrate group components to Vue 3Compare with previous version
added 1 commit
3d6bfa49- Completely migrate editing/creating groups to VueCompare with previous version
added 1 commit
22497805- Migrate the rest of the person components to Vue 3Compare with previous version
added 1 commit
58293d6f- Drop outdated address testsCompare with previous version
TODO: Certain fields only editable in certain situations
Edit form opens on empty?
added 1 commit
8a856666- Fix backOrElse functionalityCompare with previous version
added 1 commit
f9634f48- Fix AvatarContentCompare with previous version
resolved all threads
marked this merge request as ready
added 3 commits
c1949362- Fix permission handling in App.vue/for person detailsf10c0895- Fix group statistics card with less data61dce2dc- Limit editable fields for personsCompare with previous version
changed title from
Person details/form in Vue 3toPerson and group details/form in Vue 3marked the checklist item Documentation (incl. Screenshots) up-to-date as completed
marked the checklist item Copyright in
apps.pyandREADME.rstup-to-date as completedmarked the checklist item Changelog updated/No update necessary as completed
marked the checklist item (Unit) tests for new feature/regression tests for bug fixes (only if useful) as completed
marked the checklist item Adhere to URL scheme as completed
marked the checklist item Tested with admin account as completed
marked the checklist item Tested with normal account (based on permissions) as completed
marked the checklist item Use permissions for all GraphQL mutations as completed
marked the checklist item Use query optimizer for all GraphQL queries as completed
marked the checklist item Don't use inefficient DB queries as completed
marked the checklist item Screenshots are attached (mobile and desktop) as completed
marked the checklist item Tested on mobile, tablet, and desktop sizes as completed
added 1 commit
b0dffb9c- Fix group editingCompare with previous version
where is this component used?
iirc we wanted to delete this, as the crud-provider functions as an iterator already
... continue this in other components, will not mark it anymore
I believe the comment doesn't relate to your addition…
why can this be a boolean?
does this align with the allowed formats from the backend?
what about other raster formats like gif, webp, or maybe even vectors like svg?
this change renames the component, did you check (in other apps?) for usages?
requested changes
The name has already been
GroupCollectionbefore, hasn't it?where would this come from?
why does this either return a component or a string, that seems wrong…
v-ifis more important → higherwhy did you remove them?
again; returns either component or string, seems weird, why not return component directly or string at all times
what now, enabled or disabled
either remove or implement
both these changes seem like some reformatting is gonna happen, even though this happens in
lintthis seems wrong
requested changes
changed the description
Our backend actually supports much more extensions. That's probably something for a different issue.
created #1391 to continue this discussion
mentioned in issue #1391
Mixing eslint with formatting breaks everything.
Yeah, but deleting this is not part of this MR.
Because the default is
falseand this seems to have a special reason, didn't want to deviate from the pattern here (see lines below).That's just to be ready for future use cases.
I think you invented this one ;-)
Didn't work anymore as expected, this way it works perfectly fine.
Again your invention ;-)
Good catch 😆
No, it's todo, I keep this for future usage.
left review comments
changed this line in version 13 of the diff
changed this line in version 13 of the diff
changed this line in version 13 of the diff
changed this line in version 13 of the diff
changed this line in version 13 of the diff
changed this line in version 13 of the diff
changed this line in version 13 of the diff
added 1 commit
12b91694- Fix things from reviewCompare with previous version
resolved all threads
assigned to @hansegucker
mentioned in commit
bbb48f874d