aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Drop django-two-factor-auth and migrate 2FA pages to new frontend #3520

Merged
hansegucker merged 15 commits from drop-django-two-factor-auth into master 2025-06-29 13:48:20 +02:00
Conversation 69 Commits 15 Files changed 56 +1298 -1168
hansegucker commented 2025-05-31 22:31:09 +02:00
Owner
Copy link

grafik

![grafik](/uploads/ea91855d9c349a2e64979311c388a8c9/grafik.png)
hansegucker commented 2025-06-06 16:47:48 +02:00
Author
Owner
Copy link

added 1 commit

  • d3ac37b2 - Add support for allauth recovery codes to frontend

Compare with previous version

added 1 commit <ul><li>d3ac37b2 - Add support for allauth recovery codes to frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=64592&start_sha=7d81ae2f1fb821798c5fdde1be5c81d38d06e5db)
hansegucker commented 2025-06-12 11:06:45 +02:00
Author
Owner
Copy link

mentioned in issue #565

mentioned in issue #565
hansegucker commented 2025-06-12 11:07:14 +02:00
Author
Owner
Copy link

mentioned in issue #1160

mentioned in issue #1160
hansegucker commented 2025-06-12 11:07:44 +02:00
Author
Owner
Copy link

mentioned in issue #1207

mentioned in issue #1207
hansegucker commented 2025-06-12 11:08:08 +02:00
Author
Owner
Copy link

mentioned in issue #438

mentioned in issue #438
hansegucker commented 2025-06-13 15:09:54 +02:00
Author
Owner
Copy link

changed the description

changed the description
hansegucker commented 2025-06-13 15:17:56 +02:00
Author
Owner
Copy link

added 1 commit

  • 73b3b0d5 - Add support for allauth webauthn to frontend

Compare with previous version

added 1 commit <ul><li>73b3b0d5 - Add support for allauth webauthn to frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65175&start_sha=d3ac37b27e48f259b0d5276880e95b8d46c7d467)
hansegucker commented 2025-06-13 15:21:54 +02:00
Author
Owner
Copy link

added 1 commit

  • c5562eb1 - Drop old 2fa frontend

Compare with previous version

added 1 commit <ul><li>c5562eb1 - Drop old 2fa frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65177&start_sha=73b3b0d50e27dc4c9ec8af4923bc56b04ab23e8e)
hansegucker commented 2025-06-13 19:29:09 +02:00
Author
Owner
Copy link

requested review from @ZugBahnHof

requested review from @ZugBahnHof
hansegucker commented 2025-06-15 21:40:14 +02:00
Author
Owner
Copy link

added 2 commits

  • 2ffe310f - Refactor new 2fa page
  • 8a11cd76 - Update docs for 2fa

Compare with previous version

added 2 commits <ul><li>2ffe310f - Refactor new 2fa page</li><li>8a11cd76 - Update docs for 2fa</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65228&start_sha=c5562eb1267b1d1adfab1d000365a66c3e18a9c1)
hansegucker commented 2025-06-15 21:40:20 +02:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2025-06-15 21:40:31 +02:00
Author
Owner
Copy link

Migration path?

Migration path?
nik commented 2025-06-15 21:45:07 +02:00
Owner
Copy link
        sociallogin = (kwargs.get("signal_kwargs", None) or {}).get("sociallogin")

No need to instantiate two dicts.

```suggestion:-0+0 sociallogin = (kwargs.get("signal_kwargs", None) or {}).get("sociallogin") ``` No need to instantiate two dicts.
nik commented 2025-06-15 21:46:06 +02:00
Owner
Copy link

I don't think this helps.

I don't think this helps.
hansegucker commented 2025-06-15 22:50:28 +02:00
Author
Owner
Copy link

I agree ;-)

I agree ;-)
leuckeju commented 2025-06-16 15:08:24 +02:00
Member
Copy link

I thought we actually use named routes instead of hardcoding paths so the route can change without needing to update all code locations?

I thought we actually use named routes instead of hardcoding paths so the route can change without needing to update all code locations?
leuckeju commented 2025-06-16 15:08:25 +02:00
Member
Copy link

undeclared event

undeclared event
leuckeju commented 2025-06-16 15:08:25 +02:00
Member
Copy link

undeclared event

undeclared event
leuckeju commented 2025-06-16 15:08:25 +02:00
Member
Copy link

why does a dialog action trigger a redirect?

why does a dialog action trigger a redirect?
leuckeju commented 2025-06-16 15:08:25 +02:00
Member
Copy link

why change this?

why change this?
leuckeju commented 2025-06-16 15:08:25 +02:00
Member
Copy link

what are all of these django templates for?

what are all of these django templates for?
leuckeju commented 2025-06-16 15:08:26 +02:00
Member
Copy link

requested changes

requested changes
hansegucker commented 2025-06-16 15:14:24 +02:00
Author
Owner
Copy link

Yeah, that's a named route. I just changed the name for consistency with the other names.

Yeah, that's a named route. I just changed the name for consistency with the other names.
hansegucker commented 2025-06-16 15:14:24 +02:00
Author
Owner
Copy link

Ah, should be probably this.dialog = false instead.

Ah, should be probably `this.dialog = false` instead.
hansegucker commented 2025-06-16 15:14:24 +02:00
Author
Owner
Copy link

Because that's django-two-factor-auth's URL scheme and not django-allauth's URL scheme.

Because that's django-two-factor-auth's URL scheme and not django-allauth's URL scheme.
hansegucker commented 2025-06-16 15:14:24 +02:00
Author
Owner
Copy link

To make django-allauth showing things in Materialize ...

To make django-allauth showing things in Materialize ...
hansegucker commented 2025-06-16 15:14:25 +02:00
Author
Owner
Copy link

Reminds me: Drop old login templates

Reminds me: Drop old login templates
leuckeju commented 2025-06-16 15:15:27 +02:00
Member
Copy link

Recovery code status is shown as "(not) activated", should probably instead be "(not) generated". Also, the regeneration is a destructive (→ dangerous) action, button should be red.

Recovery code status is shown as "(not) activated", should probably instead be "(not) generated". Also, the regeneration is a destructive (→ dangerous) action, button should be red.
leuckeju commented 2025-06-16 15:21:47 +02:00
Member
Copy link

don't like this icon here

don't like this icon here
leuckeju commented 2025-06-16 15:21:48 +02:00
Member
Copy link

Due to only one 2fa authenticator app at a time being supported (afaik), the button to add/remove it implicitly tells the status, so the chip is unnecessary.
Maybe this can be combined with the button? Idea: clicking the chip does the same as clicking the button

Due to only one 2fa authenticator app at a time being supported (afaik), the button to add/remove it implicitly tells the status, so the chip is unnecessary. Maybe this can be combined with the button? Idea: clicking the chip does the same as clicking the button
hansegucker commented 2025-06-16 15:23:28 +02:00
Author
Owner
Copy link

I like a clear, visible, and consistent indicator for each method, so I don't think the chip is unnecessary.

I like a clear, visible, and consistent indicator for each method, so I don't think the chip is unnecessary.
hansegucker commented 2025-06-16 15:23:40 +02:00
Author
Owner
Copy link

Do you have a better idea?

Do you have a better idea?
hansegucker commented 2025-06-16 15:24:07 +02:00
Author
Owner
Copy link

Same argument with the consistency → recovery codes are a 2fa method and it can be activated or not

Same argument with the consistency → recovery codes are a 2fa method and it can be activated or not
leuckeju commented 2025-06-16 15:25:29 +02:00
Member
Copy link

Security keys cannot be deactivated/disabled but only added/removed, so the chip should either say "{None|One|n} keys added" or maybe even contain a button like this:

image

Security keys cannot be deactivated/disabled but only added/removed, so the chip should either say "{None|One|n} keys added" or maybe even contain a button like this: ![image](/uploads/6f1a0eb3426ed267dc23eae17849edb5/image.png)
leuckeju commented 2025-06-16 15:25:46 +02:00
Member
Copy link

hm, ok i guess

hm, ok i guess
leuckeju commented 2025-06-16 15:26:08 +02:00
Member
Copy link

maybe a store update is required as well

maybe a store update is required as well
leuckeju commented 2025-06-16 15:26:32 +02:00
Member
Copy link

but can't our frontend be backend-2fa-lib-agnostic?

but can't our frontend be backend-2fa-lib-agnostic?
leuckeju commented 2025-06-16 15:28:12 +02:00
Member
Copy link

they cannot be not activated tho? If they exist they are automatically active, right?

they cannot be not activated tho? If they exist they are automatically active, right?
leuckeju commented 2025-06-16 15:29:26 +02:00
Member
Copy link

May just the trashcan or something like cellphone-remove?

May just the trashcan or something like cellphone-remove?
leuckeju commented 2025-06-16 15:33:55 +02:00
Member
Copy link

I like the idea of a clear indicator per method, but I think right now they

  • can be confusing (e.g. if they imply something can be deactivated)
  • duplicate info (which is not a bad thing per se)
  • tell the user an action should be performed, but don't allow this directly (a big red chip tells users that something is not ideal, which is correct, but the action-trigger to fix this is at the other end of these cards)
I like the idea of a clear indicator per method, but I think right now they - can be confusing (e.g. if they imply something can be deactivated) - duplicate info (which is not a bad thing per se) - tell the user an action should be performed, but don't allow this directly (a big red chip tells users that something is not ideal, which is correct, but the action-trigger to fix this is at the other end of these cards)
hansegucker commented 2025-06-16 15:41:49 +02:00
Author
Owner
Copy link

No, the URL scheme is not a frontend decision. This URL had to change anyway because the account scheme is not used.

No, the URL scheme is not a frontend decision. This URL had to change anyway because the `account` scheme is not used.
hansegucker commented 2025-06-16 15:42:15 +02:00
Author
Owner
Copy link

Yeah, so they are activated.

Yeah, so they are activated.
leuckeju commented 2025-06-16 15:46:29 +02:00
Member
Copy link

change this icon

change this icon
leuckeju commented 2025-06-16 15:53:25 +02:00
Member
Copy link

image

@hansegucker an idea for this page, what do you think?

![image](/uploads/604284a4a476103b7d19350fc5eb18e0/image.png) @hansegucker an idea for this page, what do you think?
hansegucker commented 2025-06-16 15:54:22 +02:00
Author
Owner
Copy link

It's missing all the consistency I liked ...

It's missing all the consistency I liked ...
leuckeju commented 2025-06-16 20:56:17 +02:00
Member
Copy link

I see your point, maybe we can discuss/find a compromise? (maybe in the devmeeting or a call or sth?)

I see your point, maybe we can discuss/find a compromise? (maybe in the devmeeting or a call or sth?)
leuckeju commented 2025-06-16 20:57:51 +02:00
Member
Copy link

yes, but they will never be "not activated". either they exist or they don't. Simplify change the wording…

yes, but they will never be "not activated". either they exist or they don't. Simplify change the wording…
hansegucker commented 2025-06-17 14:33:32 +02:00
Author
Owner
Copy link

added 1 commit

  • cb01ffb5 - Drop old templates

Compare with previous version

added 1 commit <ul><li>cb01ffb5 - Drop old templates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65285&start_sha=8a11cd76bcd33112447fd427cb5906eaeaa89b50)
hansegucker commented 2025-06-18 20:17:59 +02:00
Author
Owner
Copy link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65335&start_sha=cb01ffb5f67aa786fed77e9820573f6bfb3420d7#a6a964843a748ae0ba2f0c303eba963855e834f4_56_56)
hansegucker commented 2025-06-18 20:18:04 +02:00
Author
Owner
Copy link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65335&start_sha=cb01ffb5f67aa786fed77e9820573f6bfb3420d7#017dc1edadeaf4db34f409c9aba47cf569c70c36_23_16)
hansegucker commented 2025-06-18 20:18:07 +02:00
Author
Owner
Copy link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65335&start_sha=cb01ffb5f67aa786fed77e9820573f6bfb3420d7#c9f85db2c06d6ba0ecacc062a167a3517a01faf4_29_29)
hansegucker commented 2025-06-18 20:18:08 +02:00
Author
Owner
Copy link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65335&start_sha=cb01ffb5f67aa786fed77e9820573f6bfb3420d7#f7c8452b629343b9626741a05b8038589a42d24c_4_4)
hansegucker commented 2025-06-18 20:18:09 +02:00
Author
Owner
Copy link

added 1 commit

  • 950e06ae - Fix things from review

Compare with previous version

added 1 commit <ul><li>950e06ae - Fix things from review</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65335&start_sha=cb01ffb5f67aa786fed77e9820573f6bfb3420d7)
hansegucker commented 2025-06-18 23:22:23 +02:00
Author
Owner
Copy link

@ZugBahnHof grafik

@ZugBahnHof ![grafik](/uploads/169c28d04595e205d74e67c759a8fc83/grafik.png)
hansegucker commented 2025-06-18 23:26:26 +02:00
Author
Owner
Copy link

added 1 commit

  • 9b6141a5 - Optimize frontend for 2FA

Compare with previous version

added 1 commit <ul><li>9b6141a5 - Optimize frontend for 2FA</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65472&start_sha=950e06ae875440c9e9a6ab4634b0072d5003fc7e)
leuckeju commented 2025-06-19 09:41:08 +02:00
Member
Copy link

For the codes please add smth like "codes are created in batches of 10", and maybe change the chip text to "... codes remaining"?

For the codes please add smth like "codes are created in batches of 10", and maybe change the chip text to "... codes remaining"?
hansegucker commented 2025-06-24 20:59:20 +02:00
Author
Owner
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65613&start_sha=9b6141a55f5247130032558e4601326f905c1f6d#46c0677a276dcd2bb7f0a286a3722d9600e6a7cf_11_0)
hansegucker commented 2025-06-24 20:59:29 +02:00
Author
Owner
Copy link

added 4 commits

  • 9acf90f9 - fixup! First steps in getting rid of django-two-factor-auth and using django-allauth[mfa]
  • dea1a191 - Fix messages for 2FA
  • 60f6159e - Update changelog
  • d8986ad7 - Finally drop 2FA

Compare with previous version

added 4 commits <ul><li>9acf90f9 - fixup! First steps in getting rid of django-two-factor-auth and using django-allauth[mfa]</li><li>dea1a191 - Fix messages for 2FA</li><li>60f6159e - Update changelog</li><li>d8986ad7 - Finally drop 2FA</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65613&start_sha=9b6141a55f5247130032558e4601326f905c1f6d)
hansegucker commented 2025-06-24 20:59:30 +02:00
Author
Owner
Copy link

marked this merge request as draft from 9acf90f96a9505e19ce93a5692f1c7670ef5eeda

marked this merge request as **draft** from 9acf90f96a9505e19ce93a5692f1c7670ef5eeda
hansegucker commented 2025-06-24 20:59:54 +02:00
Author
Owner
Copy link

added 55 commits

  • d8986ad7...0b048115 - 40 commits from branch master
  • 0b048115...8ccaa9e4 - 5 earlier commits
  • f0eb529d - Add support for allauth webauthn to frontend
  • 529d5354 - Drop old 2fa frontend
  • aaaad844 - Refactor new 2fa page
  • 37a3471f - Update docs for 2fa
  • 0525ca40 - Drop old templates
  • 01fddce4 - Fix things from review
  • 17fe06f0 - Optimize frontend for 2FA
  • fa602e22 - Fix messages for 2FA
  • a9e9b8db - Update changelog
  • 47c174b3 - Finally drop 2FA

Compare with previous version

added 55 commits <ul><li>d8986ad7...0b048115 - 40 commits from branch <code>master</code></li><li>0b048115...8ccaa9e4 - 5 earlier commits</li><li>f0eb529d - Add support for allauth webauthn to frontend</li><li>529d5354 - Drop old 2fa frontend</li><li>aaaad844 - Refactor new 2fa page</li><li>37a3471f - Update docs for 2fa</li><li>0525ca40 - Drop old templates</li><li>01fddce4 - Fix things from review</li><li>17fe06f0 - Optimize frontend for 2FA</li><li>fa602e22 - Fix messages for 2FA</li><li>a9e9b8db - Update changelog</li><li>47c174b3 - Finally drop 2FA</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65615&start_sha=d8986ad7772ab1204b1e6d64cef99a6829412353)
hansegucker commented 2025-06-24 21:01:07 +02:00
Author
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2025-06-24 21:01:12 +02:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
yuha commented 2025-06-25 20:33:21 +02:00
Member
Copy link

@hansegucker please add a new screenshot

@hansegucker please add a new screenshot
hansegucker commented 2025-06-25 22:05:22 +02:00
Author
Owner
Copy link

There is no need for a new screenshot, only some texts were updated.

There is no need for a new screenshot, only some texts were updated.
hansegucker commented 2025-06-29 13:14:40 +02:00
Author
Owner
Copy link

added 1 commit

  • fbc111ad - Finally drop 2FA

Compare with previous version

added 1 commit <ul><li>fbc111ad - Finally drop 2FA</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65674&start_sha=47c174b3540fea4a7c4731e1401893c7e687e93d)
hansegucker commented 2025-06-29 13:29:10 +02:00
Author
Owner
Copy link

added 1 commit

  • 08a1a885 - Finally drop 2FA

Compare with previous version

added 1 commit <ul><li>08a1a885 - Finally drop 2FA</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65676&start_sha=fbc111ad61ff29d2a091669a193709a185332628)
hansegucker commented 2025-06-29 13:37:37 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>4d07e0d3 - Finally drop 2FA</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1875/diffs?diff_id=65678&start_sha=08a1a885901af636812df10969d6e15dc8c4fe1e)
hansegucker commented 2025-06-29 13:48:15 +02:00
Author
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2025-06-29 13:48:24 +02:00
Author
Owner
Copy link

mentioned in commit 748bf6438d

mentioned in commit 748bf6438dc313238eedbaf8fa4c0816a3b2d55d
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!3520
No description provided.