Resolve "Rebuild account registration form" #3382
No reviewers
Labels
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
No milestone
No project
No assignees
5 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
aleksis/AlekSIS-Core!3382
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "1225-rebuild-account-registration-form"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #1225
assigned to @yuha
added 62 commits
fcfc413c- Fix migration history97d467bb- Fix permissions for person batch mutationb5bbb87c- Drop old form and views for persons46093a14- Use correct type constraint31fdbe1c- Fix image preview sizec48e5786- Restructure components32c545c2- WIP: Add edit button to person list8545a3c7- Go back on success instead of redirect to separate routeac0c4b28- ReformatCompare with previous version
added 1 commit
Compare with previous version
added 3 commits
Compare with previous version
added 24 commits
masterd1c92081- Pass systemProperties to routeValidatorsca7de4d9- Add inviteEnabled to systemProperties-Queryf3debbb6- Switch accept_invitation-menu from permission to validator8540bb28- ReformatCompare with previous version
added 20 commits
Compare with previous version
added 4 commits
Compare with previous version
added 1 commit
Compare with previous version
added 27 commits
masterbac9b3a9- Merge branch '1107-vue-rework-person-create-edit' into 8-factor-out-addresses-into-their-own-modela6dade03- Merge branch '1107-vue-rework-person-create-edit' into 8-factor-out-addresses-into-their-own-model79283a39- Create and update default address in person mutation826710bf- Add default item and set isCreate valued422fb1c- Fix default item handling1e55bff0- Merge branch 'master' into 8-factor-out-addresses-into-their-own-modelaab1474c- Fix address handling in frontend3e02a82c- Merge branch '1234-personform-does-not-work-in-create-mode' into...Compare with previous version
Too long
added 1 commit
Compare with previous version
added 48 commits
masterCompare with previous version
added 3 commits
Compare with previous version
added 1 commit
Compare with previous version
If the invite code has a person, skip personal data and also don't allow posting personal data. Don't show the personal data!
added 1 commit
Compare with previous version
needs https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/66
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 4 commits
Compare with previous version
added 4 commits
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 143 commits
master984125b3- Use correct new URL for invitation mails234e2f6c- Fix email handling412f5672- Fix invitation related step behavior60183db5- Fix mutation mail address handling3e77bff9- Implement correct rules handling1452558c- Add preference for visible fields443eec5d- Fix invitation handling in mutation74d035e4- Add info alert in case invitation was used609fa361- Reformateb884448- Fix typoCompare with previous version
added 1 commit
Compare with previous version
added 1 commit
13401fe6- Fix syntaxCompare with previous version
added 12 commits
master5cd381fc- Merge branch 'master' into 1225-rebuild-account-registration-formCompare with previous version
added 1 commit
d19915fd- ReformatCompare with previous version
added 1 commit
1a9621a8- Add username checkingCompare with previous version
added 1 commit
dce61e39- Add username checking in backgroundCompare with previous version
added 2 commits
8d29da0c- Removed unused CSS ruleCompare with previous version
added 1 commit
Compare with previous version
added 1 commit
3171cbcd- WIP: generalize multi-step form wizardCompare with previous version
created #1260 to continue this discussion
resolved all threads
mentioned in issue #1260
added 1 commit
eba6aad0- ReformatCompare with previous version
added 1 commit
019c9b11- Provide more helpful error messageCompare with previous version
added 1 commit
20682f90- Fix username rules mixinCompare with previous version
added 1 commit
068c7510- Change username site preference gql namingCompare with previous version
added 1 commit
680408ff- Fix email stepCompare with previous version
added 1 commit
ccd91918- Add privacy policy checkboxCompare with previous version
added 2 commits
7d801f6a- Add password validation in frontend7e5a7763- Validate password in backendCompare with previous version
added 2 commits
bc6b1652- Hide empty fields in person summary of account registration123b01bc- ReformatCompare with previous version
added 1 commit
c12a9c5a- Accept formatted codesCompare with previous version
added 1 commit
0f0e75c1- Hide name from PersonDetailsCard if emptyCompare with previous version
added 1 commit
Compare with previous version
added 2 commits
Compare with previous version
added 1 commit
Compare with previous version
added 3 commits
97f6e8b0- Remove Postbuero dependency878d25b8- Store registering person in request4135b892- Generalize account registration step injectionCompare with previous version
added 1 commit
b88be1f2- WIP: Remove Postbuero-specificsCompare with previous version
added 2 commits
7fa45e86- WIP: Remove Postbuero-specifics87e85ffa- Merge branch '1225-rebuild-account-registration-form' of...Compare with previous version
added 1 commit
8e086266- Refactor data structureCompare with previous version
added 1 commit
8d1e1322- Allow dynamic merging of registration mutationCompare with previous version
added 1 commit
fa140c22- Remove unused variableCompare with previous version
added 1 commit
12cff9ec- ReformatCompare with previous version
added 1 commit
16550477- Fix confirm button disabled statusCompare with previous version
added 1 commit
07b68699- Indicate registration process to other mutationsCompare with previous version
added 1 commit
08a0eb88- Show and save additional data also to invited personsCompare with previous version
added 1 commit
fe3a02d7- Do not overwrite address fields if not set in mutationCompare with previous version
added 1 commit
Compare with previous version
added 1 commit
43b09d03- Fix registration for invited persons without emailCompare with previous version
Should probably use consistent naming
This looks dangerous although I am not sure whether it's actually dangerous.
I don't think that it's a good idea to expose this information without any other security measures.
TODO
Please also drop the old view for account registration.
No idea what we should do instead.
changed this line in version 65 of the diff
changed this line in version 65 of the diff
changed this line in version 65 of the diff
changed this line in version 65 of the diff
added 1 commit
1d13369e- Fix code style issuesCompare with previous version
The URL must be hard-coded for now, until we get rid of the
/django/prefix for backend URLs..
added 3 commits
08a0eb88- Show and save additional data also to invited personsfe3a02d7- Do not overwrite address fields if not set in mutation9b31affa- Merge branch '1225-rebuild-account-registration-form' of...Compare with previous version
added 1 commit
0252b6a4- Use more consistent query namingCompare with previous version
changed this line in version 68 of the diff
added 1 commit
d80d7b14- Hard code signup url with invitation codeCompare with previous version
resolved all threads
added 2 commits
9ae502bb- Drop legacy invitation code view30283c0e- Drop legacy account registrationCompare with previous version
added 1 commit
cbf7ebe6- Drop unneeded importsCompare with previous version
changed the description
marked this merge request as ready
added 56 commits
master32d1a184- Merge branch 'master' into 1225-rebuild-account-registration-formCompare with previous version
assigned to @hansegucker and unassigned @yuha
requested review from @nik
added 1 commit
632aa12a- ReformatCompare with previous version
added 1 commit
e41b5337- Add changelogCompare with previous version
added 8 commits
master120bf233- Merge branch 'master' into 1225-rebuild-account-registration-formCompare with previous version
Unrelated
Unrelated
Unrelated
Unrelated
After this, a person
full_cleanshould be run.What? Please validate whether the newly added messages are necessary.
Please also update the changelog.
I think I did?
changed this line in version 75 of the diff
changed this line in version 75 of the diff
added 1 commit
Compare with previous version
changed this line in version 76 of the diff
changed this line in version 76 of the diff
added 1 commit
ac021ba3- ReformatCompare with previous version
added 1 commit
41a30513- Run full_clean before saving personCompare with previous version
added 1 commit
6aa5ef03- Remove unused translation stringCompare with previous version
added 1 commit
8c394349- Re-add optional address fieldCompare with previous version
added 1 commit
a3d826e4- Revert "Do not overwrite address fields if not set in mutation"Compare with previous version
added 1 commit
c621e494- Don't send address fields if empty in registrationCompare with previous version
resolved all threads
added 1 commit
ab598f7c- Fix extra mutation data not being sent via migrationCompare with previous version
approved this merge request
mentioned in commit
940fb9105b