Resolve "Implement ical alarms" #3168

Merged
hansegucker merged 9 commits from 1049-implement-ical-alarms into master 2024-12-22 11:45:40 +01:00
Member

Closes #1049

Closes #1049
Author
Member

assigned to @yuha

assigned to @yuha
Author
Member

mentioned in issue AlekSIS-App-Chronos#209

mentioned in issue AlekSIS-App-Chronos#209
Author
Member

added 1 commit

  • 60e71468 - WIP: Add CalendarAlarm

Compare with previous version

added 1 commit <ul><li>60e71468 - WIP: Add CalendarAlarm</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=45090&start_sha=75a22d52234b79df3b5c7036882ae65c30f5a657)
Author
Member

added 142 commits

  • 60e71468...9cb72beb - 141 commits from branch master
  • ba72b845 - WIP: Add CalendarAlarm

Compare with previous version

added 142 commits <ul><li>60e71468...9cb72beb - 141 commits from branch <code>master</code></li><li>ba72b845 - WIP: Add CalendarAlarm</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=46031&start_sha=60e714684ea85bd244772bc01b49ae1eb2d38783)
Author
Member

added 1 commit

  • 632e5b8d - WIP: Add CalendarAlarm

Compare with previous version

added 1 commit <ul><li>632e5b8d - WIP: Add CalendarAlarm</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=46284&start_sha=ba72b845b72eb8a9a17cc3772e81c9d16128c92e)
Author
Member

added 12 commits

  • 632e5b8d...df89f405 - 11 commits from branch master
  • 56cb204a - WIP: Add CalendarAlarm

Compare with previous version

added 12 commits <ul><li>632e5b8d...df89f405 - 11 commits from branch <code>master</code></li><li>56cb204a - WIP: Add CalendarAlarm</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=46285&start_sha=632e5b8de8ae477cd85140ed3b99934623e69dfc)
Author
Member

added 1 commit

  • a3f7392e - WIP: Add CalendarAlarm

Compare with previous version

added 1 commit <ul><li>a3f7392e - WIP: Add CalendarAlarm</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=46432&start_sha=56cb204aac7dd73d73cbf8427f70e80679579449)
Author
Member

added 30 commits

  • a3f7392e...24b7e16c - 29 commits from branch master
  • a85d4aa7 - WIP: Add CalendarAlarm

Compare with previous version

added 30 commits <ul><li>a3f7392e...24b7e16c - 29 commits from branch <code>master</code></li><li>a85d4aa7 - WIP: Add CalendarAlarm</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=46832&start_sha=a3f7392e69c649d3e1c0ca23d4eca4d1fb0a25a8)
Author
Member

added 1 commit

  • d6acffb1 - WIP: Add CalendarAlarm

Compare with previous version

added 1 commit <ul><li>d6acffb1 - WIP: Add CalendarAlarm</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=46833&start_sha=a85d4aa71db491411e2dbd1eb658b720855300ab)
Author
Member

added 1 commit

  • a5a6c1d8 - WIP: Add CalendarAlarm

Compare with previous version

added 1 commit <ul><li>a5a6c1d8 - WIP: Add CalendarAlarm</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=47054&start_sha=d6acffb15133c848851ad7f1df0806be02fbcab9)
Author
Member

added 1 commit

  • 8daf2892 - WIP: Add CalendarAlarm

Compare with previous version

added 1 commit <ul><li>8daf2892 - WIP: Add CalendarAlarm</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=47097&start_sha=a5a6c1d8187baa228a0da0d633adb54ded4a7924)
Author
Member

added 2 commits

  • 51d5b4a0 - Add CalendarAlarm
  • 6aa29138 - Allow for updating notifications of alarms

Compare with previous version

added 2 commits <ul><li>51d5b4a0 - Add CalendarAlarm</li><li>6aa29138 - Allow for updating notifications of alarms</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=47111&start_sha=8daf28921ab21b70cb824e212ff7a1965372497c)
Author
Member

added 1 commit

  • 6528792c - Allow for updating notifications of alarms

Compare with previous version

added 1 commit <ul><li>6528792c - Allow for updating notifications of alarms</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=47181&start_sha=6aa291385cfca9b6ff84838d974be7759fc7236f)
Author
Member

added 194 commits

  • 6528792c...cb265927 - 193 commits from branch master
  • f026e7d3 - Merge branch 'master' into 1049-implement-ical-alarms

Compare with previous version

added 194 commits <ul><li>6528792c...cb265927 - 193 commits from branch <code>master</code></li><li>f026e7d3 - Merge branch &#39;master&#39; into 1049-implement-ical-alarms</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=49911&start_sha=6528792c172ce305bb6de095c6191169f8a4995f)
Author
Member

marked this merge request as ready

marked this merge request as **ready**
Author
Member

added 1 commit

  • 815ddf28 - Reword code comment

Compare with previous version

added 1 commit <ul><li>815ddf28 - Reword code comment</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=49913&start_sha=f026e7d3d15d198aa83708619dfa0a9ae2c3d17a)
Author
Member

assigned to @hansegucker and unassigned @yuha

assigned to @hansegucker and unassigned @yuha
Author
Member

added 1 commit

Compare with previous version

added 1 commit <ul><li>0937f11d - Reword code comment</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=49945&start_sha=815ddf285ca459c0f5b5f4efa73d660163a1fbe9)
Author
Member

TODO: Bundling SMS/emails with many notifications at once (adjustable threshold)? Case: Teacher is on sick leave for 2 weeks and all lessons are substituted/ cancelled → medium two-digit number of notifications are created; although there is a logical bundling of all notifications, and it has no added value for all those involved to be notified individually. Idea: configurable daily digest per person?

TODO: Bundling SMS/emails with many notifications at once (adjustable threshold)? Case: Teacher is on sick leave for 2 weeks and all lessons are substituted/ cancelled → medium two-digit number of notifications are created; although there is a logical bundling of all notifications, and it has no added value for all those involved to be notified individually. Idea: configurable daily digest per person?
Author
Member

created #1136 to continue this discussion

created #1136 to continue this discussion
Author
Member

resolved all threads

resolved all threads
Author
Member

mentioned in issue #1136

mentioned in issue #1136
Owner

This is a probably broken, needs a condition to only apply if calendar_alarm is not None.

This is a probably broken, needs a condition to only apply if `calendar_alarm` is not `None`.
Owner

Please add docstrings to all value methods.

Please add docstrings to all value methods.
Author
Member

resolved all threads

resolved all threads
Author
Member

added 2 commits

  • e0d6ba03 - Add condition to notification unique constraint
  • 64bd80ca - Add docstrings

Compare with previous version

added 2 commits <ul><li>e0d6ba03 - Add condition to notification unique constraint</li><li>64bd80ca - Add docstrings</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=52866&start_sha=0937f11d396bf708c5621d0dbd1335385fcfedc6)
Author
Member

mentioned in merge request AlekSIS-App-Chronos!2005

mentioned in merge request AlekSIS-App-Chronos!2005
Author
Member

added 146 commits

  • 64bd80ca...4b2a44f1 - 145 commits from branch master
  • ae57959e - Merge branch 'master' into 1049-implement-ical-alarms

Compare with previous version

added 146 commits <ul><li>64bd80ca...4b2a44f1 - 145 commits from branch <code>master</code></li><li>ae57959e - Merge branch &#39;master&#39; into 1049-implement-ical-alarms</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=52874&start_sha=64bd80ca27d41ae46d8f581ec4c73fbc9c1f7626)
Author
Member

added 1 commit

Compare with previous version

added 1 commit <ul><li>5c1b256f - Fix typing</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=52876&start_sha=ae57959e80a7ee0d3d1e15421339068b8e576776)
Owner

added 1 commit

Compare with previous version

added 1 commit <ul><li>5db40fe2 - Update changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs?diff_id=52890&start_sha=5c1b256f9f2885c26564365a431d98e5cd9fa88c)
Owner

mentioned in commit a16ad7c0a5

mentioned in commit a16ad7c0a5260fa5059797ecf81edd59917f57f2
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!3168
No description provided.