aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Allow injecting widgets into all object views" #3105

Merged
hansegucker merged 37 commits from 122-allow-injecting-widgets-into-all-object-views into master 2024-09-17 15:32:27 +02:00
Conversation 39 Commits 37 Files changed 24 +785 -33
leuckeju commented 2024-05-02 19:08:17 +02:00
Member
Copy link

Closes #122

Closes #122
leuckeju commented 2024-05-08 16:10:31 +02:00
Author
Member
Copy link

added 6 commits

  • 82d73b5a...401ed17e - 5 commits from branch master
  • 1847dcc2 - Import collections and collection items from different apps. Merging still tbd

Compare with previous version

added 6 commits <ul><li>82d73b5a...401ed17e - 5 commits from branch <code>master</code></li><li>1847dcc2 - Import collections and collection items from different apps. Merging still tbd</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=42697&start_sha=82d73b5ae299288836415de14a31c0fb43addb27)
leuckeju commented 2024-05-11 16:50:39 +02:00
Author
Member
Copy link

added 16 commits

  • 1847dcc2...50fadace - 15 commits from branch master
  • 0ee66e70 - Import collections and collection items from different apps. Merging still tbd

Compare with previous version

added 16 commits <ul><li>1847dcc2...50fadace - 15 commits from branch <code>master</code></li><li>0ee66e70 - Import collections and collection items from different apps. Merging still tbd</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=42788&start_sha=1847dcc2599ba766b1f806b6761950990f717dc6)
leuckeju commented 2024-05-22 10:41:50 +02:00
Author
Member
Copy link

added 23 commits

  • 0ee66e70...27321636 - 22 commits from branch master
  • 016f711b - Import collections and collection items from different apps. Merging still tbd

Compare with previous version

added 23 commits <ul><li>0ee66e70...27321636 - 22 commits from branch <code>master</code></li><li>016f711b - Import collections and collection items from different apps. Merging still tbd</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=43227&start_sha=0ee66e7081b7f456c8ce4f032c7436b4c149f325)
leuckeju commented 2024-06-06 17:13:46 +02:00
Author
Member
Copy link

added 1 commit

  • f7aa0663 - Create generic merging importer

Compare with previous version

added 1 commit <ul><li>f7aa0663 - Create generic merging importer</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=43666&start_sha=016f711bcc821f12985ded509d9b84dfb5840781)
leuckeju commented 2024-06-07 17:49:29 +02:00
Author
Member
Copy link

added 45 commits

  • f7aa0663...b9517a6e - 43 commits from branch master
  • f5f28115 - Import collections and collection items from different apps. Merging still tbd
  • 24e33f51 - Create generic merging importer

Compare with previous version

added 45 commits <ul><li>f7aa0663...b9517a6e - 43 commits from branch <code>master</code></li><li>f5f28115 - Import collections and collection items from different apps. Merging still tbd</li><li>24e33f51 - Create generic merging importer</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=43761&start_sha=f7aa06637871c5e129882a17baeb1dcb6070770f)
leuckeju commented 2024-06-07 21:00:08 +02:00
Author
Member
Copy link

added 3 commits

  • 92ffc54f - Create collection transformer
  • b6b634e6 - Include collections via code, not via function
  • de58ce8c - Export collections as object

Compare with previous version

added 3 commits <ul><li>92ffc54f - Create collection transformer</li><li>b6b634e6 - Include collections via code, not via function</li><li>de58ce8c - Export collections as object</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=43765&start_sha=24e33f51a0aa7bb1ad3233fe07d006766687f261)
yuha commented 2024-08-21 20:48:04 +02:00
Member
Copy link

@ZugBahnHof whats the status here? Are you planning on working on this any time soon?

@ZugBahnHof whats the status here? Are you planning on working on this any time soon?
leuckeju commented 2024-09-03 17:25:58 +02:00
Author
Member
Copy link

added 268 commits

  • de58ce8c...66ab3eec - 263 commits from branch master
  • c73bff2a - Import collections and collection items from different apps. Merging still tbd
  • e0484ba9 - Create generic merging importer
  • 48b50255 - Create collection transformer
  • a4f1fbe0 - Include collections via code, not via function
  • 0d09bfb0 - Export collections as object

Compare with previous version

added 268 commits <ul><li>de58ce8c...66ab3eec - 263 commits from branch <code>master</code></li><li>c73bff2a - Import collections and collection items from different apps. Merging still tbd</li><li>e0484ba9 - Create generic merging importer</li><li>48b50255 - Create collection transformer</li><li>a4f1fbe0 - Include collections via code, not via function</li><li>0d09bfb0 - Export collections as object</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=47637&start_sha=de58ce8c785495283c984d3d89814ea38ff56b87)
leuckeju commented 2024-09-09 21:28:08 +02:00
Author
Member
Copy link

added 22 commits

  • 0d09bfb0...7d12df36 - 12 earlier commits
  • 7e91b308 - Make parent and child group lists expandable
  • 155bdc3a - Cleanup code
  • 6b3a089c - Change average datatype from int to float
  • e28d6903 - Require permission to view groups
  • 9b6fdd7a - Create basic component to display group member info
  • 0bdb7320 - Show injected member info on group page
  • 61364fba - Load more user data for group page
  • ecb7c60e - Load group avatars on person overview page
  • b955175e - Finish group overview translations
  • 060898ce - Reformat

Compare with previous version

added 22 commits <ul><li>0d09bfb0...7d12df36 - 12 earlier commits</li><li>7e91b308 - Make parent and child group lists expandable</li><li>155bdc3a - Cleanup code</li><li>6b3a089c - Change average datatype from int to float</li><li>e28d6903 - Require permission to view groups</li><li>9b6fdd7a - Create basic component to display group member info</li><li>0bdb7320 - Show injected member info on group page</li><li>61364fba - Load more user data for group page</li><li>ecb7c60e - Load group avatars on person overview page</li><li>b955175e - Finish group overview translations</li><li>060898ce - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=47676&start_sha=0d09bfb086da1d018e0f288562aad34ddba6d9c8)
leuckeju commented 2024-09-09 21:28:50 +02:00
Author
Member
Copy link

Bildschirmfoto_vom_2024-09-09_21-18-27

![Bildschirmfoto_vom_2024-09-09_21-18-27](/uploads/6752d2134d71711e752a1b6ff756043c/Bildschirmfoto_vom_2024-09-09_21-18-27.png)
leuckeju commented 2024-09-09 21:29:09 +02:00
Author
Member
Copy link

marked this merge request as ready

marked this merge request as **ready**
leuckeju commented 2024-09-09 21:29:16 +02:00
Author
Member
Copy link

assigned to @hansegucker

assigned to @hansegucker
leuckeju commented 2024-09-09 21:29:20 +02:00
Author
Member
Copy link

requested review from @hansegucker

requested review from @hansegucker
hansegucker commented 2024-09-11 14:25:55 +02:00
Owner
Copy link

What is the S for?

What is the `S` for?
hansegucker commented 2024-09-11 14:25:55 +02:00
Owner
Copy link

Debug log?

Debug log?
hansegucker commented 2024-09-11 14:25:55 +02:00
Owner
Copy link
        return root.get_group_stats()

?

```suggestion:-0+0 return root.get_group_stats() ``` ?
hansegucker commented 2024-09-11 14:25:55 +02:00
Owner
Copy link

Single group, isn't it?

          permission: "core.view_group_rule",
Single group, isn't it? ```suggestion:-0+0 permission: "core.view_group_rule", ```
hansegucker commented 2024-09-11 14:25:55 +02:00
Owner
Copy link

Please also add the collection for the persons page and adjust the person page accordingly.

Please also add the collection for the persons page and adjust the person page accordingly.
leuckeju commented 2024-09-11 18:43:29 +02:00
Author
Member
Copy link

This is a list of lists of collection items, so basically double plural

This is a list of lists of collection items, so basically double plural
leuckeju commented 2024-09-11 18:44:36 +02:00
Author
Member
Copy link

This is actually a property not a method, despite the name suggesting the latter

This is actually a property not a method, despite the name suggesting the latter
leuckeju commented 2024-09-11 18:45:37 +02:00
Author
Member
Copy link

I don't think we can check non-global permissions at this place, can we?

I don't think we can check non-global permissions at this place, can we?
leuckeju commented 2024-09-11 18:45:51 +02:00
Author
Member
Copy link

Can this maybe be a different merge request?

Can this maybe be a different merge request?
leuckeju commented 2024-09-11 18:46:13 +02:00
Author
Member
Copy link

Yes, will remove it

Yes, will remove it
leuckeju commented 2024-09-12 12:02:46 +02:00
Author
Member
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=47722&start_sha=060898cea574a8a98b036eb046b506f6f004c624#3a215dc075bcbf6df0b2fc2cf0dfe4d49f9bfb3c_203_203)
leuckeju commented 2024-09-12 12:02:47 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>082d901e - Remove debug print</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=47722&start_sha=060898cea574a8a98b036eb046b506f6f004c624)
leuckeju commented 2024-09-12 14:08:01 +02:00
Author
Member
Copy link

added 2 commits

  • 3e1c08bb - Allow customzing crudlist header fields
  • 06deedc9 - Use groupOverviewTabMixin in Group Overview Tabs

Compare with previous version

added 2 commits <ul><li>3e1c08bb - Allow customzing crudlist header fields</li><li>06deedc9 - Use groupOverviewTabMixin in Group Overview Tabs</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=47725&start_sha=082d901e971d42e5e09a01b84cf8823d3bdb1a12)
hansegucker commented 2024-09-12 19:35:32 +02:00
Owner
Copy link

I don't know, please check.

I don't know, please check.
hansegucker commented 2024-09-12 19:35:41 +02:00
Owner
Copy link

Yes

Yes
hansegucker commented 2024-09-12 19:35:56 +02:00
Owner
Copy link

What about collectionItemsList?

What about `collectionItemsList`?
leuckeju commented 2024-09-14 14:22:15 +02:00
Author
Member
Copy link

this still sounds to me as if it were a list of collectionItems. Then maybe something like collectionItemListList but that's equally cumbersome

this still sounds to me as if it were a list of collectionItems. Then maybe something like `collectionItemListList` but that's equally cumbersome
leuckeju commented 2024-09-14 16:09:58 +02:00
Author
Member
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=47739&start_sha=06deedc98895ce7eb02ec463367c81c2d2df668d#f3b09070d21b8a3db0f111ac66567324cc2bd287_189_183)
leuckeju commented 2024-09-14 16:09:58 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>b665ed2f - Show tab in url</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=47739&start_sha=06deedc98895ce7eb02ec463367c81c2d2df668d)
leuckeju commented 2024-09-14 16:33:16 +02:00
Author
Member
Copy link

added 1 commit

  • 2c07de2a - Allow key lookup in value field of crudlists

Compare with previous version

added 1 commit <ul><li>2c07de2a - Allow key lookup in value field of crudlists</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=47743&start_sha=b665ed2fad067aa29ad81c7aa2ca7037c51dd32c)
hansegucker commented 2024-09-16 17:38:29 +02:00
Owner
Copy link

resolved all threads

resolved all threads
leuckeju commented 2024-09-17 09:37:35 +02:00
Author
Member
Copy link

added 3 commits

Compare with previous version

added 3 commits <ul><li>3c21435d - Link to group members</li><li>5d2050b7 - Fix group overview urls</li><li>1193858a - Add `onlyShowCount` mode to counterchip</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=47765&start_sha=2c07de2a61468cac8fccc76578a6af5626c80c50)
leuckeju commented 2024-09-17 10:58:25 +02:00
Author
Member
Copy link

added 2 commits

  • beee7012 - Reformat
  • 44d6a76b - Show tooltip in GroupMembers open tab button

Compare with previous version

added 2 commits <ul><li>beee7012 - Reformat</li><li>44d6a76b - Show tooltip in GroupMembers open tab button</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=47775&start_sha=1193858ade9d2d8751c0e8dabcf459ea445c0645)
leuckeju commented 2024-09-17 11:20:46 +02:00
Author
Member
Copy link

added 1 commit

  • 52965e35 - Show tooltip in GroupMembers open tab button

Compare with previous version

added 1 commit <ul><li>52965e35 - Show tooltip in GroupMembers open tab button</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1460/diffs?diff_id=47779&start_sha=44d6a76bdbf28912e33c6aa512047913cf281853)
leuckeju commented 2024-09-17 11:35:43 +02:00
Author
Member
Copy link

requested review from @hansegucker

requested review from @hansegucker
hansegucker commented 2024-09-17 15:32:30 +02:00
Owner
Copy link

mentioned in commit 6fa761243e

mentioned in commit 6fa761243e3ba43d29e728d7f90f712592728723
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!3105
No description provided.