aleksis/AlekSIS-Core

Fork 0

WIP: Draft: Resolve "Do not restart vite serve on every uwsgi reload" #3085

Draft

hansegucker wants to merge 1 commit from 850-do-not-restart-vite-serve-on-every-uwsgi-reload into master

hansegucker commented

2024-03-27 16:43:44 +01:00

Owner

Closes #850

hansegucker commented

2024-03-27 16:45:28 +01:00

Author

Owner

added 1 commit

8ea45643 - Use smart daemon for Vite

Compare with previous version

added 1 commit <ul><li>8ea45643 - Use smart daemon for Vite</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1440/diffs?diff_id=41142&start_sha=e728a80ca5fac5c15c51de464affc79a6320122f)

hansegucker commented

2024-03-27 16:46:19 +01:00

Author

Owner

Problem: This works perfectly but stopping the server is a problem. uWSGI sends a termination signal to the outer Python process, but the inner Node process isn't affected by this signal.

leuckeju commented

2024-03-29 22:19:55 +01:00

Member

Possible fix: signal handler in django yarnpkg that will automatically kill the process when SIGTERM is received. Only problem: this will not work with SIGKILL

Current behaviour:

With signal:

(yes, I know, a video would demonstrate this better)

Possible fix: signal handler in django yarnpkg that will automatically kill the process when `SIGTERM` is received. Only problem: this will not work with `SIGKILL` Current behaviour: ![Bildschirmfoto_vom_2024-03-29_22-05-19](/uploads/d8e2c28113606c66d630644dc2d47a8f/Bildschirmfoto_vom_2024-03-29_22-05-19.png) With signal: ![Bildschirmfoto_vom_2024-03-29_22-16-44](/uploads/ab7a0dd2fc6a9c9e43350c487299d116/Bildschirmfoto_vom_2024-03-29_22-16-44.png) (yes, I know, a video would demonstrate this better)

This pull request has changes conflicting with the target branch.

aleksis/core/settings.py

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'WIP: Draft: Resolve "Do not restart vite serve on every uwsgi reload"' (#3085) from 850-do-not-restart-vite-serve-on-every-uwsgi-reload into master

Merge commit body

Reviewed-on: https://code.teckids.org/aleksis/AlekSIS-Core/pulls/3085

Merge pull request 'WIP: Draft: Resolve "Do not restart vite serve on every uwsgi reload"' (#3085) from 850-do-not-restart-vite-serve-on-every-uwsgi-reload into master

Reviewed-on: https://code.teckids.org/aleksis/AlekSIS-Core/pulls/3085

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 850-do-not-restart-vite-serve-on-every-uwsgi-reload:850-do-not-restart-vite-serve-on-every-uwsgi-reload

git switch 850-do-not-restart-vite-serve-on-every-uwsgi-reload

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master

git merge --no-ff 850-do-not-restart-vite-serve-on-every-uwsgi-reload

git switch 850-do-not-restart-vite-serve-on-every-uwsgi-reload

git rebase master

git switch master

git merge --ff-only 850-do-not-restart-vite-serve-on-every-uwsgi-reload

git switch 850-do-not-restart-vite-serve-on-every-uwsgi-reload

git rebase master

git switch master

git merge --no-ff 850-do-not-restart-vite-serve-on-every-uwsgi-reload

git switch master

git merge --squash 850-do-not-restart-vite-serve-on-every-uwsgi-reload