aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Factor out addresses into their own model" #2974

Merged
hansegucker merged 27 commits from 8-factor-out-addresses-into-their-own-model into master 2025-03-25 10:57:19 +01:00
Conversation 60 Commits 27 Files changed 25 +758 -109
lukasw commented 2023-10-06 10:23:05 +02:00
Contributor
Copy link

Closes #8

Closes #8
lukasw commented 2023-10-06 20:46:06 +02:00
Author
Contributor
Copy link

added 1 commit

  • 24b824af - Add adres model and migration from Person model

Compare with previous version

added 1 commit <ul><li>24b824af - Add adres model and migration from Person model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=34846&start_sha=4fc87f0f7e90dc13e9e5794c23829ec7dc559b8b)
lukasw commented 2023-10-11 10:03:18 +02:00
Author
Contributor
Copy link

added 1 commit

  • 736a5899 - Add adress model and migration from Person model

Compare with previous version

added 1 commit <ul><li>736a5899 - Add adress model and migration from Person model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=34868&start_sha=24b824afbcb476eb31365cbbca4467733ab8269d)
lukasw commented 2023-10-11 18:57:43 +02:00
Author
Contributor
Copy link

added 1 commit

  • 64b2b7cc - Add adress model and migration from Person model

Compare with previous version

added 1 commit <ul><li>64b2b7cc - Add adress model and migration from Person model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=34875&start_sha=736a5899740b9c053abcbc660f44ccb57d5feef6)
magicfelix commented 2023-10-14 14:57:36 +02:00
Member
Copy link

@lukasw the correct spelling is address, currently there is a d missing.

@lukasw the correct spelling is `address`, currently there is a `d` missing.
magicfelix commented 2023-10-14 15:04:59 +02:00
Member
Copy link

This will fail if there are multiple persons with the same address. Use get_or_create instead.

This will fail if there are multiple persons with the same address. Use `get_or_create` instead.
magicfelix commented 2023-10-14 15:04:59 +02:00
Member
Copy link

Just for better understandability in the code below I'd suggest to use p, or even person, as a variable name. Same thing for the j, which could be address.

Just for better understandability in the code below I'd suggest to use `p`, or even `person`, as a variable name. Same thing for the `j`, which could be `address`.
magicfelix commented 2023-10-14 15:04:59 +02:00
Member
Copy link

Because it's a ManyToManyField I'd suggest the name addresses.

Because it's a `ManyToManyField` I'd suggest the name `addresses`.
magicfelix commented 2023-10-14 19:11:23 +02:00
Member
Copy link

Sorry, wrong assumption. I expected a unique constraint.

But: Should my expectation be fulfilled, to make features like "Persons at this address" possible?
If so, editing must be handeled carefully. If multiple persons live at the same address and one moves away, this has to be represented by assigning a new/other address to that person, not by editing the address, because then the other persons would move too (at least in AlekSIS). In contrast to that, when editing in a case like fixing a typo, it is useful if that changes the address instead of creating and linking a new one.

Sorry, wrong assumption. I expected a unique constraint. But: Should my expectation be fulfilled, to make features like "Persons at this address" possible? If so, editing must be handeled carefully. If multiple persons live at the same address and one moves away, this has to be represented by assigning a new/other address to that person, not by editing the address, because then the other persons would move too (at least in AlekSIS). In contrast to that, when editing in a case like fixing a typo, it is useful if that changes the address instead of creating and linking a new one.
lukasw commented 2023-10-17 18:57:57 +02:00
Author
Contributor
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=35062&start_sha=64b2b7cc22b3e4c96215c50d4825fa836fcaccad#0a86e7f4ac950cbb72e0f6f9d0e7bf0c4e5ffebb_16_14)
lukasw commented 2023-10-17 18:57:58 +02:00
Author
Contributor
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=35062&start_sha=64b2b7cc22b3e4c96215c50d4825fa836fcaccad#0a86e7f4ac950cbb72e0f6f9d0e7bf0c4e5ffebb_14_14)
lukasw commented 2023-10-17 18:57:59 +02:00
Author
Contributor
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=35062&start_sha=64b2b7cc22b3e4c96215c50d4825fa836fcaccad#2e44ad1f61249cf0440bea20d23bd07cc7f3a61a_239_242)
lukasw commented 2023-10-17 18:57:59 +02:00
Author
Contributor
Copy link

added 1 commit

  • 3444beeb - Add adress model and migration from Person model

Compare with previous version

added 1 commit <ul><li>3444beeb - Add adress model and migration from Person model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=35062&start_sha=64b2b7cc22b3e4c96215c50d4825fa836fcaccad)
lukasw commented 2023-10-17 19:01:42 +02:00
Author
Contributor
Copy link

added 1 commit

  • 77c86a05 - Add adress model and migration from Person model

Compare with previous version

added 1 commit <ul><li>77c86a05 - Add adress model and migration from Person model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=35064&start_sha=3444beeb79d8822466d983ba36e3f672824c7bbb)
lukasw commented 2023-10-21 18:43:27 +02:00
Author
Contributor
Copy link

added 1 commit

  • e95d390b - Add adress model and migration from Person model

Compare with previous version

added 1 commit <ul><li>e95d390b - Add adress model and migration from Person model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=35207&start_sha=77c86a05d27d7a1fab8e7c2482227fbd8319ecf9)
lukasw commented 2023-12-06 19:09:25 +01:00
Author
Contributor
Copy link

added 64 commits

  • e95d390b...ffe4a694 - 58 commits from branch master
  • d60190df - Drop site framework
  • 80c6eb9d - Add some fixes to migrations
  • bfdb7d86 - Drop sites from migrations
  • 11e27ba7 - Fix migrations
  • b95c8e92 - Merge branch '742-remove-sites-framework' into 8-factor-out-addresses-into-their-own-model
  • fb7406bb - Fix migrations from merge

Compare with previous version

added 64 commits <ul><li>e95d390b...ffe4a694 - 58 commits from branch <code>master</code></li><li>d60190df - Drop site framework</li><li>80c6eb9d - Add some fixes to migrations</li><li>bfdb7d86 - Drop sites from migrations</li><li>11e27ba7 - Fix migrations</li><li>b95c8e92 - Merge branch &#39;742-remove-sites-framework&#39; into 8-factor-out-addresses-into-their-own-model</li><li>fb7406bb - Fix migrations from merge</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=36798&start_sha=e95d390b5719c7a1bf4f2e1edbddb56d85e7e83d)
lukasw commented 2023-12-13 19:03:45 +01:00
Author
Contributor
Copy link

added 16 commits

  • fb7406bb...99b990b4 - 15 commits from branch master
  • 6893e306 - Merge branch 'master' into 8-factor-out-addresses-into-their-own-model

Compare with previous version

added 16 commits <ul><li>fb7406bb...99b990b4 - 15 commits from branch <code>master</code></li><li>6893e306 - Merge branch &#39;master&#39; into 8-factor-out-addresses-into-their-own-model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=37202&start_sha=fb7406bb9ca75ca1304a5359ccdc24a75c54e57b)
hansegucker commented 2024-01-24 20:15:03 +01:00
Owner
Copy link

@lukasw Please rebase with current master

@lukasw Please rebase with current master
lukasw commented 2024-01-31 20:26:11 +01:00
Author
Contributor
Copy link

added 1 commit

  • 0e260279 - Fix bug on person overview page

Compare with previous version

added 1 commit <ul><li>0e260279 - Fix bug on person overview page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=38663&start_sha=6893e306ad029a52e94230717df6912ced2f6b15)
yuha commented 2024-01-31 20:30:17 +01:00
Member
Copy link

along the lines of addresses__street__icontains

along the lines of `addresses__street__icontains`
lukasw commented 2024-01-31 21:02:33 +01:00
Author
Contributor
Copy link

added 390 commits

  • 0e260279...5b42e097 - 386 commits from branch master
  • 9af81f17 - Add adress model and migration from Person model
  • 1dea4f2e - Drop site framework
  • b178ab41 - Fix migrations from merge
  • c2846146 - Fix bug on person overview page

Compare with previous version

added 390 commits <ul><li>0e260279...5b42e097 - 386 commits from branch <code>master</code></li><li>9af81f17 - Add adress model and migration from Person model</li><li>1dea4f2e - Drop site framework</li><li>b178ab41 - Fix migrations from merge</li><li>c2846146 - Fix bug on person overview page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=38667&start_sha=0e260279a3f5c36764c65b60fe4a47d9fcf22ba6)
lukasw commented 2024-01-31 21:10:37 +01:00
Author
Contributor
Copy link

added 5 commits

  • 273bfefa - Add adress model and migration from Person model
  • e537f7ed - Drop site framework
  • a1769503 - Fix migrations from merge
  • d8176677 - Fix bug on person overview page
  • 5308993c - Reformat

Compare with previous version

added 5 commits <ul><li>273bfefa - Add adress model and migration from Person model</li><li>e537f7ed - Drop site framework</li><li>a1769503 - Fix migrations from merge</li><li>d8176677 - Fix bug on person overview page</li><li>5308993c - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=38669&start_sha=c2846146adf470feaa92b31f0de192b4f9395339)
lukasw commented 2024-03-22 16:26:34 +01:00
Author
Contributor
Copy link

added 1 commit

  • 7eb2e59c - Fix migrations

Compare with previous version

added 1 commit <ul><li>7eb2e59c - Fix migrations</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=40955&start_sha=5308993cbfbb21f7d66d29ead5580af45395a6ee)
lukasw commented 2024-03-22 17:41:44 +01:00
Author
Contributor
Copy link

resolved all threads

resolved all threads
lukasw commented 2024-03-22 17:42:05 +01:00
Author
Contributor
Copy link

changed this line in version 13 of the diff

changed this line in [version 13 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=40957&start_sha=7eb2e59cf8f5fbafc3a9d1b32ed27e67fb8adaa3#0c1cc04efcd7070ff4e06723edf2d56455ff4095_62_60)
lukasw commented 2024-03-22 17:42:05 +01:00
Author
Contributor
Copy link

added 1 commit

  • bb6e7481 - Fix filter

Compare with previous version

added 1 commit <ul><li>bb6e7481 - Fix filter</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=40957&start_sha=7eb2e59cf8f5fbafc3a9d1b32ed27e67fb8adaa3)
nik commented 2024-03-26 12:08:33 +01:00
Owner
Copy link

Why is this a many-to-many field?

This should probably be an extra field on the through model of the Person->Address relation.

Why is this a many-to-many field? This should probably be an extra field on the `through` model of the Person->Address relation.
nik commented 2024-03-26 12:08:33 +01:00
Owner
Copy link

If we go for a structured fields approach, then this is missing, at least, a country field.

Have you done some research on best practices for moedelling an address?

If we go for a structured fields approach, then this is missing, at least, a country field. Have you done some research on best practices for moedelling an address?
nik commented 2024-03-26 12:08:33 +01:00
Owner
Copy link

This __str__ method is odd. Why does it only contain the street and housenumber?

This `__str__` method is odd. Why does it only contain the street and housenumber?
yuha commented 2024-05-29 20:48:36 +02:00
Member
Copy link

assigned to @lukasw

assigned to @lukasw
hansegucker commented 2024-06-19 20:56:45 +02:00
Owner
Copy link

https://pypi.org/project/django-countries/

https://pypi.org/project/django-countries/
lukasw commented 2024-06-26 11:44:20 +02:00
Author
Contributor
Copy link

added 259 commits

  • bb6e7481...b87afe9b - 252 commits from branch master
  • 684c5b5f - Add adress model and migration from Person model
  • 47f6c66d - Drop site framework
  • b2f3c164 - Fix migrations from merge
  • 7b9b3795 - Fix bug on person overview page
  • 1ca6608b - Reformat
  • b3bcffe0 - Fix migrations
  • 2b206315 - Fix filter

Compare with previous version

added 259 commits <ul><li>bb6e7481...b87afe9b - 252 commits from branch <code>master</code></li><li>684c5b5f - Add adress model and migration from Person model</li><li>47f6c66d - Drop site framework</li><li>b2f3c164 - Fix migrations from merge</li><li>7b9b3795 - Fix bug on person overview page</li><li>1ca6608b - Reformat</li><li>b3bcffe0 - Fix migrations</li><li>2b206315 - Fix filter</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=44398&start_sha=bb6e7481c6964b6b5d1403fba38cff212ee5d67e)
lukasw commented 2024-07-14 21:53:29 +02:00
Author
Contributor
Copy link

changed this line in version 15 of the diff

changed this line in [version 15 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=45194&start_sha=2b206315e2f7629da3bdb47d7923fb0738b2c91b#2e44ad1f61249cf0440bea20d23bd07cc7f3a61a_177_179)
lukasw commented 2024-07-14 21:53:30 +02:00
Author
Contributor
Copy link

added 1 commit

  • 0dfcad15 - Fix Address migration

Compare with previous version

added 1 commit <ul><li>0dfcad15 - Fix Address migration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=45194&start_sha=2b206315e2f7629da3bdb47d7923fb0738b2c91b)
lukasw commented 2024-07-16 14:27:55 +02:00
Author
Contributor
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>28d148bc - Fix Address migration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=45230&start_sha=0dfcad159d1d674fdd874b3917b12dab31be8820)
hansegucker commented 2024-07-16 14:31:43 +02:00
Owner
Copy link

resolved all threads

resolved all threads
lukasw commented 2024-07-16 17:49:49 +02:00
Author
Contributor
Copy link

@ZugBahnHof How do I continue now?
Right now the only thing missing is the frontend to edit / create a Person with the new address model. @hansegucker said the page needs to be redone in Vue, since it would not be efficient to change the page when it gets redone with Vue anyway.

@ZugBahnHof How do I continue now? Right now the only thing missing is the frontend to edit / create a Person with the new address model. @hansegucker said the page needs to be redone in Vue, since it would not be efficient to change the page when it gets redone with Vue anyway.
hansegucker commented 2025-02-02 19:46:14 +01:00
Owner
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=55268&start_sha=28d148bcffdda4543bb2dd96179bf938a6880e63#2e44ad1f61249cf0440bea20d23bd07cc7f3a61a_171_188)
hansegucker commented 2025-02-02 19:46:16 +01:00
Owner
Copy link

added 673 commits

  • 28d148bc...e45069f4 - 671 commits from branch master
  • 9cdf913c - Fix Lukas
  • f94f75ac - Merge branch 'master' into 8-factor-out-addresses-into-their-own-model

Compare with previous version

added 673 commits <ul><li>28d148bc...e45069f4 - 671 commits from branch <code>master</code></li><li>9cdf913c - Fix Lukas</li><li>f94f75ac - Merge branch &#39;master&#39; into 8-factor-out-addresses-into-their-own-model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=55268&start_sha=28d148bcffdda4543bb2dd96179bf938a6880e63)
hansegucker commented 2025-02-02 19:50:19 +01:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>4de7d5d9 - Fix lint</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=55270&start_sha=f94f75acdae902332dc53838b71621084014e121)
hansegucker commented 2025-02-02 20:06:43 +01:00
Owner
Copy link

added 2 commits

  • fd2a0412 - Fix migration history
  • b4ab6e1f - Make id field on PersonType nullable as DummyPerson has no ID

Compare with previous version

added 2 commits <ul><li>fd2a0412 - Fix migration history</li><li>b4ab6e1f - Make id field on PersonType nullable as DummyPerson has no ID</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=55274&start_sha=4de7d5d9b672b1ff7896aafae97a704d3c238c5b)
hansegucker commented 2025-02-02 20:08:04 +01:00
Owner
Copy link

added 16 commits

  • b4ab6e1f...46c13fe6 - 6 earlier commits
  • 00cdf546 - Reformat
  • a1c1def9 - Fix pyproject.toml
  • fcf0b90c - Improve column layout for editing persons
  • 1d3f06a1 - Improve column layout for editing persons
  • e7d3686e - Add FileField
  • a74b4067 - Merge branch '1107-vue-rework-person-create-edit' of...
  • 01cee55f - Merge branch 'master' into 1107-vue-rework-person-create-edit
  • 5ddcd57e - Reformat
  • 7e5deb3a - Add photo and avatar upload inputs to person creation form
  • bac9b3a9 - Merge branch '1107-vue-rework-person-create-edit' into 8-factor-out-addresses-into-their-own-model

Compare with previous version

added 16 commits <ul><li>b4ab6e1f...46c13fe6 - 6 earlier commits</li><li>00cdf546 - Reformat</li><li>a1c1def9 - Fix pyproject.toml</li><li>fcf0b90c - Improve column layout for editing persons</li><li>1d3f06a1 - Improve column layout for editing persons</li><li>e7d3686e - Add FileField</li><li>a74b4067 - Merge branch &#39;1107-vue-rework-person-create-edit&#39; of...</li><li>01cee55f - Merge branch &#39;master&#39; into 1107-vue-rework-person-create-edit</li><li>5ddcd57e - Reformat</li><li>7e5deb3a - Add photo and avatar upload inputs to person creation form</li><li>bac9b3a9 - Merge branch &#39;1107-vue-rework-person-create-edit&#39; into 8-factor-out-addresses-into-their-own-model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=55275&start_sha=b4ab6e1fd22589c48f5b651e025556fee18d634b)
hansegucker commented 2025-02-03 12:27:22 +01:00
Owner
Copy link

added 27 commits

  • bac9b3a9...2c0bb2e0 - 17 earlier commits
  • e35deb3f - Rearrange fields in person form
  • 7ed2bd6c - Add titles to person form
  • 520feaa1 - De-duplicate keys
  • cb2a95f4 - Rename sex choices to uppercase
  • 96b9c86f - Use sexSelectField
  • 357c2a43 - Merge branch '1110-introduce-non-dialog-object-form' into 1107-vue-rework-person-create-edit
  • a4396236 - Fix indefinite loading
  • 6c7c44e1 - Merge branch '1110-introduce-non-dialog-object-form' into 1107-vue-rework-person-create-edit
  • 6e183643 - WIP: Disable fields based on preference when editing own person
  • a6dade03 - Merge branch '1107-vue-rework-person-create-edit' into 8-factor-out-addresses-into-their-own-model

Compare with previous version

added 27 commits <ul><li>bac9b3a9...2c0bb2e0 - 17 earlier commits</li><li>e35deb3f - Rearrange fields in person form</li><li>7ed2bd6c - Add titles to person form</li><li>520feaa1 - De-duplicate keys</li><li>cb2a95f4 - Rename sex choices to uppercase</li><li>96b9c86f - Use sexSelectField</li><li>357c2a43 - Merge branch &#39;1110-introduce-non-dialog-object-form&#39; into 1107-vue-rework-person-create-edit</li><li>a4396236 - Fix indefinite loading</li><li>6c7c44e1 - Merge branch &#39;1110-introduce-non-dialog-object-form&#39; into 1107-vue-rework-person-create-edit</li><li>6e183643 - WIP: Disable fields based on preference when editing own person</li><li>a6dade03 - Merge branch &#39;1107-vue-rework-person-create-edit&#39; into 8-factor-out-addresses-into-their-own-model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=55303&start_sha=bac9b3a9bc12a30d0390fc8622313d8fbeb41281)
hansegucker commented 2025-02-09 12:42:49 +01:00
Owner
Copy link

added 1 commit

  • 79283a39 - Create and update default address in person mutation

Compare with previous version

added 1 commit <ul><li>79283a39 - Create and update default address in person mutation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=55459&start_sha=a6dade03ef58058ef01c65ef7863dfe1536033e1)
yuha commented 2025-03-18 00:11:11 +01:00
Member
Copy link

added 357 commits

  • 79283a39...017729df - 356 commits from branch master
  • 1e55bff0 - Merge branch 'master' into 8-factor-out-addresses-into-their-own-model

Compare with previous version

added 357 commits <ul><li>79283a39...017729df - 356 commits from branch <code>master</code></li><li>1e55bff0 - Merge branch &#39;master&#39; into 8-factor-out-addresses-into-their-own-model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=57305&start_sha=79283a39ca3d10117fb953982eee51fd3b4c9c37)
yuha commented 2025-03-18 00:19:08 +01:00
Member
Copy link

added 1 commit

  • aab1474c - Fix address handling in frontend

Compare with previous version

added 1 commit <ul><li>aab1474c - Fix address handling in frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=57308&start_sha=1e55bff0f8e11a795954914f7830c92d8317057a)
yuha commented 2025-03-18 00:21:06 +01:00
Member
Copy link

added 3 commits

  • 826710bf - Add default item and set isCreate value
  • d422fb1c - Fix default item handling
  • 3e02a82c - Merge branch '1234-personform-does-not-work-in-create-mode' into...

Compare with previous version

added 3 commits <ul><li>826710bf - Add default item and set isCreate value</li><li>d422fb1c - Fix default item handling</li><li>3e02a82c - Merge branch &#39;1234-personform-does-not-work-in-create-mode&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=57310&start_sha=aab1474c50bc915f1fcf6267ae42c72daef93a79)
yuha commented 2025-03-18 00:21:14 +01:00
Member
Copy link

marked this merge request as ready

marked this merge request as **ready**
yuha commented 2025-03-18 00:21:19 +01:00
Member
Copy link

assigned to @hansegucker and unassigned @lukasw

assigned to @hansegucker and unassigned @lukasw
yuha commented 2025-03-18 00:24:09 +01:00
Member
Copy link

works just fine now. should the country field be usable in the frontend? ( @hansegucker )

works just fine now. should the country field be usable in the frontend? ( @hansegucker )
hansegucker commented 2025-03-19 19:59:33 +01:00
Owner
Copy link
                      {{ address.postalCode }} {{ address.place }},

and the last comma only if country is set

```suggestion:-0+0 {{ address.postalCode }} {{ address.place }}, ``` and the last comma only if country is set
hansegucker commented 2025-03-19 20:00:15 +01:00
Owner
Copy link

@yuha Please also resolve conflicts.

@yuha Please also resolve conflicts.
yuha commented 2025-03-20 10:16:05 +01:00
Member
Copy link

todo: add country field

todo: add country field
magicfelix commented 2025-03-21 08:46:48 +01:00
Member
Copy link

added 1 commit

  • aff2719f - Add addresses to Organisation

Compare with previous version

added 1 commit <ul><li>aff2719f - Add addresses to Organisation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=57475&start_sha=3e02a82c45e7fd97e5fc4a7a49dc71c38ec1460a)
magicfelix commented 2025-03-21 09:03:03 +01:00
Member
Copy link

added 15 commits

  • aff2719f...c0264945 - 14 commits from branch master
  • b03a1e99 - Merge branch 'master' into 8-factor-out-addresses-into-their-own-model

Compare with previous version

added 15 commits <ul><li>aff2719f...c0264945 - 14 commits from branch <code>master</code></li><li>b03a1e99 - Merge branch &#39;master&#39; into 8-factor-out-addresses-into-their-own-model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=57482&start_sha=aff2719f4c044a95d6fa65cf958bb6add1eb047a)
magicfelix commented 2025-03-21 09:08:45 +01:00
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>72d6b5f6 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=57484&start_sha=b03a1e9972674b439ed2b26bea241712192ec1b9)
yuha commented 2025-03-24 01:29:38 +01:00
Member
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>41adb223 - Add CountryField</li><li>09447fea - Remove duplicated mounted hook</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=57662&start_sha=72d6b5f64a0a7ade43bfaf0b84cfd1ccccfa81de)
yuha commented 2025-03-24 01:38:11 +01:00
Member
Copy link

resolved all threads

resolved all threads
yuha commented 2025-03-24 01:50:15 +01:00
Member
Copy link

changed this line in version 32 of the diff

changed this line in [version 32 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=57668&start_sha=09447fea775cbb84bd8bdd4a2badbeb4144f3806#648c975cc51a7e0a9a106524ee68e76c0405046a_106_103)
yuha commented 2025-03-24 01:50:15 +01:00
Member
Copy link

added 2 commits

  • 09c7a917 - Add clearable prop to country field
  • d630f22e - Fix formatting of address in person overview

Compare with previous version

added 2 commits <ul><li>09c7a917 - Add clearable prop to country field</li><li>d630f22e - Fix formatting of address in person overview</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1329/diffs?diff_id=57668&start_sha=09447fea775cbb84bd8bdd4a2badbeb4144f3806)
hansegucker commented 2025-03-25 10:57:21 +01:00
Owner
Copy link

mentioned in commit 32bbc80647

mentioned in commit 32bbc806476f388a03c3652d5e54ec362c671b55
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2974
No description provided.