AlekSIS-Core 4.0: Resolve "Add preference for disallowed usernames"

lukasw commented

2023-05-20 14:26:22 +02:00

Contributor

Closes #622

lukasw commented

2023-05-20 14:26:22 +02:00

Author

Contributor

assigned to @lukasw

lukasw commented

2023-05-20 15:52:16 +02:00

Author

Contributor

added 1 commit

9af692d6 - Add preference for disallowed usernames

Compare with previous version

added 1 commit <ul><li>9af692d6 - Add preference for disallowed usernames</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1239/diffs?diff_id=30099&start_sha=95869ff18a8924eadd79a890537f4beaa7f01751)

lukasw commented

2023-05-20 16:09:37 +02:00

Author

Contributor

marked this merge request as ready

marked this merge request as **ready**

lukasw commented

2023-05-20 16:30:42 +02:00

Author

Contributor

added 1 commit

2a02c6d0 - Add preference for disallowed usernames

Compare with previous version

added 1 commit <ul><li>2a02c6d0 - Add preference for disallowed usernames</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1239/diffs?diff_id=30101&start_sha=9af692d6b422ff16d55bf083f258f1d242dc40d4)

hansegucker commented

2023-05-24 19:37:40 +02:00

Owner

assigned to @hansegucker and unassigned @lukasw

hansegucker commented

2023-05-24 19:38:57 +02:00

Owner

    verbose_name = _("Comma-separated list of disallowed usernames")

```suggestion:-0+0 verbose_name = _("Comma-separated list of disallowed usernames") ```

lukasw commented

2023-06-10 16:10:22 +02:00

Author

Contributor

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1239/diffs?diff_id=30718&start_sha=2a02c6d0d4be97ef7281a709a7cc1a87b6f5e87b#cedfd047579474194a5f10a12c798242313675da_494_494)

lukasw commented

2023-06-10 16:10:24 +02:00

Author

Contributor

added 1 commit

90df2bdf - Add preference for disallowed usernames

Compare with previous version

added 1 commit <ul><li>90df2bdf - Add preference for disallowed usernames</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1239/diffs?diff_id=30718&start_sha=2a02c6d0d4be97ef7281a709a7cc1a87b6f5e87b)

lukasw commented

2023-06-14 19:06:48 +02:00

Author

Contributor

resolved all threads

leuckeju commented

2023-06-21 19:30:14 +02:00

Member

Blocked until next major release

leuckeju commented

2023-06-21 19:30:30 +02:00

Member

changed title from Resolve "Add preference for disallowed usernames" to {+AlekSIS-Core 4.0: +}Resolve "Add preference for disallowed usernames"

changed title from **Resolve "Add preference for disallowed usernames"** to **{+AlekSIS-Core 4.0: +}Resolve "Add preference for disallowed usernames"**

hansegucker commented

2023-06-26 21:18:28 +02:00

Owner

unassigned @hansegucker

nik commented

2023-07-20 23:43:16 +02:00

Owner

@lukasw Please add a data check that checks all existing users for invalid names

hansegucker commented

2023-08-30 19:45:21 +02:00

Owner

marked this merge request as draft

marked this merge request as **draft**

hansegucker commented

2023-08-30 19:45:37 +02:00

Owner

@lukasw Please DO this!

nik commented

2023-09-10 21:12:20 +02:00

Owner

@lukasw Last reminder!

lukasw commented

2023-09-12 16:47:09 +02:00

Author

Contributor

added 1 commit

b888bc0e - Add preference for disallowed usernames

Compare with previous version

added 1 commit <ul><li>b888bc0e - Add preference for disallowed usernames</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1239/diffs?diff_id=34253&start_sha=90df2bdf1e60b23c3f2a3114d1737e705c7f5e80)

lukasw commented

2023-09-24 09:42:19 +02:00

Author

Contributor

added 519 commits

b888bc0e...5b218aba - 518 commits from branch master
761b602a - Merge branch 'master' into 622-add-preference-for-disallowed-usernames

Compare with previous version

added 519 commits <ul><li>b888bc0e...5b218aba - 518 commits from branch <code>master</code></li><li>761b602a - Merge branch 'master' into 622-add-preference-for-disallowed-usernames</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1239/diffs?diff_id=34566&start_sha=b888bc0ea297643c5fefd7f2543a85d72d579958)

lukasw commented

2023-09-27 17:56:14 +02:00

Author

Contributor

added 102 commits

761b602a...4ff1eebc - 101 commits from branch master
c6640f29 - Merge branch 'master' into 622-add-preference-for-disallowed-usernames

Compare with previous version

added 102 commits <ul><li>761b602a...4ff1eebc - 101 commits from branch <code>master</code></li><li>c6640f29 - Merge branch 'master' into 622-add-preference-for-disallowed-usernames</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1239/diffs?diff_id=34601&start_sha=761b602a0643ede3e2688c327ff0ad042dcff3c0)

lukasw commented

2023-09-30 11:43:43 +02:00

Author

Contributor

added 1 commit

5d039422 - Add user to ABSOLUTE_URL_OVERRIDES

Compare with previous version

added 1 commit <ul><li>5d039422 - Add user to ABSOLUTE_URL_OVERRIDES</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1239/diffs?diff_id=34648&start_sha=c6640f29d1782331aa1d53ebdc569e73fdb79e5e)

lukasw commented

2023-09-30 11:44:44 +02:00

Author

Contributor

marked this merge request as ready

marked this merge request as **ready**

lukasw commented

2023-09-30 12:18:44 +02:00

Author

Contributor

resolved all threads

hansegucker commented

2023-09-30 16:15:02 +02:00

Owner

approved this merge request

hansegucker commented

2023-09-30 16:15:09 +02:00

Owner

assigned to @nik

hansegucker commented

2024-01-19 20:04:58 +01:00

Owner

added 216 commits

5d039422...b58ea56b - 214 commits from branch master
12eb33aa - Add preference for disallowed usernames
e20859be - Add user to ABSOLUTE_URL_OVERRIDES

Compare with previous version

added 216 commits <ul><li>5d039422...b58ea56b - 214 commits from branch <code>master</code></li><li>12eb33aa - Add preference for disallowed usernames</li><li>e20859be - Add user to ABSOLUTE_URL_OVERRIDES</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1239/diffs?diff_id=38210&start_sha=5d0394223efff6c3f7888e41e843bc3890c99f48)

hansegucker commented

2024-01-19 20:06:36 +01:00

Owner

        for user in User.objects.filter(username__in=disallowed_uids):

```suggestion:-2+0 for user in User.objects.filter(username__in=disallowed_uids): ```

hansegucker commented

2024-01-19 20:07:21 +01:00

Owner

        raise ValidationError(_("This username is not allowed."))

```suggestion:-0+0 raise ValidationError(_("This username is not allowed.")) ```

hansegucker commented

2024-01-21 12:44:17 +01:00

Owner

@lukasw Please test my annotations.

lukasw commented

2024-01-24 18:46:04 +01:00

Author

Contributor

Works

leuckeju commented

2024-01-24 20:24:34 +01:00

Member

resolved all threads

leuckeju commented

2024-01-24 20:24:34 +01:00

Member

resolved all threads

leuckeju commented

2024-01-24 20:24:37 +01:00

Member

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1239/diffs?diff_id=38379&start_sha=e20859be9b8059357316022c8844f0253eb047e7#661b850301b994346247864bfbf021bc77433085_403_401)

leuckeju commented

2024-01-24 20:24:38 +01:00

Member

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1239/diffs?diff_id=38379&start_sha=e20859be9b8059357316022c8844f0253eb047e7#02bae0c02e44947674e21057814a24167932cb23_155_155)

leuckeju commented

2024-01-24 20:24:38 +01:00

Member

added 1 commit

f3ff1866 - Simplify queryset for disallowed usernames; fix validation error message

Compare with previous version

added 1 commit <ul><li>f3ff1866 - Simplify queryset for disallowed usernames; fix validation error message</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1239/diffs?diff_id=38379&start_sha=e20859be9b8059357316022c8844f0253eb047e7)

leuckeju commented

2024-01-24 20:24:55 +01:00

Member

assigned to @hansegucker and unassigned @nik

hansegucker scheduled this pull request to auto merge when all checks succeed

2024-01-24 20:25:40 +01:00

hansegucker canceled auto merging this pull request when all checks succeed

2024-01-24 20:35:45 +01:00

hansegucker commented

2024-01-24 20:36:10 +01:00

Owner

        for user in User.objects.filter(username__in=disallowed_uids):
            logging.info(f"Check User {user}")
            cls.register_result(user)

```suggestion:-2+0 for user in User.objects.filter(username__in=disallowed_uids): logging.info(f"Check User {user}") cls.register_result(user) ```

hansegucker commented

2024-01-24 20:36:42 +01:00

Owner

resolved all threads

hansegucker commented

2024-01-24 20:36:45 +01:00

Owner

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1239/diffs?diff_id=38381&start_sha=f3ff186650be3ce0a30ea572e681d2bdc3257b3f#661b850301b994346247864bfbf021bc77433085_403_402)

hansegucker commented

2024-01-24 20:36:46 +01:00

Owner

added 1 commit

71991917 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>71991917 - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1239/diffs?diff_id=38381&start_sha=f3ff186650be3ce0a30ea572e681d2bdc3257b3f)

hansegucker merged commit c41b75bf2e into master

2024-01-26 21:40:57 +01:00

hansegucker commented

2024-01-26 21:40:59 +01:00

Owner

mentioned in commit c41b75bf2e

mentioned in commit c41b75bf2e4924f7c1bc645476bf24058d3d2206

Rows
Columns

AlekSIS-Core 4.0: Resolve "Add preference for disallowed usernames" #2884