aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Finalise Vuetify app as SPA" #2768

Merged
hansegucker merged 264 commits from 759-finalise-vuetify-app-as-spa into master 2023-01-18 01:20:29 +01:00
Conversation 284 Commits 264 Files changed 144 +5712 -2678
yuha commented 2022-12-05 21:31:52 +01:00
Member
Copy link

Closes #759

Closes #759
yuha commented 2022-12-05 21:31:53 +01:00
Author
Member
Copy link

assigned to @yuha

assigned to @yuha
yuha commented 2022-12-17 10:41:07 +01:00
Author
Member
Copy link

added 1 commit

  • 51a8aca0 - WIP Current changes

Compare with previous version

added 1 commit <ul><li>51a8aca0 - WIP Current changes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26064&start_sha=130c005a8c393ee0a1d0c5857b031bd9063904c8)
hansegucker commented 2022-12-17 18:16:23 +01:00
Owner
Copy link

added 36 commits

  • 51a8aca0...092963f4 - 35 commits from branch master
  • 7b1cdfbe - WIP WIP WIP – SPA

Compare with previous version

added 36 commits <ul><li>51a8aca0...092963f4 - 35 commits from branch <code>master</code></li><li>7b1cdfbe - WIP WIP WIP – SPA</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26110&start_sha=51a8aca03625ed5e2bdb40889c4d31cd728bb327)
hansegucker commented 2022-12-18 12:58:59 +01:00
Owner
Copy link

added 1 commit

  • fae6596d - Start migrating AlekSIS with Vue and Vuetify to a SPA

Compare with previous version

added 1 commit <ul><li>fae6596d - Start migrating AlekSIS with Vue and Vuetify to a SPA</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26168&start_sha=7b1cdfbebb1c65d00ae6296cc3eef1ca5c4fc8d1)
hansegucker commented 2022-12-18 13:30:20 +01:00
Owner
Copy link

added 27 commits

  • fae6596d...e0a04831 - 25 commits from branch master
  • 5923a7fb - Start migrating AlekSIS with Vue and Vuetify to a SPA
  • 2b95ac4c - Redirect all URLs to the SPA

Compare with previous version

added 27 commits <ul><li>fae6596d...e0a04831 - 25 commits from branch <code>master</code></li><li>5923a7fb - Start migrating AlekSIS with Vue and Vuetify to a SPA</li><li>2b95ac4c - Redirect all URLs to the SPA</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26178&start_sha=fae6596dc2dfd19c94e0f6078d7d52a9da836c12)
hansegucker commented 2022-12-18 13:47:54 +01:00
Owner
Copy link

added 3 commits

  • 5b3c5b36 - Correctly integrate notifications with new SPA
  • 514879c0 - Reformat
  • 0ef572f5 - Remove extra margin around iframe for legacy pages

Compare with previous version

added 3 commits <ul><li>5b3c5b36 - Correctly integrate notifications with new SPA</li><li>514879c0 - Reformat</li><li>0ef572f5 - Remove extra margin around iframe for legacy pages</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26182&start_sha=2b95ac4c3058e62f635dbc8b3dd965adb72d395e)
hansegucker commented 2022-12-18 14:26:35 +01:00
Owner
Copy link

added 1 commit

  • 2bec3b75 - Optimize GraphQL queries and reformat

Compare with previous version

added 1 commit <ul><li>2bec3b75 - Optimize GraphQL queries and reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26194&start_sha=0ef572f5ddc4f3781389e420e8763c820561a0e7)
nik commented 2022-12-18 19:47:10 +01:00
Owner
Copy link

Use self-closing tags.

Use self-closing tags.
nik commented 2022-12-18 20:05:47 +01:00
Owner
Copy link

This should not be hard-coded. Instead, the GraphQL endpoint should return the fallback URL.

This should not be hard-coded. Instead, the GraphQL endpoint should return the fallback URL.
nik commented 2022-12-18 20:05:48 +01:00
Owner
Copy link

Do not use inline styles.

Do not use inline styles.
nik commented 2022-12-18 20:05:48 +01:00
Owner
Copy link

TODO

(This thread is only here to track this comment in the MR)

`TODO` (This thread is only here to track this comment in the MR)
nik commented 2022-12-18 20:05:48 +01:00
Owner
Copy link

Use self-closing tags in SFCs.

Use self-closing tags in SFCs.
nik commented 2022-12-18 20:05:48 +01:00
Owner
Copy link

Use self-closing tags in SFCs.

Use self-closing tags in SFCs.
nik commented 2022-12-18 20:05:49 +01:00
Owner
Copy link

That line break looks cool ;)

That line break looks cool ;)
nik commented 2022-12-18 20:05:49 +01:00
Owner
Copy link

Use self-closing tags.

Use self-closing tags.
nik commented 2022-12-18 20:05:49 +01:00
Owner
Copy link

Use self-closing tags.

Use self-closing tags.
nik commented 2022-12-18 20:05:49 +01:00
Owner
Copy link

Use self-closing tags.

Use self-closing tags.
nik commented 2022-12-18 20:05:49 +01:00
Owner
Copy link

Broken syntax?

Broken syntax?
nik commented 2022-12-18 20:05:50 +01:00
Owner
Copy link

Use self-closing tags.

Use self-closing tags.
nik commented 2022-12-18 20:05:50 +01:00
Owner
Copy link

Use self-closing tags.

Use self-closing tags.
nik commented 2022-12-18 20:05:50 +01:00
Owner
Copy link

Uncomment or remove

Uncomment or remove
nik commented 2022-12-18 20:05:50 +01:00
Owner
Copy link

Use self-closing tags.

Use self-closing tags.
nik commented 2022-12-18 20:05:51 +01:00
Owner
Copy link

Replace require with an import.

Replace `require` with an `import`.
nik commented 2022-12-18 20:05:51 +01:00
Owner
Copy link

Replace require with an import.

Replace `require` with an `import`.
nik commented 2022-12-18 20:05:51 +01:00
Owner
Copy link

Replace require with an import.

Replace `require` with an `import`.
nik commented 2022-12-18 20:05:51 +01:00
Owner
Copy link

Replace require with an import.

Replace `require` with an `import`.
nik commented 2022-12-18 20:05:52 +01:00
Owner
Copy link

Shouldn't this be part of the whoAmI query?

Shouldn't this be part of the `whoAmI` query?
nik commented 2022-12-18 20:05:52 +01:00
Owner
Copy link

FIXME

`FIXME`
nik commented 2022-12-18 20:05:52 +01:00
Owner
Copy link

We should only have one whoAmI query, and we should watch it.

It could be split into fragments, like one for preferences, to optimize caching, though.

We should only have one `whoAmI` query, and we should watch it. It could be split into fragments, like one for preferences, to optimize caching, though.
nik commented 2022-12-18 20:05:52 +01:00
Owner
Copy link

See above; should probably be part of the whoAmI query.

See above; should probably be part of the `whoAmI` query.
nik commented 2022-12-18 20:05:53 +01:00
Owner
Copy link

If we have this, we should also complete it and return username and such.

If we have this, we should also complete it and return username and such.
nik commented 2022-12-18 20:05:53 +01:00
Owner
Copy link

This file should be removed.

Please remove it from the entire commit history (by rebasing and dropping it from the commit where it was introduced).

This file should be removed. Please remove it from the entire commit history (by rebasing and dropping it from the commit where it was introduced).
nik commented 2022-12-18 20:05:53 +01:00
Owner
Copy link

Are you sure about this change? If so, why? It looks like a major bug breaking all hosting scenarios under sub URLs.

Are you sure about this change? If so, why? It looks like a major bug breaking all hosting scenarios under sub URLs.
nik commented 2022-12-18 20:05:54 +01:00
Owner
Copy link

What is this? Should this be there? We should not be introducing new views during the Vue transition.

What is this? Should this be there? We should not be introducing new views during the Vue transition.
nik commented 2022-12-18 20:09:31 +01:00
Owner
Copy link

assigned to @nik and unassigned @yuha

assigned to @nik and unassigned @yuha
nik commented 2022-12-20 15:38:22 +01:00
Owner
Copy link

added 42 commits

  • 2bec3b75...2deb9336 - 41 commits from branch master
  • 21e4a748 - Merge branch 'master' into 759-finalise-vuetify-app-as-spa

Compare with previous version

added 42 commits <ul><li>2bec3b75...2deb9336 - 41 commits from branch <code>master</code></li><li>21e4a748 - Merge branch &#39;master&#39; into 759-finalise-vuetify-app-as-spa</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26293&start_sha=2bec3b75d439504dc44800915d18169112c1a25a)
nik commented 2022-12-20 16:45:53 +01:00
Owner
Copy link

added 1 commit

  • e55ca161 - Fix vue index template and GraphQL view

Compare with previous version

added 1 commit <ul><li>e55ca161 - Fix vue index template and GraphQL view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26296&start_sha=21e4a748fa9de421abd3c801c6f896052952c45c)
nik commented 2022-12-20 16:55:05 +01:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>9fcfa3b3 - Fix up recent merge</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26298&start_sha=e55ca16165359c5e7f3ae93eba62f560073b8d32)
yuha commented 2022-12-20 16:57:45 +01:00
Author
Member
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26299&start_sha=9fcfa3b393c5c62fe8de1ed370cf654394ba5c33#4fd310df6f6343f9412024891dfbd83ceb0496dc_292_296)
yuha commented 2022-12-20 16:57:46 +01:00
Author
Member
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26299&start_sha=9fcfa3b393c5c62fe8de1ed370cf654394ba5c33#4fd310df6f6343f9412024891dfbd83ceb0496dc_295_296)
yuha commented 2022-12-20 16:57:47 +01:00
Author
Member
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26299&start_sha=9fcfa3b393c5c62fe8de1ed370cf654394ba5c33#4fd310df6f6343f9412024891dfbd83ceb0496dc_298_299)
yuha commented 2022-12-20 16:57:47 +01:00
Author
Member
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26299&start_sha=9fcfa3b393c5c62fe8de1ed370cf654394ba5c33#4fd310df6f6343f9412024891dfbd83ceb0496dc_301_302)
yuha commented 2022-12-20 16:57:49 +01:00
Author
Member
Copy link

added 1 commit

  • 633d94a5 - Import graphql queries instead of using require

Compare with previous version

added 1 commit <ul><li>633d94a5 - Import graphql queries instead of using require</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26299&start_sha=9fcfa3b393c5c62fe8de1ed370cf654394ba5c33)
yuha commented 2022-12-20 17:06:58 +01:00
Author
Member
Copy link

added 1 commit

  • 2fb3be5a - Fix system properties scheme

Compare with previous version

added 1 commit <ul><li>2fb3be5a - Fix system properties scheme</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26302&start_sha=633d94a532000d54b16917c04f495e25c60d8add)
yuha commented 2022-12-20 17:08:19 +01:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>32b09400 - Fix system properties scheme</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26303&start_sha=2fb3be5aa063b25875d9251cf9ad8ad2ebf99261)
nik commented 2022-12-20 17:54:45 +01:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>2aa5a420 - Do not reformat .vite cache</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26305&start_sha=32b09400095169570cfb50b1bc7fc55a359562a4)
yuha commented 2022-12-20 18:36:55 +01:00
Author
Member
Copy link

added 1 commit

  • 17c80e07 - Use require to import graphql files when using vue apollo components

Compare with previous version

added 1 commit <ul><li>17c80e07 - Use require to import graphql files when using vue apollo components</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26309&start_sha=2aa5a420748938f073874ced1196fbf0ad4d666a)
yuha commented 2022-12-20 18:45:58 +01:00
Author
Member
Copy link

It should not be there. Deleted.

It should not be there. Deleted.
yuha commented 2022-12-20 18:46:10 +01:00
Author
Member
Copy link

changed this line in version 15 of the diff

changed this line in [version 15 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26312&start_sha=17c80e07f3617a34ef1982332e3dd8e51026d6fd#ca5e4a886c594c4b59402dbdbd16348bdbcddf3a_315_313)
yuha commented 2022-12-20 18:46:10 +01:00
Author
Member
Copy link

added 1 commit

  • 026034ae - Remove test view for displaying legacy pages in vue

Compare with previous version

added 1 commit <ul><li>026034ae - Remove test view for displaying legacy pages in vue</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26312&start_sha=17c80e07f3617a34ef1982332e3dd8e51026d6fd)
yuha commented 2022-12-20 19:15:24 +01:00
Author
Member
Copy link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26315&start_sha=026034ae9cf2a1347973eb4db76889583678187f#4fd310df6f6343f9412024891dfbd83ceb0496dc_69_65)
yuha commented 2022-12-20 19:15:24 +01:00
Author
Member
Copy link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26315&start_sha=026034ae9cf2a1347973eb4db76889583678187f#4fd310df6f6343f9412024891dfbd83ceb0496dc_17_15)
yuha commented 2022-12-20 19:15:25 +01:00
Author
Member
Copy link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26315&start_sha=026034ae9cf2a1347973eb4db76889583678187f#4fd310df6f6343f9412024891dfbd83ceb0496dc_22_20)
yuha commented 2022-12-20 19:15:25 +01:00
Author
Member
Copy link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26315&start_sha=026034ae9cf2a1347973eb4db76889583678187f#4fd310df6f6343f9412024891dfbd83ceb0496dc_33_31)
yuha commented 2022-12-20 19:15:26 +01:00
Author
Member
Copy link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26315&start_sha=026034ae9cf2a1347973eb4db76889583678187f#4fd310df6f6343f9412024891dfbd83ceb0496dc_79_76)
yuha commented 2022-12-20 19:15:26 +01:00
Author
Member
Copy link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26315&start_sha=026034ae9cf2a1347973eb4db76889583678187f#4fd310df6f6343f9412024891dfbd83ceb0496dc_80_76)
yuha commented 2022-12-20 19:15:27 +01:00
Author
Member
Copy link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26315&start_sha=026034ae9cf2a1347973eb4db76889583678187f#4fd310df6f6343f9412024891dfbd83ceb0496dc_82_79)
yuha commented 2022-12-20 19:15:28 +01:00
Author
Member
Copy link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26315&start_sha=026034ae9cf2a1347973eb4db76889583678187f#4fd310df6f6343f9412024891dfbd83ceb0496dc_129_126)
yuha commented 2022-12-20 19:15:29 +01:00
Author
Member
Copy link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26315&start_sha=026034ae9cf2a1347973eb4db76889583678187f#4fd310df6f6343f9412024891dfbd83ceb0496dc_150_147)
yuha commented 2022-12-20 19:15:29 +01:00
Author
Member
Copy link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26315&start_sha=026034ae9cf2a1347973eb4db76889583678187f#4fd310df6f6343f9412024891dfbd83ceb0496dc_178_175)
yuha commented 2022-12-20 19:15:30 +01:00
Author
Member
Copy link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26315&start_sha=026034ae9cf2a1347973eb4db76889583678187f#abc9d828b78bd9d36e05475d0bc91119bc5bc6b0_542_541)
yuha commented 2022-12-20 19:15:31 +01:00
Author
Member
Copy link

added 2 commits

  • 3fc8198c - Reset static and media url to former values
  • 5d892d6e - Use self-closing tags where possible in App.vue

Compare with previous version

added 2 commits <ul><li>3fc8198c - Reset static and media url to former values</li><li>5d892d6e - Use self-closing tags where possible in App.vue</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26315&start_sha=026034ae9cf2a1347973eb4db76889583678187f)
yuha commented 2022-12-20 19:21:20 +01:00
Author
Member
Copy link

added 1 commit

  • 14ce466c - Use self-closing tags where possible in App.vue

Compare with previous version

added 1 commit <ul><li>14ce466c - Use self-closing tags where possible in App.vue</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26317&start_sha=5d892d6eae236da692e9d2da26b577b69811619b)
yuha commented 2022-12-20 19:45:23 +01:00
Author
Member
Copy link

added 1 commit

  • d8ab39c7 - Use self-closing tags where possible in App.vue

Compare with previous version

added 1 commit <ul><li>d8ab39c7 - Use self-closing tags where possible in App.vue</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26319&start_sha=14ce466c5717534f777b20f10f03796e9ac18c7f)
yuha commented 2022-12-20 20:31:55 +01:00
Author
Member
Copy link

changed this line in version 19 of the diff

changed this line in [version 19 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26322&start_sha=d8ab39c78d1b0f8a10808abffe042efa8fccf935#a1578eee22804fb064b4d1a812d29edcf846084c_6_3)
yuha commented 2022-12-20 20:31:59 +01:00
Author
Member
Copy link

added 1 commit

  • f19b9383 - Do not hard code placeholder aleksis banner in Vue code

Compare with previous version

added 1 commit <ul><li>f19b9383 - Do not hard code placeholder aleksis banner in Vue code</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26322&start_sha=d8ab39c78d1b0f8a10808abffe042efa8fccf935)
nik commented 2022-12-20 22:34:25 +01:00
Owner
Copy link

No broken syntax, I was just blind.

No broken syntax, I was just blind.
nik commented 2022-12-20 22:35:26 +01:00
Owner
Copy link

Also, we probably need the theme colours before the app is ready? To theme the loading animation, or some such?

That is probably solved by adding the splash to the base template, which we must do anyway.

Also, we probably need the theme colours before the app is ready? To theme the loading animation, or some such? That is probably solved by adding the splash to the base template, which we must do anyway.
nik commented 2022-12-20 22:43:44 +01:00
Owner
Copy link

changed this line in version 20 of the diff

changed this line in [version 20 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26326&start_sha=f19b9383661eadacd11bffabddeb82cd7d00d7d1#c7a949427e98276916313d52d9697506470a9a07_1_0)
nik commented 2022-12-20 22:43:44 +01:00
Owner
Copy link

added 3 commits

  • 7e473dac - Reintroduce meta information and Sentry into Vue index
  • 6905358f - Remove backup of old base template
  • ce0392d4 - Ignore Python files in filesystem watching

Compare with previous version

added 3 commits <ul><li>7e473dac - Reintroduce meta information and Sentry into Vue index</li><li>6905358f - Remove backup of old base template</li><li>ce0392d4 - Ignore Python files in filesystem watching</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26326&start_sha=f19b9383661eadacd11bffabddeb82cd7d00d7d1)
nik commented 2022-12-21 00:14:07 +01:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e220e6e7 - Move Sentry to Vue code</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26333&start_sha=ce0392d44adbefce7337efbf1f1d13dbbef2df4a)
nik commented 2022-12-21 00:36:35 +01:00
Owner
Copy link

added 1 commit

  • 79d4a052 - Write out vendor licensing information

Compare with previous version

added 1 commit <ul><li>79d4a052 - Write out vendor licensing information</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26334&start_sha=e220e6e77829c2e9fa92843f13b2a91cfd4ddb6a)
hansegucker commented 2022-12-21 11:28:38 +01:00
Owner
Copy link

I am not sure whether the personPreferences.graphql query is still used.

I am not sure whether the `personPreferences.graphql` query is still used.
yuha commented 2022-12-21 14:31:37 +01:00
Author
Member
Copy link

It is not and has been removed.

It is not and has been removed.
yuha commented 2022-12-21 14:32:52 +01:00
Author
Member
Copy link

changed this line in version 23 of the diff

changed this line in [version 23 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26350&start_sha=79d4a052b24b54c8b15e4bac86ee3adbbfbb88a2#1ab99c99d230b8cdebcf21d4fc77db5c49f54cc1_7_0)
yuha commented 2022-12-21 14:32:54 +01:00
Author
Member
Copy link

added 2 commits

  • 512b69f1 - Remove unused file for unused PersonPreferences query
  • a7a194d0 - Add more fields to graphene user type

Compare with previous version

added 2 commits <ul><li>512b69f1 - Remove unused file for unused PersonPreferences query</li><li>a7a194d0 - Add more fields to graphene user type</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26350&start_sha=79d4a052b24b54c8b15e4bac86ee3adbbfbb88a2)
yuha commented 2022-12-21 14:42:39 +01:00
Author
Member
Copy link

No, since that wouldn't work so well in case a user has no Person connect to them. If we are to combine these queries, then I would rather make the whoAmI query part of the currentUser query.

No, since that wouldn't work so well in case a user has no Person connect to them. If we are to combine these queries, then I would rather make the `whoAmI` query part of the `currentUser` query.
yuha commented 2022-12-21 14:43:01 +01:00
Author
Member
Copy link

See above

See above
yuha commented 2022-12-21 14:46:56 +01:00
Author
Member
Copy link

added 1 commit

  • 4ce1ef84 - Add BSD-3-Clause to allowed licenses for third party js modules

Compare with previous version

added 1 commit <ul><li>4ce1ef84 - Add BSD-3-Clause to allowed licenses for third party js modules</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26353&start_sha=a7a194d0ce815055762269f3e962e74405456787)
yuha commented 2022-12-21 15:30:20 +01:00
Author
Member
Copy link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26357&start_sha=4ce1ef8408333293a3138e2b85e392ce9bb1e647#4fd310df6f6343f9412024891dfbd83ceb0496dc_174_162)
yuha commented 2022-12-21 15:30:21 +01:00
Author
Member
Copy link

added 1 commit

  • 575deaf0 - Make footer custom menu work in vue SPA

Compare with previous version

added 1 commit <ul><li>575deaf0 - Make footer custom menu work in vue SPA</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26357&start_sha=4ce1ef8408333293a3138e2b85e392ce9bb1e647)
yuha commented 2022-12-21 15:32:49 +01:00
Author
Member
Copy link

added 1 commit

  • 3df24afc - Make footer custom menu work in vue SPA

Compare with previous version

added 1 commit <ul><li>3df24afc - Make footer custom menu work in vue SPA</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26359&start_sha=575deaf03b7a1b89c8a1e4640d936d5328cdf564)
yuha commented 2022-12-21 16:06:49 +01:00
Author
Member
Copy link

added 1 commit

  • 215d7508 - Rename vue routes with duplicate names

Compare with previous version

added 1 commit <ul><li>215d7508 - Rename vue routes with duplicate names</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26361&start_sha=3df24afcc1f7c452fbcc14761c6c3796ffc2ca66)
yuha commented 2022-12-21 16:27:39 +01:00
Author
Member
Copy link

added 1 commit

  • 456f47ce - Redirect to SPA pages (instead of legacy ones) when using sidenav search

Compare with previous version

added 1 commit <ul><li>456f47ce - Redirect to SPA pages (instead of legacy ones) when using sidenav search</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26363&start_sha=215d75087d9e9a36ce06849da0ca62874ab421ef)
yuha commented 2022-12-21 17:00:51 +01:00
Author
Member
Copy link

added 2 commits

  • cfcc6562 - Add vue route for haystack search page
  • c6edd979 - Allow for passing of query parameters to legacy iframe (for search page)

Compare with previous version

added 2 commits <ul><li>cfcc6562 - Add vue route for haystack search page</li><li>c6edd979 - Allow for passing of query parameters to legacy iframe (for search page)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26365&start_sha=456f47ce3abb9e40a7396c43ef765d415c8262dc)
yuha commented 2022-12-21 17:16:47 +01:00
Author
Member
Copy link

added 1 commit

  • ad8a0a2f - Let sidenav search redirect to new SPA search page

Compare with previous version

added 1 commit <ul><li>ad8a0a2f - Let sidenav search redirect to new SPA search page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26367&start_sha=c6edd979f09458388c446b2799eec547ad118588)
yuha commented 2022-12-21 20:54:20 +01:00
Author
Member
Copy link

added 2 commits

  • 2f52d387 - Let sidenav search redirect to new SPA search page
  • 0608304e - Implement basic error 404 handling

Compare with previous version

added 2 commits <ul><li>2f52d387 - Let sidenav search redirect to new SPA search page</li><li>0608304e - Implement basic error 404 handling</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26371&start_sha=ad8a0a2f4c6c3b0ba27bcc373cf9df21434493c4)
nik commented 2022-12-21 21:01:56 +01:00
Owner
Copy link

A person without a user does not have any permissions anyway. Every interactive user must have an associated person.

A person without a user does not have any permissions anyway. Every interactive user must have an associated person.
nik commented 2022-12-21 22:20:44 +01:00
Owner
Copy link

added 3 commits

  • 2484bec3 - Fix query string handling to work with special characters
  • 9a08f9e4 - Fix lstripping of /django prefix in legacy translation
  • 834c07b3 - Rewrite legacy iframe to use query parameter instead of path prefix

Compare with previous version

added 3 commits <ul><li>2484bec3 - Fix query string handling to work with special characters</li><li>9a08f9e4 - Fix lstripping of /django prefix in legacy translation</li><li>834c07b3 - Rewrite legacy iframe to use query parameter instead of path prefix</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26373&start_sha=0608304eb7c7753e2615eabbf7a1f8f6beeba5c1)
nik commented 2022-12-21 22:22:45 +01:00
Owner
Copy link

added 1 commit

  • 18944d4e - Rewrite legacy iframe to use query parameter instead of path prefix

Compare with previous version

added 1 commit <ul><li>18944d4e - Rewrite legacy iframe to use query parameter instead of path prefix</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26374&start_sha=834c07b3a1ff425cb710936a65fa09d8b834af16)
nik commented 2022-12-21 23:16:24 +01:00
Owner
Copy link

added 1 commit

  • 2087270e - Register app routes

Compare with previous version

added 1 commit <ul><li>2087270e - Register app routes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26379&start_sha=9a08f9e465c31b9eecd86ecd0f5c8756accde9b9)
nik commented 2022-12-21 23:23:16 +01:00
Owner
Copy link

added 1 commit

  • d58c1672 - Register app routes

Compare with previous version

added 1 commit <ul><li>d58c1672 - Register app routes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26381&start_sha=2087270ec3bc72204f7bbe902ca0762b97312973)
yuha commented 2022-12-21 23:35:07 +01:00
Author
Member
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>4d71ad68 - Register app routes</li><li>fb2d4cda - Fix building of query string</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26383&start_sha=d58c1672f618cbe064e743c4bcb03478cb7d104d)
yuha commented 2022-12-22 14:01:51 +01:00
Author
Member
Copy link

added 1 commit

  • a908c881 - Carry over page titles from iframe to SPA

Compare with previous version

added 1 commit <ul><li>a908c881 - Carry over page titles from iframe to SPA</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26390&start_sha=fb2d4cda0b8f26e4c92e1a9fb3b85055211206ed)
yuha commented 2022-12-22 14:53:32 +01:00
Author
Member
Copy link

added 1 commit

  • 88d76a14 - Redesign language select and move it to sidenav

Compare with previous version

added 1 commit <ul><li>88d76a14 - Redesign language select and move it to sidenav</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26392&start_sha=a908c881d5363b180d474dc322aab5e2f0d1a511)
yuha commented 2022-12-22 16:22:15 +01:00
Author
Member
Copy link

added 2 commits

  • 2195dcf9 - Add check for whoAmI
  • 68f982fd - Set current menu point to active

Compare with previous version

added 2 commits <ul><li>2195dcf9 - Add check for whoAmI</li><li>68f982fd - Set current menu point to active</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26396&start_sha=88d76a14b2848ec72ea55ed5404f7584f0d1931b)
yuha commented 2022-12-23 14:23:58 +01:00
Author
Member
Copy link

added 2 commits

  • ee26a995 - Set current menu point to active
  • ad8ba0a1 - Add trailing slash to all legacy URLs

Compare with previous version

added 2 commits <ul><li>ee26a995 - Set current menu point to active</li><li>ad8ba0a1 - Add trailing slash to all legacy URLs</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26420&start_sha=68f982fd6d0ddba0cae114edfca07889e361f971)
yuha commented 2022-12-23 14:35:32 +01:00
Author
Member
Copy link

added 2 commits

  • a39d1327 - Add trailing slash to all suitable legacy URLs
  • b456cc06 - Remove some items from sidenav menu

Compare with previous version

added 2 commits <ul><li>a39d1327 - Add trailing slash to all suitable legacy URLs</li><li>b456cc06 - Remove some items from sidenav menu</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26422&start_sha=ad8ba0a1464a6e8ae1125958619fb96f49c3b589)
yuha commented 2022-12-23 23:56:33 +01:00
Author
Member
Copy link

added 2 commits

  • ffbd113d - Replace height measures relative to page height due to rendering issues in iframe
  • 63832932 - Poll user and person details regularily to detect changes when login/logout happens

Compare with previous version

added 2 commits <ul><li>ffbd113d - Replace height measures relative to page height due to rendering issues in iframe</li><li>63832932 - Poll user and person details regularily to detect changes when login/logout happens</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26427&start_sha=b456cc063b8f18468ed32bedb6b101212ca2bbf4)
yuha commented 2022-12-27 11:05:04 +01:00
Author
Member
Copy link

added 1 commit

  • 22b5ae14 - WIP permission checking with routes

Compare with previous version

added 1 commit <ul><li>22b5ae14 - WIP permission checking with routes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26441&start_sha=6383293233d0400812617703a049bf4f1429771a)
hansegucker commented 2022-12-28 16:36:28 +01:00
Owner
Copy link

changed this line in version 45 of the diff

changed this line in [version 45 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26449&start_sha=22b5ae14adea500e94d3f6f8953402e09c1b4469#67745eb489c6cd031c4e748a49d0f996b97dc291_9_0)
hansegucker commented 2022-12-28 16:36:35 +01:00
Owner
Copy link

added 3 commits

  • e35bfab1 - Drop Vuetify plugin file to prevent existence of two Vue instances
  • 1b0442d9 - Reformat
  • f81d961c - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 3 commits <ul><li>e35bfab1 - Drop Vuetify plugin file to prevent existence of two Vue instances</li><li>1b0442d9 - Reformat</li><li>f81d961c - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26449&start_sha=22b5ae14adea500e94d3f6f8953402e09c1b4469)
hansegucker commented 2022-12-28 17:07:23 +01:00
Owner
Copy link

added 2 commits

  • da7f743e - Fix permission checking in schemas (performance/rule names)
  • 8f1496d6 - Fix import of external dependencies in frontend bundle

Compare with previous version

added 2 commits <ul><li>da7f743e - Fix permission checking in schemas (performance/rule names)</li><li>8f1496d6 - Fix import of external dependencies in frontend bundle</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26451&start_sha=f81d961ccc64e4b2bae514b840e8f535f0687bf4)
hansegucker commented 2022-12-28 17:36:23 +01:00
Owner
Copy link

added 1 commit

  • 94dc118e - Reformat and fix the language form

Compare with previous version

added 1 commit <ul><li>94dc118e - Reformat and fix the language form</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26453&start_sha=8f1496d69af0f004137de4c760d9482605f8e7d3)
yuha commented 2022-12-28 18:31:56 +01:00
Author
Member
Copy link

changed this line in version 48 of the diff

changed this line in [version 48 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26458&start_sha=94dc118e45139b44466e807d950ac4639348334a#88644f513d22f029ca04451741abef4667ead3c5_477_3)
yuha commented 2022-12-28 18:31:58 +01:00
Author
Member
Copy link

added 3 commits

  • a7dc1d93 - Allow serving of external apps assets in vite config
  • 0b381eb0 - Add routes when instantiating router object and fix incorporation of external app routes
  • b3075594 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 3 commits <ul><li>a7dc1d93 - Allow serving of external apps assets in vite config</li><li>0b381eb0 - Add routes when instantiating router object and fix incorporation of external app routes</li><li>b3075594 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26458&start_sha=94dc118e45139b44466e807d950ac4639348334a)
hansegucker commented 2022-12-28 18:42:35 +01:00
Owner
Copy link

added 1 commit

  • a49d7e30 - Use rules for all menu entries

Compare with previous version

added 1 commit <ul><li>a49d7e30 - Use rules for all menu entries</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26460&start_sha=b307559480bb4a691acff019fed87ac20c59b2de)
yuha commented 2022-12-28 21:28:39 +01:00
Author
Member
Copy link

added 2 commits

  • 0c56be37 - Include messages from apps
  • 62d6d95c - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>0c56be37 - Include messages from apps</li><li>62d6d95c - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26463&start_sha=a49d7e3033367d71733bb096eb72434768270d5d)
hansegucker commented 2022-12-28 21:45:28 +01:00
Owner
Copy link

added 2 commits

  • 5cf529b4 - Drop legacy vue files and views
  • bfaf1bba - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>5cf529b4 - Drop legacy vue files and views</li><li>bfaf1bba - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26465&start_sha=62d6d95cdba5462db164ed0c9cf21c42926fb124)
yuha commented 2022-12-28 21:48:04 +01:00
Author
Member
Copy link

added 3 commits

Compare with previous version

added 3 commits <ul><li>90dd557e - Reformat</li><li>3fdc40a0 - Remove some FIXMEs/TODOs</li><li>6c61797d - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26466&start_sha=bfaf1bba72f4e0260f2a68b57a7f7b1bf143dbc2)
yuha commented 2022-12-29 18:34:15 +01:00
Author
Member
Copy link

added 1 commit

  • acf475b9 - Generate menus and route list as soon as routes are ready

Compare with previous version

added 1 commit <ul><li>acf475b9 - Generate menus and route list as soon as routes are ready</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26483&start_sha=6c61797d63478624605e07e6d7c66fbb1afebf4a)
yuha commented 2022-12-29 19:13:25 +01:00
Author
Member
Copy link

added 1 commit

  • a97bf09b - Only display menu entries that the user is allowed to view

Compare with previous version

added 1 commit <ul><li>a97bf09b - Only display menu entries that the user is allowed to view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26494&start_sha=acf475b9e922298319be193ac93c8e88d702c1a2)
yuha commented 2022-12-29 22:33:44 +01:00
Author
Member
Copy link

added 2 commits

  • 90ba5f83 - Only display menu entries that the user is allowed to view
  • fcabc866 - Basic permission checking when accessing routes

Compare with previous version

added 2 commits <ul><li>90ba5f83 - Only display menu entries that the user is allowed to view</li><li>fcabc866 - Basic permission checking when accessing routes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26495&start_sha=a97bf09b49bd06ee02c4e6b925cfb42069d9909d)
yuha commented 2022-12-29 22:52:54 +01:00
Author
Member
Copy link

added 1 commit

  • 4cedd613 - Highlight menu entries only when exact match is present

Compare with previous version

added 1 commit <ul><li>4cedd613 - Highlight menu entries only when exact match is present</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26496&start_sha=fcabc866489c358710de622c8d6d2d1bcf70d6b9)
yuha commented 2022-12-29 23:21:26 +01:00
Author
Member
Copy link

added 1 commit

  • cfb1941b - Require less queries to be finished for app to be displayed

Compare with previous version

added 1 commit <ul><li>cfb1941b - Require less queries to be finished for app to be displayed</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26497&start_sha=4cedd613779b2428ae78b86094c0face99285250)
yuha commented 2022-12-30 00:08:04 +01:00
Author
Member
Copy link

added 1 commit

  • ad1f48df - Fix permission checking when displaying router-view

Compare with previous version

added 1 commit <ul><li>ad1f48df - Fix permission checking when displaying router-view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26499&start_sha=cfb1941b27f91b229433d8182e8fb5ac1c145dc8)
yuha commented 2022-12-30 00:34:38 +01:00
Author
Member
Copy link

added 1 commit

  • 3288ae14 - Fix permission checking when displaying menus and router-view

Compare with previous version

added 1 commit <ul><li>3288ae14 - Fix permission checking when displaying menus and router-view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26500&start_sha=ad1f48dfd86725a62bce416668df2dfee64d211e)
yuha commented 2022-12-30 00:54:33 +01:00
Author
Member
Copy link

added 1 commit

  • bb2ee10e - Adapt trailing slash status of iframe and SPA url when checking for new iFrame location

Compare with previous version

added 1 commit <ul><li>bb2ee10e - Adapt trailing slash status of iframe and SPA url when checking for new iFrame location</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26501&start_sha=3288ae143ab54e507d89a28fc74404f23c3f873e)
yuha commented 2022-12-30 15:19:26 +01:00
Author
Member
Copy link

added 1 commit

  • f4082ab8 - Remove unused parts of legacy main.js

Compare with previous version

added 1 commit <ul><li>f4082ab8 - Remove unused parts of legacy main.js</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26505&start_sha=bb2ee10e2ee70c2da63a7bcaf1d1ad7150e662de)
yuha commented 2022-12-30 19:07:19 +01:00
Author
Member
Copy link

added 1 commit

  • 16c68e69 - Introduce basic error handling with apollo local states

Compare with previous version

added 1 commit <ul><li>16c68e69 - Introduce basic error handling with apollo local states</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26508&start_sha=f4082ab84b30a03c8f067f215f853af62f1cc429)
yuha commented 2023-01-03 12:51:27 +01:00
Author
Member
Copy link

added 5 commits

  • 6a78f561 - Introduce basic error handling with apollo local states
  • dd61626c - Replace hrefs in App.vue with programmatic vue router navigation
  • 9c023e33 - WIP Service Worker: Do not serve offline fallback page when site cannot be fetched but show warning
  • 85b58317 - Re-Add vue alias in vite config
  • 4b00c83a - Fix displaying of photo/avatar in header

Compare with previous version

added 5 commits <ul><li>6a78f561 - Introduce basic error handling with apollo local states</li><li>dd61626c - Replace hrefs in App.vue with programmatic vue router navigation</li><li>9c023e33 - WIP Service Worker: Do not serve offline fallback page when site cannot be fetched but show warning</li><li>85b58317 - Re-Add vue alias in vite config</li><li>4b00c83a - Fix displaying of photo/avatar in header</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26527&start_sha=16c68e693563fae926a001ec48b195300bdb99ea)
leuckeju commented 2023-01-03 14:14:12 +01:00
Member
Copy link

added 3 commits

  • 16c68e69 - Introduce basic error handling with apollo local states
  • d8548a71 - Merge remote-tracking branch 'origin/759-finalise-vuetify-app-as-spa' into...
  • ed73939a - Redesign 404 component

Compare with previous version

added 3 commits <ul><li>16c68e69 - Introduce basic error handling with apollo local states</li><li>d8548a71 - Merge remote-tracking branch &#39;origin/759-finalise-vuetify-app-as-spa&#39; into...</li><li>ed73939a - Redesign 404 component</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26529&start_sha=4b00c83a760b10fde08b5611886fb295b9376a9e)
leuckeju commented 2023-01-03 16:18:11 +01:00
Member
Copy link

added 2 commits

  • 4539ba70 - Create PersonOverview component
  • 1536adc2 - Build contact details table on person overview

Compare with previous version

added 2 commits <ul><li>4539ba70 - Create PersonOverview component</li><li>1536adc2 - Build contact details table on person overview</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26530&start_sha=ed73939a1bb3605ae49ea0363b63df890853b5c0)
leuckeju commented 2023-01-04 00:01:47 +01:00
Member
Copy link

added 5 commits

  • af032f5e - Display "–" if data points are missing
  • 3aa5d8b5 - Show children and parents in person overview
  • 87fcbeec - Show group member- and ownerships in person overview
  • bf93040f - Fix breakpoints and spacing of children/parents
  • cd60350f - Display person description on person overview

Compare with previous version

added 5 commits <ul><li>af032f5e - Display &quot;–&quot; if data points are missing</li><li>3aa5d8b5 - Show children and parents in person overview</li><li>87fcbeec - Show group member- and ownerships in person overview</li><li>bf93040f - Fix breakpoints and spacing of children/parents</li><li>cd60350f - Display person description on person overview</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26533&start_sha=1536adc27a3e0cad41096e69ee0a7a87a5344bc9)
leuckeju commented 2023-01-05 13:11:07 +01:00
Member
Copy link

added 2 commits

  • 3ad62870 - Display correct avatar content in person list
  • 2b21e91e - Display person avatar and make it clickable

Compare with previous version

added 2 commits <ul><li>3ad62870 - Display correct avatar content in person list</li><li>2b21e91e - Display person avatar and make it clickable</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26562&start_sha=cd60350feefc1fea9ed58b7f84bdcb4fda410acf)
leuckeju commented 2023-01-05 14:09:17 +01:00
Member
Copy link

added 3 commits

  • ca5f0216 - Fix issues in AvatarContent.vue
  • a896f112 - Fix design of image popup
  • 6bbb3a3a - Display additional images of a person in the overview

Compare with previous version

added 3 commits <ul><li>ca5f0216 - Fix issues in AvatarContent.vue</li><li>a896f112 - Fix design of image popup</li><li>6bbb3a3a - Display additional images of a person in the overview</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26570&start_sha=2b21e91e284d2ce296d12f0281554a20c3fcef46)
leuckeju commented 2023-01-06 00:36:19 +01:00
Member
Copy link

added 4 commits

  • e6c8ddbb - Fix vite warning
  • d6f82e15 - Default icon for preferences
  • 98d1e4ec - Create component and schemas for person actions
  • a2feb51e - Redesign positions of person action buttons and avatar

Compare with previous version

added 4 commits <ul><li>e6c8ddbb - Fix vite warning</li><li>d6f82e15 - Default icon for preferences</li><li>98d1e4ec - Create component and schemas for person actions</li><li>a2feb51e - Redesign positions of person action buttons and avatar</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26581&start_sha=6bbb3a3a7f3b44952951dfe3b86a3214fa30f353)
leuckeju commented 2023-01-06 18:18:19 +01:00
Member
Copy link

added 4 commits

  • 1a3ccd8d - Create impersonation routes
  • c21bd256 - Fix impersonation bug
  • 3507e319 - Add 'stop impersonation button' to navbar
  • b1c0ae69 - Only replace '/django/' in url path

Compare with previous version

added 4 commits <ul><li>1a3ccd8d - Create impersonation routes</li><li>c21bd256 - Fix impersonation bug</li><li>3507e319 - Add &#39;stop impersonation button&#39; to navbar</li><li>b1c0ae69 - Only replace &#39;/django/&#39; in url path</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26584&start_sha=a2feb51eb04555c99bbcb57a8b3172382f5526b2)
leuckeju commented 2023-01-06 18:29:25 +01:00
Member
Copy link

added 1 commit

  • 29f74768 - Add splash loader to show an animation before vue has loaded

Compare with previous version

added 1 commit <ul><li>29f74768 - Add splash loader to show an animation before vue has loaded</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26586&start_sha=b1c0ae699a8887c11257014804cbd5bd749c5842)
leuckeju commented 2023-01-06 19:39:17 +01:00
Member
Copy link

added 1 commit

  • bc5b9408 - Display loading animation on every request in the iframe

Compare with previous version

added 1 commit <ul><li>bc5b9408 - Display loading animation on every request in the iframe</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26589&start_sha=29f7476815e37129a7b93ddc82da41aea925b964)
leuckeju commented 2023-01-07 17:30:54 +01:00
Member
Copy link

added 2 commits

  • ea07e331 - Create global loader
  • d18ef51b - Use global loader in LegacyBasetemplate (and use correct event)

Compare with previous version

added 2 commits <ul><li>ea07e331 - Create global loader</li><li>d18ef51b - Use global loader in LegacyBasetemplate (and use correct event)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26602&start_sha=bc5b94089208a03a9fa06bc4f644b6b6cc37ff5f)
leuckeju commented 2023-01-07 18:54:36 +01:00
Member
Copy link

added 4 commits

  • 60bc37e5 - Fix celery progess error messages for anonymous users
  • 771d00da - Don't show user_not_linked_to_person message box for anonymous users
  • 4436a97b - Fix login route
  • 12cc0c02 - Link to correct login view on signup page

Compare with previous version

added 4 commits <ul><li>60bc37e5 - Fix celery progess error messages for anonymous users</li><li>771d00da - Don&#39;t show user_not_linked_to_person message box for anonymous users</li><li>4436a97b - Fix login route</li><li>12cc0c02 - Link to correct login view on signup page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26603&start_sha=d18ef51b6b8c94c1d54fc8d1c96e9779391bcdcf)
leuckeju commented 2023-01-07 19:43:42 +01:00
Member
Copy link

added 1 commit

  • 7cc1915c - Load also on component change

Compare with previous version

added 1 commit <ul><li>7cc1915c - Load also on component change</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26604&start_sha=12cc0c02d6528c82d0fb368e780a69fe5c0c0aee)
hansegucker commented 2023-01-08 12:33:06 +01:00
Owner
Copy link

Short notice: The second loading spinner doesn't make use of theme colors.

Short notice: The second loading spinner doesn't make use of theme colors.
hansegucker commented 2023-01-08 12:52:09 +01:00
Owner
Copy link
      :variables="{id}"
```suggestion:-0+0 :variables="{id}" ```
hansegucker commented 2023-01-08 12:52:09 +01:00
Owner
Copy link

FIXME

FIXME
hansegucker commented 2023-01-08 12:52:09 +01:00
Owner
Copy link
          <avatar-content :id="id" class="rounded-circle"/>
```suggestion:-0+0 <avatar-content :id="id" class="rounded-circle"/> ```
hansegucker commented 2023-01-08 12:52:10 +01:00
Owner
Copy link
      :variables="{id}"
```suggestion:-0+0 :variables="{id}" ```
hansegucker commented 2023-01-08 12:52:10 +01:00
Owner
Copy link
        <avatar-content :id="person.id" />
```suggestion:-0+0 <avatar-content :id="person.id" /> ```
hansegucker commented 2023-01-08 12:52:10 +01:00
Owner
Copy link
      :variables="{id}"
```suggestion:-0+0 :variables="{id}" ```
hansegucker commented 2023-01-08 12:52:10 +01:00
Owner
Copy link
            <avatar-click-box :id="id"/>
```suggestion:-0+0 <avatar-click-box :id="id"/> ```
hansegucker commented 2023-01-08 12:52:11 +01:00
Owner
Copy link
            <person-actions :id="data.person.id" />
```suggestion:-0+0 <person-actions :id="data.person.id" /> ```
hansegucker commented 2023-01-08 12:52:11 +01:00
Owner
Copy link
            <additional-image :src="data.person.secondaryImageUrl" />
```suggestion:-0+0 <additional-image :src="data.person.secondaryImageUrl" /> ```
hansegucker commented 2023-01-08 12:52:11 +01:00
Owner
Copy link
              <person-list :persons="data.person.children"/>
```suggestion:-0+0 <person-list :persons="data.person.children"/> ```
hansegucker commented 2023-01-08 12:52:11 +01:00
Owner
Copy link
              <person-list :persons="data.person.guardians"/>
```suggestion:-0+0 <person-list :persons="data.person.guardians"/> ```
hansegucker commented 2023-01-08 12:52:12 +01:00
Owner
Copy link
                <group-list :groups="data.person.memberOf"/>
```suggestion:-0+0 <group-list :groups="data.person.memberOf"/> ```
hansegucker commented 2023-01-08 12:52:12 +01:00
Owner
Copy link
                <group-list :groups="data.person.ownerOf"/>
```suggestion:-0+0 <group-list :groups="data.person.ownerOf"/> ```
hansegucker commented 2023-01-08 12:52:12 +01:00
Owner
Copy link

Please use to attribute

Please use `to` attribute
hansegucker commented 2023-01-08 12:52:12 +01:00
Owner
Copy link

Inline style

Inline style
hansegucker commented 2023-01-08 12:52:13 +01:00
Owner
Copy link

Use to attribute

Use `to` attribute
hansegucker commented 2023-01-08 12:52:13 +01:00
Owner
Copy link

I think the menu should get its own subcomponent.

I think the menu should get its own subcomponent.
hansegucker commented 2023-01-08 12:52:13 +01:00
Owner
Copy link

Use to attribute

Use `to` attribute
hansegucker commented 2023-01-08 12:52:13 +01:00
Owner
Copy link

Has this to be here or can it be moved to a computed property?

Has this to be here or can it be moved to a `computed` property?
hansegucker commented 2023-01-08 12:52:13 +01:00
Owner
Copy link

https://booking.katharineum.de/Katharineum/sextaneranmeldung-2023/

https://booking.katharineum.de/Katharineum/sextaneranmeldung-2023/
hansegucker commented 2023-01-08 12:52:14 +01:00
Owner
Copy link

This should use the name of the route and not the URL.

This should use the name of the route and not the URL.
hansegucker commented 2023-01-08 12:52:14 +01:00
Owner
Copy link

Shouldn't this make use of translation as its shown in the frontend?

Shouldn't this make use of translation as its shown in the frontend?
hansegucker commented 2023-01-08 12:52:14 +01:00
Owner
Copy link

Shouldn't this make use of translation as its shown in the frontend?

Shouldn't this make use of translation as its shown in the frontend?
hansegucker commented 2023-01-08 12:52:51 +01:00
Owner
Copy link

Ah, and what's the issue with the icons?

Ah, and what's the issue with the icons?
yuha commented 2023-01-08 14:33:50 +01:00
Author
Member
Copy link

added 3 commits

  • 5fb28d00 - Re-implement PWA via vite-pwa/workbox
  • 5d83f5b3 - Basic implementation of persisting of apollo cache
  • 21c86b90 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 3 commits <ul><li>5fb28d00 - Re-implement PWA via vite-pwa/workbox</li><li>5d83f5b3 - Basic implementation of persisting of apollo cache</li><li>21c86b90 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26607&start_sha=7cc1915c3bd43388998584a19b53bc4d97f8da5a)
nik commented 2023-01-08 14:44:45 +01:00
Owner
Copy link

added 2 commits

  • bf0d9abc - Merge message loading into aleksisAppImporter
  • d4a8a5d6 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>bf0d9abc - Merge message loading into aleksisAppImporter</li><li>d4a8a5d6 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26609&start_sha=21c86b90fe71912fc99352c87e12962b8103a61e)
nik commented 2023-01-08 14:47:06 +01:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c7a38b9c - Update copyright years</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26611&start_sha=d4a8a5d63833498f6f19f98d572230d4892518b6)
yuha commented 2023-01-08 14:58:34 +01:00
Author
Member
Copy link

added 1 commit

  • 8b6bd8fe - Merge message loading into aleksisAppImporter

Compare with previous version

added 1 commit <ul><li>8b6bd8fe - Merge message loading into aleksisAppImporter</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26613&start_sha=c7a38b9c9e8b3e8a229901b2404f35b81f37cfcf)
nik commented 2023-01-08 15:08:46 +01:00
Owner
Copy link

added 5 commits

  • bf0d9abc - Merge message loading into aleksisAppImporter
  • d4a8a5d6 - Merge branch '759-finalise-vuetify-app-as-spa' of...
  • c7a38b9c - Update copyright years
  • 6781a772 - Load messages from separate language files
  • 3700581a - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 5 commits <ul><li>bf0d9abc - Merge message loading into aleksisAppImporter</li><li>d4a8a5d6 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li><li>c7a38b9c - Update copyright years</li><li>6781a772 - Load messages from separate language files</li><li>3700581a - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26615&start_sha=8b6bd8fea0d884bc311be124d44278a9860a0b90)
yuha commented 2023-01-08 15:38:47 +01:00
Author
Member
Copy link

changed this line in version 81 of the diff

changed this line in [version 81 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26617&start_sha=3700581a2ad9e5167eca880444228dca36ef9dcb#690e1f8a19aae102ab892ad7184ccec21af313be_129_127)
yuha commented 2023-01-08 15:38:47 +01:00
Author
Member
Copy link

changed this line in version 81 of the diff

changed this line in [version 81 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26617&start_sha=3700581a2ad9e5167eca880444228dca36ef9dcb#690e1f8a19aae102ab892ad7184ccec21af313be_132_129)
yuha commented 2023-01-08 15:38:48 +01:00
Author
Member
Copy link

added 2 commits

  • 29be87f9 - Use more general and translated error messages for GraphQL and Network error snackbars
  • 5638b59a - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>29be87f9 - Use more general and translated error messages for GraphQL and Network error snackbars</li><li>5638b59a - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26617&start_sha=3700581a2ad9e5167eca880444228dca36ef9dcb)
hansegucker commented 2023-01-08 15:49:21 +01:00
Owner
Copy link

added 2 commits

  • 72ad2fad - Fix import of messages from core
  • 6b444987 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>72ad2fad - Fix import of messages from core</li><li>6b444987 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26619&start_sha=5638b59a9b980667321c671763c49fc74f816957)
yuha commented 2023-01-08 16:16:33 +01:00
Author
Member
Copy link

changed this line in version 83 of the diff

changed this line in [version 83 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26622&start_sha=6b4449872a2acce76c6b3465485f09c0e4271068#f0c14a43f9188678bdd7e8ab7fdd82580f1bdf91_7_7)
yuha commented 2023-01-08 16:16:33 +01:00
Author
Member
Copy link

changed this line in version 83 of the diff

changed this line in [version 83 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26622&start_sha=6b4449872a2acce76c6b3465485f09c0e4271068#4fd310df6f6343f9412024891dfbd83ceb0496dc_11_11)
yuha commented 2023-01-08 16:16:34 +01:00
Author
Member
Copy link

changed this line in version 83 of the diff

changed this line in [version 83 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26622&start_sha=6b4449872a2acce76c6b3465485f09c0e4271068#4fd310df6f6343f9412024891dfbd83ceb0496dc_88_88)
yuha commented 2023-01-08 16:16:34 +01:00
Author
Member
Copy link

changed this line in version 83 of the diff

changed this line in [version 83 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26622&start_sha=6b4449872a2acce76c6b3465485f09c0e4271068#4fd310df6f6343f9412024891dfbd83ceb0496dc_262_262)
yuha commented 2023-01-08 16:16:35 +01:00
Author
Member
Copy link

added 1 commit

  • 7fbb34e0 - Use :to instead of router.push

Compare with previous version

added 1 commit <ul><li>7fbb34e0 - Use :to instead of router.push</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26622&start_sha=6b4449872a2acce76c6b3465485f09c0e4271068)
yuha commented 2023-01-08 16:19:09 +01:00
Author
Member
Copy link

v-toolbar-title does not support the to attribute

v-toolbar-title does not support the `to` attribute
yuha commented 2023-01-08 16:19:35 +01:00
Author
Member
Copy link

It is not possible to use the ´to´ attribute here.

It is not possible to use the ´to´ attribute here.
yuha commented 2023-01-08 16:21:18 +01:00
Author
Member
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26626&start_sha=7fbb34e026c0cbc75f39dc038e238fbdeeaaac99#8daa6b4f199cea98a183931c63e178f0ecd64096_4_4)
yuha commented 2023-01-08 16:21:20 +01:00
Author
Member
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26626&start_sha=7fbb34e026c0cbc75f39dc038e238fbdeeaaac99#aac9e5ae565a13a51784a5c1c4bf6ef04b223733_13_13)
yuha commented 2023-01-08 16:21:21 +01:00
Author
Member
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26626&start_sha=7fbb34e026c0cbc75f39dc038e238fbdeeaaac99#af17fcdb840543d152163cdc0a48402553c78cef_4_4)
yuha commented 2023-01-08 16:21:21 +01:00
Author
Member
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26626&start_sha=7fbb34e026c0cbc75f39dc038e238fbdeeaaac99#64da203ce8f401ec9e1b0f823fbcb30ec0f85a19_11_11)
yuha commented 2023-01-08 16:21:21 +01:00
Author
Member
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26626&start_sha=7fbb34e026c0cbc75f39dc038e238fbdeeaaac99#e8f052e66a8e1508929c23b1b93f48c111cf1ecb_4_4)
yuha commented 2023-01-08 16:21:22 +01:00
Author
Member
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26626&start_sha=7fbb34e026c0cbc75f39dc038e238fbdeeaaac99#e8f052e66a8e1508929c23b1b93f48c111cf1ecb_30_30)
yuha commented 2023-01-08 16:21:22 +01:00
Author
Member
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26626&start_sha=7fbb34e026c0cbc75f39dc038e238fbdeeaaac99#e8f052e66a8e1508929c23b1b93f48c111cf1ecb_51_51)
yuha commented 2023-01-08 16:21:22 +01:00
Author
Member
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26626&start_sha=7fbb34e026c0cbc75f39dc038e238fbdeeaaac99#e8f052e66a8e1508929c23b1b93f48c111cf1ecb_169_169)
yuha commented 2023-01-08 16:21:23 +01:00
Author
Member
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26626&start_sha=7fbb34e026c0cbc75f39dc038e238fbdeeaaac99#e8f052e66a8e1508929c23b1b93f48c111cf1ecb_180_180)
yuha commented 2023-01-08 16:21:23 +01:00
Author
Member
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26626&start_sha=7fbb34e026c0cbc75f39dc038e238fbdeeaaac99#e8f052e66a8e1508929c23b1b93f48c111cf1ecb_184_184)
yuha commented 2023-01-08 16:21:23 +01:00
Author
Member
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26626&start_sha=7fbb34e026c0cbc75f39dc038e238fbdeeaaac99#e8f052e66a8e1508929c23b1b93f48c111cf1ecb_199_199)
yuha commented 2023-01-08 16:21:24 +01:00
Author
Member
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26626&start_sha=7fbb34e026c0cbc75f39dc038e238fbdeeaaac99#e8f052e66a8e1508929c23b1b93f48c111cf1ecb_205_205)
yuha commented 2023-01-08 16:21:26 +01:00
Author
Member
Copy link

added 1 commit

  • ab6b649c - Reformat person-page related code

Compare with previous version

added 1 commit <ul><li>ab6b649c - Reformat person-page related code</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26626&start_sha=7fbb34e026c0cbc75f39dc038e238fbdeeaaac99)
hansegucker commented 2023-01-08 16:25:40 +01:00
Owner
Copy link

added 3 commits

  • 26e9feb5 - Translated using Weblate (German)
  • 9c44b6d8 - Translated using Weblate (German)
  • a652ac05 - Merge branch 'weblate-frontend' into '759-finalise-vuetify-app-as-spa'

Compare with previous version

added 3 commits <ul><li>26e9feb5 - Translated using Weblate (German)</li><li>9c44b6d8 - Translated using Weblate (German)</li><li>a652ac05 - Merge branch &#39;weblate-frontend&#39; into &#39;759-finalise-vuetify-app-as-spa&#39;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26634&start_sha=ab6b649c634f5f98139599f32af72f10262a746c)
yuha commented 2023-01-08 16:43:47 +01:00
Author
Member
Copy link

changed this line in version 86 of the diff

changed this line in [version 86 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26636&start_sha=a652ac0520c0e9f04da51c233f80e9894c6109e1#27807a50f51dc0b1f7e6d3a6ed0aee8174477110_5_5)
yuha commented 2023-01-08 16:43:50 +01:00
Author
Member
Copy link

added 2 commits

  • bcf7e763 - Remove inline style & adjust iframe width
  • c1119c38 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>bcf7e763 - Remove inline style &amp; adjust iframe width</li><li>c1119c38 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26636&start_sha=a652ac0520c0e9f04da51c233f80e9894c6109e1)
yuha commented 2023-01-08 16:51:28 +01:00
Author
Member
Copy link

changed this line in version 87 of the diff

changed this line in [version 87 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26638&start_sha=c1119c3814d0fc3a6da0fe8edbdd4f21fefb8861#a1578eee22804fb064b4d1a812d29edcf846084c_5_5)
yuha commented 2023-01-08 16:51:31 +01:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f5034217 - Remove inline styles</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26638&start_sha=c1119c3814d0fc3a6da0fe8edbdd4f21fefb8861)
yuha commented 2023-01-09 18:02:10 +01:00
Author
Member
Copy link

changed this line in version 88 of the diff

changed this line in [version 88 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26653&start_sha=f5034217f99949d63c074f040cedff5b971d7010#ad8792730df8af7b98b8c9b20befbb68096a08de_6_0)
yuha commented 2023-01-09 18:02:11 +01:00
Author
Member
Copy link

changed this line in version 88 of the diff

changed this line in [version 88 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26653&start_sha=f5034217f99949d63c074f040cedff5b971d7010#18c2c57fbfdb3dafd264f1e4a4eab1a8c6ab10bb_34_34)
yuha commented 2023-01-09 18:02:13 +01:00
Author
Member
Copy link

added 1 commit

  • b0916a64 - Fix handling of whoAmI query

Compare with previous version

added 1 commit <ul><li>b0916a64 - Fix handling of whoAmI query</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26653&start_sha=f5034217f99949d63c074f040cedff5b971d7010)
yuha commented 2023-01-09 18:20:36 +01:00
Author
Member
Copy link

added 3 commits

  • bea8a5a0 - Fix handling of whoAmI query
  • e7981fbd - Refetch permissions when whoAmI query changes
  • 8bdb97bb - Add mission messages for GraphQL and natwork errors

Compare with previous version

added 3 commits <ul><li>bea8a5a0 - Fix handling of whoAmI query</li><li>e7981fbd - Refetch permissions when whoAmI query changes</li><li>8bdb97bb - Add mission messages for GraphQL and natwork errors</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26656&start_sha=b0916a64c303e794985c5a2de7e7e9bc8ea4147f)
yuha commented 2023-01-09 19:43:30 +01:00
Author
Member
Copy link

added 3 commits

  • c3a40d2c - Fix handling of whoAmI query
  • 6c19752b - Refetch permissions when whoAmI query changes
  • 86bbe6ba - Add mission messages for GraphQL and natwork errors

Compare with previous version

added 3 commits <ul><li>c3a40d2c - Fix handling of whoAmI query</li><li>6c19752b - Refetch permissions when whoAmI query changes</li><li>86bbe6ba - Add mission messages for GraphQL and natwork errors</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26658&start_sha=8bdb97bbabdfbec911d53066202760c5ab21e1f2)
hansegucker commented 2023-01-10 20:29:06 +01:00
Owner
Copy link

changed this line in version 91 of the diff

changed this line in [version 91 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26664&start_sha=86bbe6ba01b9944df5551102d14bdba6c8c47870#aac9e5ae565a13a51784a5c1c4bf6ef04b223733_41_34)
hansegucker commented 2023-01-10 20:29:07 +01:00
Owner
Copy link

added 4 commits

  • 292afdae - Fix origin of Vite to properly include font files
  • dbd57df3 - Merge branch '759-finalise-vuetify-app-as-spa' of...
  • d749e968 - Fix integration of celery progress and PDF generation with SPA
  • c227040c - Reformat and fix lint

Compare with previous version

added 4 commits <ul><li>292afdae - Fix origin of Vite to properly include font files</li><li>dbd57df3 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li><li>d749e968 - Fix integration of celery progress and PDF generation with SPA</li><li>c227040c - Reformat and fix lint</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26664&start_sha=86bbe6ba01b9944df5551102d14bdba6c8c47870)
yuha commented 2023-01-11 14:23:12 +01:00
Author
Member
Copy link

which part of the marked section of code do you mean exactly?

which part of the marked section of code do you mean exactly?
hansegucker commented 2023-01-11 21:36:49 +01:00
Owner
Copy link

added 1 commit

  • 043ec38b - Add management command for converting Django URLs to vue-router routes

Compare with previous version

added 1 commit <ul><li>043ec38b - Add management command for converting Django URLs to vue-router routes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26673&start_sha=c227040c1b72a367a14d644129287da2e3e5c7d6)
leuckeju commented 2023-01-12 02:22:41 +01:00
Member
Copy link

added 7 commits

  • 2fc23bc9 - Check for permissions in person api
  • b45b716e - Display action menu only when it has contents
  • 5875faa6 - Replace spinning loader with splashscreen
  • 3a77c298 - Reformat
  • 580daccf - Introduce generic detailview component
  • c344c607 - Move styles from personactions to detailview
  • 7ce41d31 - Create generic ListView component

Compare with previous version

added 7 commits <ul><li>2fc23bc9 - Check for permissions in person api</li><li>b45b716e - Display action menu only when it has contents</li><li>5875faa6 - Replace spinning loader with splashscreen</li><li>3a77c298 - Reformat</li><li>580daccf - Introduce generic detailview component</li><li>c344c607 - Move styles from personactions to detailview</li><li>7ce41d31 - Create generic ListView component</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26679&start_sha=043ec38beaebd35a71c47c8128ad72d6809a0876)
yuha commented 2023-01-13 16:18:38 +01:00
Author
Member
Copy link

added 2 commits

  • 03a79765 - Introduce method for permission checking
  • 8d20bd50 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>03a79765 - Introduce method for permission checking</li><li>8d20bd50 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26692&start_sha=7ce41d311541774a4ad455da87712bf8b7216849)
yuha commented 2023-01-13 19:31:17 +01:00
Author
Member
Copy link

added 1 commit

  • 61e66423 - Fix check if messages exist when writing django vite values

Compare with previous version

added 1 commit <ul><li>61e66423 - Fix check if messages exist when writing django vite values</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26694&start_sha=8d20bd5012e0015149be5564fad757e8c5f43828)
hansegucker commented 2023-01-13 19:39:47 +01:00
Owner
Copy link

added 2 commits

  • cd4f2ff1 - Fix translations and string format
  • de48aeb8 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>cd4f2ff1 - Fix translations and string format</li><li>de48aeb8 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26696&start_sha=61e66423b8eb1df557cafd10d24d483bfec05ddd)
hansegucker commented 2023-01-13 20:28:30 +01:00
Owner
Copy link

added 1 commit

  • e9ee272e - Open external links within iframe in _blank target

Compare with previous version

added 1 commit <ul><li>e9ee272e - Open external links within iframe in _blank target</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26698&start_sha=de48aeb8bd42becd9cf76709ff45254a0ec4a575)
nik commented 2023-01-13 21:05:22 +01:00
Owner
Copy link

added 3 commits

  • 5c857efc - Ignore more files in vite watcher
  • 5df853ce - Implement title handling in SPA
  • 6ffb85c7 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 3 commits <ul><li>5c857efc - Ignore more files in vite watcher</li><li>5df853ce - Implement title handling in SPA</li><li>6ffb85c7 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26700&start_sha=e9ee272ece374215e1dc1a4925ef8a12886d70a8)
hansegucker commented 2023-01-13 21:37:58 +01:00
Owner
Copy link

added 2 commits

  • a2700f56 - Support validators for menu items and optimize permission fetching
  • 38fac866 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>a2700f56 - Support validators for menu items and optimize permission fetching</li><li>38fac866 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26703&start_sha=6ffb85c7734590ab636d8850cdc257d10754f76e)
leuckeju commented 2023-01-13 22:30:51 +01:00
Member
Copy link

added 5 commits

  • 99a7006c - Add direct url for site logo
  • cdd89dc5 - Update splash screen design
  • cd320623 - Use same splash screen design in vue and non-vue
  • 120fe0b0 - Generalize avatar click box
  • fe5a8b00 - Merge remote-tracking branch 'origin/759-finalise-vuetify-app-as-spa' into...

Compare with previous version

added 5 commits <ul><li>99a7006c - Add direct url for site logo</li><li>cdd89dc5 - Update splash screen design</li><li>cd320623 - Use same splash screen design in vue and non-vue</li><li>120fe0b0 - Generalize avatar click box</li><li>fe5a8b00 - Merge remote-tracking branch &#39;origin/759-finalise-vuetify-app-as-spa&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26705&start_sha=38fac86648516d5b825e230f1b82fcde3ae97c69)
leuckeju commented 2023-01-13 22:33:09 +01:00
Member
Copy link

added 1 commit

  • d31e344b - Apply classes to action component

Compare with previous version

added 1 commit <ul><li>d31e344b - Apply classes to action component</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26707&start_sha=fe5a8b00b9197bc2cac9a11349d243a8614ba66a)
hansegucker commented 2023-01-13 23:11:40 +01:00
Owner
Copy link

added 3 commits

Compare with previous version

added 3 commits <ul><li>1c176ca5 - Add lint for vue-i18n</li><li>bc5aa74f - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li><li>ed1b29cc - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26709&start_sha=d31e344b610148b3b41b8a3b46fcf9649e730e35)
leuckeju commented 2023-01-13 23:24:47 +01:00
Member
Copy link

added 3 commits

  • 4495605a - Generic Button Menu component
  • e3054ad0 - Use different logo link in splash screen
  • 0e7d441e - Merge remote-tracking branch 'origin/759-finalise-vuetify-app-as-spa' into...

Compare with previous version

added 3 commits <ul><li>4495605a - Generic Button Menu component</li><li>e3054ad0 - Use different logo link in splash screen</li><li>0e7d441e - Merge remote-tracking branch &#39;origin/759-finalise-vuetify-app-as-spa&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26711&start_sha=ed1b29cc959b03f1d753caa807248186998adf6c)
nik commented 2023-01-13 23:27:45 +01:00
Owner
Copy link

added 1 commit

  • d485abcb - Remove unused django-redis dependency

Compare with previous version

added 1 commit <ul><li>d485abcb - Remove unused django-redis dependency</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26714&start_sha=0e7d441ecb3c4ebf6092651eff462279367adaab)
hansegucker commented 2023-01-13 23:52:48 +01:00
Owner
Copy link

added 2 commits

  • 23d4011b - Fix menu generation for logged-out users
  • f9260c7a - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>23d4011b - Fix menu generation for logged-out users</li><li>f9260c7a - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26716&start_sha=d485abcb2da94897f56d15606bc9a616bbba6056)
leuckeju commented 2023-01-13 23:54:10 +01:00
Member
Copy link

added 2 commits

  • eb250ebf - Adjust position of loader in splash
  • 4133826f - Merge remote-tracking branch 'origin/759-finalise-vuetify-app-as-spa' into...

Compare with previous version

added 2 commits <ul><li>eb250ebf - Adjust position of loader in splash</li><li>4133826f - Merge remote-tracking branch &#39;origin/759-finalise-vuetify-app-as-spa&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26718&start_sha=f9260c7a3a76c2ec786453eb76a1bce20f9ad4d7)
hansegucker commented 2023-01-14 00:09:28 +01:00
Owner
Copy link

added 2 commits

  • 2ec3a66c - Drop old person template and view
  • ddee94a1 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>2ec3a66c - Drop old person template and view</li><li>ddee94a1 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26720&start_sha=4133826f3766ac3b285677965add8935a7e8c619)
hansegucker commented 2023-01-14 00:11:11 +01:00
Owner
Copy link

added 2 commits

  • a34a164b - Merge branch '759-finalise-vuetify-app-as-spa' of...
  • 905949fd - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>a34a164b - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li><li>905949fd - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26722&start_sha=ddee94a1888c4dfb25edc4b46954ba958d447798)
hansegucker commented 2023-01-14 00:30:56 +01:00
Owner
Copy link

added 1 commit

  • 96b512e0 - Set correct page title on person overview page

Compare with previous version

added 1 commit <ul><li>96b512e0 - Set correct page title on person overview page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26724&start_sha=905949fd52b780a00a206da46e19efa10dc45c29)
nik commented 2023-01-14 01:42:32 +01:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>dbdc3354 - Fix grammar</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26726&start_sha=96b512e0990b1469b52fe8c0494fa69257c74696)
yuha commented 2023-01-14 03:22:01 +01:00
Author
Member
Copy link

added 6 commits

  • 3a46ce16 - Remove check for dark theme in vue
  • ee19672f - Add basic offline check and indicator
  • 9cde1628 - WIP: Offline indicator
  • 619810ac - Async restore persisted apollo queries
  • 1f69c8d3 - PWA fixes
  • 74e2e2cf - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 6 commits <ul><li>3a46ce16 - Remove check for dark theme in vue</li><li>ee19672f - Add basic offline check and indicator</li><li>9cde1628 - WIP: Offline indicator</li><li>619810ac - Async restore persisted apollo queries</li><li>1f69c8d3 - PWA fixes</li><li>74e2e2cf - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26728&start_sha=dbdc33547f7feeca90b1d790fdc114ab238dfa22)
nik commented 2023-01-14 13:45:42 +01:00
Owner
Copy link

changed this line in version 112 of the diff

changed this line in [version 112 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26732&start_sha=74e2e2cf594940952fcbdd19fc29707ded4eaeb9#4fd310df6f6343f9412024891dfbd83ceb0496dc_139_0)
nik commented 2023-01-14 13:45:43 +01:00
Owner
Copy link

changed this line in version 112 of the diff

changed this line in [version 112 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26732&start_sha=74e2e2cf594940952fcbdd19fc29707ded4eaeb9#4fd310df6f6343f9412024891dfbd83ceb0496dc_5_0)
nik commented 2023-01-14 13:45:47 +01:00
Owner
Copy link

changed this line in version 112 of the diff

changed this line in [version 112 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26732&start_sha=74e2e2cf594940952fcbdd19fc29707ded4eaeb9#4fd310df6f6343f9412024891dfbd83ceb0496dc_218_0)
nik commented 2023-01-14 13:45:47 +01:00
Owner
Copy link

changed this line in version 112 of the diff

changed this line in [version 112 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26732&start_sha=74e2e2cf594940952fcbdd19fc29707ded4eaeb9#4fd310df6f6343f9412024891dfbd83ceb0496dc_225_0)
nik commented 2023-01-14 13:45:48 +01:00
Owner
Copy link

added 1 commit

  • 68568dcc - [Refactor] Move root app components into directory

Compare with previous version

added 1 commit <ul><li>68568dcc - [Refactor] Move root app components into directory</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26732&start_sha=74e2e2cf594940952fcbdd19fc29707ded4eaeb9)
nik commented 2023-01-14 15:54:20 +01:00
Owner
Copy link

added 1 commit

  • 9369709a - [Refactor] Split configuration for Vue plugins

Compare with previous version

added 1 commit <ul><li>9369709a - [Refactor] Split configuration for Vue plugins</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26734&start_sha=68568dccd143352aa92baf3cd06ada57163f395a)
nik commented 2023-01-14 18:03:16 +01:00
Owner
Copy link

added 1 commit

  • 59587d87 - [Refactor] Comment JS infrastructure code

Compare with previous version

added 1 commit <ul><li>59587d87 - [Refactor] Comment JS infrastructure code</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26739&start_sha=9369709a5027b0c7b873ef597a3895e9fb67c065)
nik commented 2023-01-14 18:52:52 +01:00
Owner
Copy link

added 2 commits

  • 191be41d - [Refactor] Move root menu code to mixin
  • 2992a42b - [Refactor] Move offline code into mixin

Compare with previous version

added 2 commits <ul><li>191be41d - [Refactor] Move root menu code to mixin</li><li>2992a42b - [Refactor] Move offline code into mixin</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26741&start_sha=59587d87765aca8f42d391294f00c810615a7fd4)
nik commented 2023-01-14 19:26:12 +01:00
Owner
Copy link

added 1 commit

  • c5c506ca - [Refactor] Do some basic cleanup of components

Compare with previous version

added 1 commit <ul><li>c5c506ca - [Refactor] Do some basic cleanup of components</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26743&start_sha=2992a42b39b97aec213017102eb6a663dc9d3d60)
nik commented 2023-01-14 19:31:16 +01:00
Owner
Copy link

added 1 commit

  • 723a9d51 - [Refactor] Get rid of window.app

Compare with previous version

added 1 commit <ul><li>723a9d51 - [Refactor] Get rid of window.app</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26745&start_sha=c5c506ca002df010fe69bfef87e2dee5a038e7e9)
nik commented 2023-01-14 20:30:22 +01:00
Owner
Copy link

added 1 commit

  • 2f2e57e1 - Comment parent view components

Compare with previous version

added 1 commit <ul><li>2f2e57e1 - Comment parent view components</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26747&start_sha=723a9d51c6fa8664238541e1aa85fc43f46874b3)
leuckeju commented 2023-01-14 21:47:58 +01:00
Member
Copy link

added 4 commits

  • da315d26 - Fix visual bug
  • b7219f7e - Move sidenav and account menu to separate components
  • 5009ea00 - Run linter/reformatter
  • 8aef51c6 - Merge remote-tracking branch 'origin/759-finalise-vuetify-app-as-spa' into...

Compare with previous version

added 4 commits <ul><li>da315d26 - Fix visual bug</li><li>b7219f7e - Move sidenav and account menu to separate components</li><li>5009ea00 - Run linter/reformatter</li><li>8aef51c6 - Merge remote-tracking branch &#39;origin/759-finalise-vuetify-app-as-spa&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26749&start_sha=2f2e57e1e65418a65e3aa884e507a1fc024cc25c)
nik commented 2023-01-14 21:48:27 +01:00
Owner
Copy link

added 4 commits

  • 01160987 - Remove unused contentLoading code
  • 5c3ac954 - Invalidate application state on route request
  • cae1be6a - [Refactor] Break import lines
  • 864b17a4 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 4 commits <ul><li>01160987 - Remove unused contentLoading code</li><li>5c3ac954 - Invalidate application state on route request</li><li>cae1be6a - [Refactor] Break import lines</li><li>864b17a4 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26750&start_sha=8aef51c670e6cea523e72f5438fe4508140957f7)
nik commented 2023-01-14 22:51:38 +01:00
Owner
Copy link

added 2 commits

  • 6f30a342 - Tidy up some now unused templates
  • 1ef23dd3 - Reimplement passing of settings to frontend

Compare with previous version

added 2 commits <ul><li>6f30a342 - Tidy up some now unused templates</li><li>1ef23dd3 - Reimplement passing of settings to frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26764&start_sha=864b17a49f1560abc9b202793f9ca7c6b7222a8b)
nik commented 2023-01-14 23:01:57 +01:00
Owner
Copy link

added 1 commit

  • 3e55f92c - Remove legacy menu and django-menu-generator

Compare with previous version

added 1 commit <ul><li>3e55f92c - Remove legacy menu and django-menu-generator</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26766&start_sha=1ef23dd3132a2ee91a1c1c492f76c2591688ab92)
nik commented 2023-01-15 01:01:49 +01:00
Owner
Copy link

added 1 commit

  • 1a507966 - Properly handle all offline and invisible states

Compare with previous version

added 1 commit <ul><li>1a507966 - Properly handle all offline and invisible states</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26768&start_sha=3e55f92c46fe611d3f5d298b143f9a76521f3e5a)
hansegucker commented 2023-01-15 12:40:55 +01:00
Owner
Copy link

added 2 commits

  • 9d342298 - Replace ApolloQuery queries by queries registered in component
  • a9fbf395 - Fix lint

Compare with previous version

added 2 commits <ul><li>9d342298 - Replace ApolloQuery queries by queries registered in component</li><li>a9fbf395 - Fix lint</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26770&start_sha=1a507966c61dbcfabe5786e60a8657665386226c)
hansegucker commented 2023-01-15 12:47:36 +01:00
Owner
Copy link

added 2 commits

  • df54daee - Translated using Weblate (German)
  • dd2948e3 - Merge branch 'weblate-frontend' into '759-finalise-vuetify-app-as-spa'

Compare with previous version

added 2 commits <ul><li>df54daee - Translated using Weblate (German)</li><li>dd2948e3 - Merge branch &#39;weblate-frontend&#39; into &#39;759-finalise-vuetify-app-as-spa&#39;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26774&start_sha=a9fbf39562724f69d3b8ca86bb3ae3f37ab401cc)
magicfelix commented 2023-01-15 13:04:26 +01:00
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>954d25bc - Fix undefined variable error</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26776&start_sha=dd2948e397215f208ba304fa1dbe0eda87c4c8ea)
yuha commented 2023-01-15 14:02:47 +01:00
Author
Member
Copy link

added 1 commit

  • 78a8c150 - Remove unneeded styles from LegacyBaseTemplate

Compare with previous version

added 1 commit <ul><li>78a8c150 - Remove unneeded styles from LegacyBaseTemplate</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26778&start_sha=954d25bc51a83db0b4041f3bba3e119e7e70eb5f)
yuha commented 2023-01-15 15:01:39 +01:00
Author
Member
Copy link

added 3 commits

  • 79e28994 - Fix faulty import of SmallContainer
  • cd24c205 - Use revisions for additional PWA precache manifest entries
  • ae80dcbe - Fix sidenav v-model passdown

Compare with previous version

added 3 commits <ul><li>79e28994 - Fix faulty import of SmallContainer</li><li>cd24c205 - Use revisions for additional PWA precache manifest entries</li><li>ae80dcbe - Fix sidenav v-model passdown</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26780&start_sha=78a8c150d5f52e61304de0520600c1e8980c5cb6)
yuha commented 2023-01-15 19:12:15 +01:00
Author
Member
Copy link

added 1 commit

  • 8235063a - Add import for crypto buildin module

Compare with previous version

added 1 commit <ul><li>8235063a - Add import for crypto buildin module</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26792&start_sha=ae80dcbefc1137dbbeb4064b6060bc36d3548fc8)
nik commented 2023-01-15 22:59:39 +01:00
Owner
Copy link

How is theme data loaded now? @hansegucker

How is theme data loaded now? @hansegucker
hansegucker commented 2023-01-15 23:02:02 +01:00
Owner
Copy link

Via a GraphQL query

Via a GraphQL query
nik commented 2023-01-15 23:38:35 +01:00
Owner
Copy link

added 1 commit

  • e0cfa85b - Reintroduce contentLoading loginc for legacy view

Compare with previous version

added 1 commit <ul><li>e0cfa85b - Reintroduce contentLoading loginc for legacy view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26794&start_sha=8235063a060a5cb65be5e5ac6dcc3e3169636083)
leuckeju commented 2023-01-16 00:24:52 +01:00
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>fed01d58 - Fix TypeErrors</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26796&start_sha=e0cfa85bdaa7bfa39ea337fede26ea6c27314d8c)
yuha commented 2023-01-16 00:52:14 +01:00
Author
Member
Copy link

added 3 commits

  • 75e34040 - Remove unnecessage emit on input in SideNav component
  • 5212aca6 - Reformat
  • ed4c83f0 - Remove unnecessary debug console.log

Compare with previous version

added 3 commits <ul><li>75e34040 - Remove unnecessage emit on input in SideNav component</li><li>5212aca6 - Reformat</li><li>ed4c83f0 - Remove unnecessary debug console.log</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26798&start_sha=fed01d58b49f27d0630ae9e53cd69cefbd7a3ae3)
nik commented 2023-01-16 12:42:05 +01:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>faeefcce - Log details of query errors</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26801&start_sha=ed4c83f0b214a8e82de08c73c29bf9d1d2cdbe84)
nik commented 2023-01-16 12:47:15 +01:00
Owner
Copy link

added 1 commit

  • 99114ec8 - Add a fancy welcome log to frontend app

Compare with previous version

added 1 commit <ul><li>99114ec8 - Add a fancy welcome log to frontend app</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26803&start_sha=faeefcce1fd5042f3ced4a6d756c8795195af629)
nik commented 2023-01-16 14:42:15 +01:00
Owner
Copy link

added 2 commits

  • af486758 - Fix typo
  • cd4834b9 - Add utility method to safely add event listener

Compare with previous version

added 2 commits <ul><li>af486758 - Fix typo</li><li>cd4834b9 - Add utility method to safely add event listener</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26805&start_sha=99114ec859ddb73e99b926f439644507ab763e6f)
nik commented 2023-01-16 14:53:03 +01:00
Owner
Copy link

added 1 commit

  • f8d317b1 - Add utility method to safely add event listener

Compare with previous version

added 1 commit <ul><li>f8d317b1 - Add utility method to safely add event listener</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26808&start_sha=cd4834b93e44b197ed331d5886b3a6b940d3253c)
nik commented 2023-01-16 15:01:26 +01:00
Owner
Copy link

added 1 commit

  • e56065d6 - Add utility method to safely add event listener

Compare with previous version

added 1 commit <ul><li>e56065d6 - Add utility method to safely add event listener</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26809&start_sha=f8d317b12132853bc3217d54f64e5384f75c0c20)
nik commented 2023-01-16 16:09:14 +01:00
Owner
Copy link

added 1 commit

  • 45f8c0ed - Rename assets firectory to frontend

Compare with previous version

added 1 commit <ul><li>45f8c0ed - Rename assets firectory to frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26814&start_sha=e56065d644c3909a82de424d7a52812662f36c63)
nik commented 2023-01-16 18:35:41 +01:00
Owner
Copy link

added 1 commit

  • be8f2649 - Allow running vite build from anywhere

Compare with previous version

added 1 commit <ul><li>be8f2649 - Allow running vite build from anywhere</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26817&start_sha=45f8c0ed4c5ac5cfde88f7dc7123a8af44b041a8)
nik commented 2023-01-16 21:41:39 +01:00
Owner
Copy link

added 2 commits

  • 756bd3b3 - Exclude static directories from watching
  • 1ee55ef6 - Support browsers by browserslist

Compare with previous version

added 2 commits <ul><li>756bd3b3 - Exclude static directories from watching</li><li>1ee55ef6 - Support browsers by browserslist</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26821&start_sha=be8f264958a50d23aa969226cfae8a26b8aa62fc)
nik commented 2023-01-16 21:43:17 +01:00
Owner
Copy link

Quote @yuha : "Das wurde als irrelevant beurteilt"

Quote @yuha : "Das wurde als irrelevant beurteilt"
nik commented 2023-01-16 21:43:46 +01:00
Owner
Copy link

resolved all threads

resolved all threads
nik commented 2023-01-16 21:59:45 +01:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3f6f39db - Fix non-selenium tests</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26824&start_sha=1ee55ef6f138c98c327be58206038c0982c15c8b)
yuha commented 2023-01-16 22:10:19 +01:00
Author
Member
Copy link

added 2 commits

  • bc21c371 - Manage snackbar items (for GraphQL errors) with root data instead of apollo state management
  • 2a72739c - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>bc21c371 - Manage snackbar items (for GraphQL errors) with root data instead of apollo state management</li><li>2a72739c - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26826&start_sha=3f6f39dbc6d5edf521fbe636b736fc9ea85b9fda)
yuha commented 2023-01-16 22:22:29 +01:00
Author
Member
Copy link

added 1 commit

  • beb79dde - Set contentLoading to false on mounted

Compare with previous version

added 1 commit <ul><li>beb79dde - Set contentLoading to false on mounted</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26828&start_sha=2a72739c2352db30fe5e76a7f6231722c8de57f4)
nik commented 2023-01-16 23:57:30 +01:00
Owner
Copy link

added 2 commits

  • 27860514 - Catch race condition when removing event handlers
  • 93bc8cea - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>27860514 - Catch race condition when removing event handlers</li><li>93bc8cea - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26829&start_sha=beb79ddea091aa19e2f8f89799169799b2c0eb27)
nik commented 2023-01-17 00:06:39 +01:00
Owner
Copy link

added 2 commits

  • ca2df622 - Remove test for "not linked to a person" text
  • 5a9520e0 - Update Python versions in tox

Compare with previous version

added 2 commits <ul><li>ca2df622 - Remove test for &quot;not linked to a person&quot; text</li><li>5a9520e0 - Update Python versions in tox</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26830&start_sha=93bc8ceafe367f40a504403b283fa24bedd2890b)
yuha commented 2023-01-17 01:12:01 +01:00
Author
Member
Copy link

added 3 commits

  • 54057af1 - Do not send snackbar error messages when offline status is detected
  • 01f8b8dc - Turn off timeout on PWA update snackbar
  • 4242cd64 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 3 commits <ul><li>54057af1 - Do not send snackbar error messages when offline status is detected</li><li>01f8b8dc - Turn off timeout on PWA update snackbar</li><li>4242cd64 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26832&start_sha=5a9520e0a6ab12ce605be989dbc93713206688d8)
nik commented 2023-01-17 01:17:24 +01:00
Owner
Copy link

added 2 commits

  • 5cfd6234 - Fix Sentry import in frontend
  • 3fcbb698 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>5cfd6234 - Fix Sentry import in frontend</li><li>3fcbb698 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26835&start_sha=4242cd6424e7dc5207af0c5feb465808d155e7ab)
nik commented 2023-01-17 01:18:04 +01:00
Owner
Copy link

added 1 commit

  • 71eed661 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 1 commit <ul><li>71eed661 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26837&start_sha=3fcbb6987d304a605a8772eb75b7813f5387c579)
nik commented 2023-01-17 01:21:47 +01:00
Owner
Copy link

added 1 commit

  • 65b864f8 - Fix typo in readme copyright list

Compare with previous version

added 1 commit <ul><li>65b864f8 - Fix typo in readme copyright list</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26839&start_sha=71eed6615b502cca522a5ecf0a6323e1d01e973b)
yuha commented 2023-01-17 13:03:19 +01:00
Author
Member
Copy link

added 2 commits

  • 0af0ff36 - Only skip queries that have pollInterval set on offline/background
  • ab6da63e - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>0af0ff36 - Only skip queries that have pollInterval set on offline/background</li><li>ab6da63e - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26845&start_sha=65b864f8e8cab3033a9d13e274f3d123958d6275)
yuha commented 2023-01-17 13:06:47 +01:00
Author
Member
Copy link

added 1 commit

  • 73db349f - Only skip queries that have pollInterval set on offline/background

Compare with previous version

added 1 commit <ul><li>73db349f - Only skip queries that have pollInterval set on offline/background</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26848&start_sha=ab6da63e2f90756c139a91e4056dbf34dd8123db)
leuckeju commented 2023-01-17 15:09:16 +01:00
Member
Copy link

added 1 commit

  • 74437eed - Prevent loader clipping into site logo on splash screen

Compare with previous version

added 1 commit <ul><li>74437eed - Prevent loader clipping into site logo on splash screen</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26850&start_sha=73db349f57651b70a36d6970fc8045766e2dbb91)
leuckeju commented 2023-01-17 15:15:13 +01:00
Member
Copy link

added 1 commit

  • 21f9def6 - Fix bug caused by wrong copy-paste

Compare with previous version

added 1 commit <ul><li>21f9def6 - Fix bug caused by wrong copy-paste</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26852&start_sha=74437eed8e50f12cf4fb008c430584b5a64cc830)
yuha commented 2023-01-17 16:05:17 +01:00
Author
Member
Copy link

added 2 commits

  • e9fcf538 - Generalize error page
  • 4201332e - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 2 commits <ul><li>e9fcf538 - Generalize error page</li><li>4201332e - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26854&start_sha=21f9def6c408e47ebce9a2fb0de40b8a28f58f70)
yuha commented 2023-01-17 16:10:08 +01:00
Author
Member
Copy link

added 1 commit

  • 76648f59 - Change wording of legacy offline page

Compare with previous version

added 1 commit <ul><li>76648f59 - Change wording of legacy offline page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26856&start_sha=4201332ef15a89ce89f6d6f9ef458d3bc68f5900)
nik commented 2023-01-17 17:27:01 +01:00
Owner
Copy link

added 1 commit

  • 049ee418 - Add app import aliases for frontend

Compare with previous version

added 1 commit <ul><li>049ee418 - Add app import aliases for frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26858&start_sha=76648f59eafd1e66a5c136a3f1355977d29c9755)
leuckeju commented 2023-01-17 17:33:27 +01:00
Member
Copy link

added 4 commits

  • 85d9ce7f - Display query path in graphql console errors
  • 7a7e2acb - Create object overview component
  • bb8eac61 - Refactor person overview component to use overview component
  • 74426b92 - Merge remote-tracking branch 'origin/759-finalise-vuetify-app-as-spa' into...

Compare with previous version

added 4 commits <ul><li>85d9ce7f - Display query path in graphql console errors</li><li>7a7e2acb - Create object overview component</li><li>bb8eac61 - Refactor person overview component to use overview component</li><li>74426b92 - Merge remote-tracking branch &#39;origin/759-finalise-vuetify-app-as-spa&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26860&start_sha=049ee418eb522d0afd5611f2ee3bb5bdb8ab5a26)
nik commented 2023-01-17 17:51:53 +01:00
Owner
Copy link

added 1 commit

  • 1869ee70 - Add app import aliases for frontend

Compare with previous version

added 1 commit <ul><li>1869ee70 - Add app import aliases for frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26863&start_sha=74426b9250feaac11edf7c44491b54a997ab2824)
leuckeju commented 2023-01-17 17:56:02 +01:00
Member
Copy link

added 7 commits

  • 049ee418 - Add app import aliases for frontend
  • 85d9ce7f - Display query path in graphql console errors
  • 7a7e2acb - Create object overview component
  • bb8eac61 - Refactor person overview component to use overview component
  • 74426b92 - Merge remote-tracking branch 'origin/759-finalise-vuetify-app-as-spa' into...
  • 73851823 - Silence graphql errors in object overview
  • bf0a88a0 - Merge remote-tracking branch 'origin/759-finalise-vuetify-app-as-spa' into...

Compare with previous version

added 7 commits <ul><li>049ee418 - Add app import aliases for frontend</li><li>85d9ce7f - Display query path in graphql console errors</li><li>7a7e2acb - Create object overview component</li><li>bb8eac61 - Refactor person overview component to use overview component</li><li>74426b92 - Merge remote-tracking branch &#39;origin/759-finalise-vuetify-app-as-spa&#39; into...</li><li>73851823 - Silence graphql errors in object overview</li><li>bf0a88a0 - Merge remote-tracking branch &#39;origin/759-finalise-vuetify-app-as-spa&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26865&start_sha=1869ee7023b431fb20c9f24fb2d74892d2295334)
leuckeju commented 2023-01-17 17:58:27 +01:00
Member
Copy link

added 1 commit

  • d6f9f204 - Change button text on error page

Compare with previous version

added 1 commit <ul><li>d6f9f204 - Change button text on error page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26867&start_sha=bf0a88a072f67a65a7d877ffd1a57f4a96a6d56f)
yuha commented 2023-01-17 21:54:12 +01:00
Author
Member
Copy link

added 4 commits

  • 5d084463 - Change including mechanism for app routes
  • bd81304f - Merge branch '759-finalise-vuetify-app-as-spa' of...
  • 10ed3521 - Hide custom footer menu when no items are present
  • 2e5efdf6 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 4 commits <ul><li>5d084463 - Change including mechanism for app routes</li><li>bd81304f - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li><li>10ed3521 - Hide custom footer menu when no items are present</li><li>2e5efdf6 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26869&start_sha=d6f9f20493c779496e9c4651374ef722805fc1ea)
hansegucker commented 2023-01-17 22:17:52 +01:00
Owner
Copy link

added 1 commit

  • 7d2e70a6 - [Tests] Deactivate Selenium test for PDF generation for now

Compare with previous version

added 1 commit <ul><li>7d2e70a6 - [Tests] Deactivate Selenium test for PDF generation for now</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26871&start_sha=2e5efdf61f97478feb3cb886b8aa7dc9b5daf727)
hansegucker commented 2023-01-17 23:27:05 +01:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e996102f - Reformat and fix lint issues</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26873&start_sha=7d2e70a60971677357f76637b7a149cb345eec65)
yuha commented 2023-01-18 01:05:04 +01:00
Author
Member
Copy link

added 3 commits

  • 3fdfc7ca - Add validator to check for hasPerson
  • b9573862 - Beautify skeleton loader in sidenav menu
  • 29665358 - Merge branch '759-finalise-vuetify-app-as-spa' of...

Compare with previous version

added 3 commits <ul><li>3fdfc7ca - Add validator to check for hasPerson</li><li>b9573862 - Beautify skeleton loader in sidenav menu</li><li>29665358 - Merge branch &#39;759-finalise-vuetify-app-as-spa&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1123/diffs?diff_id=26878&start_sha=e996102f4c850b48f768114661e4e6d7a5705389)
yuha commented 2023-01-18 01:19:51 +01:00
Author
Member
Copy link

marked this merge request as ready

marked this merge request as **ready**
nik merged commit adc31fbaaa into master 2023-01-18 01:20:30 +01:00
nik commented 2023-01-18 01:20:37 +01:00
Owner
Copy link

mentioned in commit adc31fbaaa

mentioned in commit adc31fbaaa810ebba4df29190efbd35c69994619
nik commented 2023-01-24 12:48:07 +01:00
Owner
Copy link

mentioned in issue #380

mentioned in issue #380
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2768
No description provided.