aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Show also group ownerships on person detail page" #2739

Merged
hansegucker merged 7 commits from 694-show-also-group-ownerships-on-person-detail-page into master 2022-10-12 19:37:49 +02:00
Conversation 18 Commits 7 Files changed 2 +29 -10
lukasw commented 2022-09-10 12:15:12 +02:00
Contributor
Copy link

Closes #694

Closes #694
lukasw commented 2022-09-10 12:15:13 +02:00
Author
Contributor
Copy link

assigned to @lukasw

assigned to @lukasw
lukasw commented 2022-09-10 13:47:57 +02:00
Author
Contributor
Copy link

added 2 commits

  • 8149e672 - Show also group ownerships on person detail page
  • 1f2c5768 - Update changelog

Compare with previous version

added 2 commits <ul><li>8149e672 - Show also group ownerships on person detail page</li><li>1f2c5768 - Update changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1094/diffs?diff_id=24315&start_sha=0a025d1b88ad3797a148df6457c5b85cfa8d11cd)
lukasw commented 2022-09-10 13:50:41 +02:00
Author
Contributor
Copy link

marked this merge request as ready

marked this merge request as **ready**
lukasw commented 2022-09-10 13:51:38 +02:00
Author
Contributor
Copy link

requested review from @nik

requested review from @nik
lukasw commented 2022-09-10 13:51:47 +02:00
Author
Contributor
Copy link

assigned to @nik and unassigned @lukasw

assigned to @nik and unassigned @lukasw
lukasw commented 2022-09-10 13:57:47 +02:00
Author
Contributor
Copy link

Screenshot:

image

Screenshot: ![image](/uploads/5a6e5f44a6db7956dbec72244ffb9b26/image.png)
lukasw commented 2022-09-10 14:08:44 +02:00
Author
Contributor
Copy link

As a parent:

image

As a parent: ![image](/uploads/c9e611e1a2d488598f960349834b476f/image.png)
lukasw commented 2022-09-10 16:46:54 +02:00
Author
Contributor
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>7f82d2a8 - Fix group ownership</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1094/diffs?diff_id=24320&start_sha=1f2c576883dd7bfe467e2fbab8d6876671c5ac6f)
lukasw commented 2022-09-10 16:48:30 +02:00
Author
Contributor
Copy link

If person has group ownerhip:
image

if not:
image

If person has group ownerhip: ![image](/uploads/5fef6e97e83958b06155c81a8364081b/image.png) if not: ![image](/uploads/baa067e5ef83c80cadd1c6a2497e356a/image.png)
lukasw commented 2022-09-10 18:33:03 +02:00
Author
Contributor
Copy link

added 1 commit

  • 1ebbb071 - Fix group ownership only showing when being member of a group

Compare with previous version

added 1 commit <ul><li>1ebbb071 - Fix group ownership only showing when being member of a group</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1094/diffs?diff_id=24328&start_sha=7f82d2a859ee2b48ea940c316eeb69a7a82d441f)
lukasw commented 2022-09-10 22:33:09 +02:00
Author
Contributor
Copy link

added 1 commit

  • abb8af3c - Fix group ownership not working

Compare with previous version

added 1 commit <ul><li>abb8af3c - Fix group ownership not working</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1094/diffs?diff_id=24347&start_sha=1ebbb07118f9af8d003be6dd87ee22c29010e026)
lukasw commented 2022-09-11 15:07:57 +02:00
Author
Contributor
Copy link

added 1 commit

  • 70af2427 - Fix group ownership on detail page

Compare with previous version

added 1 commit <ul><li>70af2427 - Fix group ownership on detail page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1094/diffs?diff_id=24359&start_sha=abb8af3cab3f4f1618ebe548e2bb9516d57080e9)
lukasw commented 2022-09-11 15:13:09 +02:00
Author
Contributor
Copy link

After fixing and testing it now works, both with and without permission.

Screenshots of testing:

Is member and has permission
member_haspermisson

Is not member or owner but has permission
nothing_haspermisssion

Is owner and has permission
owner_haspermission

Is owner and member and has permisson
owner_member_haspermission

  • the person that had permissions was a test user just with allowed to view persons and see groups, in second test the user wasn't allowd to see groups, witch also worked.
After fixing and testing it now works, both with and without permission. Screenshots of testing: Is member and has permission ![member_haspermisson](/uploads/7a9d5a43e2bbd51268415167f0b06c9e/member_haspermisson.png) Is not member or owner but has permission ![nothing_haspermisssion](/uploads/03ceb371d17ea4786db2a5b1c8ca2b20/nothing_haspermisssion.png) Is owner and has permission ![owner_haspermission](/uploads/52b4a68007e433918b37523c5c4060d1/owner_haspermission.png) Is owner and member and has permisson ![owner_member_haspermission](/uploads/a6f6764213d023f283cb601b7fa1245e/owner_member_haspermission.png) * the person that had permissions was a test user just with allowed to view persons and see groups, in second test the user wasn't allowd to see groups, witch also worked.
nik commented 2022-09-12 15:34:41 +02:00
Owner
Copy link

This condition is not readable.

This condition is not readable.
lukasw commented 2022-10-10 16:39:42 +02:00
Author
Contributor
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1094/diffs?diff_id=24555&start_sha=70af2427350970c2c8c56e38779e080dfca27eb5#939d54c78181d93363457192a8bfda9901e6fca7_244_244)
lukasw commented 2022-10-10 16:39:43 +02:00
Author
Contributor
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>ec36c8f5 - Simplify if statement</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/1094/diffs?diff_id=24555&start_sha=70af2427350970c2c8c56e38779e080dfca27eb5)
nik commented 2022-10-12 19:37:31 +02:00
Owner
Copy link

resolved all threads

resolved all threads
nik merged commit ccfa8bdde2 into master 2022-10-12 19:37:49 +02:00
nik commented 2022-10-12 19:37:53 +02:00
Owner
Copy link

mentioned in commit ccfa8bdde2

mentioned in commit ccfa8bdde2d8b87583cf115a14e7f1b61454ee7f
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2739
No description provided.