Resolve "shell_plus import order is suboptimal" #2506

Merged

hansegucker merged 2 commits from 597-shell_plus-import-order-is-suboptimal into master 2022-01-03 19:02:46 +01:00

Conversation 5 Commits 2 Files changed 2 +16

nik commented 2022-01-03 17:52:44 +01:00

Owner

Copy link

Closes #597

Closes #597

nik commented 2022-01-03 17:52:45 +01:00

Author

Owner

Copy link

assigned to @nik

assigned to @nik

nik commented 2022-01-03 18:10:32 +01:00

Author

Owner

Copy link

added 2 commits

• c64387ca - Configure shell_plus module loading
• ed3e366a - Resolve collisions in shell_plus by prefixing with app_label

Compare with previous version

added 2 commits <ul><li>c64387ca - Configure shell_plus module loading</li><li>ed3e366a - Resolve collisions in shell_plus by prefixing with app_label</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/861/diffs?diff_id=15542&start_sha=c41371732e75dee5825f4b792a8cf43fdc4638aa)

nik commented 2022-01-03 18:10:47 +01:00

Author

Owner

Copy link

marked this merge request as ready

marked this merge request as **ready**

nik commented 2022-01-03 18:10:52 +01:00

Author

Owner

Copy link

assigned to @hansegucker and unassigned @nik

assigned to @hansegucker and unassigned @nik

hansegucker scheduled this pull request to auto merge when all checks succeed 2022-01-03 18:47:17 +01:00

hansegucker merged commit b71f1d0c7b into master 2022-01-03 19:02:46 +01:00

hansegucker commented 2022-01-03 19:02:47 +01:00

Owner

Copy link

mentioned in commit b71f1d0c7b

mentioned in commit b71f1d0c7bca936121a1046cfc7422b76ba10665

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Security

  

TeX

Needs LaTeX template

  

auto-update

  

board

done

  

board

ready

  

board

todo

  

check

delete-eslint-rc-js

  

check

update-builddeps-package-json

  

check

update-eslint-rc-js

  

check

update-gitignore

  

check

update-merge-request-template

  

check

update-prettier-ignore

  

check

update-pyproject-toml

  

check

update-renovate-json

  

check

update-tox-ini

  

part

backend

Backend (view code, models, logic, etc.)

  

part

ci

  

part

docs

Issue or addition to the documentation

  

part

frontend

Frontend (templates, etc.)

  

part

i18n

Translation or internationalisation issue

  

part

non-technical

Non-technical (policy, maintenance, etc.) issue or discussion

  

part

packaging

Issue concerning the packaging of AlekSIS and components

  

prio

1

Priority High

  

prio

2

Priority Medium

  

prio

3

Priority Low

  

release-mr-5.x

  

size

large

  

size

medium

  

size

small

  

source

customer

Requested by a customer or affiliated user

  

source

customer::fsmw

  

source

customer::fss

  

source

customer::teckids

  

source

downstream

Issue or merge request from other projects using AlekSIS or parts of it

  

type

breaking

  

type

bug

Bug

  

type

feature

New feature

  

type

refactoring

  

workflow

blocked

Issue is blocked by another issue

  

workflow

confirmed

The bug is reproducible and will be fixed

  

workflow

current-todo

  

workflow

discussing

Needs to be discussed before implementation

  

workflow

new-app

Requires new AlekSIS app, which has to be created

  

workflow

wontfix

The bug is not reproducible or the feature was decided against

No labels

Security

TeX

auto-update

board

done

board

ready

board

todo

check

delete-eslint-rc-js

check

update-builddeps-package-json

check

update-eslint-rc-js

check

update-gitignore

check

update-merge-request-template

check

update-prettier-ignore

check

update-pyproject-toml

check

update-renovate-json

check

update-tox-ini

part

backend

part

ci

part

docs

part

frontend

part

i18n

part

non-technical

part

packaging

prio

1

prio

2

prio

3

release-mr-5.x

size

large

size

medium

size

small

source

customer

source

customer::fsmw

source

customer::fss

source

customer::teckids

source

downstream

type

breaking

type

bug

type

feature

type

refactoring

workflow

blocked

workflow

confirmed

workflow

current-todo

workflow

discussing

workflow

new-app

workflow

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

hansegucker

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

aleksis/AlekSIS-Core!2506

No description provided.