aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Rework mobile design of Person overview page" #2415

Merged
hansegucker merged 21 commits from 529-rework-mobile-design-of-person-overview-page into master 2022-01-08 22:46:14 +01:00
Conversation 24 Commits 21 Files changed 11 +342 -95
leuckeju commented 2021-11-08 16:04:28 +01:00
Member
Copy link

Closes #529

Closes #529
leuckeju commented 2021-11-08 16:04:30 +01:00
Author
Member
Copy link

assigned to @leuckeju

assigned to @leuckeju
nik commented 2021-11-08 16:49:18 +01:00
Owner
Copy link

assigned to @hansegucker and unassigned @ZugBahnHof

assigned to @hansegucker and unassigned @ZugBahnHof
leuckeju commented 2021-11-12 12:45:57 +01:00
Author
Member
Copy link

added 5 commits

  • 31627754 - Display profile pictures in person collection
  • 642aa7a6 - Don't display groups as a table
  • 8cca1909 - Display main person actions with a hero top bar
  • 6df72755 - Simplify person contact data table
  • 6b109468 - Wrap children and parents in cards

Compare with previous version

added 5 commits <ul><li>31627754 - Display profile pictures in person collection</li><li>642aa7a6 - Don&#39;t display groups as a table</li><li>8cca1909 - Display main person actions with a hero top bar</li><li>6df72755 - Simplify person contact data table</li><li>6b109468 - Wrap children and parents in cards</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/770/diffs?diff_id=13347&start_sha=5261b30c899c295f70e6ed0679f6309f779a7d37)
leuckeju commented 2021-11-24 20:56:37 +01:00
Author
Member
Copy link

mentioned in merge request !2434

mentioned in merge request !2434
leuckeju commented 2021-11-29 23:29:01 +01:00
Author
Member
Copy link

added 5 commits

  • fa07890b - Display popup image in the correct size
  • ed45a802 - Fix image hover opacity bug
  • 25ce51ed - Move the hero image snippet to an external html file
  • 2af75192 - Include an inset box shadow on the hero picture
  • 45c32fc0 - Display whole person action buttons on primary touch devices

Compare with previous version

added 5 commits <ul><li>fa07890b - Display popup image in the correct size</li><li>ed45a802 - Fix image hover opacity bug</li><li>25ce51ed - Move the hero image snippet to an external html file</li><li>2af75192 - Include an inset box shadow on the hero picture</li><li>45c32fc0 - Display whole person action buttons on primary touch devices</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/770/diffs?diff_id=13873&start_sha=6b1094688af0ca52b4af776368c2c25619c51d85)
leuckeju commented 2021-12-03 21:22:51 +01:00
Author
Member
Copy link

added 1 commit

  • 88c2099f - Display person description better

Compare with previous version

added 1 commit <ul><li>88c2099f - Display person description better</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/770/diffs?diff_id=14144&start_sha=45c32fc0dfba5c38f03e560fe5749ca7bd454687)
leuckeju commented 2021-12-03 21:36:42 +01:00
Author
Member
Copy link

image_and_description

personal_data

username

If this design is alright, this mr is ready, please check @hansegucker and @yuha

![image_and_description](/uploads/ff970b84d8de7d731c04ba9eb60e129e/image_and_description.png) ![personal_data](/uploads/d99a164698a4ee4368fba7e334606ea6/personal_data.png) ![username](/uploads/8cbb5a5a5d896ae19a3349612b402130/username.png) If this design is alright, this mr is ready, please check @hansegucker and @yuha
hansegucker commented 2021-12-04 10:52:40 +01:00
Owner
Copy link

You should add some information where you got hero.svg from and how it's licensed.

You should add some information where you got `hero.svg` from and how it's licensed.
hansegucker commented 2021-12-04 10:56:35 +01:00
Owner
Copy link

Two little things:

  • Please reformat your HTML code.
  • Please consider to replace the fallback image.
Two little things: - Please reformat your HTML code. - Please consider to replace the fallback image.
hansegucker commented 2021-12-04 10:56:57 +01:00
Owner
Copy link

But, in general, the new design looks very fine.

But, in general, the new design looks very fine.
nik commented 2021-12-04 11:06:58 +01:00
Owner
Copy link

You should add some information where you got hero.svg from and how it's licensed.

The attribution is:

"Topography" by Steve Schoger, heropatterns.com, CC-BY 4.0

And it needs to be right beneath the hero box, or at least on the same
page.

@hansegucker, please do not merge this without discussion, because I
do not think we should have such an attribution right in the uer
interface, and therefore, I do not think the chosen hero image should
be used in AlekSIS.

> You should add some information where you got `hero.svg` from and how it's licensed. The attribution is: "Topography" by Steve Schoger, heropatterns.com, CC-BY 4.0 And it needs to be right beneath the hero box, or at least on the same page. @hansegucker, please do not merge this without discussion, because I do not think we should have such an attribution right in the uer interface, and therefore, I do not think the chosen hero image should be used in AlekSIS.
nik commented 2021-12-14 12:56:24 +01:00
Owner
Copy link

Any news on that, @ZugBahnHof?

Any news on that, @ZugBahnHof?
leuckeju commented 2022-01-06 17:05:08 +01:00
Author
Member
Copy link

added 134 commits

  • 88c2099f...723b1537 - 121 commits from branch master
  • a2d6f712 - [Person] Add avatar field
  • d7bdfb94 - [Person] Add detailed help text to distinguish between photo/avatar
  • 80ffe88b - [Group] Add image support for groups
  • 9a8e2d8d - Add migration for group/person photo/avatar
  • 4adfae49 - Re-introduce django-image-cropping
  • 315f175d - Make avatars and photos croppable
  • 95fd5b8e - Disable bundled jQuery in django-image-cropping
  • 3c62138c - Add cropping fields to forms
  • 99be5072 - Use different hero image
  • 761ef5b0 - Merge branch '560-add-avatar-field-to-person-and-group' into...
  • 4d263942 - Require a permission to view a persons avatar
  • a64bd0f6 - Add an initials property to the person model
  • ab056c59 - Display personal photo on the person overview page.

Compare with previous version

added 134 commits <ul><li>88c2099f...723b1537 - 121 commits from branch <code>master</code></li><li>a2d6f712 - [Person] Add avatar field</li><li>d7bdfb94 - [Person] Add detailed help text to distinguish between photo/avatar</li><li>80ffe88b - [Group] Add image support for groups</li><li>9a8e2d8d - Add migration for group/person photo/avatar</li><li>4adfae49 - Re-introduce django-image-cropping</li><li>315f175d - Make avatars and photos croppable</li><li>95fd5b8e - Disable bundled jQuery in django-image-cropping</li><li>3c62138c - Add cropping fields to forms</li><li>99be5072 - Use different hero image</li><li>761ef5b0 - Merge branch &#39;560-add-avatar-field-to-person-and-group&#39; into...</li><li>4d263942 - Require a permission to view a persons avatar</li><li>a64bd0f6 - Add an initials property to the person model</li><li>ab056c59 - Display personal photo on the person overview page.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/770/diffs?diff_id=15665&start_sha=88c2099fb423be57ce58751ca0fd646ccecdbc95)
leuckeju commented 2022-01-06 17:28:03 +01:00
Author
Member
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2022-01-08 15:58:07 +01:00
Owner
Copy link

assigned to @nik and unassigned @hansegucker

assigned to @nik and unassigned @hansegucker
hansegucker commented 2022-01-08 16:03:10 +01:00
Owner
Copy link

added 218 commits

  • ab056c59...973eb378 - 217 commits from branch master
  • 82dd912c - Merge branch 'master' into 529-rework-mobile-design-of-person-overview-page

Compare with previous version

added 218 commits <ul><li>ab056c59...973eb378 - 217 commits from branch <code>master</code></li><li>82dd912c - Merge branch &#39;master&#39; into 529-rework-mobile-design-of-person-overview-page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/770/diffs?diff_id=15926&start_sha=ab056c59101b581905cf2b29a7d1df936c8c2b90)
nik commented 2022-01-08 21:29:04 +01:00
Owner
Copy link

added 39 commits

  • 82dd912c...b5b519ce - 38 commits from branch master
  • 48051064 - Merge branch 'master' into 529-rework-mobile-design-of-person-overview-page

Compare with previous version

added 39 commits <ul><li>82dd912c...b5b519ce - 38 commits from branch <code>master</code></li><li>48051064 - Merge branch &#39;master&#39; into 529-rework-mobile-design-of-person-overview-page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/770/diffs?diff_id=16060&start_sha=82dd912cbd87b6dcaafdcddc6c1261a2c874cde3)
nik commented 2022-01-08 21:34:05 +01:00
Owner
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>cdf6a513 - Merge avatar migrations</li><li>c1a5856a - Update changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/770/diffs?diff_id=16072&start_sha=48051064850f1d27b837b56a7d91eaba83ce7329)
nik commented 2022-01-08 21:37:10 +01:00
Owner
Copy link

added 1 commit

  • 1044890f - Use member_of for person groups

Compare with previous version

added 1 commit <ul><li>1044890f - Use member_of for person groups</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/770/diffs?diff_id=16073&start_sha=c1a5856adf7856bff62cdeb8cb70dd260ddcd500)
nik commented 2022-01-08 21:37:19 +01:00
Owner
Copy link

assigned to @hansegucker and unassigned @nik

assigned to @hansegucker and unassigned @nik
nik commented 2022-01-08 21:37:22 +01:00
Owner
Copy link

approved this merge request

approved this merge request
tteichler commented 2022-01-08 22:04:40 +01:00
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2022-01-08 22:46:16 +01:00
Owner
Copy link

mentioned in commit 6be90653ae

mentioned in commit 6be90653aed8384bed8830929edd3ba4ef832138
nik approved these changes 2026-07-30 18:30:43 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
nik
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2415
No description provided.