aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Check for correct semantic html elements" #2302

Merged
hansegucker merged 9 commits from 474-check-for-correct-semantic-html-elements into master 2021-06-20 11:14:23 +02:00
Conversation 17 Commits 9 Files changed 21 +78 -37
leuckeju commented 2021-06-08 11:05:47 +02:00
Member
Copy link

Closes #474

Closes #474
leuckeju commented 2021-06-11 15:56:43 +02:00
Author
Member
Copy link

added 4 commits

  • 9a668b19 - Load all roboto variants in the head.
  • 49b28002 - Use h1 as the main heading in the base template
  • a9b7b9f1 - Style h1 and h2 elements to better fit aleksis
  • 820a05ef - Replace all heading tags with semantic correct alternatives

Compare with previous version

added 4 commits <ul><li>9a668b19 - Load all roboto variants in the head.</li><li>49b28002 - Use h1 as the main heading in the base template</li><li>a9b7b9f1 - Style h1 and h2 elements to better fit aleksis</li><li>820a05ef - Replace all heading tags with semantic correct alternatives</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/657/diffs?diff_id=9664&start_sha=c6c2c474fc12e18bd0c1282ca036e731e6e623f2)
leuckeju commented 2021-06-11 16:00:44 +02:00
Author
Member
Copy link

Only ready in the core! Please check the design in the dev meeting:
old:
old____AlekSIS
new:
new___AlekSIS

Only ready in the core! Please check the design in the dev meeting: old: ![old____AlekSIS](/uploads/ab150a597384455b562c90319e7ff432/old____AlekSIS.png) new: ![new___AlekSIS](/uploads/e3c6f41bf1ce521a4bd4bbc0af4f5b6d/new___AlekSIS.png)
leuckeju commented 2021-06-11 16:00:48 +02:00
Author
Member
Copy link

marked this merge request as ready

marked this merge request as **ready**
nik commented 2021-06-11 16:41:36 +02:00
Owner
Copy link

assigned to @hansegucker and unassigned @ZugBahnHof

assigned to @hansegucker and unassigned @ZugBahnHof
nik commented 2021-06-11 16:42:28 +02:00
Owner
Copy link

approved this merge request

approved this merge request
leuckeju commented 2021-06-11 21:57:58 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>58981921 - Adjust font-weight</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/657/diffs?diff_id=9684&start_sha=820a05ef37de4a052ffeb34a2816a4bc2ea84b30)
hansegucker commented 2021-06-12 12:02:52 +02:00
Owner
Copy link

Current screenshot:
Screenshot_2021-06-11_at_21-44-51_Persons___AlekSIS

Current screenshot: ![Screenshot_2021-06-11_at_21-44-51_Persons___AlekSIS](/uploads/d49bcf30d0461c2094648dc44c2c4370/Screenshot_2021-06-11_at_21-44-51_Persons___AlekSIS.png)
hansegucker commented 2021-06-12 12:04:37 +02:00
Owner
Copy link

Do we really need all these different font weights? Or, can we limit them at least to some?

Do we really need all these different font weights? Or, can we limit them at least to some?
hansegucker commented 2021-06-15 16:03:52 +02:00
Owner
Copy link

This is a little reminder, @ZugBahnHof: Please check the discussion item above and add the change to the changelog.

This is a little reminder, @ZugBahnHof: Please check the discussion item above and add the change to the changelog.
leuckeju commented 2021-06-17 18:09:41 +02:00
Author
Member
Copy link

added 27 commits

  • 58981921...8edf8636 - 25 commits from branch master
  • 4aade7a8 - Merge branch 'master' into 474-check-for-correct-semantic-html-elements
  • e2a827cb - Update CHANGELOG.rst

Compare with previous version

added 27 commits <ul><li>58981921...8edf8636 - 25 commits from branch <code>master</code></li><li>4aade7a8 - Merge branch &#39;master&#39; into 474-check-for-correct-semantic-html-elements</li><li>e2a827cb - Update CHANGELOG.rst</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/657/diffs?diff_id=9882&start_sha=5898192170e2d9136548ddc3b64a1f64796db30f)
leuckeju commented 2021-06-17 18:13:03 +02:00
Author
Member
Copy link

Not necessarily (→ currently not). But maybe in the future… Therefore, I would leave the declaration in the settings by all means, the loading in the template is maybe not that important. What do you think about this @hansegucker ?

Not necessarily (→ currently not). But maybe in the future… Therefore, I would leave the declaration in the settings by all means, the loading in the template is maybe not that important. What do you think about this @hansegucker ?
hansegucker commented 2021-06-17 22:17:54 +02:00
Owner
Copy link

Ok, then leave them there. Additionally, please check why the pipeline fails.

Ok, then leave them there. Additionally, please check why the pipeline fails.
hansegucker commented 2021-06-17 22:17:54 +02:00
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2021-06-18 12:22:32 +02:00
Owner
Copy link

added 1 commit

  • 3bc5a44d - Use correct Roboto font variants in base_print.html

Compare with previous version

added 1 commit <ul><li>3bc5a44d - Use correct Roboto font variants in base_print.html</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/657/diffs?diff_id=9898&start_sha=e2a827cb7887ccf14bc66468f6d83dcc120e6397)
hansegucker commented 2021-06-19 10:44:32 +02:00
Owner
Copy link

added 5 commits

  • 3bc5a44d...0b1ce1d9 - 4 commits from branch master
  • abb9ce12 - Merge branch 'master' into 474-check-for-correct-semantic-html-elements

Compare with previous version

added 5 commits <ul><li>3bc5a44d...0b1ce1d9 - 4 commits from branch <code>master</code></li><li>abb9ce12 - Merge branch &#39;master&#39; into 474-check-for-correct-semantic-html-elements</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/657/diffs?diff_id=9912&start_sha=3bc5a44d56b08e861e77d4a5d6b7627ffd48fb00)
hansegucker commented 2021-06-20 11:14:29 +02:00
Owner
Copy link

mentioned in commit aa32d543f7

mentioned in commit aa32d543f784bbb21f626f327d94ae793aac5dc1
nik approved these changes 2026-07-30 18:32:37 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
nik
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2302
No description provided.