added 1 commit <ul><li>998182d5 - Rewrite PWA icon handling to new django-favicons-plus API</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8297&start_sha=53f3d204582628a949936d15d65bd11de188e54c)

nik commented

2021-05-15 18:56:57 +02:00

Author

Owner

added 1 commit

faf82ebf - Rewrite PWA icon handling to new django-favicons-plus API

Compare with previous version

added 1 commit <ul><li>faf82ebf - Rewrite PWA icon handling to new django-favicons-plus API</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8310&start_sha=998182d5975ee27a3c81694881f581df450d02f8)

hansegucker commented

2021-05-15 21:06:56 +02:00

Owner

  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/rules/contrib/views.py", line 221, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/aleksis/core/views.py", line 136, in index
    return render(request, "core/index.html", context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/shortcuts.py", line 19, in render
    content = loader.render_to_string(template_name, context, request, using=using)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/loader.py", line 62, in render_to_string
    return template.render(context, request)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/backends/django.py", line 61, in render
    return self.template.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 170, in render
    return self._render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/test/utils.py", line 100, in instrumented_test_render
    return self.nodelist.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/loader_tags.py", line 150, in render
    return compiled_parent._render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/test/utils.py", line 100, in instrumented_test_render
    return self.nodelist.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/loader_tags.py", line 195, in render
    return template.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 172, in render
    return self._render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/test/utils.py", line 100, in instrumented_test_render
    return self.nodelist.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/library.py", line 192, in render
    output = self.func(*resolved_args, **resolved_kwargs)
  File "/home/wethjo/dev/AlekSIS/apps/official/django-favicon-plus/favicon/templatetags/favtags.py", line 29, in place_favicon
    html = fav.as_html()
  File "/home/wethjo/dev/AlekSIS/apps/official/django-favicon-plus/favicon/models.py", line 115, in as_html
    for favicon in self.get_favicons(update=update):
  File "/home/wethjo/dev/AlekSIS/apps/official/django-favicon-plus/favicon/models.py", line 96, in get_favicons
    fav.generate_image()
  File "/home/wethjo/dev/AlekSIS/apps/official/django-favicon-plus/favicon/models.py", line 145, in generate_image
    tmp = Image.open(storage.open(self.faviconFK.faviconImage.name))
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/core/files/storage.py", line 36, in open
    return self._open(name, mode)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/core/files/storage.py", line 231, in _open
    return File(open(self.path(name), mode))
IsADirectoryError: [Errno 21] Is a directory: '/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/aleksis/media'

```Traceback (most recent call last): File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/core/handlers/exception.py", line 47, in inner response = get_response(request) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/core/handlers/base.py", line 181, in _get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/rules/contrib/views.py", line 221, in _wrapped_view return view_func(request, *args, **kwargs) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/aleksis/core/views.py", line 136, in index return render(request, "core/index.html", context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/shortcuts.py", line 19, in render content = loader.render_to_string(template_name, context, request, using=using) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/loader.py", line 62, in render_to_string return template.render(context, request) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/backends/django.py", line 61, in render return self.template.render(context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 170, in render return self._render(context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/test/utils.py", line 100, in instrumented_test_render return self.nodelist.render(context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 938, in render bit = node.render_annotated(context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 905, in render_annotated return self.render(context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/loader_tags.py", line 150, in render return compiled_parent._render(context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/test/utils.py", line 100, in instrumented_test_render return self.nodelist.render(context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 938, in render bit = node.render_annotated(context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 905, in render_annotated return self.render(context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/loader_tags.py", line 195, in render return template.render(context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 172, in render return self._render(context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/test/utils.py", line 100, in instrumented_test_render return self.nodelist.render(context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 938, in render bit = node.render_annotated(context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 905, in render_annotated return self.render(context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/library.py", line 192, in render output = self.func(*resolved_args, **resolved_kwargs) File "/home/wethjo/dev/AlekSIS/apps/official/django-favicon-plus/favicon/templatetags/favtags.py", line 29, in place_favicon html = fav.as_html() File "/home/wethjo/dev/AlekSIS/apps/official/django-favicon-plus/favicon/models.py", line 115, in as_html for favicon in self.get_favicons(update=update): File "/home/wethjo/dev/AlekSIS/apps/official/django-favicon-plus/favicon/models.py", line 96, in get_favicons fav.generate_image() File "/home/wethjo/dev/AlekSIS/apps/official/django-favicon-plus/favicon/models.py", line 145, in generate_image tmp = Image.open(storage.open(self.faviconFK.faviconImage.name)) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/core/files/storage.py", line 36, in open return self._open(name, mode) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/core/files/storage.py", line 231, in _open return File(open(self.path(name), mode)) IsADirectoryError: [Errno 21] Is a directory: '/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/aleksis/media' ```

hansegucker commented

2021-05-15 21:09:29 +02:00

Owner

added 23 commits

faf82ebf...e546f60c - 22 commits from branch master
12ff4a86 - Rewrite PWA icon handling to new django-favicons-plus API

Compare with previous version

added 23 commits <ul><li>faf82ebf...e546f60c - 22 commits from branch <code>master</code></li><li>12ff4a86 - Rewrite PWA icon handling to new django-favicons-plus API</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8327&start_sha=faf82ebf33f6d17e492299af0d7e83afc537c8e3)

nik commented

2021-05-15 21:37:32 +02:00

Author

Owner

added 1 commit

d6a94664 - Fix image saving

Compare with previous version

added 1 commit <ul><li>d6a94664 - Fix image saving</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8332&start_sha=12ff4a86d9cc68c7f8a020347d4584de03eb043a)

nik commented

2021-05-15 21:46:36 +02:00

Author

Owner

added 1 commit

f046e2ff - Fix image saving

Compare with previous version

added 1 commit <ul><li>f046e2ff - Fix image saving</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8335&start_sha=d6a94664dee60fd4ec6a4cfdbb75d5a4a29e5167)

hansegucker commented

2021-05-16 10:58:03 +02:00

Owner

added 1 commit

93560627 - Do not make use of memoize for favicons

Compare with previous version

added 1 commit <ul><li>93560627 - Do not make use of memoize for favicons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8371&start_sha=f046e2ff70a8c14e91b39c611b1e06c39d480c3c)

nik commented

2021-05-16 11:16:08 +02:00

Author

Owner

added 2 commits

2923449a - Monkey-patch Django's JSON encoder to unwrap promises
6c064bf8 - Merge branch '356-favicon-icon-generation-mauls-database' of...

Compare with previous version

added 2 commits <ul><li>2923449a - Monkey-patch Django's JSON encoder to unwrap promises</li><li>6c064bf8 - Merge branch '356-favicon-icon-generation-mauls-database' of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8372&start_sha=935606275cbea996e34e04b2a9f892427895fa40)

nik commented

2021-05-16 11:21:05 +02:00

Author

Owner

added 1 commit

7233f1b2 - Fix typo

Compare with previous version

added 1 commit <ul><li>7233f1b2 - Fix typo</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8373&start_sha=6c064bf83c6483d5cfe0c5cdbda78f240765fd99)

nik commented

2021-05-16 12:33:36 +02:00

Author

Owner

added 1 commit

d58a3f7f - Use `encode()` to encode unwrapped lazy object

Compare with previous version

added 1 commit <ul><li>d58a3f7f - Use `encode()` to encode unwrapped lazy object</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8393&start_sha=7233f1b29d1b54e2829b9b0b9c549cac2719c11a)

hansegucker commented

2021-05-16 12:34:08 +02:00

Owner

added 4 commits

fc61d801 - Ensure that favicons are always created and updated
a87196b5 - Merge branch '356-favicon-icon-generation-mauls-database' of...
be098d0f - Fix import og JSONEncoder in monkey patch
06d973bf - Merge branch '356-favicon-icon-generation-mauls-database' of...

Compare with previous version

added 4 commits <ul><li>fc61d801 - Ensure that favicons are always created and updated</li><li>a87196b5 - Merge branch '356-favicon-icon-generation-mauls-database' of...</li><li>be098d0f - Fix import og JSONEncoder in monkey patch</li><li>06d973bf - Merge branch '356-favicon-icon-generation-mauls-database' of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8394&start_sha=d58a3f7fac032fa29683195c33cf5bd2873ad6a7)

hansegucker commented

2021-05-16 12:37:53 +02:00

Owner

added 1 commit

3b83c327 - Fix monkey patch of JSONEncoder

Compare with previous version

added 1 commit <ul><li>3b83c327 - Fix monkey patch of JSONEncoder</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8395&start_sha=06d973bfa52c6466f2626146ee37b53f438aeb65)

hansegucker commented

2021-05-16 12:43:02 +02:00

Owner

marked this merge request as ready

marked this merge request as **ready**

hansegucker commented

2021-05-16 12:43:02 +02:00

Owner

changed the description

hansegucker commented

2021-05-16 12:47:45 +02:00

Owner

added 4 commits

3b83c327...942db4b5 - 2 commits from branch master
4416e8b0 - Merge branch 'master' into 356-favicon-icon-generation-mauls-database
b606d922 - Update django-favicon-plus-reloaded to 1.1.0

Compare with previous version

added 4 commits <ul><li>3b83c327...942db4b5 - 2 commits from branch <code>master</code></li><li>4416e8b0 - Merge branch 'master' into 356-favicon-icon-generation-mauls-database</li><li>b606d922 - Update django-favicon-plus-reloaded to 1.1.0</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8399&start_sha=3b83c3275cb6a68545c426016ff791f22ed1d0da)

hansegucker commented

2021-05-16 12:50:48 +02:00

Owner

added 1 commit

d117f834 - Update django-favicon-plus-reloaded to 1.1.0

Compare with previous version

added 1 commit <ul><li>d117f834 - Update django-favicon-plus-reloaded to 1.1.0</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8401&start_sha=b606d92253f633333b5e9f834ec0ab94e98f7c92)

nik scheduled this pull request to auto merge when all checks succeed

2021-05-16 12:51:45 +02:00

hansegucker commented

2021-05-16 14:31:44 +02:00

Owner

aborted the automatic merge because source branch was updated

hansegucker commented

2021-05-16 14:31:47 +02:00

Owner

added 2 commits

b144caf3 - Move icon generation to maintain_default_data
af70dd32 - Reformat

Compare with previous version

added 2 commits <ul><li>b144caf3 - Move icon generation to maintain_default_data</li><li>af70dd32 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8442&start_sha=d117f834958970dfabfe7960430d0704aa451076)

nik commented

2021-05-16 14:59:02 +02:00

Author

Owner

assigned to @hansegucker and unassigned @nik

hansegucker commented

2021-05-16 15:07:59 +02:00

Owner

added 8 commits

af70dd32...0051b0bd - 7 commits from branch master
301bc166 - Merge branch 'master' into 356-favicon-icon-generation-mauls-database

Compare with previous version

added 8 commits <ul><li>af70dd32...0051b0bd - 7 commits from branch <code>master</code></li><li>301bc166 - Merge branch 'master' into 356-favicon-icon-generation-mauls-database</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/601/diffs?diff_id=8454&start_sha=af70dd32090ceeddb6c6863fcf6013621038d4d6)

hansegucker commented

2021-05-16 15:49:38 +02:00

Owner

mentioned in commit 026ac06861

mentioned in commit 026ac06861ef6528610765023b6195dcc7f5ab28

hansegucker merged commit 026ac06861 into master

2021-05-16 15:49:39 +02:00