aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Rely on object permissions for search index" #2236

Merged
hansegucker merged 15 commits from 363-rely-on-object-permissions-for-search-index into master 2021-05-20 00:05:27 +02:00
Conversation 28 Commits 15 Files changed 8 +155 -125
yuha commented 2021-05-14 23:22:35 +02:00
Member
Copy link

Closes #363

Closes #363
nik commented 2021-05-15 19:48:23 +02:00
Owner
Copy link

assigned to @nik and unassigned @yuha

assigned to @nik and unassigned @yuha
yuha commented 2021-05-16 16:54:18 +02:00
Author
Member
Copy link

added 53 commits

  • d6a555e0...e546f60c - 51 commits from branch master
  • c456377b - Drop deprecated haystack view and switch to newer implementation
  • 8e4dc3e5 - Crude permission filtering

Compare with previous version

added 53 commits <ul><li>d6a555e0...e546f60c - 51 commits from branch <code>master</code></li><li>c456377b - Drop deprecated haystack view and switch to newer implementation</li><li>8e4dc3e5 - Crude permission filtering</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8494&start_sha=d6a555e0f0317874432b6fa3f0b4aac54d5de008)
yuha commented 2021-05-16 16:56:03 +02:00
Author
Member
Copy link

added 1 commit

  • b6ca0573 - Reformat

Compare with previous version

added 1 commit <ul><li>b6ca0573 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8498&start_sha=8e4dc3e53c4c42c5fb9884efe41a443b7e5c6197)
yuha commented 2021-05-16 16:56:09 +02:00
Author
Member
Copy link

marked this merge request as ready

marked this merge request as **ready**
yuha commented 2021-05-16 17:02:43 +02:00
Author
Member
Copy link

marked this merge request as draft

marked this merge request as **draft**
yuha commented 2021-05-16 19:04:23 +02:00
Author
Member
Copy link

added 1 commit

  • 0a86727b - Implement permission filtering

Compare with previous version

added 1 commit <ul><li>0a86727b - Implement permission filtering</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8542&start_sha=b6ca057306a959d7a988e83380ec3bb250371edb)
yuha commented 2021-05-16 19:06:18 +02:00
Author
Member
Copy link

added 1 commit

  • d634e6da - Change default search backend to whoosh

Compare with previous version

added 1 commit <ul><li>d634e6da - Change default search backend to whoosh</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8543&start_sha=0a86727b35fa7596ff21a393bd6973bf94b1f142)
yuha commented 2021-05-16 19:08:35 +02:00
Author
Member
Copy link

added 2 commits

  • 58629686 - Implement permission filtering
  • ad7b8aa7 - Change default search backend to whoosh

Compare with previous version

added 2 commits <ul><li>58629686 - Implement permission filtering</li><li>ad7b8aa7 - Change default search backend to whoosh</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8545&start_sha=d634e6da477d94265b2467150660fd015a902e13)
yuha commented 2021-05-16 19:08:48 +02:00
Author
Member
Copy link

marked this merge request as ready

marked this merge request as **ready**
yuha commented 2021-05-16 19:10:56 +02:00
Author
Member
Copy link

added 2 commits

  • 1a0e0261 - Implement permission filtering
  • 7f6048fa - Change default search backend to whoosh

Compare with previous version

added 2 commits <ul><li>1a0e0261 - Implement permission filtering</li><li>7f6048fa - Change default search backend to whoosh</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8548&start_sha=ad7b8aa7ffb2b23d871d1eabe92c4e8aef2d915b)
yuha commented 2021-05-16 19:27:07 +02:00
Author
Member
Copy link

marked this merge request as draft

marked this merge request as **draft**
nik commented 2021-05-18 11:34:06 +02:00
Owner
Copy link

If using Whoosh, this backend must be used: https://github.com/steinbro/haystack-redis

Also, we could probably remove support for all other kind sof backends, and make whoosh the default backend (raising its dependency to be mandatory).

If using Whoosh, this backend must be used: https://github.com/steinbro/haystack-redis Also, we could probably remove support for all other kind sof backends, and make whoosh the default backend (raising its dependency to be mandatory).
yuha commented 2021-05-19 20:10:43 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>996d7a97 - Filtering by rules</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8688&start_sha=7f6048fa356625c5b3d091c05fbb2681c983aa2c)
yuha commented 2021-05-19 21:40:00 +02:00
Author
Member
Copy link

added 42 commits

  • 996d7a97...d4bf41b7 - 39 commits from branch master
  • 36e60113 - Merge branch 'master' into 363-rely-on-object-permissions-for-search-index
  • 2e25bc0f - Introduce hyastack-redis to allow redis caching for whoosh indexes
  • 4147980b - Fix typo

Compare with previous version

added 42 commits <ul><li>996d7a97...d4bf41b7 - 39 commits from branch <code>master</code></li><li>36e60113 - Merge branch &#39;master&#39; into 363-rely-on-object-permissions-for-search-index</li><li>2e25bc0f - Introduce hyastack-redis to allow redis caching for whoosh indexes</li><li>4147980b - Fix typo</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8721&start_sha=996d7a9761dcc6665249867057444f634d7bf73c)
yuha commented 2021-05-19 21:45:02 +02:00
Author
Member
Copy link

added 2 commits

  • 8eaa5476 - Introduce haystack-redis to allow redis caching for whoosh indexes
  • 91124257 - Fix typo

Compare with previous version

added 2 commits <ul><li>8eaa5476 - Introduce haystack-redis to allow redis caching for whoosh indexes</li><li>91124257 - Fix typo</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8724&start_sha=4147980bddf612d6b76e7d5e62bd9b53df46693e)
yuha commented 2021-05-19 21:51:39 +02:00
Author
Member
Copy link

added 1 commit

  • c685660e - Remove unused import

Compare with previous version

added 1 commit <ul><li>c685660e - Remove unused import</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8729&start_sha=911242578121b10dd08b1b45e928e330227f7c4c)
yuha commented 2021-05-19 22:10:34 +02:00
Author
Member
Copy link

added 3 commits

  • 69d909e3 - Introduce haystack-redis to allow redis caching for whoosh indexes
  • 65bcb779 - Fix typo
  • 9f896082 - Remove unused import

Compare with previous version

added 3 commits <ul><li>69d909e3 - Introduce haystack-redis to allow redis caching for whoosh indexes</li><li>65bcb779 - Fix typo</li><li>9f896082 - Remove unused import</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8751&start_sha=c685660e60caa2b7e35599197f4c1f8eae3c5862)
tteichler commented 2021-05-19 22:42:40 +02:00
Owner
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>bf42feb5 - Update haystack-redis</li><li>61636a40 - Use whoosh as default index</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8764&start_sha=9f896082c92a2e78eb1ca1bc6d7ccf4d03e9fdc8)
nik commented 2021-05-19 22:52:26 +02:00
Owner
Copy link

Not needed anymore

Not needed anymore
yuha commented 2021-05-19 23:33:04 +02:00
Author
Member
Copy link

added 2 commits

  • fb1a2057 - Move code for getting search objects to core_helpers and add comments
  • 2393c4cc - Merge branch '363-rely-on-object-permissions-for-search-index' of...

Compare with previous version

added 2 commits <ul><li>fb1a2057 - Move code for getting search objects to core_helpers and add comments</li><li>2393c4cc - Merge branch &#39;363-rely-on-object-permissions-for-search-index&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8768&start_sha=61636a407f6d8bc7b7eb608f997f937185996b7d)
yuha commented 2021-05-19 23:42:55 +02:00
Author
Member
Copy link

added 1 commit

  • e73ad38b - Remove whitespaces

Compare with previous version

added 1 commit <ul><li>e73ad38b - Remove whitespaces</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8770&start_sha=2393c4cc2b2c603973428b0f43b782de55220ffe)
yuha commented 2021-05-19 23:43:28 +02:00
Author
Member
Copy link

added 1 commit

  • 60852278 - Remove unnecessary blank lines

Compare with previous version

added 1 commit <ul><li>60852278 - Remove unnecessary blank lines</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8771&start_sha=e73ad38bc8cf2f2ea98be93e76a1a68044e154ff)
yuha commented 2021-05-19 23:43:31 +02:00
Author
Member
Copy link

marked this merge request as ready

marked this merge request as **ready**
yuha commented 2021-05-19 23:43:41 +02:00
Author
Member
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-05-19 23:45:10 +02:00
Owner
Copy link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8773&start_sha=608522781e4ea1cf38d9610a09e2701e6dae4b75#abc9d828b78bd9d36e05475d0bc91119bc5bc6b0_760_760)
tteichler commented 2021-05-19 23:45:13 +02:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>1986082a - Drop unused setting</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8773&start_sha=608522781e4ea1cf38d9610a09e2701e6dae4b75)
nik commented 2021-05-19 23:50:29 +02:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>5c5f6804 - Remove unused import</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/591/diffs?diff_id=8775&start_sha=1986082a30d13394097498ddcf85590405a33ae0)
nik scheduled this pull request to auto merge when all checks succeed 2021-05-19 23:52:12 +02:00
nik merged commit 62442312c2 into master 2021-05-20 00:05:27 +02:00
nik commented 2021-05-20 00:05:32 +02:00
Owner
Copy link

mentioned in commit 62442312c2

mentioned in commit 62442312c2987875a5d77eeb6171755ac4757ecb
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2236
No description provided.