aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Correctly implement the ckeditor" #2230

Merged
hansegucker merged 2 commits from 340-correctly-implement-the-ckeditor-2 into master 2021-05-15 11:51:10 +02:00
Conversation 16 Commits 2 Files changed 2 +33
leuckeju commented 2021-05-04 11:26:52 +02:00
Member
Copy link

Closes #340

Closes #340
leuckeju commented 2021-05-04 11:56:25 +02:00
Author
Member
Copy link

added 1 commit

  • 39c31522 - Add a crude template for a material_form widget, this should be enough for now

Compare with previous version

added 1 commit <ul><li>39c31522 - Add a crude template for a material_form widget, this should be enough for now</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/585/diffs?diff_id=7908&start_sha=db66c5d5c700c42999553f43db9cce40810711ff)
leuckeju commented 2021-05-04 11:56:27 +02:00
Author
Member
Copy link

assigned to @hansegucker and unassigned @ZugBahnHof

assigned to @hansegucker and unassigned @ZugBahnHof
leuckeju commented 2021-05-04 11:56:30 +02:00
Author
Member
Copy link

requested review from @nik

requested review from @nik
leuckeju commented 2021-05-04 11:56:34 +02:00
Author
Member
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2021-05-04 12:06:20 +02:00
Owner
Copy link

Can you please provide a screenshot?

Can you please provide a screenshot?
leuckeju commented 2021-05-04 12:07:15 +02:00
Author
Member
Copy link

Bildschirmfoto_von_2021-05-04_12-06-55

![Bildschirmfoto_von_2021-05-04_12-06-55](/uploads/43a1548c3c6e81c891f9c9514b14d3b6/Bildschirmfoto_von_2021-05-04_12-06-55.png)
hansegucker commented 2021-05-04 12:07:27 +02:00
Owner
Copy link

This shouldn't be hardcoded.

This shouldn't be hardcoded.
leuckeju commented 2021-05-04 12:08:24 +02:00
Author
Member
Copy link

why not? This is a specific value that will only be ever needed here, and most of the ckeditor css is inline, why not this as well?

why not? This is a specific value that will only be ever needed here, and most of the ckeditor css is inline, why not this as well?
leuckeju commented 2021-05-04 12:09:39 +02:00
Author
Member
Copy link

Resizing in x direction does not work, as ckeditor has a fixed width. Therefore, the editor is wider than the screen on mobile devices. This has to be changed in the future, but for our current uses this is enough.

Resizing in x direction does not work, as ckeditor has a fixed width. Therefore, the editor is wider than the screen on mobile devices. This has to be changed in the future, but for our current uses this is enough.
hansegucker commented 2021-05-04 18:13:05 +02:00
Owner
Copy link

Because this template is not a part of the ckeditor where some CSS seems to be inline, but a part of AlekSIS where no CSS should be inline.

Because this template is not a part of the ckeditor where some CSS seems to be inline, but a part of AlekSIS where no CSS should be inline.
leuckeju commented 2021-05-14 16:26:47 +02:00
Author
Member
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/585/diffs?diff_id=8094&start_sha=39c31522636152975f29aea3f62390e148bc58fa#34caccf9a1619f5db48c90c402e32ac73fae4866_14_14)
leuckeju commented 2021-05-14 16:26:48 +02:00
Author
Member
Copy link

added 1 commit

  • 3c24658f - Remove inline styling

Compare with previous version

added 1 commit <ul><li>3c24658f - Remove inline styling</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/585/diffs?diff_id=8094&start_sha=39c31522636152975f29aea3f62390e148bc58fa)
nik commented 2021-05-14 16:30:23 +02:00
Owner
Copy link

Please reformat (space before bracket, semicolon behind rule)

Please reformat (space before bracket, semicolon behind rule)
yuha commented 2021-05-14 16:43:50 +02:00
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>18757130 - Remove inline styling</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/585/diffs?diff_id=8098&start_sha=3c24658fd1c3960497142cbcf33cd49bcd6941bb)
hansegucker commented 2021-05-15 11:50:56 +02:00
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2021-05-15 11:51:09 +02:00
Owner
Copy link

mentioned in commit bf7dffbec0

mentioned in commit bf7dffbec0a6ef8f8e190876aeba232474443483
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2230
No description provided.