aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Allow control over self-editing of person" #2208

Merged
hansegucker merged 3 commits from 245-allow-control-over-self-editing-of-person into master 2021-04-22 20:57:25 +02:00
Conversation 74 Commits 3 Files changed 6 +141 -4
tteichler commented 2021-04-05 21:00:08 +02:00
Owner
Copy link

Closes #245

Closes #245
tteichler commented 2021-04-05 22:28:49 +02:00
Author
Owner
Copy link

added 2 commits

  • 4ff47207 - Add preferences
  • 626ab6af - Trigger email

Compare with previous version

added 2 commits <ul><li>4ff47207 - Add preferences</li><li>626ab6af - Trigger email</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=6950&start_sha=7d0221763448976b8e24049771acf9fadcebef96)
tteichler commented 2021-04-05 22:35:39 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e1650f50 - Trigger email</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=6952&start_sha=626ab6af3feed27eec90774c2534810aff1229bd)
tteichler commented 2021-04-05 22:44:41 +02:00
Author
Owner
Copy link

assigned to @nik and unassigned @debdolph

assigned to @nik and unassigned @debdolph
tteichler commented 2021-04-05 22:49:19 +02:00
Author
Owner
Copy link

added 1 commit

  • 4e887423 - Use syncable_fields

Compare with previous version

added 1 commit <ul><li>4e887423 - Use syncable_fields</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=6954&start_sha=e1650f50bc9ccb9d5e819283ea5cd7bd63a78014)
tteichler commented 2021-04-05 22:58:09 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>2fd6ad6e - Use syncable_fields</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=6955&start_sha=4e887423d7cb3bb945fb4a89c2cb98e0a8f7b3f0)
tteichler commented 2021-04-05 23:13:44 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>6d86bab1 - Disable fields in form</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=6956&start_sha=2fd6ad6ebc0b2da042861195197cc475f623e8bb)
tteichler commented 2021-04-13 19:02:39 +02:00
Author
Owner
Copy link

added 8 commits

  • 6d86bab1...466a6e29 - 7 commits from branch master
  • 83fc8097 - Merge branch 'master' into 245-allow-control-over-self-editing-of-person

Compare with previous version

added 8 commits <ul><li>6d86bab1...466a6e29 - 7 commits from branch <code>master</code></li><li>83fc8097 - Merge branch &#39;master&#39; into 245-allow-control-over-self-editing-of-person</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7163&start_sha=6d86bab10de99ecb64b3585b57d0061a3d017f20)
tteichler commented 2021-04-13 19:18:36 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>97e442b6 - Update lockfile</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7164&start_sha=83fc8097a14bb009e86085695931c794cba37875)
tteichler commented 2021-04-13 20:45:57 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>7d08be1c - Fix choices</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7168&start_sha=97e442b6acc8a28a6ad2c9fbd5fb11009e9b3fce)
tteichler commented 2021-04-13 22:42:41 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>0e4b12c8 - Disable fields correctly</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7172&start_sha=7d08be1c6241b126f3a5b3b64a2d798dac43ca6c)
tteichler commented 2021-04-13 22:53:29 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a990b99b - Disable fields correctly</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7173&start_sha=0e4b12c8a4b4a896853b71f8b9c60fab7f61d50e)
tteichler commented 2021-04-14 15:11:13 +02:00
Author
Owner
Copy link

added 3 commits

  • 0e4b12c8 - Disable fields correctly
  • 7694db61 - Merge branch '245-allow-control-over-self-editing-of-person' of...
  • 3333d61a - Fix mail template

Compare with previous version

added 3 commits <ul><li>0e4b12c8 - Disable fields correctly</li><li>7694db61 - Merge branch &#39;245-allow-control-over-self-editing-of-person&#39; of...</li><li>3333d61a - Fix mail template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7201&start_sha=a990b99bcd8622abde30ded54f628e6bff0b3235)
tteichler commented 2021-04-14 15:11:26 +02:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
tteichler commented 2021-04-14 15:11:30 +02:00
Author
Owner
Copy link

requested review from @hansegucker

requested review from @hansegucker
hansegucker commented 2021-04-14 17:55:18 +02:00
Owner
Copy link
 {% blocktrans with person=person %}{{ person }} changed their data!{% endblocktrans %}
```suggestion:-0+0 {% blocktrans with person=person %}{{ person }} changed their data!{% endblocktrans %} ```
hansegucker commented 2021-04-14 17:55:19 +02:00
Owner
Copy link

Is the following change an option?

        if self.instance.user and request.user == self.instance.user:

Also, please check if the form still works as a create form.

Is the following change an option? ```suggestion:-0+0 if self.instance.user and request.user == self.instance.user: ``` Also, please check if the form still works as a create form.
hansegucker commented 2021-04-14 17:55:19 +02:00
Owner
Copy link

Missing docstring.

Missing docstring.
hansegucker commented 2021-04-14 17:55:19 +02:00
Owner
Copy link

Missing docstring.

Missing docstring.
hansegucker commented 2021-04-14 17:55:20 +02:00
Owner
Copy link

Missing docstring.

Also, we maybe should do this like in DataChecksEmailsRecipients and DataChecksEmailsRecipientGroups.

Missing docstring. Also, we **maybe** should do this like in `DataChecksEmailsRecipients` and `DataChecksEmailsRecipientGroups`.
tteichler commented 2021-04-16 20:09:48 +02:00
Author
Owner
Copy link

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7335&start_sha=3333d61aacd0cea632265adc521cb513c8dfbefa#622da2712f4801473aba0b611c3232f8148ef126_145_145)
tteichler commented 2021-04-16 20:09:50 +02:00
Author
Owner
Copy link

added 18 commits

  • 3333d61a...29e673dd - 16 commits from branch master
  • df473854 - Merge branch 'master' into 245-allow-control-over-self-editing-of-person
  • e07a8fa9 - Fix creation of persons

Compare with previous version

added 18 commits <ul><li>3333d61a...29e673dd - 16 commits from branch <code>master</code></li><li>df473854 - Merge branch &#39;master&#39; into 245-allow-control-over-self-editing-of-person</li><li>e07a8fa9 - Fix creation of persons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7335&start_sha=3333d61aacd0cea632265adc521cb513c8dfbefa)
tteichler commented 2021-04-16 20:15:12 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>32a135e4 - Fix creation of persons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7336&start_sha=e07a8fa97eaa5f6fe570991a6c5d94855135913d)
tteichler commented 2021-04-16 20:16:03 +02:00
Author
Owner
Copy link

changed this line in version 14 of the diff

changed this line in [version 14 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7338&start_sha=32a135e41410a047ef8d7b9ae3439025aeb2f2d9#7eca79a89fa3595b42d5a928862751ada32dd3a7_4_4)
tteichler commented 2021-04-16 20:16:04 +02:00
Author
Owner
Copy link

added 1 commit

  • 091e559d - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>091e559d - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7338&start_sha=32a135e41410a047ef8d7b9ae3439025aeb2f2d9)
tteichler commented 2021-04-16 20:19:32 +02:00
Author
Owner
Copy link

I don't think so. The recipient is not always a person or a group in AlekSIS.

I don't think so. The recipient is not always a person or a group in AlekSIS.
tteichler commented 2021-04-16 20:20:17 +02:00
Author
Owner
Copy link

added 1 commit

  • fe071e70 - Add missing docstrings

Compare with previous version

added 1 commit <ul><li>fe071e70 - Add missing docstrings</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7339&start_sha=091e559daf91cc2a1645dba1bf1fc97d4aeba17d)
tteichler commented 2021-04-16 20:20:38 +02:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-04-16 20:25:36 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a9e12912 - Add missing docstrings</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7341&start_sha=fe071e70be09b2f6d553876eab98365bc168dc19)
hansegucker commented 2021-04-16 21:53:25 +02:00
Owner
Copy link

approved this merge request

approved this merge request
tteichler commented 2021-04-20 21:45:32 +02:00
Author
Owner
Copy link

added 46 commits

  • a9e12912...b9fe9e08 - 45 commits from branch master
  • 1ff21d51 - Merge branch 'master' into 245-allow-control-over-self-editing-of-person

Compare with previous version

added 46 commits <ul><li>a9e12912...b9fe9e08 - 45 commits from branch <code>master</code></li><li>1ff21d51 - Merge branch &#39;master&#39; into 245-allow-control-over-self-editing-of-person</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7532&start_sha=a9e129127897d6b303393c7e50f9f09cfbcae80c)
tteichler commented 2021-04-20 21:57:55 +02:00
Author
Owner
Copy link

added 1 commit

  • c64671b6 - Merge branch 'master' into 245-allow-control-over-self-editing-of-person

Compare with previous version

added 1 commit <ul><li>c64671b6 - Merge branch &#39;master&#39; into 245-allow-control-over-self-editing-of-person</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7534&start_sha=1ff21d5179f7f9b67604cea1bac5bbbd58589190)
tteichler commented 2021-04-20 23:03:53 +02:00
Author
Owner
Copy link

added 1 commit

  • 52b900fc - Use rules

Compare with previous version

added 1 commit <ul><li>52b900fc - Use rules</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7537&start_sha=c64671b6b6e2094a112a92319aeb80be52867e62)
tteichler commented 2021-04-20 23:12:30 +02:00
Author
Owner
Copy link

added 1 commit

  • e8dc50c3 - Use rules

Compare with previous version

added 1 commit <ul><li>e8dc50c3 - Use rules</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7538&start_sha=52b900fc1ba9060c79b77a46b7c55aff6c31234a)
tteichler commented 2021-04-20 23:18:45 +02:00
Author
Owner
Copy link

added 1 commit

  • dbf51f9e - Use rules

Compare with previous version

added 1 commit <ul><li>dbf51f9e - Use rules</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7540&start_sha=e8dc50c31a6b996b816c7b86c006018ebc66d106)
nik commented 2021-04-20 23:20:11 +02:00
Owner
Copy link

marked this merge request as draft

marked this merge request as **draft**
tteichler commented 2021-04-20 23:20:34 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e71f1ea9 - Use rules</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7541&start_sha=dbf51f9e9f34b259b7d92661a2206a5bd07137ad)
tteichler commented 2021-04-21 20:36:35 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>451fd6ae - Check rule in form</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7557&start_sha=e71f1ea92db50fd17c6ed69a9ad7e272334a49fe)
tteichler commented 2021-04-21 20:47:01 +02:00
Author
Owner
Copy link

added 1 commit

  • 3eb2fac7 - Check if current person is current user

Compare with previous version

added 1 commit <ul><li>3eb2fac7 - Check if current person is current user</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7558&start_sha=451fd6ae4636f26b46891c20276bdeb168b19157)
tteichler commented 2021-04-21 20:49:28 +02:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
tteichler commented 2021-04-21 20:52:11 +02:00
Author
Owner
Copy link

added 1 commit

  • 6631ab3b - Check if current person is current user

Compare with previous version

added 1 commit <ul><li>6631ab3b - Check if current person is current user</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7560&start_sha=3eb2fac7054ad4170f9e109fc35dc411e7c0c09c)
nik commented 2021-04-21 21:03:30 +02:00
Owner
Copy link

Please re-word to make clear that this checks the existence of a list item.

Please re-word to make clear that this checks the existence of a list item.
nik commented 2021-04-21 21:03:31 +02:00
Owner
Copy link

That's wrong. The code is independent of who the current user is.

That's wrong. The code is independent of who the current user is.
nik commented 2021-04-21 21:03:31 +02:00
Owner
Copy link

This must convey that this preference is about persons editing themselves.

This must convey that this preference is about persons editing **themselves**.
nik commented 2021-04-21 21:03:31 +02:00
Owner
Copy link

Use the edit_person rule here isntead.

Use the `edit_person` rule here isntead.
nik commented 2021-04-21 21:03:31 +02:00
Owner
Copy link

This must be combine wit ha check on whether the person is the same as the current user.

This must be combine wit ha check on whether the person is the same as the current user.
tteichler commented 2021-04-21 21:08:26 +02:00
Author
Owner
Copy link

changed this line in version 26 of the diff

changed this line in [version 26 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7562&start_sha=6631ab3b8f80eca60a0a78de8f58203d53857c94#f18032ae09f8cc14c59919f1376970c13eb57713_137_137)
tteichler commented 2021-04-21 21:08:26 +02:00
Author
Owner
Copy link

changed this line in version 26 of the diff

changed this line in [version 26 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7562&start_sha=6631ab3b8f80eca60a0a78de8f58203d53857c94#622da2712f4801473aba0b611c3232f8148ef126_144_144)
tteichler commented 2021-04-21 21:08:27 +02:00
Author
Owner
Copy link

changed this line in version 26 of the diff

changed this line in [version 26 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7562&start_sha=6631ab3b8f80eca60a0a78de8f58203d53857c94#cedfd047579474194a5f10a12c798242313675da_284_284)
tteichler commented 2021-04-21 21:08:27 +02:00
Author
Owner
Copy link

changed this line in version 26 of the diff

changed this line in [version 26 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7562&start_sha=6631ab3b8f80eca60a0a78de8f58203d53857c94#216f48f50c6758eba4a72b334fd1ea4e6af4b3c0_335_334)
tteichler commented 2021-04-21 21:08:28 +02:00
Author
Owner
Copy link

added 1 commit

  • 3bb850d2 - Fix naming issues

Compare with previous version

added 1 commit <ul><li>3bb850d2 - Fix naming issues</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7562&start_sha=6631ab3b8f80eca60a0a78de8f58203d53857c94)
tteichler commented 2021-04-21 21:09:01 +02:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-04-21 21:10:58 +02:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-04-21 21:11:13 +02:00
Author
Owner
Copy link

changed this line in version 27 of the diff

changed this line in [version 27 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7563&start_sha=3bb850d27905e1fb39db659ffc8a21e2da11947e#216f48f50c6758eba4a72b334fd1ea4e6af4b3c0_336_336)
tteichler commented 2021-04-21 21:11:14 +02:00
Author
Owner
Copy link

added 1 commit

  • 043197eb - Fix naming issues

Compare with previous version

added 1 commit <ul><li>043197eb - Fix naming issues</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7563&start_sha=3bb850d27905e1fb39db659ffc8a21e2da11947e)
nik commented 2021-04-21 21:15:10 +02:00
Owner
Copy link

Please use permission prefetching.

Please use permission prefetching.
nik commented 2021-04-21 21:15:11 +02:00
Owner
Copy link

This needs to be comined with a check on the preference enabling/disabling editing of the person themselves.

This needs to be comined with a check on the preference enabling/disabling editing of the person themselves.
nik commented 2021-04-21 21:15:11 +02:00
Owner
Copy link

Use parantheses to make conjunction precedence clearer.

Use parantheses to make conjunction precedence clearer.
tteichler commented 2021-04-21 21:21:51 +02:00
Author
Owner
Copy link

changed this line in version 28 of the diff

changed this line in [version 28 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7565&start_sha=043197ebd23d53c7d949ce886f977d046513df9c#216f48f50c6758eba4a72b334fd1ea4e6af4b3c0_73_73)
tteichler commented 2021-04-21 21:21:51 +02:00
Author
Owner
Copy link

changed this line in version 28 of the diff

changed this line in [version 28 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7565&start_sha=043197ebd23d53c7d949ce886f977d046513df9c#216f48f50c6758eba4a72b334fd1ea4e6af4b3c0_337_336)
tteichler commented 2021-04-21 21:21:52 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>4c0c841f - Fix naming issues</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7565&start_sha=043197ebd23d53c7d949ce886f977d046513df9c)
tteichler commented 2021-04-21 21:30:42 +02:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-04-21 21:31:03 +02:00
Author
Owner
Copy link

added 1 commit

  • a8368f0a - Prefetch permissions

Compare with previous version

added 1 commit <ul><li>a8368f0a - Prefetch permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7566&start_sha=4c0c841f9002e44c3927fa6696e99df7d89a2377)
tteichler commented 2021-04-21 21:33:06 +02:00
Author
Owner
Copy link

added 1 commit

  • 6fc69398 - Prefetch permissions

Compare with previous version

added 1 commit <ul><li>6fc69398 - Prefetch permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7568&start_sha=a8368f0a48d9304915b0a1de0764be6d80a3744c)
tteichler commented 2021-04-21 21:39:36 +02:00
Author
Owner
Copy link

added 1 commit

  • 8d6e2051 - Prefetch permissions

Compare with previous version

added 1 commit <ul><li>8d6e2051 - Prefetch permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7570&start_sha=6fc693986be00cae71336d5861624a7edbd4ae09)
tteichler commented 2021-04-21 21:41:06 +02:00
Author
Owner
Copy link

added 1 commit

  • 5b3c5679 - Prefetch permissions

Compare with previous version

added 1 commit <ul><li>5b3c5679 - Prefetch permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7571&start_sha=8d6e205175040fade29005669ca5e3b22fcebae0)
tteichler commented 2021-04-21 21:43:37 +02:00
Author
Owner
Copy link

changed this line in version 33 of the diff

changed this line in [version 33 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7573&start_sha=5b3c5679117bc780c4ef3be88b85cf194b05e125#622da2712f4801473aba0b611c3232f8148ef126_155_153)
tteichler commented 2021-04-21 21:43:40 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>54077d6f - Prefetch permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7573&start_sha=5b3c5679117bc780c4ef3be88b85cf194b05e125)
nik commented 2021-04-21 21:50:29 +02:00
Owner
Copy link

assigned to @hansegucker and unassigned @nik

assigned to @hansegucker and unassigned @nik
nik commented 2021-04-21 21:50:32 +02:00
Owner
Copy link

requested review from @nik and removed review request for @hansegucker

requested review from @nik and removed review request for @hansegucker
nik commented 2021-04-21 21:50:35 +02:00
Owner
Copy link

approved this merge request

approved this merge request
tteichler commented 2021-04-21 21:51:29 +02:00
Author
Owner
Copy link

added 3 commits

  • 5f896c20 - Implement rules and predicates
  • 93ff633a - Add preferences
  • 92b9b545 - Check permissions and send mail if enabled

Compare with previous version

added 3 commits <ul><li>5f896c20 - Implement rules and predicates</li><li>93ff633a - Add preferences</li><li>92b9b545 - Check permissions and send mail if enabled</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/563/diffs?diff_id=7576&start_sha=54077d6fa9876778ef4496ab58a5c00fdcd152e2)
hansegucker commented 2021-04-22 20:57:24 +02:00
Owner
Copy link

mentioned in commit c7fae2a048

mentioned in commit c7fae2a048f2c62468133dbad7b5ab120024cfdd
nik approved these changes 2026-07-30 18:34:23 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
hansegucker
nik
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2208
No description provided.