aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "[Docker] Do not run as root" #2189

Merged
hansegucker merged 9 commits from 409-docker-do-not-run-as-root into master 2021-03-23 17:47:49 +01:00
Conversation 26 Commits 9 Files changed 5 +24 -47
nik commented 2021-03-22 12:43:15 +01:00
Owner
Copy link

Closes #409

This MR also partially addresses #403 because fixing the permissions on the data required touching the volumes anyway. But it is not complete — especially, the static root should not be writable by www-data.

Closes #409 This MR also partially addresses #403 because fixing the permissions on the data required touching the volumes anyway. But it is not complete — especially, the static root should not be writable by `www-data`.
nik commented 2021-03-22 12:53:00 +01:00
Author
Owner
Copy link

added 1 commit

  • ce183405 - [Docker] Drop privileges to www-data after container build

Compare with previous version

added 1 commit <ul><li>ce183405 - [Docker] Drop privileges to www-data after container build</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/544/diffs?diff_id=6169&start_sha=57fe7befb81ab968c55350a5fe5bc43504d0211e)
nik commented 2021-03-22 20:55:15 +01:00
Author
Owner
Copy link

added 2 commits

  • 280434aa - Run `collectstatic` at build time
  • 74eb629e - [Docker] Honour storage locations and declare volumes correctly

Compare with previous version

added 2 commits <ul><li>280434aa - Run `collectstatic` at build time</li><li>74eb629e - [Docker] Honour storage locations and declare volumes correctly</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/544/diffs?diff_id=6177&start_sha=ce183405ad384f755952aa66e2fddb9f4a877114)
nik commented 2021-03-22 20:58:37 +01:00
Author
Owner
Copy link

changed the description

changed the description
nik commented 2021-03-22 20:58:37 +01:00
Author
Owner
Copy link

assigned to @hansegucker and unassigned @nik

assigned to @hansegucker and unassigned @nik
nik commented 2021-03-22 20:58:37 +01:00
Author
Owner
Copy link

requested review from @debdolph

requested review from @debdolph
nik commented 2021-03-22 21:32:23 +01:00
Author
Owner
Copy link

added 1 commit

  • b7156de7 - [Docker} Do not declare static root as volume

Compare with previous version

added 1 commit <ul><li>b7156de7 - [Docker} Do not declare static root as volume</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/544/diffs?diff_id=6184&start_sha=74eb629e982fb0311d1348a0dc572eea14961ee7)
nik commented 2021-03-22 22:26:54 +01:00
Author
Owner
Copy link

added 1 commit

  • d99ebffc - Use media storage for maintenance mode state file

Compare with previous version

added 1 commit <ul><li>d99ebffc - Use media storage for maintenance mode state file</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/544/diffs?diff_id=6190&start_sha=b7156de723bf1d897220e090f907eb03347d4d9d)
nik commented 2021-03-22 22:42:10 +01:00
Author
Owner
Copy link

added 1 commit

  • e973795f - [Docker] Use numeric user ID in USER to not confuse K8s

Compare with previous version

added 1 commit <ul><li>e973795f - [Docker] Use numeric user ID in USER to not confuse K8s</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/544/diffs?diff_id=6197&start_sha=d99ebffcdb31e3ae9ff19d9d6e728ed62c10d50e)
nik commented 2021-03-22 23:03:15 +01:00
Author
Owner
Copy link

added 2 commits

  • 1b4ba2a2 - Use media storage for maintenance mode state file
  • fc9837d7 - [Docker] Use numeric user ID in USER to not confuse K8s

Compare with previous version

added 2 commits <ul><li>1b4ba2a2 - Use media storage for maintenance mode state file</li><li>fc9837d7 - [Docker] Use numeric user ID in USER to not confuse K8s</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/544/diffs?diff_id=6200&start_sha=e973795fa80c5f1c926f8af661469e4d6e0410d4)
nik commented 2021-03-22 23:20:50 +01:00
Author
Owner
Copy link

added 5 commits

  • bdcb1036 - Run `collectstatic` at build time
  • 1f2833ac - [Docker] Honour storage locations and declare volumes correctly
  • 8194a7d0 - [Docker} Do not declare static root as volume
  • da0050cc - Use media storage for maintenance mode state file
  • 39df0f57 - [Docker] Use numeric user ID in USER to not confuse K8s

Compare with previous version

added 5 commits <ul><li>bdcb1036 - Run `collectstatic` at build time</li><li>1f2833ac - [Docker] Honour storage locations and declare volumes correctly</li><li>8194a7d0 - [Docker} Do not declare static root as volume</li><li>da0050cc - Use media storage for maintenance mode state file</li><li>39df0f57 - [Docker] Use numeric user ID in USER to not confuse K8s</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/544/diffs?diff_id=6202&start_sha=fc9837d7bb52bf765f03d7725b38871b140dc3ea)
nik commented 2021-03-22 23:40:30 +01:00
Author
Owner
Copy link

added 4 commits

  • 0d5c0fbd - [Docker] Honour storage locations and declare volumes correctly
  • 86a9b0e8 - [Docker] Do not declare static root as volume
  • e6762257 - Use media storage for maintenance mode state file
  • 1b6fd8ef - [Docker] Use numeric user ID in USER to not confuse K8s

Compare with previous version

added 4 commits <ul><li>0d5c0fbd - [Docker] Honour storage locations and declare volumes correctly</li><li>86a9b0e8 - [Docker] Do not declare static root as volume</li><li>e6762257 - Use media storage for maintenance mode state file</li><li>1b6fd8ef - [Docker] Use numeric user ID in USER to not confuse K8s</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/544/diffs?diff_id=6204&start_sha=39df0f57cb6f13391368c09b0e7e8c86addf4299)
nik commented 2021-03-22 23:41:19 +01:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
nik commented 2021-03-22 23:43:57 +01:00
Author
Owner
Copy link

marked this merge request as draft

marked this merge request as **draft**
nik commented 2021-03-22 23:51:45 +01:00
Author
Owner
Copy link

added 2 commits

  • 214f5bb4 - Use media storage for maintenance mode state file
  • fd9c6006 - [Docker] Use numeric user ID in USER to not confuse K8s

Compare with previous version

added 2 commits <ul><li>214f5bb4 - Use media storage for maintenance mode state file</li><li>fd9c6006 - [Docker] Use numeric user ID in USER to not confuse K8s</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/544/diffs?diff_id=6205&start_sha=1b6fd8ef5a80e8af788f5ec4537b82fc004758ed)
nik commented 2021-03-23 00:16:23 +01:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
nik commented 2021-03-23 11:58:51 +01:00
Author
Owner
Copy link

marked this merge request as draft

marked this merge request as **draft**
nik commented 2021-03-23 12:07:32 +01:00
Author
Owner
Copy link

added 3 commits

  • dba23b95 - Run poetry update
  • d12a111d - Merge branch 'feature/poetry-update' into 409-docker-do-not-run-as-root
  • 35ea4686 - Use `DefaultStorageBackend` from upstream django-maintenance-mode

Compare with previous version

added 3 commits <ul><li>dba23b95 - Run poetry update</li><li>d12a111d - Merge branch &#39;feature/poetry-update&#39; into 409-docker-do-not-run-as-root</li><li>35ea4686 - Use `DefaultStorageBackend` from upstream django-maintenance-mode</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/544/diffs?diff_id=6211&start_sha=fd9c6006b54325ccff02aabcedbf09c82bb9552b)
nik commented 2021-03-23 12:09:33 +01:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
nik commented 2021-03-23 12:48:21 +01:00
Author
Owner
Copy link

mentioned in merge request !2194

mentioned in merge request !2194
hansegucker commented 2021-03-23 13:24:21 +01:00
Owner
Copy link

approved this merge request

approved this merge request
hansegucker commented 2021-03-23 13:24:28 +01:00
Owner
Copy link

There are some merge conflicts.

There are some merge conflicts.
tteichler commented 2021-03-23 14:53:10 +01:00
Owner
Copy link

approved this merge request

approved this merge request
nik commented 2021-03-23 17:28:52 +01:00
Author
Owner
Copy link

added 6 commits

  • 35ea4686...6560c434 - 5 commits from branch master
  • 7e458d32 - Merge branch 'master' into 409-docker-do-not-run-as-root

Compare with previous version

added 6 commits <ul><li>35ea4686...6560c434 - 5 commits from branch <code>master</code></li><li>7e458d32 - Merge branch &#39;master&#39; into 409-docker-do-not-run-as-root</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/544/diffs?diff_id=6244&start_sha=35ea4686be33e0c0c55a910d9ad7daeaaad3c3e0)
nik scheduled this pull request to auto merge when all checks succeed 2021-03-23 17:33:54 +01:00
nik merged commit c6f14fe12b into master 2021-03-23 17:47:49 +01:00
nik commented 2021-03-23 17:47:52 +01:00
Author
Owner
Copy link

mentioned in commit c6f14fe12b

mentioned in commit c6f14fe12bd593ccbb29dbab165aa67e3bc62202
tteichler approved these changes 2026-07-30 18:34:26 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
hansegucker
debdolph
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2189
No description provided.