aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Allow using Django-local accounts in addition to LDAP accounts" #2146

Merged
hansegucker merged 3 commits from 389-allow-using-django-local-accounts-in-addition-to-ldap-accounts into master 2021-04-30 16:15:26 +02:00
Conversation 15 Commits 3 Files changed 2 +6 -6
nik commented 2021-02-25 23:27:07 +01:00
Owner
Copy link

This approach moves the check for the SET_USABLE_PASSWORD setting to happen before failing authentication. If we do not handle passwords, we allow logging in with whatever is there.

The default behaviour remains to fail authentication for users that are not found in LDAP for the security reasons pointed out in #389.

Closes #388, #389

@debdolph We have to check what this does to the password changing feature. How does it behave if we disable usable Django passwords, and do we need to disable the feature then?

This approach moves the check for the `SET_USABLE_PASSWORD` setting to happen before failing authentication. If we do not handle passwords, we allow logging in with whatever is there. The default behaviour remains to fail authentication for users that are not found in LDAP for the security reasons pointed out in #389. Closes #388, #389 @debdolph We have to check what this does to the password changing feature. How does it behave if we disable usable Django passwords, and do we need to disable the feature then?
nik commented 2021-02-25 23:35:27 +01:00
Author
Owner
Copy link

assigned to @hansegucker and unassigned @nik

assigned to @hansegucker and unassigned @nik
nik commented 2021-02-25 23:35:32 +01:00
Author
Owner
Copy link

added 2 commits

  • be66faa1 - Only fail auth for non-LDAP users if password handling is enabled
  • 49c997eb - Allow overriding password handling in config

Compare with previous version

added 2 commits <ul><li>be66faa1 - Only fail auth for non-LDAP users if password handling is enabled</li><li>49c997eb - Allow overriding password handling in config</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/501/diffs?diff_id=4984&start_sha=77df2d66145d28a710fa2e8fe60c5aa194665259)
nik commented 2021-02-25 23:37:30 +01:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
nik commented 2021-02-25 23:37:30 +01:00
Author
Owner
Copy link

changed the description

changed the description
nik commented 2021-02-25 23:40:56 +01:00
Author
Owner
Copy link

requested review from @debdolph

requested review from @debdolph
nik commented 2021-02-25 23:43:07 +01:00
Author
Owner
Copy link

changed the description

changed the description
nik commented 2021-02-25 23:43:13 +01:00
Author
Owner
Copy link

marked this merge request as draft

marked this merge request as **draft**
nik commented 2021-03-27 23:46:07 +01:00
Author
Owner
Copy link

@debdolph Please provide feedback asap.

@debdolph Please provide feedback asap.
tteichler commented 2021-04-04 19:18:49 +02:00
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
tteichler commented 2021-04-04 19:19:07 +02:00
Owner
Copy link

added 192 commits

  • 49c997eb...7d022176 - 190 commits from branch master
  • 66d244f0 - Only fail auth for non-LDAP users if password handling is enabled
  • 16eaf34f - Allow overriding password handling in config

Compare with previous version

added 192 commits <ul><li>49c997eb...7d022176 - 190 commits from branch <code>master</code></li><li>66d244f0 - Only fail auth for non-LDAP users if password handling is enabled</li><li>16eaf34f - Allow overriding password handling in config</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/501/diffs?diff_id=6897&start_sha=49c997ebb506f3f8ba67aee62262cbd4f339a971)
nik commented 2021-04-16 00:29:53 +02:00
Author
Owner
Copy link

@debdolph Your feedback is still missing.

@debdolph Your feedback is still missing.
tteichler commented 2021-04-17 19:36:35 +02:00
Owner
Copy link

added 65 commits

  • 16eaf34f...1fd6195e - 64 commits from branch master
  • 6b514d1e - Merge branch 'master' into 389-allow-using-django-local-accounts-in-addition-to-ldap-accounts

Compare with previous version

added 65 commits <ul><li>16eaf34f...1fd6195e - 64 commits from branch <code>master</code></li><li>6b514d1e - Merge branch &#39;master&#39; into 389-allow-using-django-local-accounts-in-addition-to-ldap-accounts</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/501/diffs?diff_id=7439&start_sha=16eaf34f610bacd28ff0b21574f2ac7e69be8cec)
tteichler commented 2021-04-17 20:41:34 +02:00
Owner
Copy link

approved this merge request

approved this merge request
hansegucker commented 2021-04-30 16:15:57 +02:00
Owner
Copy link

mentioned in commit 72bcb568be

mentioned in commit 72bcb568be6a1226c1498f8cfaaf01c122f4579f
tteichler approved these changes 2026-07-30 18:35:17 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
debdolph
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2146
No description provided.