aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Add health check for dbbackup" #2140

Merged
hansegucker merged 3 commits from 378-add-health-check-for-dbbackup into master 2021-02-21 21:04:11 +01:00
Conversation 89 Commits 3 Files changed 3 +69 -1
tteichler commented 2021-02-17 10:13:26 +01:00
Owner
Copy link

Closes #378

Closes #378
tteichler commented 2021-02-17 10:15:12 +01:00
Author
Owner
Copy link

added 1 commit

  • da26944f - Add health checks for media and db backups. Closes #378

Compare with previous version

added 1 commit <ul><li>da26944f - Add health checks for media and db backups. Closes #378</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4853&start_sha=26fabd33ca43c29529133b5e9e9d6d3d03f1b252)
tteichler commented 2021-02-17 10:15:35 +01:00
Author
Owner
Copy link

requested review from @hansegucker

requested review from @hansegucker
tteichler commented 2021-02-17 10:15:37 +01:00
Author
Owner
Copy link

assigned to @nik and unassigned @debdolph

assigned to @nik and unassigned @debdolph
tteichler commented 2021-02-17 10:15:39 +01:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2021-02-17 11:07:18 +01:00
Owner
Copy link

approved this merge request

approved this merge request
hansegucker commented 2021-02-17 11:08:01 +01:00
Owner
Copy link

unapproved this merge request

unapproved this merge request
hansegucker commented 2021-02-17 11:09:06 +01:00
Owner
Copy link

As the two newly added system checks share a lot of code, I would suggest to use a common base class.

As the two newly added system checks share a lot of code, I would suggest to use a common base class.
tteichler commented 2021-02-17 11:12:40 +01:00
Author
Owner
Copy link

added 1 commit

  • 085cbbb5 - Add health checks for media and db backups. Closes #378

Compare with previous version

added 1 commit <ul><li>085cbbb5 - Add health checks for media and db backups. Closes #378</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4854&start_sha=da26944f835d3b9d620133c52c1696f3d939e052)
tteichler commented 2021-02-17 11:15:31 +01:00
Author
Owner
Copy link

added 1 commit

  • 8810d676 - Add health checks for media and db backups. Closes #378

Compare with previous version

added 1 commit <ul><li>8810d676 - Add health checks for media and db backups. Closes #378</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4855&start_sha=085cbbb519b4643f4c287fefbbe376c6ccd8637e)
nik commented 2021-02-17 21:15:33 +01:00
Owner
Copy link

This should not inherit from BaseDbBackupCommand as this is not a management command.

This should not inherit from `BaseDbBackupCommand` as this is not a management command.
nik commented 2021-02-17 21:15:33 +01:00
Owner
Copy link

This should not inherit from BaseDbBackupCommand as this is not a management command.

This should not inherit from `BaseDbBackupCommand` as this is not a management command.
nik commented 2021-02-17 21:15:33 +01:00
Owner
Copy link

This import name is to generic.

Please import as dbbackup_utils or, even better, just import dbbackup itself and use the rest of it namespaced.

This import name is to generic. Please import as `dbbackup_utils` or, even better, just import `dbbackup` itself and use the rest of it namespaced.
nik commented 2021-02-17 21:15:34 +01:00
Owner
Copy link

Is this DBBACKUP_SECONDS by intention. i.e. timeout is intended to be the same for dbbackup and media backup?

Is this `DBBACKUP_SECONDS` by intention. i.e. timeout is intended to be the same for dbbackup and media backup?
nik commented 2021-02-17 21:15:34 +01:00
Owner
Copy link

Why do you convert the date to a string and then back to a datetime?

Why do you convert the date to a string and then back to a datetime?
nik commented 2021-02-17 21:15:35 +01:00
Owner
Copy link

Why do you convert the date to a string and then back to a datetime?

Why do you convert the date to a string and then back to a datetime?
nik commented 2021-02-17 21:15:35 +01:00
Owner
Copy link

This is not precise. It checks whether the last backup was run a defined timespan ago.

Are you sure that existence of a backup file means the backup was successful?

This is not precise. It checks whether the last backup was run a defined timespan ago. Are you sure that existence of a backup file means the backup was successful?
nik commented 2021-02-17 21:15:36 +01:00
Owner
Copy link

This is not precise. It checks whether the last backup was run a defined timespan ago.

Are you sure that existence of a backup file means the backup was successful?

This is not precise. It checks whether the last backup was run a defined timespan ago. Are you sure that existence of a backup file means the backup was successful?
nik commented 2021-02-17 21:15:37 +01:00
Owner
Copy link

Can/should we derive this fro mthe configured backup plan somehow?

Can/should we derive this fro mthe configured backup plan somehow?
tteichler commented 2021-02-17 21:24:07 +01:00
Author
Owner
Copy link

yes

yes
tteichler commented 2021-02-17 21:24:57 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4866&start_sha=8810d6760ac131b4ebcc44a3e8c370ddefe20950#358275720d816cfb0e6a4145a70f46181f8b430e_27_27)
tteichler commented 2021-02-17 21:24:57 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4866&start_sha=8810d6760ac131b4ebcc44a3e8c370ddefe20950#358275720d816cfb0e6a4145a70f46181f8b430e_46_46)
tteichler commented 2021-02-17 21:24:57 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4866&start_sha=8810d6760ac131b4ebcc44a3e8c370ddefe20950#358275720d816cfb0e6a4145a70f46181f8b430e_6_6)
tteichler commented 2021-02-17 21:24:58 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4866&start_sha=8810d6760ac131b4ebcc44a3e8c370ddefe20950#358275720d816cfb0e6a4145a70f46181f8b430e_36_35)
tteichler commented 2021-02-17 21:24:58 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4866&start_sha=8810d6760ac131b4ebcc44a3e8c370ddefe20950#358275720d816cfb0e6a4145a70f46181f8b430e_55_54)
tteichler commented 2021-02-17 21:24:58 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4866&start_sha=8810d6760ac131b4ebcc44a3e8c370ddefe20950#358275720d816cfb0e6a4145a70f46181f8b430e_47_46)
tteichler commented 2021-02-17 21:24:59 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4866&start_sha=8810d6760ac131b4ebcc44a3e8c370ddefe20950#358275720d816cfb0e6a4145a70f46181f8b430e_28_27)
tteichler commented 2021-02-17 21:24:59 +01:00
Author
Owner
Copy link

added 1 commit

  • 5535258f - Update health_checks.py

Compare with previous version

added 1 commit <ul><li>5535258f - Update health_checks.py</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4866&start_sha=8810d6760ac131b4ebcc44a3e8c370ddefe20950)
tteichler commented 2021-02-17 21:25:37 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-02-17 21:31:39 +01:00
Author
Owner
Copy link

added 31 commits

  • 5535258f...d23be3b6 - 30 commits from branch master
  • 97148608 - Merge branch 'master' into 378-add-health-check-for-dbbackup

Compare with previous version

added 31 commits <ul><li>5535258f...d23be3b6 - 30 commits from branch <code>master</code></li><li>97148608 - Merge branch &#39;master&#39; into 378-add-health-check-for-dbbackup</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4867&start_sha=5535258fad13fd076ea1a200e7a630cdf0ca3516)
tteichler commented 2021-02-17 21:37:42 +01:00
Author
Owner
Copy link

added 1 commit

  • b42c86f8 - Merge branch 'master' into 378-add-health-check-for-dbbackup

Compare with previous version

added 1 commit <ul><li>b42c86f8 - Merge branch &#39;master&#39; into 378-add-health-check-for-dbbackup</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4868&start_sha=971486084cde7f677c83c3a3e06b79fe7ce313bf)
tteichler commented 2021-02-17 21:39:22 +01:00
Author
Owner
Copy link

added 1 commit

  • d777cf92 - Merge branch 'master' into 378-add-health-check-for-dbbackup

Compare with previous version

added 1 commit <ul><li>d777cf92 - Merge branch &#39;master&#39; into 378-add-health-check-for-dbbackup</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4869&start_sha=b42c86f8d1ca6caac248e7a33ce6d8b82c6d5c02)
tteichler commented 2021-02-17 22:19:06 +01:00
Author
Owner
Copy link

added 1 commit

  • b7d863a1 - Add check if last job was successful

Compare with previous version

added 1 commit <ul><li>b7d863a1 - Add check if last job was successful</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4871&start_sha=d777cf922f8c3f0577dd380b218ce357e45e61b7)
tteichler commented 2021-02-17 22:25:42 +01:00
Author
Owner
Copy link

added 1 commit

  • a172aa90 - Add check if last job was successful

Compare with previous version

added 1 commit <ul><li>a172aa90 - Add check if last job was successful</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4872&start_sha=b7d863a1545dec38c71e4f6d58f13f5b8c7b4c36)
tteichler commented 2021-02-17 22:47:47 +01:00
Author
Owner
Copy link

added 1 commit

  • 7dc85759 - Add check if last job was successful

Compare with previous version

added 1 commit <ul><li>7dc85759 - Add check if last job was successful</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4873&start_sha=a172aa904057f4ec922a468a43e7a0f1294cc984)
nik commented 2021-02-18 01:07:39 +01:00
Owner
Copy link

I second that.

I second that.
nik commented 2021-02-18 01:08:50 +01:00
Owner
Copy link

Why query the database twice?

Why query the database twice?
nik commented 2021-02-18 01:10:10 +01:00
Owner
Copy link

This will fail with the code above if no task is found (NameError because task was never set). Fixing the comment above by just calling last() unconditionally implicitly solves this.

This will fail with the code above if no task is found (`NameError` because task was never set). Fixing the comment above by just calling `last()` unconditionally implicitly solves this.
nik commented 2021-02-18 17:12:50 +01:00
Owner
Copy link

Why?

Why?
tteichler commented 2021-02-18 20:43:13 +01:00
Author
Owner
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4885&start_sha=7dc857593513fb8c5f53b403b52865206c0369cf#358275720d816cfb0e6a4145a70f46181f8b430e_74_71)
tteichler commented 2021-02-18 20:43:13 +01:00
Author
Owner
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4885&start_sha=7dc857593513fb8c5f53b403b52865206c0369cf#358275720d816cfb0e6a4145a70f46181f8b430e_77_74)
tteichler commented 2021-02-18 20:43:14 +01:00
Author
Owner
Copy link

added 1 commit

  • edcd4b25 - Fix check of TaskResult

Compare with previous version

added 1 commit <ul><li>edcd4b25 - Fix check of TaskResult</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4885&start_sha=7dc857593513fb8c5f53b403b52865206c0369cf)
tteichler commented 2021-02-18 21:03:07 +01:00
Author
Owner
Copy link

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4886&start_sha=edcd4b25ede782717b744efcf670c0d40d755f0e#358275720d816cfb0e6a4145a70f46181f8b430e_58_55)
tteichler commented 2021-02-18 21:03:07 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-02-18 21:03:09 +01:00
Author
Owner
Copy link

added 1 commit

  • ff9daec6 - Add health checks for media and db backups. Closes #378

Compare with previous version

added 1 commit <ul><li>ff9daec6 - Add health checks for media and db backups. Closes #378</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4886&start_sha=edcd4b25ede782717b744efcf670c0d40d755f0e)
tteichler commented 2021-02-18 21:11:03 +01:00
Author
Owner
Copy link

added 1 commit

  • eb80b193 - Add health checks for media and db backups. Closes #378

Compare with previous version

added 1 commit <ul><li>eb80b193 - Add health checks for media and db backups. Closes #378</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4887&start_sha=ff9daec69fea5a2c6976cf028045eb948881b5ec)
hansegucker commented 2021-02-19 11:08:02 +01:00
Owner
Copy link

Please split this up for db backup and media backup.

Please split this up for db backup and media backup.
tteichler commented 2021-02-20 14:52:14 +01:00
Author
Owner
Copy link

done

done
tteichler commented 2021-02-20 14:52:15 +01:00
Author
Owner
Copy link

added 1 commit

  • cc241b84 - Use seperate settings for db and media backup

Compare with previous version

added 1 commit <ul><li>cc241b84 - Use seperate settings for db and media backup</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4909&start_sha=eb80b19383c4e0459b83ff489fcff0b5d6132da1)
tteichler commented 2021-02-20 14:52:15 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2021-02-20 14:59:57 +01:00
Owner
Copy link

approved this merge request

approved this merge request
nik commented 2021-02-21 01:00:26 +01:00
Owner
Copy link

This should be part of the sub class. Inheritance was invented to encapsulate code within its respective class, not to do sub-class logic in a base class.

This should be part of the sub class. Inheritance was invented to encapsulate code within its respective class, not to do sub-class logic in a base class.
nik commented 2021-02-21 01:00:49 +01:00
Owner
Copy link

Didn't you say this was unnecessary?

Didn't you say this was unnecessary?
nik commented 2021-02-21 01:00:56 +01:00
Owner
Copy link

Didn't you say this was unnecessary?

Didn't you say this was unnecessary?
nik commented 2021-02-21 01:02:24 +01:00
Owner
Copy link

Didn't you say this was unnecessary?

Didn't you say this was unnecessary?
nik commented 2021-02-21 01:02:55 +01:00
Owner
Copy link

This still uses the same parameter from the config file.

This still uses the same parameter from the config file.
tteichler commented 2021-02-21 12:02:40 +01:00
Author
Owner
Copy link

changed this line in version 15 of the diff

changed this line in [version 15 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4921&start_sha=cc241b84266269603e5335ebe3fa9bb30ab77ccf#abc9d828b78bd9d36e05475d0bc91119bc5bc6b0_733_733)
tteichler commented 2021-02-21 12:02:41 +01:00
Author
Owner
Copy link

changed this line in version 15 of the diff

changed this line in [version 15 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4921&start_sha=cc241b84266269603e5335ebe3fa9bb30ab77ccf#358275720d816cfb0e6a4145a70f46181f8b430e_52_51)
tteichler commented 2021-02-21 12:02:41 +01:00
Author
Owner
Copy link

changed this line in version 15 of the diff

changed this line in [version 15 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4921&start_sha=cc241b84266269603e5335ebe3fa9bb30ab77ccf#358275720d816cfb0e6a4145a70f46181f8b430e_61_57)
tteichler commented 2021-02-21 12:02:41 +01:00
Author
Owner
Copy link

changed this line in version 15 of the diff

changed this line in [version 15 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4921&start_sha=cc241b84266269603e5335ebe3fa9bb30ab77ccf#358275720d816cfb0e6a4145a70f46181f8b430e_79_71)
tteichler commented 2021-02-21 12:02:41 +01:00
Author
Owner
Copy link

changed this line in version 15 of the diff

changed this line in [version 15 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4921&start_sha=cc241b84266269603e5335ebe3fa9bb30ab77ccf#abc9d828b78bd9d36e05475d0bc91119bc5bc6b0_734_733)
tteichler commented 2021-02-21 12:02:42 +01:00
Author
Owner
Copy link

added 1 commit

  • bacd3df6 - Use seperate settings for db and media backup

Compare with previous version

added 1 commit <ul><li>bacd3df6 - Use seperate settings for db and media backup</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4921&start_sha=cc241b84266269603e5335ebe3fa9bb30ab77ccf)
tteichler commented 2021-02-21 18:28:56 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-02-21 18:29:01 +01:00
Author
Owner
Copy link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4922&start_sha=bacd3df64640ccaa0a0cafaa5f2032d9b3f813fc#358275720d816cfb0e6a4145a70f46181f8b430e_39_37)
tteichler commented 2021-02-21 18:29:01 +01:00
Author
Owner
Copy link

added 1 commit

  • 1727a4a3 - Use seperate settings for db and media backup

Compare with previous version

added 1 commit <ul><li>1727a4a3 - Use seperate settings for db and media backup</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4922&start_sha=bacd3df64640ccaa0a0cafaa5f2032d9b3f813fc)
nik commented 2021-02-21 20:35:52 +01:00
Owner
Copy link

Potential use before assignment ­set to a dummy value in this class.

Also, what if there is no last backup?

Potential use before assignment ­set to a dummy value in this class. Also, what if there is no last backup?
nik commented 2021-02-21 20:35:52 +01:00
Owner
Copy link

s/settings/seconds/?

`s/settings/seconds/`?
nik commented 2021-02-21 20:35:52 +01:00
Owner
Copy link

Pull the .last() up here, as it is used in every access later on.

Pull the `.last()` up here, as it is used in every access later on.
nik commented 2021-02-21 20:35:53 +01:00
Owner
Copy link

Please use the configuration namespaces properly, as for the keep option.

Please use the configuration namespaces properly, as for the `keep` option.
tteichler commented 2021-02-21 20:36:46 +01:00
Author
Owner
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4928&start_sha=1727a4a3f24322645fa4449a881d4bc58bf127db#358275720d816cfb0e6a4145a70f46181f8b430e_47_52)
tteichler commented 2021-02-21 20:36:46 +01:00
Author
Owner
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4928&start_sha=1727a4a3f24322645fa4449a881d4bc58bf127db#abc9d828b78bd9d36e05475d0bc91119bc5bc6b0_734_733)
tteichler commented 2021-02-21 20:36:47 +01:00
Author
Owner
Copy link

added 1 commit

  • 5834ee44 - Use seperate settings for db and media backup

Compare with previous version

added 1 commit <ul><li>5834ee44 - Use seperate settings for db and media backup</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4928&start_sha=1727a4a3f24322645fa4449a881d4bc58bf127db)
tteichler commented 2021-02-21 20:38:37 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-02-21 20:42:31 +01:00
Author
Owner
Copy link

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4929&start_sha=5834ee44e5ab278518f9996dfd16499657c3db17#358275720d816cfb0e6a4145a70f46181f8b430e_68_68)
tteichler commented 2021-02-21 20:42:32 +01:00
Author
Owner
Copy link

added 1 commit

  • a2a593e4 - Use seperate settings for db and media backup

Compare with previous version

added 1 commit <ul><li>a2a593e4 - Use seperate settings for db and media backup</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4929&start_sha=5834ee44e5ab278518f9996dfd16499657c3db17)
nik commented 2021-02-21 20:48:29 +01:00
Owner
Copy link

Also, what if there is no last backup?

> Also, what if there is no last backup?
nik commented 2021-02-21 20:50:10 +01:00
Owner
Copy link
        elif task and task.status != "SUCCESS":
```suggestion:-0+0 elif task and task.status != "SUCCESS": ```
nik commented 2021-02-21 20:50:36 +01:00
Owner
Copy link

Please be clearer in the option name (e.g. timeout_seconds)

Please be clearer in the option name (e.g. `timeout_seconds`)
tteichler commented 2021-02-21 20:55:01 +01:00
Author
Owner
Copy link

changed this line in version 19 of the diff

changed this line in [version 19 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4930&start_sha=a2a593e420c9b0940182d7b659778b8428c02617#358275720d816cfb0e6a4145a70f46181f8b430e_36_36)
tteichler commented 2021-02-21 20:55:01 +01:00
Author
Owner
Copy link

changed this line in version 19 of the diff

changed this line in [version 19 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4930&start_sha=a2a593e420c9b0940182d7b659778b8428c02617#abc9d828b78bd9d36e05475d0bc91119bc5bc6b0_734_733)
tteichler commented 2021-02-21 20:55:02 +01:00
Author
Owner
Copy link

added 1 commit

  • 3e2a9284 - Use seperate settings for db and media backup

Compare with previous version

added 1 commit <ul><li>3e2a9284 - Use seperate settings for db and media backup</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4930&start_sha=a2a593e420c9b0940182d7b659778b8428c02617)
tteichler commented 2021-02-21 20:55:13 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-02-21 20:55:19 +01:00
Author
Owner
Copy link

changed this line in version 20 of the diff

changed this line in [version 20 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4931&start_sha=3e2a92845d4f8e099ac3eca9448779c41e136a45#358275720d816cfb0e6a4145a70f46181f8b430e_74_74)
tteichler commented 2021-02-21 20:55:20 +01:00
Author
Owner
Copy link

added 1 commit

  • d86bf0e7 - Use seperate settings for db and media backup

Compare with previous version

added 1 commit <ul><li>d86bf0e7 - Use seperate settings for db and media backup</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4931&start_sha=3e2a92845d4f8e099ac3eca9448779c41e136a45)
nik commented 2021-02-21 20:57:11 +01:00
Owner
Copy link
            last_backup = backups[-1]
```suggestion:-0+0 last_backup = backups[-1] ```
tteichler commented 2021-02-21 20:58:12 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-02-21 20:58:16 +01:00
Author
Owner
Copy link

changed this line in version 21 of the diff

changed this line in [version 21 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4932&start_sha=d86bf0e7427ebcea953d0aebc52f962f8adfe00f#358275720d816cfb0e6a4145a70f46181f8b430e_38_38)
tteichler commented 2021-02-21 20:58:17 +01:00
Author
Owner
Copy link

added 1 commit

  • ca269aa6 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>ca269aa6 - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/495/diffs?diff_id=4932&start_sha=d86bf0e7427ebcea953d0aebc52f962f8adfe00f)
nik scheduled this pull request to auto merge when all checks succeed 2021-02-21 21:00:53 +01:00
nik merged commit d50b445b86 into master 2021-02-21 21:04:11 +01:00
nik commented 2021-02-21 21:04:16 +01:00
Owner
Copy link

mentioned in commit d50b445b86

mentioned in commit d50b445b86faf8a5263cf05102558a7d64d2f011
Sign in to join this conversation.
Reviewers
No reviewers
hansegucker
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2140
No description provided.