aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

WIP: Draft: Build icons from SVG automatically #2125

Draft
nik wants to merge 9 commits from feature/build-icons-automatically into master
pull from: feature/build-icons-automatically
merge into: aleksis:master
Conversation 9 Commits 9 Files changed 13 +58
nik commented 2021-02-11 00:40:41 +01:00
Owner
Copy link
No description provided.
nik commented 2021-02-11 00:52:00 +01:00
Author
Owner
Copy link

marked this merge request as draft

marked this merge request as **draft**
nik commented 2021-02-11 00:58:17 +01:00
Author
Owner
Copy link

added 1 commit

  • be573cbb - Make Makefile in icons more readable

Compare with previous version

added 1 commit <ul><li>be573cbb - Make Makefile in icons more readable</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/480/diffs?diff_id=4738&start_sha=5f83f2869dae78d80ee9904d7445bbccaba07b51)
tteichler commented 2021-02-12 20:34:24 +01:00
Owner
Copy link

Why is this still draft?

Why is this still draft?
nik commented 2021-04-20 23:51:51 +02:00
Author
Owner
Copy link

added 329 commits

  • be573cbb...b9fe9e08 - 328 commits from branch master
  • 3f447b3b - Merge branch 'master' into feature/build-icons-automatically

Compare with previous version

added 329 commits <ul><li>be573cbb...b9fe9e08 - 328 commits from branch <code>master</code></li><li>3f447b3b - Merge branch &#39;master&#39; into feature/build-icons-automatically</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/480/diffs?diff_id=7542&start_sha=be573cbbb1c1dd4033aab696e526663ec0a5123a)
nik commented 2021-04-21 01:01:34 +02:00
Author
Owner
Copy link

added 4 commits

  • 2dabe202 - Move icon build code to build.py
  • fa57f3e3 - Update gitignore to ignore icons directory
  • accea3d2 - Build-depend on cairosvg
  • 863b393d - Explicitly add generated icons to package_data

Compare with previous version

added 4 commits <ul><li>2dabe202 - Move icon build code to build.py</li><li>fa57f3e3 - Update gitignore to ignore icons directory</li><li>accea3d2 - Build-depend on cairosvg</li><li>863b393d - Explicitly add generated icons to package_data</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/480/diffs?diff_id=7546&start_sha=3f447b3b930742588fead218e0a0eb095b8ce0f9)
nik commented 2021-04-21 01:04:59 +02:00
Author
Owner
Copy link

added 1 commit

  • 27e5a423 - Revert Makefile change to tox.ini

Compare with previous version

added 1 commit <ul><li>27e5a423 - Revert Makefile change to tox.ini</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/480/diffs?diff_id=7548&start_sha=863b393d588bd45c0440b23421dd5f994b7c38eb)
nik commented 2021-04-21 01:05:39 +02:00
Author
Owner
Copy link

added 1 commit

  • 712c3442 - Revert Makefile change to tox.ini

Compare with previous version

added 1 commit <ul><li>712c3442 - Revert Makefile change to tox.ini</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/480/diffs?diff_id=7550&start_sha=27e5a4230856af43b36b79762bcb739e392c6564)
nik commented 2021-04-21 01:07:04 +02:00
Author
Owner
Copy link

This works now in general, but the built icons never show up in the generated wheel. They are copied to the dist tree, but then are missing in the zipped wheel. I have no idea why.

This works now in general, but the built icons never show up in the generated wheel. They are copied to the dist tree, but then are missing in the zipped wheel. I have no idea why.
nik commented 2021-12-07 21:24:13 +01:00
Author
Owner
Copy link

mentioned in merge request !2417

mentioned in merge request !2417
This pull request has changes conflicting with the target branch.
  • .gitignore
  • aleksis/core/static/img/aleksis-favicon.png
  • pyproject.toml
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/build-icons-automatically:feature/build-icons-automatically
git switch feature/build-icons-automatically

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff feature/build-icons-automatically
git switch feature/build-icons-automatically
git rebase master
git switch master
git merge --ff-only feature/build-icons-automatically
git switch feature/build-icons-automatically
git rebase master
git switch master
git merge --no-ff feature/build-icons-automatically
git switch master
git merge --squash feature/build-icons-automatically
git switch master
git merge --ff-only feature/build-icons-automatically
git switch master
git merge feature/build-icons-automatically
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2125
No description provided.