aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Favicon should contain only school bag" #2124

Merged
hansegucker merged 2 commits from 254-favicon-should-contain-only-school-bag into master 2021-02-10 23:48:47 +01:00
Conversation 21 Commits 2 Files changed 4 +3
tteichler commented 2021-02-10 16:22:46 +01:00
Owner
Copy link

Closes #254

Closes #254
tteichler commented 2021-02-10 16:31:38 +01:00
Author
Owner
Copy link

added 1 commit

  • b2ff7317 - Use school bag as favicon. Closes #254.

Compare with previous version

added 1 commit <ul><li>b2ff7317 - Use school bag as favicon. Closes #254.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/479/diffs?diff_id=4731&start_sha=b528d8060c7ba74d7d082280996231b8745bbd30)
tteichler commented 2021-02-10 16:31:44 +01:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
tteichler commented 2021-02-10 16:31:48 +01:00
Author
Owner
Copy link

assigned to @nik and unassigned @debdolph

assigned to @nik and unassigned @debdolph
tteichler commented 2021-02-10 16:32:12 +01:00
Author
Owner
Copy link

requested review from @hansegucker

requested review from @hansegucker
hansegucker commented 2021-02-10 16:33:55 +01:00
Owner
Copy link

You replaced all icons, not just the favicons.

You replaced all icons, not just the favicons.
tteichler commented 2021-02-10 17:43:52 +01:00
Author
Owner
Copy link

added 1 commit

  • 731fd6b4 - Use school bag as favicon. Closes #254.

Compare with previous version

added 1 commit <ul><li>731fd6b4 - Use school bag as favicon. Closes #254.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/479/diffs?diff_id=4732&start_sha=b2ff7317b6e103505501b1963f9df2bafb7a67c1)
hansegucker commented 2021-02-10 19:20:13 +01:00
Owner
Copy link

approved this merge request

approved this merge request
nik commented 2021-02-10 21:46:27 +01:00
Owner
Copy link

The source for the bitmaps is missing.

The source for the bitmaps is missing.
nik commented 2021-02-10 21:47:41 +01:00
Owner
Copy link

Also, the shadow is missing.

Also, the shadow is missing.
tteichler commented 2021-02-10 23:08:07 +01:00
Author
Owner
Copy link

added 1 commit

  • 7e3df8dc - [Artwork] 🖼️ Enable building favicon with only schoolbag from original SVG

Compare with previous version

added 1 commit <ul><li>7e3df8dc - [Artwork] 🖼️ Enable building favicon with only schoolbag from original SVG</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/479/diffs?diff_id=4733&start_sha=731fd6b49d79076d8ed530aea142eb5b06a1bad5)
tteichler commented 2021-02-10 23:08:22 +01:00
Author
Owner
Copy link

done

done
tteichler commented 2021-02-10 23:08:23 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-02-10 23:08:38 +01:00
Author
Owner
Copy link

I don't think the shadow is needed for the favicon.

I don't think the shadow is needed for the favicon.
tteichler commented 2021-02-10 23:08:39 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2021-02-10 23:08:43 +01:00
Author
Owner
Copy link

approved this merge request

approved this merge request
tteichler commented 2021-02-10 23:26:29 +01:00
Author
Owner
Copy link

added 1 commit

  • 53011e82 - Generate favicons from SVG

Compare with previous version

added 1 commit <ul><li>53011e82 - Generate favicons from SVG</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/479/diffs?diff_id=4734&start_sha=7e3df8dc45ed9d987a34e086fe46d575e3e9b6bc)
tteichler commented 2021-02-10 23:44:47 +01:00
Author
Owner
Copy link

added 2 commits

  • 9224f53d - [Artwork] 🖼️ Enable building favicon with only schoolbag from original SVG
  • bc041fc2 - Use school bag as favicon. Closes #254.

Compare with previous version

added 2 commits <ul><li>9224f53d - [Artwork] 🖼️ Enable building favicon with only schoolbag from original SVG</li><li>bc041fc2 - Use school bag as favicon. Closes #254.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/479/diffs?diff_id=4735&start_sha=53011e823b84f31becc951484e9e61dadd6bda55)
nik scheduled this pull request to auto merge when all checks succeed 2021-02-10 23:45:53 +01:00
nik merged commit 81a32daf9d into master 2021-02-10 23:48:47 +01:00
nik commented 2021-02-10 23:48:52 +01:00
Owner
Copy link

mentioned in commit 81a32daf9d

mentioned in commit 81a32daf9df37a31b815b31ec0ed8636680e3f6b
leuckeju commented 2021-11-09 16:15:01 +01:00
Member
Copy link

mentioned in merge request !2417

mentioned in merge request !2417
tteichler approved these changes 2026-07-30 18:36:04 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
hansegucker
debdolph
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2124
No description provided.