aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Allow automatic linking of persons to account by e-mail address" #2059

Merged
hansegucker merged 5 commits from 332-allow-automatic-linking-of-persons-to-account-by-e-mail-address into master 2021-01-23 17:40:24 +01:00
Conversation 19 Commits 5 Files changed 2 +50 -8
nik commented 2020-12-26 22:48:32 +01:00
Owner
Copy link

Closes #332

Closes #332
nik commented 2020-12-26 23:06:53 +01:00
Author
Owner
Copy link

added 1 commit

  • 4120a2c0 - Link/Create persons if a matching one is found for a user

Compare with previous version

added 1 commit <ul><li>4120a2c0 - Link/Create persons if a matching one is found for a user</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/414/diffs?diff_id=4089&start_sha=6563144f6a64e4ad80682c57713ee3d7ae682845)
nik commented 2020-12-26 23:07:03 +01:00
Author
Owner
Copy link

assigned to @hansegucker

assigned to @hansegucker
nik commented 2020-12-26 23:07:08 +01:00
Author
Owner
Copy link

requested review from @debdolph

requested review from @debdolph
nik commented 2020-12-26 23:07:15 +01:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
nik commented 2020-12-26 23:14:44 +01:00
Author
Owner
Copy link

added 1 commit

  • 0b2be5f2 - Reverse logic in auto-creation of persons

Compare with previous version

added 1 commit <ul><li>0b2be5f2 - Reverse logic in auto-creation of persons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/414/diffs?diff_id=4091&start_sha=4120a2c0530ffd5c0c7ca6de6336031d5f1f398f)
tteichler commented 2020-12-26 23:22:23 +01:00
Owner
Copy link

Tested successfully. Can be merged.

Tested successfully. Can be merged.
tteichler commented 2020-12-26 23:22:25 +01:00
Owner
Copy link

approved this merge request

approved this merge request
nik commented 2020-12-26 23:27:20 +01:00
Author
Owner
Copy link

added 1 commit

  • 68600351 - Validate that the user has a name before trying to create a person

Compare with previous version

added 1 commit <ul><li>68600351 - Validate that the user has a name before trying to create a person</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/414/diffs?diff_id=4092&start_sha=0b2be5f2cada2f7526fe07e85672535110a3e598)
hansegucker commented 2020-12-27 10:39:46 +01:00
Owner
Copy link

If I read the code correctly, a person is also created if the corresponding preference is deactivated, but it's just not linked to the user.

If I read the code correctly, a person is also created if the corresponding preference is deactivated, but it's just not linked to the user.
nik commented 2020-12-27 11:34:04 +01:00
Author
Owner
Copy link

I cannot find prrof for this in the code. Maybe you want to annotate the corresponsing lines with your comment.

I cannot find prrof for this in the code. Maybe you want to annotate the corresponsing lines with your comment.
hansegucker commented 2020-12-27 12:11:25 +01:00
Owner
Copy link

The person is created independent of the preference account__auto_create_person.

The person is created independent of the preference ``account__auto_create_person``.
hansegucker commented 2021-01-21 15:18:51 +01:00
Owner
Copy link

@nik When do you want to finish this?

@nik When do you want to finish this?
nik commented 2021-01-23 16:47:19 +01:00
Author
Owner
Copy link

added 106 commits

  • 68600351...d39a3291 - 105 commits from branch master
  • d3f6819a - Merge branch 'master' into 332-allow-automatic-linking-of-persons-to-account-by-e-mail-address

Compare with previous version

added 106 commits <ul><li>68600351...d39a3291 - 105 commits from branch <code>master</code></li><li>d3f6819a - Merge branch &#39;master&#39; into 332-allow-automatic-linking-of-persons-to-account-by-e-mail-address</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/414/diffs?diff_id=4462&start_sha=68600351340e61342f386a89896cafe26b809bfa)
nik commented 2021-01-23 16:54:12 +01:00
Author
Owner
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/414/diffs?diff_id=4463&start_sha=d3f6819a94dd04c921e7d0475a2d958ecbfb9b1b#2ffc99ca7c6e2244ab28fdf7909272e34234943e_31_31)
nik commented 2021-01-23 16:54:13 +01:00
Author
Owner
Copy link

added 1 commit

  • c7daea20 - Correctly honour auto_create_person preference

Compare with previous version

added 1 commit <ul><li>c7daea20 - Correctly honour auto_create_person preference</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/414/diffs?diff_id=4463&start_sha=d3f6819a94dd04c921e7d0475a2d958ecbfb9b1b)
nik commented 2021-01-23 16:54:19 +01:00
Author
Owner
Copy link

Done @hansegucker

Done @hansegucker
nik commented 2021-01-23 16:54:20 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2021-01-23 17:40:28 +01:00
Owner
Copy link

mentioned in commit 8911d0e45d

mentioned in commit 8911d0e45dd3ac73f40643289b9e7b3461390c29
tteichler approved these changes 2026-07-30 18:36:59 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
debdolph
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2059
No description provided.