aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Ordering of dashboard widgets #2056

Merged
hansegucker merged 6 commits from feature/ordering-of-dashboard-widgets into master 2020-12-23 12:20:49 +01:00
Conversation 17 Commits 6 Files changed 12 +242 -4
hansegucker commented 2020-12-22 16:40:03 +01:00
Owner
Copy link

Close #191

Blocked by !2055, !2054

Close #191 Blocked by !2055, !2054
hansegucker commented 2020-12-22 16:41:36 +01:00
Author
Owner
Copy link

image

![image](/uploads/6be3dfd3d3f9216ad2b389ea9fc2e512/image.png)
hansegucker commented 2020-12-22 16:41:57 +01:00
Author
Owner
Copy link

image

![image](/uploads/ca48e64f0a808aa2e6e4c0c22d268415/image.png)
hansegucker commented 2020-12-22 21:04:45 +01:00
Author
Owner
Copy link

requested review from @nik

requested review from @nik
hansegucker commented 2020-12-22 21:04:49 +01:00
Author
Owner
Copy link

requested review from @ZugBahnHof and removed review request for @nik

requested review from @ZugBahnHof and removed review request for @nik
nik commented 2020-12-23 12:05:42 +01:00
Owner
Copy link

Invlaid variable name (outside a for-loop). Didn't the linter catch that?

Invlaid variable name (outside a `for`-loop). Didn't the linter catch that?
nik commented 2020-12-23 12:05:42 +01:00
Owner
Copy link

Are you sure this code is reachable? You are in get(), how does a POST request get here?

Are you sure this code is reachable? You are in `get()`, how does a `POST` request get here?
nik commented 2020-12-23 12:05:42 +01:00
Owner
Copy link

Ah now I see. But no. That's not how this separation thing works!

Ah now I see. But no. That's not how this separation thing works!
nik commented 2020-12-23 12:05:43 +01:00
Owner
Copy link

Please also fix variable naming here.

Please also fix variable naming here.
hansegucker commented 2020-12-23 12:09:28 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/411/diffs?diff_id=4054&start_sha=f1f1728fb9137a9cf3a0e3c3dd403ea1b4baf296#ca5e4a886c594c4b59402dbdbd16348bdbcddf3a_793_793)
hansegucker commented 2020-12-23 12:09:30 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/411/diffs?diff_id=4054&start_sha=f1f1728fb9137a9cf3a0e3c3dd403ea1b4baf296#6b139b2c9e46bf24e6e511aaf6b5f35b272b373e_3_3)
hansegucker commented 2020-12-23 12:09:31 +01:00
Author
Owner
Copy link

added 1 commit

  • 8fbdabb3 - Improve variable names (replace i by speaking names)

Compare with previous version

added 1 commit <ul><li>8fbdabb3 - Improve variable names (replace i by speaking names)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/411/diffs?diff_id=4054&start_sha=f1f1728fb9137a9cf3a0e3c3dd403ea1b4baf296)
nik commented 2020-12-23 12:14:53 +01:00
Owner
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/411/diffs?diff_id=4055&start_sha=8fbdabb34c086105753518d836d87f29e60509f4#ca5e4a886c594c4b59402dbdbd16348bdbcddf3a_807_806)
nik commented 2020-12-23 12:14:55 +01:00
Owner
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/official/AlekSIS-Core/-/merge_requests/411/diffs?diff_id=4055&start_sha=8fbdabb34c086105753518d836d87f29e60509f4#ca5e4a886c594c4b59402dbdbd16348bdbcddf3a_832_834)
nik commented 2020-12-23 12:14:56 +01:00
Owner
Copy link

added 2 commits

  • 27017cb8 - Restructure class-based view to properly encapsulate request methods
  • 0a23aac9 - Merge branch 'feature/ordering-of-dashboard-widgets' of...

Compare with previous version

added 2 commits <ul><li>27017cb8 - Restructure class-based view to properly encapsulate request methods</li><li>0a23aac9 - Merge branch &#39;feature/ordering-of-dashboard-widgets&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/411/diffs?diff_id=4055&start_sha=8fbdabb34c086105753518d836d87f29e60509f4)
hansegucker commented 2020-12-23 12:16:27 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>6211b26c - Fix typo</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-Core/-/merge_requests/411/diffs?diff_id=4056&start_sha=0a23aac9a02d818613d9625e484271e2bb0e8c99)
nik commented 2020-12-23 12:17:21 +01:00
Owner
Copy link

resolved all threads

resolved all threads
nik scheduled this pull request to auto merge when all checks succeed 2020-12-23 12:17:37 +01:00
nik commented 2020-12-23 12:20:49 +01:00
Owner
Copy link

mentioned in commit 70b39a38eb

mentioned in commit 70b39a38ebddd2a0274a17ef959d0d8a6e3a8903
nik merged commit 70b39a38eb into master 2020-12-23 12:20:49 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2056
No description provided.