aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Allow site-local configuration of available languages" #2026

Merged
hansegucker merged 1 commit from 261-allow-site-local-configuration-of-available-languages into master 2020-11-11 19:44:08 +01:00
Conversation 31 Commits 1 Files changed 2 +14 -2
tteichler commented 2020-11-11 07:59:41 +01:00
Owner
Copy link

Closes #261

Closes #261
tteichler commented 2020-11-11 08:00:17 +01:00
Author
Owner
Copy link

changed the description

changed the description
tteichler commented 2020-11-11 08:02:01 +01:00
Author
Owner
Copy link

added 1 commit

  • d0443327 - Allow site local configuration of available languages. Closes #261.

Compare with previous version

added 1 commit <ul><li>d0443327 - Allow site local configuration of available languages. Closes #261.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/381/diffs?diff_id=3667&start_sha=d8cc34123392d4bb0774790c800d775eb96e192f)
tteichler commented 2020-11-11 08:03:03 +01:00
Author
Owner
Copy link

Screenshot_2020-11-11_Preferences___AlekSIS

![Screenshot_2020-11-11_Preferences___AlekSIS](/uploads/a172c56c918a76730cb78cf7faf0b110/Screenshot_2020-11-11_Preferences___AlekSIS.png)
tteichler commented 2020-11-11 08:03:54 +01:00
Author
Owner
Copy link

assigned to @hansegucker

assigned to @hansegucker
tteichler commented 2020-11-11 08:04:10 +01:00
Author
Owner
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
tteichler commented 2020-11-11 08:05:01 +01:00
Author
Owner
Copy link

added 1 commit

  • 23c03b82 - Allow site local configuration of available languages. Closes #261.

Compare with previous version

added 1 commit <ul><li>23c03b82 - Allow site local configuration of available languages. Closes #261.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/381/diffs?diff_id=3668&start_sha=d04433276bf585a849882f6be00e7a5b5cd020a7)
tteichler commented 2020-11-11 08:11:57 +01:00
Author
Owner
Copy link

added 1 commit

  • 26a90c94 - Allow site local configuration of available languages. Closes #261.

Compare with previous version

added 1 commit <ul><li>26a90c94 - Allow site local configuration of available languages. Closes #261.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/381/diffs?diff_id=3669&start_sha=23c03b82b35e3aadff5dd59f872ba9bf602efae3)
tteichler commented 2020-11-11 08:27:24 +01:00
Author
Owner
Copy link

added 1 commit

  • bc8ecf07 - Allow site local configuration of available languages. Closes #261.

Compare with previous version

added 1 commit <ul><li>bc8ecf07 - Allow site local configuration of available languages. Closes #261.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/381/diffs?diff_id=3672&start_sha=26a90c94ed0713871fdde5432d5d7372219a9315)
hansegucker commented 2020-11-11 09:29:54 +01:00
Owner
Copy link

Please use https://docs.djangoproject.com/en/3.1/ref/forms/widgets/#selectmultiple as widget.

Please use https://docs.djangoproject.com/en/3.1/ref/forms/widgets/#selectmultiple as widget.
tteichler commented 2020-11-11 10:11:41 +01:00
Author
Owner
Copy link

added 1 commit

  • 2954f85a - Allow site local configuration of available languages. Closes #261.

Compare with previous version

added 1 commit <ul><li>2954f85a - Allow site local configuration of available languages. Closes #261.</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/381/diffs?diff_id=3673&start_sha=bc8ecf076f00928d382d4f399122bfc89f8a77b7)
tteichler commented 2020-11-11 10:14:02 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2020-11-11 10:16:26 +01:00
Author
Owner
Copy link

Screenshot_2020-11-11_Preferences___AlekSIS_1_

![Screenshot_2020-11-11_Preferences___AlekSIS_1_](/uploads/443cffd283f9ec3661e27f133d063ac3/Screenshot_2020-11-11_Preferences___AlekSIS_1_.png)
hansegucker commented 2020-11-11 10:59:29 +01:00
Owner
Copy link

approved this merge request

approved this merge request
hansegucker commented 2020-11-11 10:59:32 +01:00
Owner
Copy link

assigned to @nik and unassigned @hansegucker

assigned to @nik and unassigned @hansegucker
hansegucker commented 2020-11-11 11:00:04 +01:00
Owner
Copy link

@nik Please check backend implementation and merge if everything is fine.

@nik Please check backend implementation and merge if everything is fine.
nik commented 2020-11-11 11:27:31 +01:00
Owner
Copy link

Please use British English

Please use British English
nik commented 2020-11-11 11:27:31 +01:00
Owner
Copy link

Don't we have a generic helper to get site preferences inside templates?

Don't we have a generic helper to get site preferences inside templates?
nik commented 2020-11-11 11:27:32 +01:00
Owner
Copy link

I think the default should be all available languages.

I think the default should be all available languages.
tteichler commented 2020-11-11 11:49:19 +01:00
Author
Owner
Copy link

No

No
nik commented 2020-11-11 12:31:34 +01:00
Owner
Copy link

Bad luck.

We should take the opportunity to mimic https://github.com/EliotBerriot/django-dynamic-preferences/blob/develop/dynamic_preferences/processors.py, then.

Bad luck. We should take the opportunity to mimic https://github.com/EliotBerriot/django-dynamic-preferences/blob/develop/dynamic_preferences/processors.py, then.
tteichler commented 2020-11-11 16:04:35 +01:00
Author
Owner
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/AlekSIS/official/AlekSIS/-/merge_requests/381/diffs?diff_id=3674&start_sha=2954f85ab1cbd82fa6d9dec00639405beec60f60#cedfd047579474194a5f10a12c798242313675da_26_26)
tteichler commented 2020-11-11 16:04:37 +01:00
Author
Owner
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/AlekSIS/official/AlekSIS/-/merge_requests/381/diffs?diff_id=3674&start_sha=2954f85ab1cbd82fa6d9dec00639405beec60f60#cedfd047579474194a5f10a12c798242313675da_207_207)
tteichler commented 2020-11-11 16:04:39 +01:00
Author
Owner
Copy link

added 4 commits

  • 2954f85a...5af9f95a - 2 commits from branch master
  • e469667a - Merge branch 'master' into 261-allow-site-local-configuration-of-available-languages
  • 87ea8e09 - Enable all languages by default

Compare with previous version

added 4 commits <ul><li>2954f85a...5af9f95a - 2 commits from branch <code>master</code></li><li>e469667a - Merge branch &#39;master&#39; into 261-allow-site-local-configuration-of-available-languages</li><li>87ea8e09 - Enable all languages by default</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/381/diffs?diff_id=3674&start_sha=2954f85ab1cbd82fa6d9dec00639405beec60f60)
tteichler commented 2020-11-11 16:47:11 +01:00
Author
Owner
Copy link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/AlekSIS/official/AlekSIS/-/merge_requests/381/diffs?diff_id=3675&start_sha=87ea8e0971351f15ff86186555d370b01075e4c6#1839426565dc577c667616b79bc00477285b1159_58_54)
tteichler commented 2020-11-11 16:47:14 +01:00
Author
Owner
Copy link

added 1 commit

  • c1e5cebd - Allow site local configuration of available languages

Compare with previous version

added 1 commit <ul><li>c1e5cebd - Allow site local configuration of available languages</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/381/diffs?diff_id=3675&start_sha=87ea8e0971351f15ff86186555d370b01075e4c6)
tteichler commented 2020-11-11 16:48:18 +01:00
Author
Owner
Copy link

Please look at the code again. We also use preferences in all other templates this way (thanks to @hansegucker)

Please look at the code again. We also use preferences in all other templates this way (thanks to @hansegucker)
tteichler commented 2020-11-11 16:48:19 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2020-11-11 16:48:34 +01:00
Author
Owner
Copy link

approved this merge request

approved this merge request
nik commented 2020-11-11 19:44:09 +01:00
Owner
Copy link

mentioned in commit 19a4ddd567

mentioned in commit 19a4ddd567581e035105ffcf8ecde86e4df28624
nik merged commit 19a4ddd567 into master 2020-11-11 19:44:09 +01:00
tteichler approved these changes 2026-07-30 18:37:47 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
hansegucker
debdolph
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!2026
No description provided.