aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Add landscape print template. Closes #311 #1984

Merged
hansegucker merged 1 commit from add-landscape-print-template into master 2020-10-27 17:31:20 +01:00
Conversation 24 Commits 1 Files changed 1 +8
tteichler commented 2020-08-01 22:37:42 +02:00
Owner
Copy link
No description provided.
hansegucker commented 2020-08-02 11:43:26 +02:00
Owner
Copy link

It may be good to not just copy everything, but provide common used templates for portrait and landscape templates. I mean there is only one line difference – if I saw it correctly.

It may be good to not just copy everything, but provide common used templates for portrait and landscape templates. I mean there is only one line difference – if I saw it correctly.
nik commented 2020-08-07 16:28:43 +02:00
Owner
Copy link

marked as a Work In Progress

marked as a **Work In Progress**
tteichler commented 2020-09-09 18:50:16 +02:00
Author
Owner
Copy link
diff -u base_print.html base_print_landscape.html                                                                                                                      ✔ 
--- base_print.html     2020-09-08 21:37:27.408649565 +0200
+++ base_print_landscape.html   2020-09-09 18:49:34.766674574 +0200
@@ -22,11 +22,11 @@
   {% block extra_head %}{% endblock %}
 </head>
 
-<body class="A4 print-body">
+<body class="A4 print-body landscape">
 <main class="sheet infinite">
   <div style="margin-top: -10mm;"></div>
 
-  <table class="print-layout-table">
+  <table>
     <thead>
     <tr class="no-border">
       <td class="print-layout-td">
@@ -37,9 +37,9 @@
 
     <tbody>
     <tr class="no-border">
-      <td class="print-layout-td">
+      <td>
         <div class="content">
-          <header>
+          <header style="width: 100%">
             <div id="print-header" class="row">
               <div class="col s6 logo">
                 {% static "img/aleksis-banner.svg" as aleksis_banner %}
``` diff -u base_print.html base_print_landscape.html  ✔ --- base_print.html 2020-09-08 21:37:27.408649565 +0200 +++ base_print_landscape.html 2020-09-09 18:49:34.766674574 +0200 @@ -22,11 +22,11 @@ {% block extra_head %}{% endblock %} </head> -<body class="A4 print-body"> +<body class="A4 print-body landscape"> <main class="sheet infinite"> <div style="margin-top: -10mm;"></div> - <table class="print-layout-table"> + <table> <thead> <tr class="no-border"> <td class="print-layout-td"> @@ -37,9 +37,9 @@ <tbody> <tr class="no-border"> - <td class="print-layout-td"> + <td> <div class="content"> - <header> + <header style="width: 100%"> <div id="print-header" class="row"> <div class="col s6 logo"> {% static "img/aleksis-banner.svg" as aleksis_banner %} ```
tteichler commented 2020-09-12 16:12:35 +02:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2020-09-22 17:54:32 +02:00
Author
Owner
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
nik commented 2020-10-27 13:35:50 +01:00
Owner
Copy link

marked as a Work In Progress

marked as a **Work In Progress**
tteichler commented 2020-10-27 16:38:25 +01:00
Author
Owner
Copy link

added 104 commits

  • 10b6f475...518a9471 - 103 commits from branch master
  • 389fb69b - Merge branch 'master' into add-landscape-print-template

Compare with previous version

added 104 commits <ul><li>10b6f475...518a9471 - 103 commits from branch <code>master</code></li><li>389fb69b - Merge branch &#39;master&#39; into add-landscape-print-template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/339/diffs?diff_id=3534&start_sha=10b6f4759bba23407726425164b1bf89b0e9b2bb)
hansegucker commented 2020-10-27 16:46:53 +01:00
Owner
Copy link

The dev meeting decided some time ago that the diff is too small to justify just copying a file ;-)

The dev meeting decided some time ago that the diff is too small to justify just copying a file ;-)
tteichler commented 2020-10-27 17:23:36 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2020-10-27 17:24:30 +01:00
Author
Owner
Copy link

added 1 commit

  • a7151757 - Remove useless template

Compare with previous version

added 1 commit <ul><li>a7151757 - Remove useless template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/339/diffs?diff_id=3536&start_sha=389fb69bc546528f037e99e7119e5ee99db6bd30)
tteichler commented 2020-10-27 17:26:13 +01:00
Author
Owner
Copy link

added 1 commit

  • df78f6bc - Add option to use landscape print template

Compare with previous version

added 1 commit <ul><li>df78f6bc - Add option to use landscape print template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/339/diffs?diff_id=3537&start_sha=a715175797d2b0568e08c62b5639ec3696a6a253)
tteichler commented 2020-10-27 17:27:09 +01:00
Author
Owner
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
hansegucker scheduled this pull request to auto merge when all checks succeed 2020-10-27 17:29:05 +01:00
tteichler commented 2020-10-27 17:29:12 +01:00
Author
Owner
Copy link

changed title from Add landscape print template to Add landscape print template{+. Closes #311+}

changed title from **Add landscape print template** to **Add landscape print template{+. Closes #311+}**
hansegucker canceled auto merging this pull request when all checks succeed 2020-10-27 17:31:12 +01:00
hansegucker commented 2020-10-27 17:31:20 +01:00
Owner
Copy link

mentioned in commit da80a66898

mentioned in commit da80a66898c21caeb56e003113354ddaf82a611b
nik commented 2020-10-28 21:23:21 +01:00
Owner
Copy link

Please only wrap the class attribute value.

Please only wrap the class attribute value.
nik commented 2020-10-28 21:23:22 +01:00
Owner
Copy link

Inline CSS is forbidden.

Inline CSS is forbidden.
nik commented 2020-10-28 21:25:01 +01:00
Owner
Copy link

Also, this looks semantically wrong. Why shouldn't the header be full width in portrait mode?

Also, this looks semantically wrong. Why shouldn't the header be full width in portrait mode?
nik commented 2020-10-28 21:26:27 +01:00
Owner
Copy link

@hansegucker , @debdolph Please either fix immediately or revert the MR

@hansegucker , @debdolph Please either fix immediately or revert the MR
nik commented 2020-10-28 21:39:50 +01:00
Owner
Copy link

Also, this looks semantically wrong. It seems that both portrait and landscape print tables are a print layout table?

Also, this looks semantically wrong. It seems that both portrait and landscape print tables are a print layout table?
hansegucker commented 2020-10-29 13:21:44 +01:00
Owner
Copy link

mentioned in commit e6e683ec25

mentioned in commit e6e683ec2544f961778d3e50d91672be85b7ff4d
hansegucker commented 2020-10-29 13:21:57 +01:00
Owner
Copy link

mentioned in merge request !2022

mentioned in merge request !2022
nik commented 2020-10-29 16:26:34 +01:00
Owner
Copy link

I will revert this MR at 20:00 CET if the listed issues are not fixed.

I will revert this MR at 20:00 CET if the listed issues are not fixed.
hansegucker commented 2020-10-29 16:27:04 +01:00
Owner
Copy link

As you can see, this has been reverted already.

As you can see, this has been reverted already.
nik commented 2020-10-29 16:42:07 +01:00
Owner
Copy link

Oh, it's not noted in the MR change history? Hmm...

Oh, it's not noted in the MR change history? Hmm...
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!1984
No description provided.