aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

WIP: Resolve "Include django-letsagree" #1869

Closed
tteichler wants to merge 11 commits from 157-include-django-letsagree into master
pull from: 157-include-django-letsagree
merge into: aleksis:master
Conversation 25 Commits 11 Files changed 7 +139
tteichler commented 2020-04-17 17:03:22 +02:00
Owner
Copy link

Closes #157

Closes #157
tteichler commented 2020-04-17 17:03:23 +02:00
Author
Owner
Copy link

changed milestone to %"2.0a2"

changed milestone to %"2.0a2"
tteichler commented 2020-04-17 20:20:17 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>586ebb0b - Install django-letsagree</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/224/diffs?diff_id=1766&start_sha=cb52402954b39dc603b0b0429322a1f4b78f22f2)
tteichler commented 2020-04-17 20:21:29 +02:00
Author
Owner
Copy link

added 25 commits

  • 586ebb0b...b4a22ee7 - 24 commits from branch master
  • a73c25f0 - Merge branch 'master' into 157-include-django-letsagree

Compare with previous version

added 25 commits <ul><li>586ebb0b...b4a22ee7 - 24 commits from branch <code>master</code></li><li>a73c25f0 - Merge branch &#39;master&#39; into 157-include-django-letsagree</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/224/diffs?diff_id=1767&start_sha=586ebb0ba234e2f6da303802a2ae99c74b329791)
tteichler commented 2020-04-17 21:13:52 +02:00
Author
Owner
Copy link

added 4 commits

  • a73c25f0...a7665dd6 - 2 commits from branch master
  • 221d6bb2 - Merge branch 'master' into 157-include-django-letsagree
  • 4ec7846d - Add initial migration

Compare with previous version

added 4 commits <ul><li>a73c25f0...a7665dd6 - 2 commits from branch <code>master</code></li><li>221d6bb2 - Merge branch &#39;master&#39; into 157-include-django-letsagree</li><li>4ec7846d - Add initial migration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/224/diffs?diff_id=1768&start_sha=a73c25f0976eac75bbb8df61383ca8712adf2e84)
tteichler commented 2020-04-17 22:36:13 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>83615785 - Add custom template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/224/diffs?diff_id=1769&start_sha=4ec7846d038f8615a897ee80da07e2222ac950c3)
tteichler commented 2020-04-17 22:37:25 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>189a339f - Enable caching</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/224/diffs?diff_id=1770&start_sha=83615785214dbb253e0a304077ceacefbab7c789)
tteichler commented 2020-04-23 14:13:41 +02:00
Author
Owner
Copy link

added 85 commits

  • 189a339f...c2439d02 - 84 commits from branch master
  • bb0ddd48 - Merge branch 'master' into 157-include-django-letsagree

Compare with previous version

added 85 commits <ul><li>189a339f...c2439d02 - 84 commits from branch <code>master</code></li><li>bb0ddd48 - Merge branch &#39;master&#39; into 157-include-django-letsagree</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/224/diffs?diff_id=1844&start_sha=189a339ff263652c8a358fc4311d989f508c3e79)
tteichler commented 2020-04-27 15:28:25 +02:00
Author
Owner
Copy link

Maybe we can add blank=True also here like at title_en, so the customer can choose which language he would like to use.

/cc @hansegucker

(Also this must be regenerated if we add a new language…)

Maybe we can add `blank=True` also here like at `title_en`, so the customer can choose which language he would like to use. /cc @hansegucker (Also this must be regenerated if we add a new language…)
hansegucker commented 2020-04-28 13:10:10 +02:00
Owner
Copy link

How this migration is generated?

How this migration is generated?
tteichler commented 2020-04-28 13:14:46 +02:00
Author
Owner
Copy link

with ./manage.py makemigrations letsagree

with `./manage.py makemigrations letsagree`
hansegucker commented 2020-04-28 13:15:31 +02:00
Owner
Copy link

OK. I would try to set it to blank.

OK. I would try to set it to blank.
tteichler commented 2020-04-28 13:15:57 +02:00
Author
Owner
Copy link

I can do that too, if you have to do other stuff, k ;)?

I can do that too, if you have to do other stuff, k ;)?
hansegucker commented 2020-04-28 13:16:24 +02:00
Owner
Copy link

"would", not "will".

"would", not "will".
tteichler commented 2020-04-28 13:16:53 +02:00
Author
Owner
Copy link

ah, oh :D…

ah, oh :D…
hansegucker commented 2020-04-28 13:16:53 +02:00
Owner
Copy link

assigned to @hansegucker

assigned to @hansegucker
tteichler commented 2020-04-28 13:20:11 +02:00
Author
Owner
Copy link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/AlekSIS/official/AlekSIS/-/merge_requests/224/diffs?diff_id=1867&start_sha=bb0ddd48fd3ee4f6fb922115a3fd3a50fa342a96#3c178dc52c6923c10be29bb676482d41e342e26a_23_23)
tteichler commented 2020-04-28 13:20:12 +02:00
Author
Owner
Copy link

added 19 commits

  • bb0ddd48...7d9a57fc - 17 commits from branch master
  • 9282eb86 - Merge branch 'master' into 157-include-django-letsagree
  • e9f9895a - Update migration

Compare with previous version

added 19 commits <ul><li>bb0ddd48...7d9a57fc - 17 commits from branch <code>master</code></li><li>9282eb86 - Merge branch &#39;master&#39; into 157-include-django-letsagree</li><li>e9f9895a - Update migration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/224/diffs?diff_id=1867&start_sha=bb0ddd48fd3ee4f6fb922115a3fd3a50fa342a96)
tteichler commented 2020-04-28 13:45:26 +02:00
Author
Owner
Copy link

Result: Apparently it IS possible to create a letsagree migration without required fields, but for some reasons django ignores this and these fields are (also in a new database) still required…

Result: Apparently it IS possible to create a letsagree migration without required fields, but for some reasons django ignores this and these fields are (also in a new database) still required…
hansegucker commented 2020-04-28 19:12:24 +02:00
Owner
Copy link

Mhmm

Mhmm
nik commented 2020-04-28 19:14:14 +02:00
Owner
Copy link

The main issue here is that the language cannot be switched before accepting terms.

What did your evaluaton of alternative solutions turn up, @debdolph?

The main issue here is that the language cannot be switched before accepting terms. What did your evaluaton of alternative solutions turn up, @debdolph?
tteichler commented 2020-04-28 19:34:59 +02:00
Author
Owner
Copy link

Everything similar to django-letsagree is either old or has the same problems…

Everything similar to django-letsagree is either old or has the same problems…
nik commented 2020-05-15 16:36:25 +02:00
Owner
Copy link

removed milestone

removed milestone
tteichler commented 2020-06-29 11:46:53 +02:00
Author
Owner
Copy link

added 473 commits

  • e9f9895a...d6a0b2bd - 471 commits from branch master
  • 696c5c6f - Merge branch 'master' into 157-include-django-letsagree
  • db1b8da5 - Add migrations

Compare with previous version

added 473 commits <ul><li>e9f9895a...d6a0b2bd - 471 commits from branch <code>master</code></li><li>696c5c6f - Merge branch &#39;master&#39; into 157-include-django-letsagree</li><li>db1b8da5 - Add migrations</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/224/diffs?diff_id=2725&start_sha=e9f9895aabb642788f7106577b3a8f33636a3032)
nik commented 2022-08-15 12:02:18 +02:00
Owner
Copy link

I think this MR will not deliver any suitable solution. An implementation needs to be re-drafted from scratch.

I think this MR will not deliver any suitable solution. An implementation needs to be re-drafted from scratch.
nik closed this pull request 2022-08-15 12:02:19 +02:00
nik commented 2022-08-15 12:02:29 +02:00
Owner
Copy link

unassigned @hansegucker

unassigned @hansegucker

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!1869
No description provided.