aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

WIP: Resolve "Add geolocation of persons" #1865

Closed
tteichler wants to merge 6 commits from 215-add-geolocation-of-persons into master
pull from: 215-add-geolocation-of-persons
merge into: aleksis:master
Conversation 21 Commits 6 Files changed 6 +115 -10
tteichler commented 2020-04-14 14:49:05 +02:00
Owner
Copy link

Closes #215

Closes #215
tteichler commented 2020-04-14 14:49:05 +02:00
Author
Owner
Copy link

changed milestone to %"2.0a2"

changed milestone to %"2.0a2"
tteichler commented 2020-04-14 15:59:44 +02:00
Author
Owner
Copy link

added 1 commit

  • 50664195 - Add celery task to set longitude and latitude of person

Compare with previous version

added 1 commit <ul><li>50664195 - Add celery task to set longitude and latitude of person</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/220/diffs?diff_id=1715&start_sha=1cc55ed59725f3951800e6aa17ec5528c65dbb7e)
tteichler commented 2020-04-14 16:00:09 +02:00
Author
Owner
Copy link

assigned to @nik

assigned to @nik
tteichler commented 2020-04-14 16:00:22 +02:00
Author
Owner
Copy link

Maybe you can do a short review ;)?

Maybe you can do a short review ;)?
tteichler commented 2020-04-14 16:11:44 +02:00
Author
Owner
Copy link

added 1 commit

  • 53a2e618 - Add celery task to set longitude and latitude of person

Compare with previous version

added 1 commit <ul><li>53a2e618 - Add celery task to set longitude and latitude of person</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/220/diffs?diff_id=1717&start_sha=506641955b1efcce491fd7101d29b9bb707e1429)
nik commented 2020-04-14 16:22:14 +02:00
Owner
Copy link
  1. If the feature is optional, do not hard-depend on geopy.
  2. Have you researched options for external libraries, both for the geocoding and for a specialised model field?
  3. What is the rationale for not having the geocoding called from Person.save? Maybe by having a celery task to update one person by id, and calling that from save?
1. If the feature is optional, do not hard-depend on geopy. 2. Have you researched options for external libraries, both for the geocoding and for a specialised model field? 3. What is the rationale for not having the geocoding called from `Person.save`? Maybe by having a celery task to update one person by id, and calling that from `save`?
tteichler commented 2020-04-14 17:22:09 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f168c8de - Do not hard-depend on geopy</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/220/diffs?diff_id=1720&start_sha=53a2e618aaa74a4496bf7906d48beb5508647d28)
tteichler commented 2020-04-14 17:33:44 +02:00
Author
Owner
Copy link

added 1 commit

  • 97605ccc - Move to util

Compare with previous version

added 1 commit <ul><li>97605ccc - Move to util</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/220/diffs?diff_id=1723&start_sha=f168c8de9ca6cfc6b4e567a8c5433e3eb9df0275)
tteichler commented 2020-04-14 17:35:18 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>003ca60f - Move to util</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/220/diffs?diff_id=1725&start_sha=97605ccc068796bfeaf93b30e5fe3b42cee70233)
tteichler commented 2020-04-14 17:38:24 +02:00
Author
Owner
Copy link

If the feature is optional, do not hard-depend on geopy.

Done

Have you researched options for external libraries, both for the geocoding and for a specialised model field?

Nope. This library simply saves the coordinates in the fields. Maybe we can look into this together later

What is the rationale for not having the geocoding called from Person.save? Maybe by having a celery task to update one person by id, and calling that from save?

update_geolocation() is now called from save()

> If the feature is optional, do not hard-depend on geopy. Done > Have you researched options for external libraries, both for the geocoding and for a specialised model field? Nope. This library simply saves the coordinates in the fields. Maybe we can look into this together later > What is the rationale for not having the geocoding called from `Person.save`? Maybe by having a celery task to update one person by id, and calling that from `save`? update_geolocation() is now called from save()
tteichler commented 2020-04-14 18:24:20 +02:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2020-04-15 21:27:07 +02:00
Author
Owner
Copy link

added 22 commits

  • 003ca60f...5adc7377 - 21 commits from branch master
  • 4feb0246 - Merge branch 'master' into 215-add-geolocation-of-persons

Compare with previous version

added 22 commits <ul><li>003ca60f...5adc7377 - 21 commits from branch <code>master</code></li><li>4feb0246 - Merge branch &#39;master&#39; into 215-add-geolocation-of-persons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/220/diffs?diff_id=1750&start_sha=003ca60f4b0c33933215802c8d29954845e45eb4)
nik commented 2020-05-15 16:36:24 +02:00
Owner
Copy link

removed milestone

removed milestone
tteichler commented 2020-06-28 15:04:42 +02:00
Author
Owner
Copy link

added 598 commits

  • 4feb0246...75256e08 - 597 commits from branch master
  • 664f72b3 - Merge branch 'master' into 215-add-geolocation-of-persons

Compare with previous version

added 598 commits <ul><li>4feb0246...75256e08 - 597 commits from branch <code>master</code></li><li>664f72b3 - Merge branch &#39;master&#39; into 215-add-geolocation-of-persons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/220/diffs?diff_id=2713&start_sha=4feb024670e6fcde17aad0eeca3d55cd622356c3)
nik commented 2020-06-28 15:11:58 +02:00
Owner
Copy link

Seems somehow unrelated, and we do not even use constance anymore.

Seems somehow unrelated, and we do not even use constance anymore.
nik commented 2020-06-28 15:12:40 +02:00
Owner
Copy link

Should be a method on Person.

Should be a method on `Person`.
tteichler commented 2020-06-28 15:31:05 +02:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2020-06-28 15:31:09 +02:00
Author
Owner
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/official/AlekSIS/-/merge_requests/220/diffs?diff_id=2715&start_sha=664f72b327471d9ed38262e2e7e98b9398f23493#abc9d828b78bd9d36e05475d0bc91119bc5bc6b0_395_395)
tteichler commented 2020-06-28 15:31:09 +02:00
Author
Owner
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/official/AlekSIS/-/merge_requests/220/diffs?diff_id=2715&start_sha=664f72b327471d9ed38262e2e7e98b9398f23493#8c15ef90a05145592bdded0de1ca9faad06ca049_337_337)
tteichler commented 2020-06-28 15:31:10 +02:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2020-06-28 15:31:10 +02:00
Author
Owner
Copy link

added 1 commit

  • d46f05ba - Make update_geolocation method on person

Compare with previous version

added 1 commit <ul><li>d46f05ba - Make update_geolocation method on person</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/220/diffs?diff_id=2715&start_sha=664f72b327471d9ed38262e2e7e98b9398f23493)
nik closed this pull request 2026-01-19 13:38:13 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!1865
No description provided.