aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Migrate from constance to dynamic-preferences #1862

Merged
hansegucker merged 34 commits from feature/dynamic-preferences into master 2020-05-01 14:43:11 +02:00
Conversation 21 Commits 34 Files changed 29 +559 -310
nik commented 2020-04-14 00:39:20 +02:00
Owner
Copy link

Rationale: django-dynamic-preferences allows defining global preferences and "instance preferences", i.e. user preferences, the same way. It is also way more sophisticated than constance and provides more possibilities for preference fields as well as rendering options.

Closes #162, advances #214 and others.

Rationale: `django-dynamic-preferences` allows defining global preferences and "instance preferences", i.e. user preferences, the same way. It is also way more sophisticated than constance and provides more possibilities for preference fields as well as rendering options. Closes #162, advances #214 and others.
nik commented 2020-04-14 00:39:21 +02:00
Author
Owner
Copy link

changed milestone to %"2.0a2"

changed milestone to %"2.0a2"
tteichler commented 2020-04-14 18:25:34 +02:00
Owner
Copy link

mentioned in merge request !1860

mentioned in merge request !1860
tteichler commented 2020-04-27 22:32:01 +02:00
Owner
Copy link

added 150 commits

  • 553ba953...7d9a57fc - 149 commits from branch master
  • b9cd0a08 - Merge branch 'master' into feature/dynamic-preferences

Compare with previous version

added 150 commits <ul><li>553ba953...7d9a57fc - 149 commits from branch <code>master</code></li><li>b9cd0a08 - Merge branch &#39;master&#39; into feature/dynamic-preferences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1864&start_sha=553ba953c70b221f3067d9aa4f1046b0507b3086)
nik commented 2020-04-27 22:54:07 +02:00
Author
Owner
Copy link

added 5 commits

  • 1645d398 - CHange config_updated signal handle to preference_updated
  • 9d472638 - Fix typo
  • 8ad4abc2 - Rename lazy_config to lazy_preference and add section as argument
  • bbb59cc0 - Fix missed rename
  • a456a860 - Replace constance in sass helpers and models

Compare with previous version

added 5 commits <ul><li>1645d398 - CHange config_updated signal handle to preference_updated</li><li>9d472638 - Fix typo</li><li>8ad4abc2 - Rename lazy_config to lazy_preference and add section as argument</li><li>bbb59cc0 - Fix missed rename</li><li>a456a860 - Replace constance in sass helpers and models</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1865&start_sha=b9cd0a085cdfc0c6cb60dbe5c021da1226d28708)
tteichler commented 2020-04-27 23:36:13 +02:00
Owner
Copy link

added 1 commit

  • 87637abc - Fix missing bits for migration to dynamic_preferences

Compare with previous version

added 1 commit <ul><li>87637abc - Fix missing bits for migration to dynamic_preferences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1866&start_sha=a456a860d93f3b8f48aaab19192da81609fd4d7d)
hansegucker commented 2020-04-29 09:46:21 +02:00
Owner
Copy link

Is there anything left to do?

Is there anything left to do?
hansegucker commented 2020-04-29 21:46:33 +02:00
Owner
Copy link

added 1 commit

  • cb79f536 - Set field_class with Field object instead of widget with Field object in preferences

Compare with previous version

added 1 commit <ul><li>cb79f536 - Set field_class with Field object instead of widget with Field object in preferences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1887&start_sha=87637abc2bb912ce499d2bfbbf1c3ccf03502ab9)
hansegucker commented 2020-04-30 13:24:49 +02:00
Owner
Copy link

added 1 commit

  • 5f57b7a5 - Fix use of some preferences

Compare with previous version

added 1 commit <ul><li>5f57b7a5 - Fix use of some preferences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1890&start_sha=cb79f53633def29f3c9fab7b2fd7e5e5a4f649c2)
tteichler commented 2020-04-30 20:15:55 +02:00
Owner
Copy link

added 23 commits

  • 5f57b7a5...dd7a8710 - 22 commits from branch master
  • 1d83ef51 - Merge branch 'master' into feature/dynamic-preferences

Compare with previous version

added 23 commits <ul><li>5f57b7a5...dd7a8710 - 22 commits from branch <code>master</code></li><li>1d83ef51 - Merge branch &#39;master&#39; into feature/dynamic-preferences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1894&start_sha=5f57b7a57a12135ad07f438216cd13eae4fc60ab)
tteichler commented 2020-04-30 20:33:56 +02:00
Owner
Copy link

added 1 commit

  • 61ee0287 - Update templates

Compare with previous version

added 1 commit <ul><li>61ee0287 - Update templates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1895&start_sha=1d83ef51c836e5559b3267d6df27273513cb17f7)
nik commented 2020-04-30 21:12:46 +02:00
Author
Owner
Copy link

added 1 commit

  • 218818de - Move School attributes to site preferences and introduce all registries

Compare with previous version

added 1 commit <ul><li>218818de - Move School attributes to site preferences and introduce all registries</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1896&start_sha=61ee0287b0709bc71fd0209c674c536fc2e41edb)
tteichler commented 2020-04-30 21:48:45 +02:00
Owner
Copy link

added 5 commits

  • 7ca999f6 - Fix model fields
  • d9a24816 - Drop School and SchoolTerm from admin.py
  • e17aa3ff - Drop School stuff
  • db3dc8bc - Add meta class
  • 894b50c9 - Add migration

Compare with previous version

added 5 commits <ul><li>7ca999f6 - Fix model fields</li><li>d9a24816 - Drop School and SchoolTerm from admin.py</li><li>e17aa3ff - Drop School stuff</li><li>db3dc8bc - Add meta class</li><li>894b50c9 - Add migration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1897&start_sha=218818dea80d8fe45e58bc56f45fb1919725615c)
nik commented 2020-04-30 22:20:59 +02:00
Author
Owner
Copy link

added 1 commit

  • ddbb91fd - Fix access to site preferences

Compare with previous version

added 1 commit <ul><li>ddbb91fd - Fix access to site preferences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1898&start_sha=894b50c9be35a8f6ae5bd8799c1bfd9265d8ebb8)
nik commented 2020-04-30 22:21:36 +02:00
Author
Owner
Copy link

added 1 commit

  • 34d4ee36 - Fix typo

Compare with previous version

added 1 commit <ul><li>34d4ee36 - Fix typo</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1899&start_sha=ddbb91fd928557b8a509b5b51796d4233ccd86a5)
nik commented 2020-04-30 22:45:18 +02:00
Author
Owner
Copy link

added 4 commits

  • 744f3a6c - FIx get_current_site call
  • 20e393b5 - Move remaining parts to site preferences
  • 62bd0327 - Determine site by SITE_ID only
  • a71aa354 - Remove stray code

Compare with previous version

added 4 commits <ul><li>744f3a6c - FIx get_current_site call</li><li>20e393b5 - Move remaining parts to site preferences</li><li>62bd0327 - Determine site by SITE_ID only</li><li>a71aa354 - Remove stray code</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1900&start_sha=34d4ee36b123081dd834b552553b7d3e4c70b737)
tteichler commented 2020-04-30 23:16:13 +02:00
Owner
Copy link

added 3 commits

  • 528f3c27 - Move import from Site
  • 5e1b6c6a - Get site preferences
  • e1cc2a46 - Fix import

Compare with previous version

added 3 commits <ul><li>528f3c27 - Move import from Site</li><li>5e1b6c6a - Get site preferences</li><li>e1cc2a46 - Fix import</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1902&start_sha=a71aa354f623fc37a39a95635cca45c09e879a5e)
hansegucker commented 2020-05-01 12:36:01 +02:00
Owner
Copy link

added 33 commits

  • aefbade8 - Translate constance configs to dynamic preferences
  • 1ae4215c - CHange config_updated signal handle to preference_updated
  • d139058c - Fix typo
  • 2229692f - Rename lazy_config to lazy_preference and add section as argument
  • bfe78906 - Fix missed rename
  • c23f1224 - Replace constance in sass helpers and models
  • 3f901408 - Fix missing bits for migration to dynamic_preferences
  • 256e3864 - Set field_class with Field object instead of widget with Field object in preferences
  • d2a359bb - Fix use of some preferences
  • 676f9548 - Update templates
  • 5997caf8 - Move School attributes to site preferences and introduce all registries
  • 1d66da17 - Fix model fields
  • 813fb34d - Drop School and SchoolTerm from admin.py
  • d7dbf458 - Drop School stuff
  • 5f6aa24f - Add meta class
  • 192c6e56 - Add migration
  • 0bb2d16f - Fix access to site preferences
  • 8a43f0e7 - Fix typo
  • 66a5c580 - FIx get_current_site call
  • 27d0b60e - Move remaining parts to site preferences
  • 9b2e7496 - Determine site by SITE_ID only
  • 224bd6fa - Remove stray code
  • 9b73e079 - Move import from Site
  • 430a0f18 - Get site preferences
  • 535d0ea8 - Fix import
  • 1bdc98d7 - Fix order of INSTALLED_APPS so we can overwrite templates
  • df41b5f3 - Add preferences view
  • 9feb92c9 - Add missing CurrentSiteMiddleware
  • fdf0d4be - Change dbsettings syntax for footer URLs to dynamic-preferences
  • 5c70304b - Add permissions for preferences view
  • 18a0043a - Add menu entries for preferences
  • ad44b24c - Add buttons for changing preferences to group and person templates
  • c399d463 - Merge branch 'feature/dynamic-preferences' of...

Compare with previous version

added 33 commits <ul><li>aefbade8 - Translate constance configs to dynamic preferences</li><li>1ae4215c - CHange config_updated signal handle to preference_updated</li><li>d139058c - Fix typo</li><li>2229692f - Rename lazy_config to lazy_preference and add section as argument</li><li>bfe78906 - Fix missed rename</li><li>c23f1224 - Replace constance in sass helpers and models</li><li>3f901408 - Fix missing bits for migration to dynamic_preferences</li><li>256e3864 - Set field_class with Field object instead of widget with Field object in preferences</li><li>d2a359bb - Fix use of some preferences</li><li>676f9548 - Update templates</li><li>5997caf8 - Move School attributes to site preferences and introduce all registries</li><li>1d66da17 - Fix model fields</li><li>813fb34d - Drop School and SchoolTerm from admin.py</li><li>d7dbf458 - Drop School stuff</li><li>5f6aa24f - Add meta class</li><li>192c6e56 - Add migration</li><li>0bb2d16f - Fix access to site preferences</li><li>8a43f0e7 - Fix typo</li><li>66a5c580 - FIx get_current_site call</li><li>27d0b60e - Move remaining parts to site preferences</li><li>9b2e7496 - Determine site by SITE_ID only</li><li>224bd6fa - Remove stray code</li><li>9b73e079 - Move import from Site</li><li>430a0f18 - Get site preferences</li><li>535d0ea8 - Fix import</li><li>1bdc98d7 - Fix order of INSTALLED_APPS so we can overwrite templates</li><li>df41b5f3 - Add preferences view</li><li>9feb92c9 - Add missing CurrentSiteMiddleware</li><li>fdf0d4be - Change dbsettings syntax for footer URLs to dynamic-preferences</li><li>5c70304b - Add permissions for preferences view</li><li>18a0043a - Add menu entries for preferences</li><li>ad44b24c - Add buttons for changing preferences to group and person templates</li><li>c399d463 - Merge branch &#39;feature/dynamic-preferences&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1905&start_sha=e1cc2a465695bbbd411ac673627dd8f5418d29e5)
hansegucker commented 2020-05-01 14:36:26 +02:00
Owner
Copy link

added 2 commits

  • 4e484844 - Call super in CoreConfig.ready
  • e20548d1 - Use django-dynamic-preferences from Git

Compare with previous version

added 2 commits <ul><li>4e484844 - Call super in CoreConfig.ready</li><li>e20548d1 - Use django-dynamic-preferences from Git</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS/-/merge_requests/217/diffs?diff_id=1914&start_sha=ad44b24ceaa3205906fd6d3c915cef0e15effda9)
hansegucker commented 2020-05-01 14:37:59 +02:00
Owner
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
hansegucker commented 2020-05-01 14:43:10 +02:00
Owner
Copy link

mentioned in commit 37c46bb290

mentioned in commit 37c46bb290a903bd1fdc341deaedf821745351e4
hansegucker commented 2020-05-01 14:43:11 +02:00
Owner
Copy link

merged

merged
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!1862
No description provided.